From nobody Sun Feb 8 22:17:34 2026 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5D462046BA; Wed, 31 Dec 2025 20:04:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767211483; cv=none; b=hMXt6KN/ZDRcIJcUITjiywGiLLn0XNtZ3mBAgwvZRWnorxoKoC/qEc1J588ZBYoVyQ2Gdh+Tsz7y3fVp5DxI8IU8fVvxUUTD4ZkII4Te/CMVIS9/7q4NNjBe1KakfxSaXxgmKUAkGdF+0kFeX5bM+U9sTnoYsOtTh/U2ssJ4rx0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767211483; c=relaxed/simple; bh=ivJYBIqvY4duhUZ4XVnOBB0/SA/kSDK67zFf3vvhRdQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qdV1f22cRxSsSG8h52EFv4JbiBMsPsGEFhkIvJtlGguGxNxRko5xsKMerQ9k2kNiGxAMHfxF3tF20fpk/2Pr04OrULBY3SocUKTML7jIrAqkMVoOMH+tiZaLWIg58FpkRJCSuGiWoGtX2MXRcP57g9eKEv37YttlPbHhcU1AcrY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=kHSWIo2N; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="kHSWIo2N" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1767211473; bh=ivJYBIqvY4duhUZ4XVnOBB0/SA/kSDK67zFf3vvhRdQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=kHSWIo2NanC9MT6LtFyhMUsp23KH/vhaB7h67+hm1hdGOJado4Ac+vIHxqlC7RN0L 4Gj6T8njhThr4fgLeGjC0PuVT+K9RZSrWmPhwsUYss3+o4ThDPfTSfAQe0/yWGI0x1 5PgSEjVVwPlBlX3R7pCmBD+ohbADcKX3+uZi15kM9XeXmwf8RSQUm7RCLs5F34AhSF FyfqX/C4ChIyF3UNQU3JnWDpE6COGoMdSyEOIyXPVCsVi3WMAohHgR7YhjQP8pNRA7 AswVP73Q/OWQBIFEj6/cQqJoOqPRFG3GUyIHslhYzHmgocraQ+FQSkK//af4dyQrcU 8wb9/FEZY0/Aw== Received: from localhost (unknown [82.79.138.145]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 6714017E1533; Wed, 31 Dec 2025 21:04:33 +0100 (CET) From: Cristian Ciocaltea Date: Wed, 31 Dec 2025 22:04:15 +0200 Subject: [PATCH 1/7] ASoC: nau8821: Fixup nau8821_enable_jack_detect() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251231-nau8821-cleanup-v1-1-6b0b76cbbb64@collabora.com> References: <20251231-nau8821-cleanup-v1-0-6b0b76cbbb64@collabora.com> In-Reply-To: <20251231-nau8821-cleanup-v1-0-6b0b76cbbb64@collabora.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Seven Lee Cc: kernel@collabora.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 The nau8821_enable_jack_detect() function was supposed to allow enabling or disabling jack events reporting. However, once enabled, any subsequent invocation would fail and the following splat is shown: [ 3136.996771] Hardware name: Valve Jupiter/Jupiter, BIOS F7A0131 01/30/2024 [ 3136.996773] Workqueue: events_unbound deferred_probe_work_func [ 3136.996780] Call Trace: [ 3136.996782] [ 3136.996787] dump_stack_lvl+0x6e/0xa0 [ 3136.996796] __setup_irq.cold+0x9c/0xce [ 3136.996803] ? __pfx_irq_default_primary_handler+0x10/0x10 [ 3136.996812] ? __pfx_nau8821_interrupt+0x10/0x10 [snd_soc_nau8821] [ 3136.996825] request_threaded_irq+0xd9/0x160 [ 3136.996853] devm_request_threaded_irq+0x71/0xd0 [ 3136.996859] ? __pfx_nau8821_interrupt+0x10/0x10 [snd_soc_nau8821] [ 3136.996882] nau8821_enable_jack_detect+0xa5/0xc0 [snd_soc_nau8821] [ 3136.996901] acp5x_8821_init+0x8d/0xa0 [snd_soc_acp5x_mach] [ 3136.996917] snd_soc_link_init+0x25/0x50 [snd_soc_core] [ 3136.996958] snd_soc_bind_card+0x615/0xd00 [snd_soc_core] [ 3136.997026] snd_soc_register_card+0x1b2/0x1c0 [snd_soc_core] [ 3136.997064] devm_snd_soc_register_card+0x47/0x90 [snd_soc_core] [ 3136.997108] acp5x_probe+0x72/0xb0 [snd_soc_acp5x_mach] [...] [ 3136.997508] nau8821 i2c-NVTN2020:00: Cannot request irq 58 (-16) Introduce jdet_active flag to driver data structure and use it to provide one-time initialization of the jack detection work queue and related interrupt line. Note this is also a prerequisite for additional fixes around module unloading and suspend handling. Fixes: aab1ad11d69f ("ASoC: nau8821: new driver") Signed-off-by: Cristian Ciocaltea --- sound/soc/codecs/nau8821.c | 5 +++++ sound/soc/codecs/nau8821.h | 1 + 2 files changed, 6 insertions(+) diff --git a/sound/soc/codecs/nau8821.c b/sound/soc/codecs/nau8821.c index 3beb3c44dc2c..2d25a182f4ab 100644 --- a/sound/soc/codecs/nau8821.c +++ b/sound/soc/codecs/nau8821.c @@ -1655,8 +1655,13 @@ int nau8821_enable_jack_detect(struct snd_soc_compon= ent *component, int ret; =20 nau8821->jack =3D jack; + + if (nau8821->jdet_active) + return 0; + /* Initiate jack detection work queue */ INIT_DELAYED_WORK(&nau8821->jdet_work, nau8821_jdet_work); + nau8821->jdet_active =3D true; =20 ret =3D devm_request_threaded_irq(nau8821->dev, nau8821->irq, NULL, nau8821_interrupt, IRQF_TRIGGER_LOW | IRQF_ONESHOT, diff --git a/sound/soc/codecs/nau8821.h b/sound/soc/codecs/nau8821.h index 88602923780d..f9d7cd8cbd21 100644 --- a/sound/soc/codecs/nau8821.h +++ b/sound/soc/codecs/nau8821.h @@ -562,6 +562,7 @@ struct nau8821 { struct snd_soc_dapm_context *dapm; struct snd_soc_jack *jack; struct delayed_work jdet_work; + bool jdet_active; int irq; int clk_id; int micbias_voltage; --=20 2.52.0 From nobody Sun Feb 8 22:17:34 2026 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C620C2459E5; Wed, 31 Dec 2025 20:04:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767211484; cv=none; b=iFMNuvh2EuY3q8trMjiwXvVYD1fOxsmqLJGXbR6wLl2+g53/+07GF/i0g23nNuelzgYJSNKdttUvtEGzkwk8UAZ/+xZ72W0tOIf4F7kP0LFx0GnTAQfxfBz0Z018JdrJbWKeO7i0OTuE7yfa5MuNbux5BYDmdAVBtVz9m/m0WdM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767211484; c=relaxed/simple; bh=lqIxe+2iBfqIt72uH4+4mwkm/E5wkMupDxN+jbjIW2s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UHgvofhYsfO2P7G2LPx3NKPsdSeDfRLY6DNNwqkTGX8VIOpvGgCRjKSQlFLo0Ak4KsmindKnZy/mDrH6aW34J9sfm5Ky0HPZtdJ51g8qMuGtupaUzQwbgBQ5LPqx6bOG4bW1/SMc/I80rdycZRpMlXooHmqf3xQhaI8IC7UQSws= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=EQoQ4lx8; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="EQoQ4lx8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1767211474; bh=lqIxe+2iBfqIt72uH4+4mwkm/E5wkMupDxN+jbjIW2s=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=EQoQ4lx8Nc9mHm6Tl+CFj9ET4uUYQv94treG7mwD3MnWk9n4TVNqhSAUAGuR15QnO MtU0bduM4hyt5W723vRCZrO5PTmWs16WJ6if3JhDrykN8i4/NiLu64BjEraxBqifFf qHCLvLTR/zd0rLfB0jQ3/x6KVogfo//kczXmXFPjpemPNxZp+N9yOc4HYWQZkZOUIR kprS1MBD332KrYNXCOIMAQF5zQMm+8GKYoMHRXbJhI0dVy3mLiPk1EDaaTOOD/5InS W81gneT1MtGQ2j97F80mYvwWiY79bn9mdUUQ5Aph7li43ZGbVSXqDMbyVVGcDq+r02 UywbTdxmieDbg== Received: from localhost (unknown [82.79.138.145]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 413D917E1536; Wed, 31 Dec 2025 21:04:34 +0100 (CET) From: Cristian Ciocaltea Date: Wed, 31 Dec 2025 22:04:16 +0200 Subject: [PATCH 2/7] ASoC: nau8821: Cancel delayed work on component remove Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251231-nau8821-cleanup-v1-2-6b0b76cbbb64@collabora.com> References: <20251231-nau8821-cleanup-v1-0-6b0b76cbbb64@collabora.com> In-Reply-To: <20251231-nau8821-cleanup-v1-0-6b0b76cbbb64@collabora.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Seven Lee Cc: kernel@collabora.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 Attempting to unload the driver while a jack detection work is pending would likely crash the kernel when it is eventually scheduled for execution: [ 1984.896308] BUG: unable to handle page fault for address: ffffffffc10c2a= 20 [...] [ 1984.896388] Hardware name: Valve Jupiter/Jupiter, BIOS F7A0131 01/30/2024 [ 1984.896396] Workqueue: events nau8821_jdet_work [snd_soc_nau8821] [ 1984.896414] RIP: 0010:__mutex_lock+0x9f/0x11d0 [...] [ 1984.896504] Call Trace: [ 1984.896511] [ 1984.896524] ? snd_soc_dapm_disable_pin+0x26/0x60 [snd_soc_core] [ 1984.896572] ? snd_soc_dapm_disable_pin+0x26/0x60 [snd_soc_core] [ 1984.896596] snd_soc_dapm_disable_pin+0x26/0x60 [snd_soc_core] [ 1984.896622] nau8821_jdet_work+0xeb/0x1e0 [snd_soc_nau8821] [ 1984.896636] process_one_work+0x211/0x590 [ 1984.896649] ? srso_return_thunk+0x5/0x5f [ 1984.896670] worker_thread+0x1cd/0x3a0 Cancel unscheduled jdet_work or wait for its execution to finish before the component driver gets removed. Fixes: aab1ad11d69f ("ASoC: nau8821: new driver") Fixes: ee70bacef1c6 ("ASoC: nau8821: Avoid unnecessary blocking in IRQ hand= ler") Signed-off-by: Cristian Ciocaltea --- sound/soc/codecs/nau8821.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/sound/soc/codecs/nau8821.c b/sound/soc/codecs/nau8821.c index 2d25a182f4ab..2e2714b47501 100644 --- a/sound/soc/codecs/nau8821.c +++ b/sound/soc/codecs/nau8821.c @@ -1264,6 +1264,14 @@ static int nau8821_component_probe(struct snd_soc_co= mponent *component) return 0; } =20 +static void nau8821_component_remove(struct snd_soc_component *component) +{ + struct nau8821 *nau8821 =3D snd_soc_component_get_drvdata(component); + + if (nau8821->jdet_active) + cancel_delayed_work_sync(&nau8821->jdet_work); +}; + /** * nau8821_calc_fll_param - Calculate FLL parameters. * @fll_in: external clock provided to codec. @@ -1621,6 +1629,7 @@ static int __maybe_unused nau8821_resume(struct snd_s= oc_component *component) =20 static const struct snd_soc_component_driver nau8821_component_driver =3D { .probe =3D nau8821_component_probe, + .remove =3D nau8821_component_remove, .set_sysclk =3D nau8821_set_sysclk, .set_pll =3D nau8821_set_fll, .set_bias_level =3D nau8821_set_bias_level, --=20 2.52.0 From nobody Sun Feb 8 22:17:34 2026 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BC833064AE; Wed, 31 Dec 2025 20:04:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767211484; cv=none; b=a4k+jY8zsoHQCC1oooGldHrXj2BxPJ3qdXCUtRbdYCgzo0wZ6lManHUyQH994jXYp6cT+tZAZ+6cDQaX/aLcDV6bNeap1PSZrYScTq/P0tWT5RSw76zYVmLTLfXENpAyAgLuJ4PoHInJlscjE8EH+ckS2C7m6OezR/YdAlflaf8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767211484; c=relaxed/simple; bh=xJvRw08s346aB4bQFdhdVkcd/oioURVI+ywOOYi+vOw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=epn451Lm7rGy78a1limBKiBAbJ570rX2NPY8uaPyJKAZU+QcXBlAqNSHwC8OfbtjCYxuBVUBYviynbomPbak+ZlA/dHXdF5d+YHP6DTss1JheT8c5QAd+ea0LvlEqHYeRAC0tISqjGzEh45SPHiU7hjnj8FPN51m1TfXhUh7ia8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=JZOBcusy; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="JZOBcusy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1767211475; bh=xJvRw08s346aB4bQFdhdVkcd/oioURVI+ywOOYi+vOw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=JZOBcusyijt4Ky04eJXtwqYaeWO5EoVRQQDabsc/7jiTiaf+jY3+dt2MKR4h8N0BX Ql2ACO4RVEMQfTnkyEkhPkpsqJ2iFbhHknbz49LN6y++4H1FO7+C0BH7IqSdb9/wNX TzM+KtXs1nvlGLqBAB2WSusnEL85PUAsYSDPreh6PkQB1Or4oh4zXmBI/gg0yE+Bj9 rpP+E5FYFSuQl0+pTTQdIfkHiLxHfUfeTBv+cqu7zqr6FZMgnTslVzMazodrhVfOck lZsrM7saeB0b0Ix961CGICgrbfw8jRew8fBF3lmAfKpnGZBa4PkGUchgy70xitmTrm o5vgA5pXiY+Zw== Received: from localhost (unknown [82.79.138.145]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 1F96317E3685; Wed, 31 Dec 2025 21:04:35 +0100 (CET) From: Cristian Ciocaltea Date: Wed, 31 Dec 2025 22:04:17 +0200 Subject: [PATCH 3/7] ASoC: nau8821: Cancel pending work before suspend Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251231-nau8821-cleanup-v1-3-6b0b76cbbb64@collabora.com> References: <20251231-nau8821-cleanup-v1-0-6b0b76cbbb64@collabora.com> In-Reply-To: <20251231-nau8821-cleanup-v1-0-6b0b76cbbb64@collabora.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Seven Lee Cc: kernel@collabora.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 A jack detection work that is unscheduled or in progress while executing the suspend handler could trigger a race condition. Ensure state consistency by cancelling any pending work or wait for its execution to complete before processing the suspend. Since driver (re)enables both insert and eject interrupts on resume, there is no risk to miss the related jack events. Therefore, flush_delayed_work() is not required here. Fixes: aab1ad11d69f ("ASoC: nau8821: new driver") Fixes: ee70bacef1c6 ("ASoC: nau8821: Avoid unnecessary blocking in IRQ hand= ler") Signed-off-by: Cristian Ciocaltea --- sound/soc/codecs/nau8821.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/soc/codecs/nau8821.c b/sound/soc/codecs/nau8821.c index 2e2714b47501..58d2d5e77c8f 100644 --- a/sound/soc/codecs/nau8821.c +++ b/sound/soc/codecs/nau8821.c @@ -1605,6 +1605,10 @@ static int __maybe_unused nau8821_suspend(struct snd= _soc_component *component) =20 if (nau8821->irq) disable_irq(nau8821->irq); + + if (nau8821->jdet_active) + cancel_delayed_work_sync(&nau8821->jdet_work); + snd_soc_dapm_force_bias_level(nau8821->dapm, SND_SOC_BIAS_OFF); /* Power down codec power; don't support button wakeup */ snd_soc_dapm_disable_pin(nau8821->dapm, "MICBIAS"); --=20 2.52.0 From nobody Sun Feb 8 22:17:34 2026 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58E0D30C37E; Wed, 31 Dec 2025 20:04:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767211485; cv=none; b=W7AYBw7mzRYnTgGAEohbUnzZJ2ysa/vR7K12oMbDPoWuILU1Lr81MO8vffFB2k9x14Ykt/CaqtLiEtKep6EGKs4FscbYqFDtxIuB1IQfMyT6zDwY4VaCfq1AD3lXAwDbvwNvzwk17lyUln24yA4U1bppS0lA5diylC4GHh31k3U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767211485; c=relaxed/simple; bh=mCw6ltfCixzC+E6N5eLf/+9apdNIhEOfV146Q1qsneE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=V3bFX82V1piuK8Ejb22XU+MCT4Xm+5UOxvWvnsTbreNUDMh77BTxfwvhTCuWRtEcdLPtcaG/K8LeVB6lGf/nqYc1ZLv6Vfjdj4Yok2qa1mV5+VtYe+JemGMC8eXuv8H+Vb3RLP2d9Ny8QjHfBZ+LAZalL+yrezBhoolpSTaeIg0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=ntfTUAB7; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="ntfTUAB7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1767211476; bh=mCw6ltfCixzC+E6N5eLf/+9apdNIhEOfV146Q1qsneE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=ntfTUAB7yzHRhPJ5FTAqPypGDYiUjFk/cOVyo8JFzcABAppU6X/SLJVyObxjMwgQq +RI7AEfoqS5a7xRSQvkZr7nkoiT/wmVFqiyOENzb+v85FJIBrmiltOEBozq+Q5MZRl +KN24pI+Z4IF54TpttD5od/VWGoswAfmXksMiWbFtSGKTMHfqimb4K7gnwx6gux8/+ CqtPbV35Q8VQXNODx72SNUc0YGgrBqt8/PT8EBDPJOqp8Gp70o8SOrKjKD4svYthJ2 kM1eOQp7DqntChsTXY/Alx1U/okSRkq7sC6atGoYXaEOERESV8zH1GmFfOCA65aSg5 vMWw02taBbAsA== Received: from localhost (unknown [82.79.138.145]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id EF92C17E368C; Wed, 31 Dec 2025 21:04:35 +0100 (CET) From: Cristian Ciocaltea Date: Wed, 31 Dec 2025 22:04:18 +0200 Subject: [PATCH 4/7] ASoC: nau8821: Drop superfluous return statement Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251231-nau8821-cleanup-v1-4-6b0b76cbbb64@collabora.com> References: <20251231-nau8821-cleanup-v1-0-6b0b76cbbb64@collabora.com> In-Reply-To: <20251231-nau8821-cleanup-v1-0-6b0b76cbbb64@collabora.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Seven Lee Cc: kernel@collabora.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 Simplify error handling in nau8821_enable_jack_detect() by removing the unnecessary return after logging the request irq message. Signed-off-by: Cristian Ciocaltea --- sound/soc/codecs/nau8821.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/nau8821.c b/sound/soc/codecs/nau8821.c index 58d2d5e77c8f..6dffda69f1ff 100644 --- a/sound/soc/codecs/nau8821.c +++ b/sound/soc/codecs/nau8821.c @@ -1679,11 +1679,9 @@ int nau8821_enable_jack_detect(struct snd_soc_compon= ent *component, ret =3D devm_request_threaded_irq(nau8821->dev, nau8821->irq, NULL, nau8821_interrupt, IRQF_TRIGGER_LOW | IRQF_ONESHOT, "nau8821", nau8821); - if (ret) { + if (ret) dev_err(nau8821->dev, "Cannot request irq %d (%d)\n", nau8821->irq, ret); - return ret; - } =20 return ret; } --=20 2.52.0 From nobody Sun Feb 8 22:17:34 2026 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA39430CDAF; Wed, 31 Dec 2025 20:04:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767211486; cv=none; b=ouJzP6JggJNyqTAWpVdfKN23ZZoaCcdMKvUPpHbo8Q9Vb32JWL612Xej3Oj1/uQhFzi2HZP9nHM5NYBEYKGqFsni3LJuKdnaZI2snFLuS2evR6Dkk+zikt/BjWDe2+wyYA3lQ9Up9/LGfC1WMQDBSzRn1XqEG5Szg9e66j2I0LU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767211486; c=relaxed/simple; bh=n1P57dwOxahXW/vQtjNfBHnINRtQ/DHmkoESJbr/80A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=a41Qh0ZVidTM+GlR1Hu1sbTIb1sQou3PV+2Hi7H+oCMfbtVb0FPMMgT8hRC1aHjMYkWt0UkaEe2En6gjZ9XgqWohbW7wSN4Pw4D7Umqi0PC/nXsRN3xZW1WhFyZzGnKng/VHz5IwGwGbXAfuC76DyV5p4+k57dSEoVqb+b+YAuY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=nkiYZTzK; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="nkiYZTzK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1767211476; bh=n1P57dwOxahXW/vQtjNfBHnINRtQ/DHmkoESJbr/80A=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=nkiYZTzKJTUMqYWGEi1EwI8AL6iOZS5NamW5hwAtH7uUz4D3NQ/0kgcqNGX/2J5g7 S4kFGidWQZgHan+hYBTx0dgGNUFQaSpjGp58y6Kc8TITNlDJp8FFNWsmARnNhD0pFI zdv4+LicM7wmOZI7vCpTrcPpKbtoDmq0/W6HWLzH5ZEjcNsGV1sdtqROYAEhWdrmco YkmFTuDkeQbxeNUzK5NlFlpWTfzjN3wpxyVQ4GHsrBxN524BHL1HpMfduNTODAb2Zr OP4zrXQlg/ihQIHJ1ICI107WcIhPm2qVETS9sjfB0mJ9epnjKd5B7L8VS0q87zTQs1 F2HS9ZNZ/vMng== Received: from localhost (unknown [82.79.138.145]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id C12D017E368E; Wed, 31 Dec 2025 21:04:36 +0100 (CET) From: Cristian Ciocaltea Date: Wed, 31 Dec 2025 22:04:19 +0200 Subject: [PATCH 5/7] ASoC: nau8821: Simplify conditional in nau8821_get_osr() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251231-nau8821-cleanup-v1-5-6b0b76cbbb64@collabora.com> References: <20251231-nau8821-cleanup-v1-0-6b0b76cbbb64@collabora.com> In-Reply-To: <20251231-nau8821-cleanup-v1-0-6b0b76cbbb64@collabora.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Seven Lee Cc: kernel@collabora.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 Get rid of the unnecessary branch to address checkpatch complaint: WARNING: else is not generally useful after a break or return Signed-off-by: Cristian Ciocaltea --- sound/soc/codecs/nau8821.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/sound/soc/codecs/nau8821.c b/sound/soc/codecs/nau8821.c index 6dffda69f1ff..10e8c220c0e0 100644 --- a/sound/soc/codecs/nau8821.c +++ b/sound/soc/codecs/nau8821.c @@ -806,16 +806,20 @@ nau8821_get_osr(struct nau8821 *nau8821, int stream) if (stream =3D=3D SNDRV_PCM_STREAM_PLAYBACK) { regmap_read(nau8821->regmap, NAU8821_R2C_DAC_CTRL1, &osr); osr &=3D NAU8821_DAC_OVERSAMPLE_MASK; + if (osr >=3D ARRAY_SIZE(osr_dac_sel)) return NULL; + return &osr_dac_sel[osr]; - } else { - regmap_read(nau8821->regmap, NAU8821_R2B_ADC_RATE, &osr); - osr &=3D NAU8821_ADC_SYNC_DOWN_MASK; - if (osr >=3D ARRAY_SIZE(osr_adc_sel)) - return NULL; - return &osr_adc_sel[osr]; } + + regmap_read(nau8821->regmap, NAU8821_R2B_ADC_RATE, &osr); + osr &=3D NAU8821_ADC_SYNC_DOWN_MASK; + + if (osr >=3D ARRAY_SIZE(osr_adc_sel)) + return NULL; + + return &osr_adc_sel[osr]; } =20 static int nau8821_dai_startup(struct snd_pcm_substream *substream, --=20 2.52.0 From nobody Sun Feb 8 22:17:34 2026 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA41730CDB0; Wed, 31 Dec 2025 20:04:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767211486; cv=none; b=tCcgwZw74uNmAi+6oCQQRGLva3tMKWW8o5nzxHDdfMLpgOfwX+oqC9Go8xi+Ut2x1v3HauABbfqLm33k0t9cZv1vdQli1V1ybZapfX9n/gg1KsGP8IwjTgCT1NCanNmFXA+Ndy/R/OCTCkeFWiA5/o4eufWVfC0zAORR8f/N5E8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767211486; c=relaxed/simple; bh=AM65amuekUvL2dVwT3EQhiS2lVut1Fm81BBvjBbNDtE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PrKK+hg9w0dCmPNCihONPm7p8hgTFDM8F4W+ku9FSsx1HiCDP4hadXZlVqY4RGZgMZa6he2hbWgSPckEFe5CT8CAPY00gp4KCRFU0ejRcKuMxzbIo7GwbGyTHji2ALaLdLS4nV9c7fkSFDI4wiqjtYBphjlsuSUTLITo6VWkOfc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=H40tnygK; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="H40tnygK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1767211477; bh=AM65amuekUvL2dVwT3EQhiS2lVut1Fm81BBvjBbNDtE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=H40tnygKP3vJSUaboHji+p5PfmzCCq2sJSo2N6IJxa8zHh51qtpaPiUkuNnKjZ+Bq J0fuyPMCE58oFPiVVaI880EZcWtcmMUIytMU/tCtrRVl8AMXVCf3i7HW1juGJs7TJN H1IGvm2GTfhR/5GS3WtkRTHO0sR9yfkAmMtPDtp4CuzatYmCOJ+HaO0RP9UmXY0R9v C4/YtaIi9ReL6GBJS9yz1zTVAdWSTej2VygPOQmx/4dP3cnr5HGruJEgFjKQ63D6Ku uHKw6nShR/ATe7mkDA2CK6g/eX3DagLl4Ue14tCjWKlTUgjnpWbWOcT5kiTli4lGRk Prw5wzWphz/6Q== Received: from localhost (unknown [82.79.138.145]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 93C5817E0DC0; Wed, 31 Dec 2025 21:04:37 +0100 (CET) From: Cristian Ciocaltea Date: Wed, 31 Dec 2025 22:04:20 +0200 Subject: [PATCH 6/7] ASoC: nau8821: Drop unneeded braces in nau8821_hw_params() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251231-nau8821-cleanup-v1-6-6b0b76cbbb64@collabora.com> References: <20251231-nau8821-cleanup-v1-0-6b0b76cbbb64@collabora.com> In-Reply-To: <20251231-nau8821-cleanup-v1-0-6b0b76cbbb64@collabora.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Seven Lee Cc: kernel@collabora.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 Get rid of the superfluous braces and silent checkpatch complaint: WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: Cristian Ciocaltea --- sound/soc/codecs/nau8821.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/nau8821.c b/sound/soc/codecs/nau8821.c index 10e8c220c0e0..181214fa792d 100644 --- a/sound/soc/codecs/nau8821.c +++ b/sound/soc/codecs/nau8821.c @@ -872,15 +872,16 @@ static int nau8821_hw_params(struct snd_pcm_substream= *substream, if (ctrl_val & NAU8821_I2S_MS_MASTER) { /* get the bclk and fs ratio */ bclk_fs =3D snd_soc_params_to_bclk(params) / nau8821->fs; + if (bclk_fs <=3D 32) clk_div =3D 3; else if (bclk_fs <=3D 64) clk_div =3D 2; else if (bclk_fs <=3D 128) clk_div =3D 1; - else { + else return -EINVAL; - } + regmap_update_bits(nau8821->regmap, NAU8821_R1D_I2S_PCM_CTRL2, NAU8821_I2S_LRC_DIV_MASK | NAU8821_I2S_BLK_DIV_MASK, (clk_div << NAU8821_I2S_LRC_DIV_SFT) | clk_div); --=20 2.52.0 From nobody Sun Feb 8 22:17:34 2026 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C5CA30DD19; Wed, 31 Dec 2025 20:04:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767211487; cv=none; b=oM/LudmZmgmarAD/jOUrKwk0zpSxI0XAOBtcUBjOVu8vAKJuR96KlbjeI4dtH/CRxavSyzfPxoAP/0hhPpee3sacdBORFUnjIMSA7LYbZFLoBs3WPcyYlp3E8szz7kJ7nShf+E2dywHogOgEV1+ZytL6IBPobtJBfEyyl1sQE44= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767211487; c=relaxed/simple; bh=G5tbss/I9BerqD7yyqFl5i2+sbkH+2tcNPOQsdt7FAY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dlVZ8zlqjm7mne7jWzsDd9uR7qmd7ujlh5MycK8dAK/hG5nM03pwtdHAyXDlgGQwcUPKBCqHaMy0XECWoT3VNiwFCKsrV/FPjjytYX0epuGjAHsRnr/fNNJDlMTm2Ii3Fg8vYYzXBAUd6oZ2I00mE14S6IV3DOjL5DSlWh+r/d8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=a2JCYNeF; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="a2JCYNeF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1767211478; bh=G5tbss/I9BerqD7yyqFl5i2+sbkH+2tcNPOQsdt7FAY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=a2JCYNeFNK0OMuHhdOniUS4T9bsFy7b/BewAmhYxJjDckMjXFVpbXWewaH0SLat2I UoloAUYJi2BMx6xIV1whA7LKN3f4FpNpT5hw3KS5oQYX0HBQ/v2shCJy0BZ4F+YR/L IgXFHgHsC7C0O380UfmvZLNvXB4h811h9kpqxM3CFUSwdTsxkVWdotTafpkwuXI9+w DJYr0oSyAWSwY6304rSB0gEpU2dOME/ZWTBYevwJSNGHIL2lBRWZYxbcogTUvChKUK 8lmExbkmTKQf82Iqc/O3FvElUuCZEgjAEmOsnT+Bh+d4qyux4vhwatHeGofh+hr7Py XZgtVremR3vfg== Received: from localhost (unknown [82.79.138.145]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 66D6B17E0EFE; Wed, 31 Dec 2025 21:04:38 +0100 (CET) From: Cristian Ciocaltea Date: Wed, 31 Dec 2025 22:04:21 +0200 Subject: [PATCH 7/7] ASoC: nau8821: Sort #include directives Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251231-nau8821-cleanup-v1-7-6b0b76cbbb64@collabora.com> References: <20251231-nau8821-cleanup-v1-0-6b0b76cbbb64@collabora.com> In-Reply-To: <20251231-nau8821-cleanup-v1-0-6b0b76cbbb64@collabora.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Seven Lee Cc: kernel@collabora.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 Make sure #include directives are ordered alphabetically. Signed-off-by: Cristian Ciocaltea --- sound/soc/codecs/nau8821.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/nau8821.c b/sound/soc/codecs/nau8821.c index 181214fa792d..ffb526de0021 100644 --- a/sound/soc/codecs/nau8821.c +++ b/sound/soc/codecs/nau8821.c @@ -11,10 +11,10 @@ #include #include #include -#include #include -#include +#include #include +#include #include #include #include @@ -24,6 +24,7 @@ #include #include #include + #include "nau8821.h" =20 #define NAU8821_QUIRK_JD_ACTIVE_HIGH BIT(0) --=20 2.52.0