From nobody Sat Feb 7 19:45:19 2026 Received: from mail-dl1-f74.google.com (mail-dl1-f74.google.com [74.125.82.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A96D2DFF3F for ; Tue, 30 Dec 2025 23:57:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767139026; cv=none; b=jlOUW+/Z3P8in890YR1qzT5nWEz3ajdZjq1xT6NNTiMizxlH2FBZXJiG9AbfLJ47djwsj9fC92ZnbVh6qZInfv84Ivjdtxi2D5qr0o6JqwrKgiEadmAExL42+V3+/vcHCnWe5n0R5ntaE8eNNf8hEBNT4p37H0vNzP7996c+9Gc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767139026; c=relaxed/simple; bh=gTyDjneYMywgzwOsVojtgReBKWldGAntIvNhEE6gK5Y=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=gxGLlHk7hpN7WJ3phFAPyNLOK2ReAOslzWnQQdEiLC41KtZxsGGBhHloHNmJca0xarfmPmyyALMmHBQ5Hv9XX537Wf0AArKHuzFdrttiN/bkFPvZk8GQNQD0GlAxmgu5EVPVI2RXtEisL9gVKYKENZNq1f2GsKG2aBpNHz2YBzA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--boolli.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Cp+gMj20; arc=none smtp.client-ip=74.125.82.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--boolli.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Cp+gMj20" Received: by mail-dl1-f74.google.com with SMTP id a92af1059eb24-11ddcc9f85eso19818585c88.0 for ; Tue, 30 Dec 2025 15:57:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1767139024; x=1767743824; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=0z+YZ2YNsMdoMFE7LSlh6yUmpOlG2Vk2g7LqMYQuv6I=; b=Cp+gMj20HXKQi81pmNJKhz42/WS+RyIXlzQnaTxFZHxj6/P37/cvu8Mfh0QZ2Ud321 /UHwLAFnc2YrgsOgy/XL5cIU+IEpNerWB6yKo6rHBd/KWA1WUwE3B1yEnK7BagJqB5y2 hgnPNTMed2LJvzaxX2jlfTllYvEvIgOdol4w3p2CmhQnIAgrQ2kno3wA4aHYkM5ikrO3 vW9Ng826qi1gNAgXA+1lBYgj3HpUNbf8Gc1oJzirUXmgcqx9XIbQAoeIkyL0vvjKyzCf r/L8DDQSlNjjI+yRDeDoROkh4Ohc4G7qjEY8dvojj9fVMZHStC9hjLfCkL8qcKpH9HCj v1dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767139024; x=1767743824; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=0z+YZ2YNsMdoMFE7LSlh6yUmpOlG2Vk2g7LqMYQuv6I=; b=YOxrVEuhj3kxpwkRwdI4girvRQTkKrbNWq73tG8NbEcSZ2rVYAMZzJcpgMs3/6T/ST 5pw97ky+aCezGcYVqo/6fRHQ6xR8jpvmAgEi0ljopsTslRBC8o8Nu+818L7bvlJO1di1 dZN5EaHCeUoygHuMGWaga0nNaPlkNmYFL2Vn5YFlf8cukVNERs7r9XmRt2hY1TU5xKkW Pn61Zbpvjj9UZ+agqSZptLYLvr4BPFYrR5FxYgtha5Fc+Z0i2TsMHExZ4kW7JTEMZyQN hlOeXqkEkGpTNUG6BRnMaA7SSk655L/hnnu+6D9wmmdtCaRe3Wq78pSMZBCD6O0RBMZl W4/g== X-Forwarded-Encrypted: i=1; AJvYcCULDAwMx7Vqp9TK91x20BYMEarcTDNmMToRjkoqL+c6wCOusASlJWWQbx+F0b1OS0821z91aNmuMK1zpfA=@vger.kernel.org X-Gm-Message-State: AOJu0YxJ2a7GHdOHaz/myZeAdWjHG8PVRKXDluDJNRsvDW4NIgtrC8Pe 0uB6cjwlgHdf9jVddFeD4kKEsdxQthBjtFbIwzld+btD+V9fNGCTniTiZuO5wYD3jAfEgIYzDM0 vH+F4Tg== X-Google-Smtp-Source: AGHT+IHuKsYSd2kwNPtEc4XiZmk+kOE4LhPvJ+nztAMwJKOGMzdDI0Og5UaGs2DvBeC0wc83yh3yJySPuis= X-Received: from dlbrx13.prod.google.com ([2002:a05:7022:170d:b0:11f:3fcf:58c]) (user=boolli job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:e01:b0:11b:f271:835a with SMTP id a92af1059eb24-120619277e0mr35739751c88.3.1767139024417; Tue, 30 Dec 2025 15:57:04 -0800 (PST) Date: Tue, 30 Dec 2025 23:56:57 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.52.0.351.gbe84eed79e-goog Message-ID: <20251230235657.2497593-1-boolli@google.com> Subject: [PATCH] idpf: increment completion queue next_to_clean in sw marker wait routine From: Li Li To: Tony Nguyen , Przemek Kitszel , "David S. Miller" , Jakub Kicinski , Eric Dumazet , intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Decotigny , Anjali Singhai , Sridhar Samudrala , emil.s.tantilov@intel.com, Brian Vazquez , Li Li Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Currently, in idpf_wait_for_sw_marker_completion(), when an IDPF_TXD_COMPLT_SW_MARKER packet is found, the routine breaks out of the for loop and does not increment the next_to_clean counter. This causes the subsequent NAPI polls to run into the same IDPF_TXD_COMPLT_SW_MARKER packet again and print out the following: [ 23.261341] idpf 0000:05:00.0 eth1: Unknown TX completion type: 5 Instead, we should increment next_to_clean regardless when an IDPF_TXD_COMPLT_SW_MARKER packet is found. Tested: with the patch applied, we do not see the errors above from NAPI polls anymore. Signed-off-by: Li Li --- drivers/net/ethernet/intel/idpf/idpf_txrx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.c b/drivers/net/ethe= rnet/intel/idpf/idpf_txrx.c index 69bab7187e541..4435dba27a24a 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.c +++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.c @@ -2346,14 +2346,14 @@ void idpf_wait_for_sw_marker_completion(const struc= t idpf_tx_queue *txq) target =3D complq->txq_grp->txqs[id]; =20 idpf_queue_clear(SW_MARKER, target); - if (target =3D=3D txq) - break; =20 next: if (unlikely(++ntc =3D=3D complq->desc_count)) { ntc =3D 0; gen_flag =3D !gen_flag; } + if (target =3D=3D txq) + break; } while (time_before(jiffies, timeout)); =20 idpf_queue_assign(GEN_CHK, complq, gen_flag); --=20 2.52.0.351.gbe84eed79e-goog