From nobody Sun Feb 8 02:26:43 2026 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67401CA52 for ; Tue, 30 Dec 2025 22:18:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767133115; cv=none; b=oWOgRo8yh/V2TS1ZxYJFDGLSukSVPs2W6v5mH9sXDd6oJTE8uWlf166wZ4DKQl2+0qjPKvF1il+u2U4juE7QBksFpGtT7WgzYhnFrRpx9BbDjUm3A1al1g4vgwBSsTHXQ3qVkkPazKzw0lxTkvVuDUJi+xw6/cMMfLXX9Xif83U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767133115; c=relaxed/simple; bh=sOp+kd1qCh3MeJ/8yTnJMXHs8RV/SSODMC7ac2xca9s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=eZQf8hKxe5gfySLOaEPX8JTyn8X7DeSWz1vyaoeKVeirgbaj14AEigcfhgYFRsQPeqy505QiuSLgoRL74UsWewuElR2P6leS/DrdPIuXQYPdRgKpvcpxknz3Wo4Yjy+Z1PzJbOiGK6LdnMFkwoUQAARvqRM/b1pgJ+2wlEqXNPU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ACTQceiB; arc=none smtp.client-ip=209.85.222.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ACTQceiB" Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-8bc53dae8c2so1586545885a.2 for ; Tue, 30 Dec 2025 14:18:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767133113; x=1767737913; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=R79e1i+foFV/YWbiGAa8tDJk4eowJC7pJWmKNNM5++Y=; b=ACTQceiBuUuFI2IcG8ZPHgXrRahHqNihuIAFLv2QQsz0NVVoVcSDbnucm948V++yqz bGSWfVnBqCwftDFeQe6BTPGALjsRbgIo2G0SNAEmGSc8sKuq9P5EEVpYIIjKIN2a3PY8 H8z/sRDOaqywx8Q+kqtl5zrA8dZPjK0dGZqhAqqpRVFJWxSY6KfKCecMwGFhZumifEuM x9w6E+55iNt1ywjspJUESADhucJh2wjc2havOKtazUx3jrhbhKLSZqmtsevyJrqWkfBJ cAxy0OZKfB1ULKAid1qhFHDv2m0DXHDE8Vs25cY8TCAhp+Opw6U4qMlipllAhTk9BBXJ ajhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767133113; x=1767737913; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R79e1i+foFV/YWbiGAa8tDJk4eowJC7pJWmKNNM5++Y=; b=OiVs54FUfX66JTwDdCwQ5UerJL3cwp9F2Ud04WozbkgsWAL6c3Cbc2MyKThiU5CQyB tNJVyTe8rO/mN4vU6h2p2PPkQ46dXdn1EXshdXQnOJIpvJMufIQoWgm39VIg15fGkAh1 IY6QdQIl3mdxGtABS3oAGWlONjLBS4Pd8jfK2YoEdeB3+wp2ccD0RG+99nSJDNoF44nG ChhuSDBnqIX0qRoVRPxvcVo8zHxpb0/34XOMEdVFjsqwoKPJeLK0nHLicD4FvMayhYw9 ZRsp1nvhd40JMJxQWl3ZjylFDRqgZoYFhtKx/JBkOvmRC6/4Pe0Q9y6WuhUhVfY4/y2d Ig8Q== X-Forwarded-Encrypted: i=1; AJvYcCX94Z2YnZYB/7eArN+Zza24u0mHcfyqNlBXX1zyUU6mw3y6MNc59M3p1uRfZ1zCn2Pk4YX28vwlo/+fpEM=@vger.kernel.org X-Gm-Message-State: AOJu0YzMDWQmKHGoSZsJCaSWi/sIIbm5rhy7Vb1H72Hxc9PNnMnTOElh W6RV+/nPhPddDlZYCXVhlCv1fhRxAUK3KFtN0JNzAu+wP4XRW4q0P8dW X-Gm-Gg: AY/fxX55CmwJjKaWrOIHIhvYZCAruewu7OQV0iT/vR8lI/BwWXsQD9/C0E8A+3Q2IyN D97Abba3l6wUtUo81ncBC2mii/dqvI0t9dhFyuoYZDQxpgOvs6oIsqV2dmZ7qu4OhGU15/DtiJs Mp90zBBsc2gWWv0qHnq32ykh7iSr6ZBCnWbcs7WJ3u0GnKkjSGC5Q2FZuQwM44x5iwMo2n5kB8r DjSxGiBcPsbi4oqqoZ4Hj9jECKQcWOZVc736fbslmZs9XSPwtY5ASGv1yEQ1dzm1FZhVve1ma/A hAEsi3P7+iwbzckT1wu03SRzdO2pr7By0SXDpeC3SnGyrLKE+F2z9BJ0o/5JC8ipxowCUDXEgLQ AtM6cv3Mdm2Lu8QQvRSeHlyJ1yiOnLU0DPOLjS0DMYWbc4W0EM3YQO7ZOKxueDWZfTTL0eKQ4O5 BGgCjibN2bALj7MbuVfRGAv9hhjk3kBKqmCQghldAEMFOg3P/Iq30k83Xa6TRfHtb1RCltbg== X-Google-Smtp-Source: AGHT+IEISVv424OHohSbsA5+ZXBe0V5aT6h7gqVV5xL/pj/8lhTfGyO23QccIK2/X876HtDEgdFPeg== X-Received: by 2002:a05:620a:710a:b0:8ba:41b2:da01 with SMTP id af79cd13be357-8c08fd058fbmr5132069085a.71.1767133113290; Tue, 30 Dec 2025 14:18:33 -0800 (PST) Received: from YAJAT (lnsm3-toronto63-142-117-56-201.internet.virginmobile.ca. [142.117.56.201]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-88d997aeebesm253586526d6.35.2025.12.30.14.18.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Dec 2025 14:18:32 -0800 (PST) From: Yajat Kumar To: Hans de Goede , Dmitry Torokhov , linux-input@vger.kernel.org (open list:GOODIX TOUCHSCREEN), linux-kernel@vger.kernel.org (open list) Cc: Yajat Kumar Subject: [PATCH] Input: goodix - fix inverted Y coordinate on SUPI S10 Date: Tue, 30 Dec 2025 17:16:39 -0500 Message-ID: <20251230221639.582406-1-yajatapps3@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The touchscreen on the SUPI S10 reports inverted Y coordinates, causing touch input to be mirrored vertically relative to the display. Add a DMI-based quirk to invert the Y coordinate on this device so that touch input matches the display orientation. Tested on SUPI S10 tablet with Goodix touchscreen controller. Signed-off-by: Yajat Kumar Tested-by: Yajat Kumar --- drivers/input/touchscreen/goodix.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen= /goodix.c index f8798d11ec03..d675a85a9312 100644 --- a/drivers/input/touchscreen/goodix.c +++ b/drivers/input/touchscreen/goodix.c @@ -160,6 +160,22 @@ static const struct dmi_system_id inverted_x_screen[] = =3D { {} }; =20 +/* + * Those tablets have their y coordinate inverted + */ +static const struct dmi_system_id inverted_y_screen[] =3D { +#if defined(CONFIG_DMI) && defined(CONFIG_X86) + { + .ident =3D "SUPI S10", + .matches =3D { + DMI_MATCH(DMI_SYS_VENDOR, "SUPI"), + DMI_MATCH(DMI_PRODUCT_NAME, "S10") + }, + }, +#endif + {} +}; + /** * goodix_i2c_read - read data from a register of the i2c slave device. * @@ -1212,6 +1228,12 @@ static int goodix_configure_dev(struct goodix_ts_dat= a *ts) "Applying 'inverted x screen' quirk\n"); } =20 + if (dmi_check_system(inverted_y_screen)) { + ts->prop.invert_y =3D true; + dev_dbg(&ts->client->dev, + "Applying 'inverted y screen' quirk\n"); + } + error =3D input_mt_init_slots(ts->input_dev, ts->max_touch_num, INPUT_MT_DIRECT | INPUT_MT_DROP_UNUSED); if (error) { --=20 2.51.0