From nobody Sun Feb 8 21:26:34 2026 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7805299AAC for ; Tue, 30 Dec 2025 20:35:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767126930; cv=none; b=nBUsdScYhGdx7Ls2vvb6IKuHUPH92BBiQb4xUJp6lwHsFVegiqMpl0/RAAKF4pPSKsAkZ55HR4a1zLJKdmAYLA9tIl0fcHjESaGAuv4UMHzoe/u6zQxFcgrHiQUtDJLpYXlFTbcqSDvFJSJ4ecSHWZcjOWby+SIcqNW7yX66Mvw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767126930; c=relaxed/simple; bh=UAGRpfY4KwT+V4v61wxdidc8gTTnzFLqaP44Mz50hz8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=o5A4Ajj1VbUugkJ/xqF7LZ2oaJdeEMOY+3PhPoBwZvXa5b5eFNEi73mX80UbcNFKk/jXcvGkdGIxQJF6tJUDYZQyt4Lu3xay24eLHYxDJbvUZLubYjfNItZ5tc9v9d2xElx1UId4vOCfzZ+WMmUgiq43rrn4BLbfz56mfEsFtn8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=epw2/IAC; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="epw2/IAC" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-bc0d7255434so6049044a12.0 for ; Tue, 30 Dec 2025 12:35:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767126928; x=1767731728; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xNqW8ND68Qn1BInNnrDeX5W9wJC6ZSLjSp3dk9M7GPQ=; b=epw2/IACFFedkNyPfGJPyZNXKxnln9SIt1aIRK2KAC8gK3FfVl8R/ugXyCou82JeJD cxYJ6wyV0WNoX7R0gVQ/tB+IJPNEKJgjGRtozOS1bD+s05+UakNfvxtTGoiY5RFd3lko dHj8dpoEc0/zVJD0addMPTzESLa19wzBxsAIzNY9/IpBpxXxE0wVl2Z+8YGQRk2rOt07 Dp9POIACFWiWC313GZJ5hwFbUlNhbJe5GNh6Er6jWH8og/pqrg3AvaTjMY+MXxjIT3ao dpmYu9W+DLCKGz6a92/H9NzNRIvfjrwwz1Q2PsUkLfzdncY+hqyhfZmvavvctRbJJ4is BJNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767126928; x=1767731728; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xNqW8ND68Qn1BInNnrDeX5W9wJC6ZSLjSp3dk9M7GPQ=; b=Q6VsjUrSyNb5eyNLHT4DDBiYZWqrG8K0alin25kJP3sVTi9BADBLibUYfcKUa8BcFN hM/n+/UvMtOR3aCe6kk/FT5CkdraTlKfWRPChHoIImXxh6o9VUja9Ols5DUIVsfoP6L9 Ro3V5dNJRUBuvPWHbFXrVs4dJCSocvv58NHoaklnYiGh0itUZmQGMAm1so5WPG0FiSMs VGnXSrdxdV5o6zc++iQMt8mlM56ax6wWFhHqe3GFX5AvbiUbz81sFODIcgshuhM+dl3h AesgwPYLD4DZIyUzgtQpbcRKFLl6JEcVT9405D/X5pOOAhpl87d9EdKC6FucP6mEoG84 /ckg== X-Forwarded-Encrypted: i=1; AJvYcCWexswn0gN5oSf2D95UxsAKjExDc6Z49rF43sPbefC5dsXQoVrF6AUQ2pEVTjNS8Ed03yJ//kZKj17WfG4=@vger.kernel.org X-Gm-Message-State: AOJu0YwV4UEAf9WBsEneSiRHT7D7o5mshtDgoHrS1jYQnFN34ujJLVVr qZv/NP+zOtU4Cjui0yfgHPj5sOda0EtkAY2Pcu/246sTxvRGjNX8OIih X-Gm-Gg: AY/fxX77UAqjTtiO/TvNtVyiT/N81L0qLfAK/CXZ/9jYWLPPoz9CNgLIrdYBGMblmhE AFIzpJc5dRndlX09kuIsP5PeVC+cY0e3R63m518E1Cirsa0tE4r7oYqgbKFs9TirJBwGDHcbMPw zNBA+eSjqGaq11G0hlqFn4f2JlxRq88UiUWXFwk/lhdtzqM4e33qfLBOsF8UyLGTLfQLPzJ6bso GKEmnxpsvKX0v9OOzP1nqSIekf8t9tbeZI969kBtKO9i0r+gMtWYFOy3OE/CbVJsFFi3fHIMDPI fbxpECj+PcE0zuU/74r822zCu7J/n1yItKHEpPJvA9/Zt2ZoqV2GBsM4Yuet/bBef/r/r9QrzQP sDX+kilYCzvFq+w42+RZkkRZdL1/XnbLlx8Z80HDMlx26sre6xunN9FOEP0zXvWmajjo5kv8H1Z o4MEPEvwq+xkIrWd4yoron4JQ3kZY5epv2cOTISOZ+88S+Ru2zoUg+5sTsp9vk5drGc5ohuf1E3 JKNAWQ/t6NtiQ/k45jy9a57gAdfT6PK4DdfMY8Q27cbmbF5fTNgmwOrfH9SIFnJk+YSqx85 X-Google-Smtp-Source: AGHT+IEsKIgPV4K9v9BN3J2QnbXkkuZD29ZOjL2Cv8OdoAPvO3VG4YohYWZFBlHHTexO8jnbyNRtjg== X-Received: by 2002:a05:7022:92a:b0:119:e55a:9c03 with SMTP id a92af1059eb24-121722dd671mr36870001c88.31.1767126927887; Tue, 30 Dec 2025 12:35:27 -0800 (PST) Received: from Lewboski.localdomain ([181.191.143.75]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1217253c23csm128074981c88.9.2025.12.30.12.35.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Dec 2025 12:35:27 -0800 (PST) From: Tomas Borquez To: Jonathan Cameron , Greg Kroah-Hartman , Lars-Peter Clausen , Michael Hennerich Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, Tomas Borquez Subject: [PATCH v2 1/6] staging: iio: ad9832: cleanup dev_err_probe() Date: Tue, 30 Dec 2025 17:34:54 -0300 Message-ID: <20251230203459.28935-2-tomasborquez13@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251230203459.28935-1-tomasborquez13@gmail.com> References: <20251230203459.28935-1-tomasborquez13@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Cleanup dev_err_probe() by keeping messages consistent and adding error message for clock acquisition failure. Signed-off-by: Tomas Borquez --- drivers/staging/iio/frequency/ad9832.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/f= requency/ad9832.c index b87ea1781b27..a5523e2210bf 100644 --- a/drivers/staging/iio/frequency/ad9832.c +++ b/drivers/staging/iio/frequency/ad9832.c @@ -293,27 +293,28 @@ static const struct iio_info ad9832_info =3D { =20 static int ad9832_probe(struct spi_device *spi) { + struct device *dev =3D &spi->dev; struct iio_dev *indio_dev; struct ad9832_state *st; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; =20 st =3D iio_priv(indio_dev); =20 - ret =3D devm_regulator_get_enable(&spi->dev, "avdd"); + ret =3D devm_regulator_get_enable(dev, "avdd"); if (ret) - return dev_err_probe(&spi->dev, ret, "failed to enable specified AVDD vo= ltage\n"); + return dev_err_probe(dev, ret, "failed to enable AVDD supply\n"); =20 - ret =3D devm_regulator_get_enable(&spi->dev, "dvdd"); + ret =3D devm_regulator_get_enable(dev, "dvdd"); if (ret) - return dev_err_probe(&spi->dev, ret, "Failed to enable specified DVDD su= pply\n"); + return dev_err_probe(dev, ret, "failed to enable DVDD supply\n"); =20 - st->mclk =3D devm_clk_get_enabled(&spi->dev, "mclk"); + st->mclk =3D devm_clk_get_enabled(dev, "mclk"); if (IS_ERR(st->mclk)) - return PTR_ERR(st->mclk); + return dev_err_probe(dev, PTR_ERR(st->mclk), "failed to enable MCLK\n"); =20 st->spi =3D spi; mutex_init(&st->lock); --=20 2.43.0