From nobody Sun Feb 8 14:52:04 2026 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62811272816 for ; Tue, 30 Dec 2025 14:51:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767106283; cv=none; b=VyJWxVyTbfFi6JUWjMhHX7EJXSYf/qc1Et4yRMBav2VDmIu7YZEdfs7ZLgjdNMN/o3j0PLukaBYIY71RuMI+APFyjX4Lk4JDugupMYJVzRvGU06aKpmIucp9631Eb3+rS7NGqH+Z5+lj14/O7XNd57TH8Wc7AmDl9E1kkKULYV0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767106283; c=relaxed/simple; bh=PafXgWDMvXLR2Nstor1AR1m6gZWJgpmSJIc0jQ0emsk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=izw2NHss9IHOcjOMxPjk/9nyu10PCuyPZfRP8Msslj3KVlHrcTn8gLe5Kvy1CiX8a4E6d/I6w7BKoFTZdblHQRrASRQMwhdTgKg8tJ8QJw86OHzJLowSXYYjajCJwJ8d0nDffB068ZJaEBOo+st4F1KRxOUKQvPdeScU0VStlNQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=D4WjBufF; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D4WjBufF" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2a09d981507so73961465ad.1 for ; Tue, 30 Dec 2025 06:51:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767106278; x=1767711078; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xbAQovtJoKutCpVbRAys9lPE9fj9fNigF3AvHChA6z4=; b=D4WjBufFKWJRbhhoytD4vdCGmMhu9+zkffluefb8iWHWhkbSyGlsihb5EiyDdZLxco xpDywUNzYvfX5v95YvClBJo7R6ZlYMgxXYGB0pFZUx0b0aEsh+ulu8UUWwJRA4xtD0jT Lx4HDNLFPkLXbTFTcmjvpSaq1t8pWgEXbOPErmyqkYKzx+bcd6nSbB+1LkoYScN4x77N TVjadq+1uD1ZT5XMcWYUH1jdSqqpah2eoVV08gWJWRErTD6fM6rpRBBr+sYCS2tCoDld BUx/ExVeAHPy1z1WxSyWZ4RTinpR9/n9B0gkbOpkfkgaO96qOD3wAVAdsIL0tkrpkMb7 B7jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767106278; x=1767711078; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xbAQovtJoKutCpVbRAys9lPE9fj9fNigF3AvHChA6z4=; b=TS7y4keBdUF/EMwa7BpwCdr0vEoVkxJGvQNgSwm/ypvelSdmgkJTY+7+ZhrOll+EAK J9UKFI78l36pv/nurEViAYe1dpq3249jq+TdcbFkwo24L+J2DdUYfwKsyIvZmUHVQFSf RgT7QcINjPgU1nnBC9gfe6wG9lWMHBGGN/4C6eLHME9xL1+0sx55uLQM+yDGQnyEywAD 1xYRrBbZzq7zjJsjEHtgFzLrxmJzk6xlIFKcJx1nFvaqqZ6jhyP1nimq/s/oYhRR8jH6 IIjtwYNgIh9FKFna/5vSc51rBwsz8Ky1otFig4RNwu7svAXu1rPx87v6lWkUvQAcjNp3 SuFA== X-Forwarded-Encrypted: i=1; AJvYcCVT2Mdl0cWvLtdvfQc1P4NLACykSwpDItK5hyJ7wXCcLcxXhhY95sl3OaAJWbURodrFCuDxE5Y+cSBrDD0=@vger.kernel.org X-Gm-Message-State: AOJu0YxDz/g0mVkukqmFyPx5zfXsvn0ODso8gh6V8D5SokfmRT3VtCpP JN2A0P+4cUwxwr86wMt3+s2vg7dh7fA7C8EjYCoiofjAtgyNQHi0wA7Y X-Gm-Gg: AY/fxX7riwKZoTxYbM9rtqfP7XCGOHciExSAgxsUUDKe+owS3nhHZXINXqShSNHJmeq q7gPpeghwwCjKOVCbMnZKvgBq2I8AGROU/+I59mYrFKhttrSisMtBLm4BtIiaiPudZaLmDfEGO1 gsqq4eYRLOZ1NSEIJw5w47agfp3ANnNUWamWgdfulXfj2POPbsve5dXotDdYoUClompByDNYx31 U++2DufylhxRNOij6K5WeqfVx95ZnvZ/2aRfglNd+pAFi4PLnO2zEa7/hGJKeL7ODUjYqalTmXs X2WfZK2QZ/I4RfGuznSsHkyUhiBPz326nDImcgv0PYseNyA3qr7ahoezbONgu0qpb3iqAsGBVZh WUcy0GqAluEYUCyPVbqPnaBb9n2DupRf8G9ynykqckKHTmUvwwJJ4DsLds7jy4oJLDwF2ShqXt7 vhdVzKNEQndM2nlmnuv6i8OsYVJzh9fA== X-Google-Smtp-Source: AGHT+IEus/WFmxvaHScCzlZVMv3z622sVJr0P9J3GJWro2Nxl6f1Smit9+HrdVV6jt9rstkznaDlyg== X-Received: by 2002:a17:903:2450:b0:2a0:e5c3:d149 with SMTP id d9443c01a7336-2a2f0d40410mr353178025ad.23.1767106278186; Tue, 30 Dec 2025 06:51:18 -0800 (PST) Received: from archlinux ([2405:201:1b:225c:eb9d:1fc0:f95c:bd90]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3d5d86esm301257245ad.74.2025.12.30.06.51.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Dec 2025 06:51:17 -0800 (PST) From: Krishna Chomal To: ilpo.jarvinen@linux.intel.com, hansg@kernel.org, linux@roeck-us.net Cc: platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Krishna Chomal Subject: [PATCH v2 2/2] platform/x86: hp-wmi: implement fan keep-alive Date: Tue, 30 Dec 2025 20:20:53 +0530 Message-ID: <20251230145053.516196-3-krishna.chomal108@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230145053.516196-1-krishna.chomal108@gmail.com> References: <20251225142310.204831-1-krishna.chomal108@gmail.com> <20251230145053.516196-1-krishna.chomal108@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The firmware on some HP laptops automatically reverts the fan speed control to "Auto" mode after a 120 second timeout window. To ensure that the user-selected fan profile (Max/Manual) persists, implement a keep-alive mechanism that periodically refreshes the fan mode trigger before the timeout occurs. - Introduce a delayed workqueue to trigger the fan mode refresh every 90 seconds, ensuring the system maintains the correct fan mode setting. - Integrate the refresh mechanism into hp_wmi_hwmon_enforce_ctx() to start, update or cancel the keep-alive process based on the current fan mode. This ensures that the driver stays in sync with the hardware. Tested on: HP Omen 16-wf1xxx (board ID 8C78) Signed-off-by: Krishna Chomal --- Changes in v2: - Explicitly specify time unit in KEEP_ALIVE_DELAY macro - Handle work rescheduling directly in switch/case --- drivers/platform/x86/hp/hp-wmi.c | 46 +++++++++++++++++++++++++++++--- 1 file changed, 43 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-= wmi.c index ef419575174c..cf9327e1f40e 100644 --- a/drivers/platform/x86/hp/hp-wmi.c +++ b/drivers/platform/x86/hp/hp-wmi.c @@ -34,6 +34,7 @@ #include #include #include +#include =20 MODULE_AUTHOR("Matthew Garrett "); MODULE_DESCRIPTION("HP laptop WMI driver"); @@ -368,6 +369,7 @@ struct hp_wmi_hwmon_priv { u8 gpu_delta; u8 mode; u8 pwm; + struct delayed_work keep_alive_dwork; }; =20 struct victus_s_fan_table_header { @@ -386,6 +388,12 @@ struct victus_s_fan_table { struct victus_s_fan_table_entry entries[]; } __packed; =20 +/* + * 90s delay to prevent the firmware from resetting fan mode after fixed + * 120s timeout + */ +#define KEEP_ALIVE_DELAY_SECS 90 + static inline u8 rpm_to_pwm(u8 rpm, struct hp_wmi_hwmon_priv *priv) { return fixp_linear_interpolate(0, 0, priv->max_rpm, U8_MAX, @@ -2093,6 +2101,7 @@ static int __init hp_wmi_bios_setup(struct platform_d= evice *device) static void __exit hp_wmi_bios_remove(struct platform_device *device) { int i; + struct hp_wmi_hwmon_priv *ctx; =20 for (i =3D 0; i < rfkill2_count; i++) { rfkill_unregister(rfkill2[i].rfkill); @@ -2111,6 +2120,10 @@ static void __exit hp_wmi_bios_remove(struct platfor= m_device *device) rfkill_unregister(wwan_rfkill); rfkill_destroy(wwan_rfkill); } + + ctx =3D platform_get_drvdata(device); + if (ctx) + cancel_delayed_work_sync(&ctx->keep_alive_dwork); } =20 static int hp_wmi_resume_handler(struct device *device) @@ -2179,12 +2192,20 @@ static int hp_wmi_apply_fan_settings(struct hp_wmi_= hwmon_priv *priv) if (is_victus_s_thermal_profile()) hp_wmi_get_fan_count_userdefine_trigger(); ret =3D hp_wmi_fan_speed_max_set(1); - return ret; + if (ret < 0) + return ret; + schedule_delayed_work(&priv->keep_alive_dwork, + secs_to_jiffies(KEEP_ALIVE_DELAY_SECS)); + return 0; case PWM_MODE_MANUAL: if (!is_victus_s_thermal_profile()) return -EOPNOTSUPP; ret =3D hp_wmi_fan_speed_set(priv, pwm_to_rpm(priv->pwm, priv)); - return ret; + if (ret < 0) + return ret; + schedule_delayed_work(&priv->keep_alive_dwork, + secs_to_jiffies(KEEP_ALIVE_DELAY_SECS)); + return 0; case PWM_MODE_AUTO: if (is_victus_s_thermal_profile()) { hp_wmi_get_fan_count_userdefine_trigger(); @@ -2192,7 +2213,10 @@ static int hp_wmi_apply_fan_settings(struct hp_wmi_h= wmon_priv *priv) } else { ret =3D hp_wmi_fan_speed_max_set(0); } - return ret; + if (ret < 0) + return ret; + cancel_delayed_work_sync(&priv->keep_alive_dwork); + return 0; default: /* shouldn't happen */ return -EINVAL; @@ -2337,6 +2361,20 @@ static const struct hwmon_chip_info chip_info =3D { .info =3D info, }; =20 +static void hp_wmi_hwmon_keep_alive_handler(struct work_struct *work) +{ + struct delayed_work *dwork; + struct hp_wmi_hwmon_priv *ctx; + + dwork =3D to_delayed_work(work); + ctx =3D container_of(dwork, struct hp_wmi_hwmon_priv, keep_alive_dwork); + /* + * Re-apply the current hwmon context settings. + * NOTE: hp_wmi_apply_fan_settings will handle the re-scheduling. + */ + hp_wmi_apply_fan_settings(ctx); +} + static int hp_wmi_setup_fan_settings(struct hp_wmi_hwmon_priv *priv) { u8 fan_data[128] =3D { 0 }; @@ -2395,6 +2433,8 @@ static int hp_wmi_hwmon_init(void) return PTR_ERR(hwmon); } =20 + INIT_DELAYED_WORK(&priv->keep_alive_dwork, hp_wmi_hwmon_keep_alive_handle= r); + platform_set_drvdata(hp_wmi_platform_dev, priv); hp_wmi_apply_fan_settings(priv); =20 return 0; --=20 2.52.0