From nobody Sat Feb 7 18:21:06 2026 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 400D21F4CBB for ; Tue, 30 Dec 2025 13:21:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767100896; cv=none; b=s21V1jnlCb3GSF+fmxil3JhICpO6cMFNvn+guG8Dn0wcz4MmltW7+dph+Mt4oTuNoJ5cjH8NXot13zFtFp4S0Fa4JbuA3WCPDd5i/coZKfy9xnE7D+7KHpX9x8liaDeOEUtbU5eo36+64mC6f5LLXIqOlEUpjPyO1tSmWvFbEpQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767100896; c=relaxed/simple; bh=Id22RWJdiD1lWCvJ6wPUpNkE50dgXyI6el9nvkjasPs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=k07c9ah1Xzj03wFyKSvoaTdJdbAuA48wbpG1z506diy35VM29hdJhBtNt+Kpc0zhnm1+BVfWYOtP2jfgiuksP4b1YW4hHo8N7Z2rp5+iTe+/pWkMRt1zsrNgHXu3+H+NIzNnVyFzwtaAm5ya9/7aJOxuqiLCjg16wWZnOeKRLS4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OmSZ1tXR; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OmSZ1tXR" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-7aa9be9f03aso8241287b3a.2 for ; Tue, 30 Dec 2025 05:21:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767100894; x=1767705694; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XDWnxPQ5/BZi65DH5ONyZDXL3Tpvrkq0u7vocACuE+U=; b=OmSZ1tXR3VgySbjIuZAVaPtGXyRPeFxBkCojSSw2jDF7n8Z1JAfeldf4s9boFIZUN9 ZykW5CweeV+LBJhljIjZCW1MNrvGotUKrUAGZobPLUF6ODSFGyJIcz1BqHCX5q7A+maL muwOD+sxSKjX7QmvEDtUeMSTbEeQVECnqSvQpcQC7B3YmzSkqdsU0mT305D8vCvsxuhz ZisgR0OKh5LyzkuGYqnaDietOFeGabzvrWmNda+aon5pVkGiVz8VPGjxa1VDXYq6HA5A h3UNb30nqhwlW6bnuCdoiZ13zD4++kOHa8sCApmfW0U0MAX2jn/gTEtJDGYOZz8f0F8P 9P0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767100894; x=1767705694; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XDWnxPQ5/BZi65DH5ONyZDXL3Tpvrkq0u7vocACuE+U=; b=eUT5E/hoHMEcOnxDnPtd/iQdzb2011hYBo3dgS6Zx26hBC5rYZiMBVA/KqkROQuscC aXV4Jr1XUWs+iIuGZsQKJ3Q/Q5JlDbmgPjHY8QLN3vbRAa4z1x/wqmxakQlxMlU2QWr9 mgn4EapoJRl87NoqpIeHJy7MVmsarD3HNGBB0qfZNXWMkUb8QkOj9gX+GBt2F6gFnpEM vYbtGJxt5AaERwc1PgXPAXkZ/KD5jHAZDy7B6ROD7mldU52LH/c64zF4iiGFy1DhWvKY jEdFAJ1+d9KCOyibOHH68fe/hH1uszeKhxZ27EH1MOx9WY4OswriabwbSsvD/OySksLV EKPw== X-Forwarded-Encrypted: i=1; AJvYcCXFXh8UE13VVocFl8/8Xn4qTRrlumtvqKxXy16EBdDiR4Hisv5HOjjer1VQubAJYZ2DWe/vJlSe0XcwgCA=@vger.kernel.org X-Gm-Message-State: AOJu0YybFD89SGgJmHS5egNIq/jThQRV3qiWQdNx2qBKUrmp4YWmO9Lt 5Rv/PR+OP+49ob0rrc62NNUTSGx7mPz4GWtABvo7nflISnuOoqpo3yOw X-Gm-Gg: AY/fxX5tmwmWLuzUM/8+uDKGbOs6NE6aX9FGuJCWpftDgqrOECDG6YDEUlBRYgfGpvp prFdbLbeJWPzNL2gPje0l7o9QQ+LM8k+b+AIxFA+sW6yCDEpI7c8fzu2Z8rUXXb+CpPDEce1/cZ 4IkxRtxr+gEE3to9ZjIs6oMSv3fUmxpOaIdVNO6Um2w7/fWUzk6tv0ddn39KZSbuEnpCvCEvNcD niGZIVK8oTzMSzA/lM4fciCTzw5s18St50WpCA3TzXDmto7u8YoKztSDmxH7eFXQsCvuSXokLx7 t3z+b1xPgLoUW9gtI/BVGmPiPKzexTkm8NvT8Trl7WGP/7l3aoqK6dgnyQStT3CkjuTHTAi4FKk 9exqqsQi0mj1YA7TD2be4CWRftgJaw0MJdZ17wyQxGhAGXKOgaS2iZ1hwAjws5z85SOWcdXAi/0 5G3Y0KihHunHWtZbCr8myX2KkaDoAUqZPrGOE= X-Google-Smtp-Source: AGHT+IHKH0V9VAEfdHhckfOoBsAhYOHCEl8/fRkP84Km/yU8GhngDkm43LFibTbH/iRmH1/msFbvAQ== X-Received: by 2002:a05:6a00:bc90:b0:7e8:4471:8c1 with SMTP id d2e1a72fcca58-7ff6627b86fmr30752936b3a.34.1767100894401; Tue, 30 Dec 2025 05:21:34 -0800 (PST) Received: from fedora ([61.74.238.173]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e88cd71sm32469013b3a.64.2025.12.30.05.21.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Dec 2025 05:21:33 -0800 (PST) From: SeungJu Cheon To: antoniu.miclaus@analog.com, lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org Cc: andriy.shevchenko@intel.com, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, SeungJu Cheon Subject: [PATCH v2] iio:frequency:adf4377: Fix duplicated soft reset mask Date: Tue, 30 Dec 2025 22:21:26 +0900 Message-ID: <20251230132126.217802-1-suunj1331@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230123609.210454-1-suunj1331@gmail.com> References: <20251230123609.210454-1-suunj1331@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The regmap_read_poll_timeout() uses ADF4377_0000_SOFT_RESET_R_MSK twice instead of checking both SOFT_RESET_MSK (bit 0) and SOFT_RESET_R_MSK (bit 7). This causes incomplete reset status check. Fix by using both masks as done in regmap_update_bits() above. Fixes: eda549e2e524 ("iio:frequency:adf4377: add support for ADF4377") Signed-off-by: SeungJu Cheon --- drivers/iio/frequency/adf4377.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/frequency/adf4377.c b/drivers/iio/frequency/adf437= 7.c index 08833b7035e4..48aa4b015a14 100644 --- a/drivers/iio/frequency/adf4377.c +++ b/drivers/iio/frequency/adf4377.c @@ -501,7 +501,7 @@ static int adf4377_soft_reset(struct adf4377_state *st) return ret; =20 return regmap_read_poll_timeout(st->regmap, 0x0, read_val, - !(read_val & (ADF4377_0000_SOFT_RESET_R_MSK | + !(read_val & (ADF4377_0000_SOFT_RESET_MSK | ADF4377_0000_SOFT_RESET_R_MSK)), 200, 200 * 100); } =20 --=20 2.52.0