From nobody Mon Feb 9 11:29:44 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF43D8F5B for ; Tue, 30 Dec 2025 11:02:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767092557; cv=none; b=MAGqIMpjrg8JdnaVgQ/VfAk5VCho3dPHywbe0oD2OetnZC+TPKY/vhR6DvjMjilT5oqTfiJHpxjNJflPBlPGUo/Dgs7ZzJB0W0T1I6G93iXgWLjN9AVgXOqy6YTVSJqHMYbzYrezxGbsLlfu8REolw5wpn9Y0oBJjmO/lnEREns= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767092557; c=relaxed/simple; bh=m50kh3FueoAo7RgZQTmW1gLTt+u3WeihoOaE+wK6BZ0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=rmqJRLbdXqmexVi4Iu1rIh4Pr7I+IbNLUeRYmr98EQZRNz0U9fg4bglPVca9i7Pik7KQROL6OlK80UAQ6cbRj9qgjznzIUQULUyKdlZwR7ZX6sDatyCSNAJp/fDTbHS0/XtrM92G5kr0moFWVAnVEnKM6VOFoMqECKqPSDLgdAo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nLzKyOg4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=g6x+p22y; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nLzKyOg4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="g6x+p22y" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BU541FE3538683 for ; Tue, 30 Dec 2025 11:02:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=uXOb6/A5UVi 94XYfCLNblq+Mqdl95+smoRAtSR12Qsc=; b=nLzKyOg4PiyG2B1JCNk3PVrbwLP OsWjO2chMmmxsV4Hk/qNTO3EL1PW7WPYUAGr1SlIZRuBSAA02SCbqs7sxBot62g3 na/gZ/Un+7qSOBP/0LASmN7tTWShrV6g0UrjCCZDxFEK+ter41AlnyEt5gR/e8LZ DC6/cMQA3HpHJgEjjbogb30bRrN+lMOh/vh7IXq34Srpn37AxBcgGH4M2cO+21kY GvxK2EfkBYNkxkwWGEFjUBxZUztjHso3CvchhzSM5g4jPW3sxfdIud4Iuys/i5yN el0Onvgj6SKVwxM/TygjBDwFoTiSeetjpINpfu1Z7tTzMNOwmm4/ylZc8oA== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bc88ygsr2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Dec 2025 11:02:34 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-34c387d3eb6so9129133a91.2 for ; Tue, 30 Dec 2025 03:02:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767092554; x=1767697354; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uXOb6/A5UVi94XYfCLNblq+Mqdl95+smoRAtSR12Qsc=; b=g6x+p22y2Ujj9VEUehHxDZjbWXgU50RekYr15HHuQDeFA2GSCpLtyY28X1rnislaVt nNFt/W33fCXj16/uY7wxaszY8uRIm6T4Yon3C0h2/Vgqnt6eb6SMKffjlkKSrJ5142yH U/G+H+OE8HE7QXLSf6/Cce8sr93FtMZnDI12Jdk61tRIqLVur+WgXCtr1owW1ZHHnm4a FbHWFCrGPOFCk2lfvZgJOHUKUMAC0TKFhV6mLk1fJUOvCWGYe5zUYm/piejyTbyEKOwe nyuZ8gyYUwBwCFJUN8vqZIyWIinRP9izblSaUn4uyN2xGzT74cdYrFIbbsMic7iLzn9O X9jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767092554; x=1767697354; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uXOb6/A5UVi94XYfCLNblq+Mqdl95+smoRAtSR12Qsc=; b=aWIYPbhBVvsZV4STwGHXLdu6+5ALGupcGy9GuCd0jtAoE8YxCk4A9e/y9DacBWp2k6 7vOBop4zDM1zJsYejxJny6i3CrFV4UgyDdeuQEpXECn7XHey/3FMYGyCUPYuUz3Shm+p F9AbKM1LBV9OqlcnPc0AZJ131D1zlmtVUjzrjwTvLHtUsvoH4UEY2z6JTaPyQuSSubXs pinR4rAeXGlTKsKHXPKwOWNjvPRg/WZAz5IOa5BMazeDM0ZHGB25jsAdPAPkch68vB3D 8s+n5F5jndFDDh8DvBykrsumwnTzHQsJGYI7jrlr31YpJE3zv9fU0z3n0dzaTT1EI5DE N4dQ== X-Forwarded-Encrypted: i=1; AJvYcCWIeVM//4m15JnNno5Ibct2hvS87QqyOPXPiD5FclygnYwWf/W+xioC5MYseQDOWWGQxoiMVe6yWMnCuzE=@vger.kernel.org X-Gm-Message-State: AOJu0YxIQu6TP2V251OCMYrP1tJkKimAMyHt8j0h4CpSuxp8ISQu8XGU lWk/gUJFn5tjY6PpPStpI+pZYzgas5/cA0nb7BYn0RmeF4tAWh+p846NAVOTphEUoCDPg3NxweG 45FWr/v6S4b87oB7N0bCHOfocxxUJ6uGb4jIa5xB5ggETMyd1XUI7yYmUwWMuGt4oCWM= X-Gm-Gg: AY/fxX519ARn+GTbNnF8HChZLdT18MhcM59yJk4RqvK9VVunBRPzCn4EZ5/0C4nYmWB BPdM6WsMFnBpJpQC+cbZhp5nV5y/xKTX+u/sRlOmCj9qy7qlm4eVFsOSrGe8wIw8n4DlQdl3fEO WRvO/mXFpKhcyPNSc8/qLLRU95OW/ebLhF+zMXmIwU2ovT4/Ko/87GvB3xk7Jdhy+SV+1egWCgc S1PS4GuG1NCEs+bVBol6jEHHBAaPy0tC+Gf1V/RQc8hqTF55kt25DBDD34hblLQGb96DGjzdXIt F1KAMYKyDqIHNboqCVulnKGBbWXpVD+R/WpURj2yREYJr9NzDeletGvOpZt2JskqpQE8zYS0GWs dXrF1A9SX0qj5Dwp0kn6VH3baeYqwTVmbQPwKuhbwgA== X-Received: by 2002:a05:6a21:6d9a:b0:35d:2172:5ffb with SMTP id adf61e73a8af0-376a94b9f40mr33065458637.47.1767092554352; Tue, 30 Dec 2025 03:02:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IFmzcXCgCAF/KfhFTejp806J8JhYinHBklMJhbJpOqY8ALnUh2jYcR9CnXOC5f6eAcCigeiOA== X-Received: by 2002:a05:6a21:6d9a:b0:35d:2172:5ffb with SMTP id adf61e73a8af0-376a94b9f40mr33065431637.47.1767092553805; Tue, 30 Dec 2025 03:02:33 -0800 (PST) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c3a4deb6f17sm2556908a12.22.2025.12.30.03.02.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Dec 2025 03:02:33 -0800 (PST) From: Ekansh Gupta To: srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com, stable@kernel.org Subject: [PATCH v3 1/3] misc: fastrpc: Sanitize address logging and remove tabs Date: Tue, 30 Dec 2025 16:32:23 +0530 Message-Id: <20251230110225.3655707-2-ekansh.gupta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251230110225.3655707-1-ekansh.gupta@oss.qualcomm.com> References: <20251230110225.3655707-1-ekansh.gupta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=POcCOPqC c=1 sm=1 tr=0 ts=6953b14b cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=TXGx01ld9870rz7a8QIA:9 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-ORIG-GUID: xFuEijb0rJtySqS2NoU36gi3CmTj09uz X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjMwMDA5OSBTYWx0ZWRfXz50b3swVNeXi s3AR46yNNe0Nq+fMa+DDgC+kVRWPwkdHdOfe0aj84EwxBjBRsz//ryGdBFkZg0013500NVBDseK e3MkkWVOmARYDTaEbwkyiy916B0M3Yuk80CA2WGPBQvodIavwAOkUffqxme3iuK66QoIODc4n3w cpWNQwv7GVISYTUPdMTm3aRHQVLRJIyu33VR7CO1v5F2MmHSnB5l/u2NiLG1bsYXD0ldSdewHrH wXPEe4jFICel4AXzeX8Ca/bOWZbo8AmCYjgxNNYZTqCyVVuwkiYJnbRIHz8CcUxm9ZFRgmsLts5 ecC6mnoxQs2VZGt+QHNDXhA/eD0KgFDH4fjzW6qV8Y2dgYrENC2TfErnC7LCw0wusKiySiHq+u8 5CtUYZ8/6aJ14tiyKuKhuXmgIs9WQvdI9QeWqJuAPXIYKQhapFwvHUvy8uuBdEl/gHF4/uv7V/h 1z3Gm53O4UogUxBA1gg== X-Proofpoint-GUID: xFuEijb0rJtySqS2NoU36gi3CmTj09uz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-29_07,2025-12-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 bulkscore=0 phishscore=0 clxscore=1015 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512300099 Content-Type: text/plain; charset="utf-8" Avoid printing raw addresses in driver logs by using %p for remote buffer addresses. This reduces the risk of information leaks and conforms to kernel logging guidelines. Remove tabs in dev_* messages. Fixes: 2419e55e532d ("misc: fastrpc: add mmap/unmap support") Cc: stable@kernel.org Signed-off-by: Ekansh Gupta --- drivers/misc/fastrpc.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index ee652ef01534..408fe47e9db7 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -1830,13 +1830,13 @@ static int fastrpc_req_munmap_impl(struct fastrpc_u= ser *fl, struct fastrpc_buf * err =3D fastrpc_internal_invoke(fl, true, FASTRPC_INIT_HANDLE, sc, &args[0]); if (!err) { - dev_dbg(dev, "unmmap\tpt 0x%09lx OK\n", buf->raddr); + dev_dbg(dev, "unmap OK: raddr=3D%p\n", (void *)(unsigned long)buf->raddr= ); spin_lock(&fl->lock); list_del(&buf->node); spin_unlock(&fl->lock); fastrpc_buf_free(buf); } else { - dev_err(dev, "unmmap\tpt 0x%09lx ERROR\n", buf->raddr); + dev_err(dev, "unmap error: raddr=3D%p\n", (void *)(unsigned long)buf->ra= ddr); } =20 return err; @@ -1861,8 +1861,8 @@ static int fastrpc_req_munmap(struct fastrpc_user *fl= , char __user *argp) spin_unlock(&fl->lock); =20 if (!buf) { - dev_err(dev, "mmap\t\tpt 0x%09llx [len 0x%08llx] not in list\n", - req.vaddrout, req.size); + dev_err(dev, "buffer not found: addr=3D%p [len=3D0x%08llx]\n", + (void *)(unsigned long)req.vaddrout, req.size); return -EINVAL; } =20 @@ -1959,8 +1959,8 @@ static int fastrpc_req_mmap(struct fastrpc_user *fl, = char __user *argp) goto err_assign; } =20 - dev_dbg(dev, "mmap\t\tpt 0x%09lx OK [len 0x%08llx]\n", - buf->raddr, buf->size); + dev_dbg(dev, "mmap OK: raddr=3D%p [len=3D0x%08llx]\n", + (void *)(unsigned long)buf->raddr, buf->size); =20 return 0; =20 @@ -2006,7 +2006,8 @@ static int fastrpc_req_mem_unmap_impl(struct fastrpc_= user *fl, struct fastrpc_me err =3D fastrpc_internal_invoke(fl, true, FASTRPC_INIT_HANDLE, sc, &args[0]); if (err) { - dev_err(dev, "unmmap\tpt fd =3D %d, 0x%09llx error\n", map->fd, map->ra= ddr); + dev_err(dev, "unmap error: fd=3D%d, raddr=3D%p\n", + map->fd, (void *)(unsigned long)map->raddr); return err; } fastrpc_map_put(map); @@ -2074,8 +2075,8 @@ static int fastrpc_req_mem_map(struct fastrpc_user *f= l, char __user *argp) sc =3D FASTRPC_SCALARS(FASTRPC_RMID_INIT_MEM_MAP, 3, 1); err =3D fastrpc_internal_invoke(fl, true, FASTRPC_INIT_HANDLE, sc, &args[= 0]); if (err) { - dev_err(dev, "mem mmap error, fd %d, vaddr %llx, size %lld\n", - req.fd, req.vaddrin, map->len); + dev_err(dev, "mem mmap error: fd=3D%d, vaddrin=3D%p, size=3D%lld\n", + req.fd, (void *)(unsigned long)req.vaddrin, map->len); goto err_invoke; } =20 --=20 2.34.1