From nobody Sun Feb 8 18:15:47 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03E682E0418 for ; Tue, 30 Dec 2025 05:29:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767072550; cv=none; b=g8mC7fK/4GFEK6QZVP318U+XU2ZiKfznTo9zFQMI1GMA9RsROn3AApUnDq7A5TyQhtA5tgWjK1LeU1LLY+GICK0C71g4CABtBWeRLRbrBaIb7RwmozJDZBwU2mb6/y8TtVJeKUqvnOUOb/U7r3li2p/L6z0NACWaC94wShwGYqA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767072550; c=relaxed/simple; bh=NLZLkjHuusyZxcw9lTFQIq8VGGtemLVYiNqCQHZYJL4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HxWNor3xSylTHTuxMgbm+2SrSMjb5p2E7IIc5UwGiWueWXH4wzrnDpVCP8zZSybPvzfbMwnFKcDqZ1p9vOpGYWWPBzurvm8sDZ5mPQiNimkUtRKJw3NnardCGppogfOrEoB8zFPxkY4NON6q60TWMR493vxexQga8VJc1sh4sns= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KNvpcxIY; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KNvpcxIY" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2a0d06ffa2aso119082145ad.3 for ; Mon, 29 Dec 2025 21:29:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767072548; x=1767677348; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9ci5hl1fGtHa6SMuwo1VapvWaLUMCAvqlqzaI482cWA=; b=KNvpcxIYzc/Nn8MFw9dep+CALY84eksZAo0WvR/gSdQXEs3jXjLIwRcqdMKH1Hmq16 nz9gJZc38J5sKVNTy1mKQDdBgagvj/46awh1jFTgCB0X1UYh4mhi8yZMq3+Lw70cfV2y z6a+nV0ygViFK8la3fDgOOyZaNuIgLwpCZyRclxW7f74KKpNC/NfVTDpIS5/b2Ccr6Lr d1GQ0RG4+9nsYFScie75W5L2KZxSXh1/kWnRBePPiUrhjuvNCLDWWU7dG2P8phW7CCEm SsFf5Lpxi+5xPEV11uk5zk/1Nyifv+ReDtyCsnzO8uOmgxsTp+nItzT0f3My8laCl7O5 NH5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767072548; x=1767677348; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9ci5hl1fGtHa6SMuwo1VapvWaLUMCAvqlqzaI482cWA=; b=GiSu0k3NlHUlakGZHTKZksR0tLYJnVbK2khFdILaOFlt4DLKnBtynT6hPCgC73rWYU 6svpn7aNHUBx2rsx71jrcwt8yKBHBYQD2InQvqGdP1eFCXVNmumDdXRcivP7MqYQjyhY B2FT+O0a8QyEKiv72owzN/9Rmd4HcLHBLVGNRWVq1W5o8AW0j1hrBmsjYsEYY0zBmc3L de1H1n4tN1I4KeQlEclhUPF7Y1oVFOkWiQGn5GSx0XgbZuuzrOFLBMVAfXeifkS2GU0I cv9WLoDZzoLi1gBQoxdZK13UqGcg6+uZGalSiW0rcsCvKtpfGim9izkqa9yfHHCZhlFv cYHA== X-Gm-Message-State: AOJu0YzUGRb/nj1aReiQ6N9xfuJkO8503U+T8qOjbuaBCl+ED896Cscb VCBGhyy17KNZhouigfhUSPdo/abzHpjuv+LfKJVy6e0UbVQxNAIe69on X-Gm-Gg: AY/fxX5ChQ9JsMYG/26C6UiuRZ4vP4HaCukBWJ1SvjExVEyFjxA3WRmUVbp+OAE3lk5 GJ0JIfCVNSEpPfQpzVcfYtFe12fpOIUQ/YaGS5HWhlY8CGc8ENUFEWs0CUnxidNULcd+XAXTbnz 50dz3ERIwiBzE7XCaPO9hzf+aodUAgp2SSOynlsfdUCIlzBzSTQUTB0FyoBP4MnRSfnmPHeY11E uPWVg3PY+RShdTWmrcVlKBwqpWMP+AQ3RuK8u7jv5d2Mas06aQ+Qjaz41XPcdrpzxAEnZZAeRs8 oKt+CZUKa/eAhyUy2Yokf0aOFF/J6tx0uuwmUE55IhXOn+94CWtIxCOlJIOL0bwHKEfQWsTaLjz buB+859Ycu2u2ZD9jPlzhHOQLe0H5mlIxDMPvtgPfQip1PyCZu0XfJL+3RmwCqLymI3klC+TgmD 1qua0nr6X9gdyQslZ/INXj3s05mF0bB6gW0Q9TQBHjNQ== X-Google-Smtp-Source: AGHT+IGHZFAx8HgkjBpBEKVqWvo2fMWKQIfWR+KFRWNCjGwdqjZSd66OErzGlHaqwrUbyJ5EQMboOQ== X-Received: by 2002:a17:903:4405:b0:295:565b:c691 with SMTP id d9443c01a7336-2a2f22292e6mr304546365ad.17.1767072548211; Mon, 29 Dec 2025 21:29:08 -0800 (PST) Received: from cmpatel-home.hsd1.or.comcast.net ([2601:1c0:5780:9200:f7a0:c2f:d915:faf0]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3c8286esm289290375ad.33.2025.12.29.21.29.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Dec 2025 21:29:07 -0800 (PST) From: Chintan Patel To: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-omap@vger.kernel.org Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tzimmermann@suse.de, andy@kernel.org, deller@gmx.de, gregkh@linuxfoundation.org, Chintan Patel Subject: [PATCH v3 3/4] fbdev: omapfb: Make FB_DEVICE dependency optional Date: Mon, 29 Dec 2025 21:28:21 -0800 Message-ID: <20251230052827.4676-4-chintanlike@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251230052827.4676-1-chintanlike@gmail.com> References: <20251230052827.4676-1-chintanlike@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" omapfb provides several sysfs interfaces for framebuffer configuration and debugging, but these are not required for the core driver. Remove the hard dependency on CONFIG_FB_DEVICE and make sysfs support optional by using dev_of_fbinfo() to obtain the backing device at runtime. When FB_DEVICE is disabled, sysfs operations are skipped while the code still builds and is type-checked. Suggested-by: Helge Deller Signed-off-by: Chintan Patel Reviewed-by: Helge Deller --- drivers/video/fbdev/omap2/omapfb/Kconfig | 3 ++- drivers/video/fbdev/omap2/omapfb/omapfb-sysfs.c | 16 ++++++++++++---- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/Kconfig b/drivers/video/fbdev= /omap2/omapfb/Kconfig index f4cdf999a080..2d20e79adefc 100644 --- a/drivers/video/fbdev/omap2/omapfb/Kconfig +++ b/drivers/video/fbdev/omap2/omapfb/Kconfig @@ -5,7 +5,6 @@ config OMAP2_VRFB menuconfig FB_OMAP2 tristate "OMAP2+ frame buffer support" depends on FB - depends on FB_DEVICE depends on DRM_OMAP =3D n depends on GPIOLIB select FB_OMAP2_DSS @@ -13,6 +12,8 @@ menuconfig FB_OMAP2 select FB_IOMEM_HELPERS help Frame buffer driver for OMAP2+ based boards. + FB_DEVICE is not required, but if enabled, provides sysfs interface + for framebuffer configuration and debugging. =20 if FB_OMAP2 =20 diff --git a/drivers/video/fbdev/omap2/omapfb/omapfb-sysfs.c b/drivers/vide= o/fbdev/omap2/omapfb/omapfb-sysfs.c index 831b2c2fbdf9..ef555dd598aa 100644 --- a/drivers/video/fbdev/omap2/omapfb/omapfb-sysfs.c +++ b/drivers/video/fbdev/omap2/omapfb/omapfb-sysfs.c @@ -558,10 +558,14 @@ int omapfb_create_sysfs(struct omapfb2_device *fbdev) =20 DBG("create sysfs for fbs\n"); for (i =3D 0; i < fbdev->num_fbs; i++) { + struct device *dev =3D dev_of_fbinfo(fbdev->fbs[i]); int t; + + if (!dev) + continue; + for (t =3D 0; t < ARRAY_SIZE(omapfb_attrs); t++) { - r =3D device_create_file(fbdev->fbs[i]->dev, - &omapfb_attrs[t]); + r =3D device_create_file(dev, &omapfb_attrs[t]); =20 if (r) { dev_err(fbdev->dev, "failed to create sysfs " @@ -580,9 +584,13 @@ void omapfb_remove_sysfs(struct omapfb2_device *fbdev) =20 DBG("remove sysfs for fbs\n"); for (i =3D 0; i < fbdev->num_fbs; i++) { + struct device *dev =3D dev_of_fbinfo(fbdev->fbs[i]); + + if (!dev) + continue; + for (t =3D 0; t < ARRAY_SIZE(omapfb_attrs); t++) - device_remove_file(fbdev->fbs[i]->dev, - &omapfb_attrs[t]); + device_remove_file(dev, &omapfb_attrs[t]); } } =20 --=20 2.43.0