From nobody Sat Feb 7 18:15:29 2026 Received: from mail-yx1-f54.google.com (mail-yx1-f54.google.com [74.125.224.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 195BD1EEA31 for ; Tue, 30 Dec 2025 01:29:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767058163; cv=none; b=OdtxUwsDjeMaH8mVzMmVHdT+UvhI0arr9bKVKpeK0JE7cKAf2Tg/2Wa2Eht84urpxmx+J7g8ZffmuZJFv2RkoHmh1FgDpCRxwYK1elvtuQl04ceVr6Z3U0Sx1IynJBMNlrsJyWBp74wvUzR4SPSEDlYGO9DErg+6bTVKp6my+mk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767058163; c=relaxed/simple; bh=z4smCjzgbyLxVTyyQxI8x701+sbXiGbMsA0OzVfWxsg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UCfXqlijbBZQC3XV8iCBVWVb5C4ImB1YbyZYJjVcjc8E27LHkx8hJRVgGpaUGEgtAezhVvTi7e2CRaDPHaNyblbyqkN0JhVKOGNGVOIKLuYsUnaJW3QoYUq60fyyCgMyRGZL/RKTaHNVm8u6ZO3bTcOAUk0tBa9/NIz51++a8qw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Slknzxrs; arc=none smtp.client-ip=74.125.224.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Slknzxrs" Received: by mail-yx1-f54.google.com with SMTP id 956f58d0204a3-6455a60c12bso8851946d50.3 for ; Mon, 29 Dec 2025 17:29:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767058161; x=1767662961; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H4VMCEyZbX49K+uJ8S0Aycwo/Q5cQrq3uBbh2PVpI/g=; b=SlknzxrsnNsGrjv0EVMO2dgRUqAKfmCpMCw8Yy7B7yWTT5l81ejF/pyRXXNZjQMefI /nIqamu1hodhEz3Q97HhHPTYZzOWw7B176n+hIqe9V/4ht5X8uNQKOVYNTGOk2exF768 trS+kQakBTsCI+1q/WSltspONL2xPAP+qV1m0QUeJEAECKbGRDcDp16D2JUuUft/xMdV tySDjNa3WKT3o6DZ4ZXp1UoUewXme3Y1aFXh+0lLGYVGNhMeiL1bUuwhf7VtU3s3mc11 fpkwr41TKGyzmytf+1Yit5RgHh57d5RPq+fWlLK80j4LsFeuEznrmHulqlC6ZRrQ2hSp mq7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767058161; x=1767662961; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=H4VMCEyZbX49K+uJ8S0Aycwo/Q5cQrq3uBbh2PVpI/g=; b=vCJHSJXCNCaH4vWhiDroQgWiL+XEd5/L/P13fDo5H/lK+CUL/+q4yCI+XbqyEsRO87 449+BhcGIsr6Bs3RV15NXaOcYiOBJyhaZfgD4jFaAPbhxK+WzJeO25iN9yJjEfGi9piX HTqlw9RN1vp+rjQ4NxYFNeL4s6Jq3cqiIkALlBkBp4LloeS7yvrLOna3F8GvrYrI5tqH 1jNqhhCw1KbQ3yJEG7xt6VTDzcgLNPurg8ZadKWOfxRMF8h9yMT/Ci9IHXHMfigad3Bf t5fdDVIVKY2JZJXmWejnT5JbuGhnIURlVRRhFQ3D92A6dARfVWfPRwHbCYxga3ooTyqt k18w== X-Forwarded-Encrypted: i=1; AJvYcCXAjscBCOONJ1c/5Ta4ezRHFhzELXZ6lAUiYtxAbK3uvLRBAZP/MT3f/d6RkwRSc5Fb9pMDYknRAJzTGyg=@vger.kernel.org X-Gm-Message-State: AOJu0Ywz6an01o7ITE2VVnXXdVWz0rU4dbdsBWelZcjc1uImQ+uxxYCb EreX2ZA4oS4c+Yl4uUZXBDOwuijwEXAWOXc48KbMpjmzdWqvhtfQ/Ewx X-Gm-Gg: AY/fxX71/mcZm8dTzBzEphZPNT8KUa2lpJAN20l8uPjkUOaVlLloLPH3uPO/YTHwA5x AmZ16lSDEoSC8tjbzQRMKX0MXpYena77S4KaJI/1M1zEbZQ/TplVCuq35489N6wpZtd0OW3n1uA KY51j6Kygti4lOxDBFuko/2RaJAvTakjxKQZB/uH59rJV0iRbf8RUFi93tRtL7bY4s0QnPFw209 p1C/F0T+VOr825RFCsPeBw3RzCzNtsicrBQ/mPmu8G6hWPWfn2Eq03X/Y9xDABmziZw4fvEdbxj raU/StrLtick7D4Ik98JUir6AokQulAh2c4a+PJKFooB5AEZkZcYkeBeusoiHzJ5KOb0+QOheVt iABnkx9CPkQj3e7F0e946igriaUtaDBm/ioTsnjgKqgfUcp5d3FxpSuSwdtuwZQSPmhD0ibJPjH U51+ZZa0cxsrdt3TD+vN0z9p16FLf3KF+pEZhbn/dVtgmayT+7FQ6MJpYnjqUjlssBVI3zWVF6v cfSpG0= X-Google-Smtp-Source: AGHT+IF1uzGQtNSUKHpaPWieWb5HEiYm+y5X8EOW/a99wtyLQIpk+7wpFwjEXhRTJomY9pVjrkwUNA== X-Received: by 2002:a05:690e:310:b0:63f:a283:9ac1 with SMTP id 956f58d0204a3-6466a9010e8mr21297850d50.46.1767058161011; Mon, 29 Dec 2025 17:29:21 -0800 (PST) Received: from ubuntu-linux-2404.. (108-214-96-168.lightspeed.sntcca.sbcglobal.net. [108.214.96.168]) by smtp.gmail.com with ESMTPSA id 00721157ae682-78fb4376656sm120691687b3.9.2025.12.29.17.29.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Dec 2025 17:29:20 -0800 (PST) From: Sun Jian To: Vaibhav Agarwal , Johan Hovold Cc: Mark Greer , Alex Elder , Greg Kroah-Hartman , David Laight , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Sun Jian Subject: [PATCH v3] staging: greybus: audio: avoid snprintf truncation warnings Date: Tue, 30 Dec 2025 09:29:08 +0800 Message-ID: <20251230012908.214959-1-sun.jian.kdev@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251229112649.137391-1-sun.jian.kdev@gmail.com> References: <20251229112649.137391-1-sun.jian.kdev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" W=3D1 reports possible truncation when formatting widget/control names with snprintf() and a %s argument. Use a small helper and hide the %s pointer from the compiler's truncation analysis via OPTIMIZER_HIDE_VAR(), while keeping the existing snprintf() formatting. No functional change intended. Signed-off-by: Sun Jian Changes in v3: - Replace the earlier scnprintf()/strlcat() approach with a helper keeping snprintf(). - Hide the %s argument from compiler truncation analysis using OPTIMIZER_HIDE_VAR(). - Add a small local length limit macro with a short comment. --- drivers/staging/greybus/audio_topology.c | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/staging/greybus/audio_topology.c b/drivers/staging/gre= ybus/audio_topology.c index 76146f91cddc..35775067897c 100644 --- a/drivers/staging/greybus/audio_topology.c +++ b/drivers/staging/greybus/audio_topology.c @@ -1009,6 +1009,19 @@ static const struct snd_soc_dapm_widget gbaudio_widg= ets[] =3D { SND_SOC_DAPM_POST_PMD), }; =20 +/* Limit %s length to avoid -Wformat-truncation with snprintf() */ +#define GB_NAME_TMP_LEN 32 + +static void gbaudio_prefix_dev_id(char *name, size_t name_len, + unsigned int dev_id) +{ + char temp_name[GB_NAME_TMP_LEN], *cp =3D temp_name; + + strscpy(temp_name, name, sizeof(temp_name)); + OPTIMIZER_HIDE_VAR(cp); + snprintf(name, name_len, "GB %u %s", dev_id, cp); +} + static int gbaudio_tplg_create_widget(struct gbaudio_module_info *module, struct snd_soc_dapm_widget *dw, struct gb_audio_widget *w, int *w_size) @@ -1018,7 +1031,6 @@ static int gbaudio_tplg_create_widget(struct gbaudio_= module_info *module, struct gb_audio_control *curr; struct gbaudio_control *control, *_control; size_t size; - char temp_name[NAME_SIZE]; =20 ret =3D gbaudio_validate_kcontrol_count(w); if (ret) { @@ -1086,8 +1098,7 @@ static int gbaudio_tplg_create_widget(struct gbaudio_= module_info *module, } =20 /* Prefix dev_id to widget control_name */ - strscpy(temp_name, w->name, sizeof(temp_name)); - snprintf(w->name, sizeof(w->name), "GB %d %s", module->dev_id, temp_name); + gbaudio_prefix_dev_id(w->name, sizeof(w->name), module->dev_id); =20 switch (w->type) { case snd_soc_dapm_spk: @@ -1143,7 +1154,6 @@ static int gbaudio_tplg_process_kcontrols(struct gbau= dio_module_info *module, struct gb_audio_control *curr; struct gbaudio_control *control, *_control; size_t size; - char temp_name[NAME_SIZE]; =20 size =3D sizeof(struct snd_kcontrol_new) * module->num_controls; dapm_kctls =3D devm_kzalloc(module->dev, size, GFP_KERNEL); @@ -1168,9 +1178,7 @@ static int gbaudio_tplg_process_kcontrols(struct gbau= dio_module_info *module, } control->id =3D curr->id; /* Prefix dev_id to widget_name */ - strscpy(temp_name, curr->name, sizeof(temp_name)); - snprintf(curr->name, sizeof(curr->name), "GB %d %s", module->dev_id, - temp_name); + gbaudio_prefix_dev_id(curr->name, sizeof(curr->name), module->dev_id); control->name =3D curr->name; if (curr->info.type =3D=3D GB_AUDIO_CTL_ELEM_TYPE_ENUMERATED) { struct gb_audio_enumerated *gbenum =3D --=20 2.43.0