From nobody Tue Feb 10 01:16:21 2026 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3895824BD for ; Tue, 30 Dec 2025 14:04:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767103448; cv=none; b=aXhXUaUocedjv/i/jqQhJs0l0ogptYJD7PuU0BGe+7Amse0Ll03tCKoAr1dbXQKxaMWYdH6JJ+z1TxG4nR3I7GmVCYUdNKHcmk/5eZQ38irI6yQl86OwX4XVFiu/8epbMCxh1E6/ZjQUFSJKyWi2dbzrKBkhA/Z2plrxUNk1CfA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767103448; c=relaxed/simple; bh=2zwHE6VS64y4Vju4EqV2SaPOMxtYDh5dxEHGfmBSgxo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=L7g5cI9cUOQt4NXq2lR+KXa1kqUHCrpl35aj+hVTJdVooOCUus1xesL0mudsR3+hCDc/vxIGJGItL47/K0PKlCErtTupexnidoRDcS1aSgbrS82Xl9uRz9jc/D3YnZQlMuZg3wy1+p0csYsU/Y8V6cryjOns3Livh9J7dCdGNJQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=iYFVD69P; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="iYFVD69P" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1767103445; bh=2zwHE6VS64y4Vju4EqV2SaPOMxtYDh5dxEHGfmBSgxo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=iYFVD69PDeKLH+y/WbmkmAQ3srpkFolh002OMQj1ttIfP4JwfqCB031iSvR6qPp0Y uZ2+8W9VywIL5fo53xJLuJ2eo8bowdfn6Mkje9J9Gaa55X1D2JnnkgkPgbKz91nvyl sNGrF26v6w+Kiy2/jhVeVoynlg3xVrF42n1mHLXrCoIcGduuYhq//pJzSdhSOC4s0w dlna8aSn1dDRZjAKPvxNaV7KWY48JnoXQgIJ9hGFbjbl1fGS+Pbdy9NUyPaQs5iCpO cvX9T9IQzayeQvdUyJVNNcADzyXhtsdkZvfeSykfmVawDRzQGSkCTeb0DQtUl8g6N2 IDbnu8DomLL1Q== Received: from [127.0.1.1] (unknown [IPv6:2804:1b1:f803:a1ec:e46f:3b67:baf0:3d70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by bali.collaboradmins.com (Postfix) with ESMTPSA id 2968317E127C; Tue, 30 Dec 2025 15:03:59 +0100 (CET) From: =?utf-8?q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= Date: Tue, 30 Dec 2025 11:03:06 -0300 Subject: [PATCH RFC 6/6] drm/mediatek: Re-enable AFBC support on MediaTek DRM driver Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251230-mtk-afbc-fixes-v1-6-6c0247b66e32@collabora.com> References: <20251230-mtk-afbc-fixes-v1-0-6c0247b66e32@collabora.com> In-Reply-To: <20251230-mtk-afbc-fixes-v1-0-6c0247b66e32@collabora.com> To: Chun-Kuang Hu , Philipp Zabel , David Airlie , Simona Vetter , Matthias Brugger , AngeloGioacchino Del Regno , Justin Green Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ariel.dalessandro@collabora.com, daniels@collabora.com, kernel@collabora.com, Nancy.Lin@mediatek.com, Jason-JH.Lin@mediatek.com, =?utf-8?q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= X-Mailer: b4 0.14.3 Commit 9882a4064003 ("drm/mediatek: Disable AFBC support on Mediatek DRM driver") disabled AFBC support on the MediaTek DRM driver since it was broken. With the bugs in the AFBC support now fixed, re-enable the support. Signed-off-by: N=C3=ADcolas F. R. A. Prado Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_plane.c | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_plane.c b/drivers/gpu/drm/mediate= k/mtk_plane.c index 8fb08768e8ce..38dd94cdd665 100644 --- a/drivers/gpu/drm/mediatek/mtk_plane.c +++ b/drivers/gpu/drm/mediatek/mtk_plane.c @@ -22,6 +22,9 @@ =20 static const u64 modifiers[] =3D { DRM_FORMAT_MOD_LINEAR, + DRM_FORMAT_MOD_ARM_AFBC(AFBC_FORMAT_MOD_BLOCK_SIZE_32x8 | + AFBC_FORMAT_MOD_SPLIT | + AFBC_FORMAT_MOD_SPARSE), DRM_FORMAT_MOD_INVALID, }; =20 @@ -69,7 +72,26 @@ static bool mtk_plane_format_mod_supported(struct drm_pl= ane *plane, uint32_t format, uint64_t modifier) { - return modifier =3D=3D DRM_FORMAT_MOD_LINEAR; + if (modifier =3D=3D DRM_FORMAT_MOD_LINEAR) + return true; + + if (modifier !=3D DRM_FORMAT_MOD_ARM_AFBC( + AFBC_FORMAT_MOD_BLOCK_SIZE_32x8 | + AFBC_FORMAT_MOD_SPLIT | + AFBC_FORMAT_MOD_SPARSE)) + return false; + + if (format !=3D DRM_FORMAT_XRGB8888 && + format !=3D DRM_FORMAT_ARGB8888 && + format !=3D DRM_FORMAT_BGRX8888 && + format !=3D DRM_FORMAT_BGRA8888 && + format !=3D DRM_FORMAT_ABGR8888 && + format !=3D DRM_FORMAT_XBGR8888 && + format !=3D DRM_FORMAT_RGB888 && + format !=3D DRM_FORMAT_BGR888) + return false; + + return true; } =20 static void mtk_plane_destroy_state(struct drm_plane *plane, --=20 2.51.0