From nobody Tue Feb 10 12:57:13 2026 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72396267731 for ; Tue, 30 Dec 2025 14:03:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767103437; cv=none; b=KZ2HhvGhqeuNkExtEggap2Bbn73SzRVyJTGUa5rq0A6L6dEfZwH/azeQe6dOEYNqBBgqGlWrnjAvM8OTTH/B3EMduavXisNcSdDaljhV7n9eyVJl/U5wrWoDLpLJiwTsF7+53Ai6oxCMX1HeSY9IkIdw/IrvlNaZdtbiTSWcNLM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767103437; c=relaxed/simple; bh=8znKm4tlbIYhdYcckfvwcGyuwybXFTON9zwc8N6bIic=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=u7oNiSAAIUiuA/0Mao8798SYNAiP3H3trW/Q3td4q0qY0KOeBQ3274PvToZA3eBTDS/wnfb4u8Fu9yVi7QBfP8Rc/0kpUVn7P+0smftSAZQW4zj0Riscgn4n0bGqMxDFWy4sANmFTo8l0rzsXY1Z6/5tC4NlhdaOfT3bufDgBpU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=lmbQoavr; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="lmbQoavr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1767103433; bh=8znKm4tlbIYhdYcckfvwcGyuwybXFTON9zwc8N6bIic=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=lmbQoavrlIm15+Amp4DI3XQat3GPgt6YXkrYSHkQKm+CyNzEugh0rRDS4oWxdNxpP Sx2fcCdxEgIU2mucChAYAy5281KY87zwVPfdVHH0AdwkDHTMHJnM+n2U8NpPJfrpOU JcHIM2iMDEpuFwkj+xTWDZV80vGfgagZbaE8+Ys+4TmrSr7SLwEe1WnoWCmRJ3oeAO q16LGzwjqaAZR9J2pHoE2FmuDLN7uBSSe1certtjonRZiJDunZlAb5jaKF00MeFban 9adqFE8nbhZyjz5KRSmP/TdHZDN/BLrFmqTRcoN8cZmWB01zEr/fqGBIGLK8ro8TpY Qsy9jCcBX2cpw== Received: from [127.0.1.1] (unknown [IPv6:2804:1b1:f803:a1ec:e46f:3b67:baf0:3d70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by bali.collaboradmins.com (Postfix) with ESMTPSA id 783B817E127C; Tue, 30 Dec 2025 15:03:48 +0100 (CET) From: =?utf-8?q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= Date: Tue, 30 Dec 2025 11:03:04 -0300 Subject: [PATCH RFC 4/6] drm/mediatek: ovl: Disallow AFBC buffers with width over 1920 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251230-mtk-afbc-fixes-v1-4-6c0247b66e32@collabora.com> References: <20251230-mtk-afbc-fixes-v1-0-6c0247b66e32@collabora.com> In-Reply-To: <20251230-mtk-afbc-fixes-v1-0-6c0247b66e32@collabora.com> To: Chun-Kuang Hu , Philipp Zabel , David Airlie , Simona Vetter , Matthias Brugger , AngeloGioacchino Del Regno , Justin Green Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ariel.dalessandro@collabora.com, daniels@collabora.com, kernel@collabora.com, Nancy.Lin@mediatek.com, Jason-JH.Lin@mediatek.com, =?utf-8?q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= X-Mailer: b4 0.14.3 AFBC buffers with width over 1920 are not supported by OVL. If attempted, the image displayed contains many artifacts. Add this restriction to the layer check callback so such configurations are not allowed. NOTE: This doesn't seem to be a good way to handle this restriction, as when tested with Weston, it simply fails to render, rather than fallback to not using the modifier: [19:09:03.857] atomic: couldn't commit new state: Invalid argument [19:09:03.857] repaint-flush failed: Invalid argument Signed-off-by: N=C3=ADcolas F. R. A. Prado Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/medi= atek/mtk_disp_ovl.c index c6a00c2256dd..196b874057ba 100644 --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c @@ -368,6 +368,13 @@ int mtk_ovl_layer_check(struct device *dev, unsigned i= nt idx, if (state->fb->format->is_yuv && (state->rotation & ~DRM_MODE_ROTATE_0)) return -EINVAL; =20 + /* + * AFBC buffers with width > 1920 are not supported and produce + * artifacts, so should be disabled. + */ + if (state->fb->modifier !=3D DRM_FORMAT_MOD_LINEAR && state->fb->width > = 1920) + return -EINVAL; + return 0; } =20 --=20 2.51.0