From nobody Tue Feb 10 01:14:50 2026 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E21513A258 for ; Tue, 30 Dec 2025 14:03:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767103419; cv=none; b=Oy0xw8Q8mUQktoAmLoFjtZPlWlzLTAVBq8WqhmmcEmJ2ZzFHtcwWFUd8sJCgY1tvTtCJgV09BTZREZ+xvhwbxmVVuXD3yOqVE4vNTw3c0QDyX+ywyFfDabxyiJbrF9BPK5a75SfzMKlNIsJCk9KPMHv0dW9VP6hsd6b/IEtOWBY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767103419; c=relaxed/simple; bh=+9dZdnFTOLQEU43l4IQfP9P4NbPSetsJuzCQ32SzXns=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aXiuvLEUHtZWf3tUgqC440beXCYeI0Y8jHoHRui8W6vp1FrE7QhJ6v+KvaSVaKO6OEp9qDpGRy5n76OS65NfxpTTKzI/HJfottOrStG+0tYRpQ6gM69qbUi/VpJZ1lT4ipu7PvmP2/QhZAoV/N8Q7AsGxQfe2tmlPCd/SAM8tJE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=jIsErsen; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="jIsErsen" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1767103415; bh=+9dZdnFTOLQEU43l4IQfP9P4NbPSetsJuzCQ32SzXns=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=jIsErsenY6TL6SJSyJkoGGLS1NOKlhLcd6p7YPvROtay4CGMpi7TbCqFFTLQE7hOE 3QroSgNQieFaOh8EAMdh3NmrpZS8liS2pVoE0Ba5FMuVEpisJJeG2NByc4CBYfrCGZ I2RQInSZ+2x83QKzlxa7i/4Pc4QjAF6xpL3E7q8k0LPC6OxQy8Zr0qPF+VwJ7DTYah KI0LqFjVUHgwjNDQufzRBzyPRzERTmtH+T+iClywQ+y1BiyttuVq1lPNyH2CYQ6apV aNN/CMIPDoP6lEir/rogTD3zZ8pvA4V9NTRo2H3A7rayEdiJiYSSCdKUS+XhTkhzE6 zL0PfNET9SaLw== Received: from [127.0.1.1] (unknown [IPv6:2804:1b1:f803:a1ec:e46f:3b67:baf0:3d70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by bali.collaboradmins.com (Postfix) with ESMTPSA id 8CEE917E127C; Tue, 30 Dec 2025 15:03:30 +0100 (CET) From: =?utf-8?q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= Date: Tue, 30 Dec 2025 11:03:01 -0300 Subject: [PATCH RFC 1/6] drm/mediatek: plane: Remove extra block from AFBC data payload offset Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251230-mtk-afbc-fixes-v1-1-6c0247b66e32@collabora.com> References: <20251230-mtk-afbc-fixes-v1-0-6c0247b66e32@collabora.com> In-Reply-To: <20251230-mtk-afbc-fixes-v1-0-6c0247b66e32@collabora.com> To: Chun-Kuang Hu , Philipp Zabel , David Airlie , Simona Vetter , Matthias Brugger , AngeloGioacchino Del Regno , Justin Green Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ariel.dalessandro@collabora.com, daniels@collabora.com, kernel@collabora.com, Nancy.Lin@mediatek.com, Jason-JH.Lin@mediatek.com, =?utf-8?q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= X-Mailer: b4 0.14.3 The AFBC data payload is in fact not offset by 1 additional block as the code and comment suggest, and this causes the buffer to be rendered offset by one block. Remove this extraneous offset to get the buffer correctly displayed. Fixes: c410fa9b07c3 ("drm/mediatek: Add AFBC support to Mediatek DRM driver= ") Signed-off-by: N=C3=ADcolas F. R. A. Prado Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_plane.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_plane.c b/drivers/gpu/drm/mediate= k/mtk_plane.c index 5043e0377270..1214f623859e 100644 --- a/drivers/gpu/drm/mediatek/mtk_plane.c +++ b/drivers/gpu/drm/mediatek/mtk_plane.c @@ -164,10 +164,9 @@ static void mtk_plane_update_new_state(struct drm_plan= e_state *new_state, */ hdr_addr =3D addr + hdr_offset; =20 - /* The data plane is offset by 1 additional block. */ offset =3D pitch * y_offset_in_blocks + AFBC_DATA_BLOCK_WIDTH * AFBC_DATA_BLOCK_HEIGHT * - fb->format->cpp[0] * (x_offset_in_blocks + 1); + fb->format->cpp[0] * x_offset_in_blocks; =20 /* * Using dma_addr_t variable to calculate with multiplier of different t= ypes, --=20 2.51.0