From nobody Mon Feb 9 09:32:33 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9101F32D7FB for ; Tue, 30 Dec 2025 17:03:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767114207; cv=none; b=ExAWlXUyCzqZC5t8NdQ5Syh/1Ev/p322qws6WjBWBe9PnrZZ0gJNU62VGvDEkUTXyFNi23BDfoTR1uajZIZ0cMFvjBDqIIKDYowM2uUc7Z3vi+cUU5QAKLjoCQN4S3+x4VgAP5q4Y7TJ/HYTg/iDthiDAl91xPt1TlOMFKdQAdA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767114207; c=relaxed/simple; bh=pUcV1dbBTQOxDk0ARdiNFmxLQfbTJhPxGeN+tE1pFF8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZAQNkFG529fFMZMroTk4iOmG962KE5OubDGLwN3SmUvPZ9PNNLmuKPw290rc3eQOdjuZu3snnd6sbmJdXOvBohvzM3RUkQqrEraW3ji/m0G7ba1HpnnJFy7W4Hqgi563mRP2hE+81o83KPNElWGTbPvgwgeBhJj8ESZUNTvxz+c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oDyPXCKl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=a2K5/tG/; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oDyPXCKl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="a2K5/tG/" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BUEkBXs3539777 for ; Tue, 30 Dec 2025 17:03:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= U/WEOACPXuz2v8eCCxwXJfIP8bRHqqSF490HJaExyDI=; b=oDyPXCKl+D8PLMpb QDz+bzO7J1np1ugrveEAllXfS7IL32+eTuJZM26g6C9lLkmhmLMhCQk2abO3LJqR xV2PLYaF3wmYdMmPhk2WoM0t26IWQXS8olwrQYnpGFaesJcGw718sEqywwaV2ixQ cmCaKxd2fuljLZIbl6eBWNCuMi/fvxqA40wGdGOoy+UHQcpUrfYe9e10a5ZiYkI3 6EC9spOoEg16IJF2GShiQRpOA6tnnBfIBs4pyc17Za5B8JIi06eArZ/kxABqg+mO JmHfkTVvlY0Cwti+xduGYNV4xrEVfEtz32cJzw9jHfr27um071qiKXTm1yR5fsUn WfSqbw== Received: from mail-yx1-f69.google.com (mail-yx1-f69.google.com [74.125.224.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bc88yhn9p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Dec 2025 17:03:23 +0000 (GMT) Received: by mail-yx1-f69.google.com with SMTP id 956f58d0204a3-64473bfcb4eso14424954d50.2 for ; Tue, 30 Dec 2025 09:03:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767114202; x=1767719002; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=U/WEOACPXuz2v8eCCxwXJfIP8bRHqqSF490HJaExyDI=; b=a2K5/tG/3Oqd8ZM64pyiQ9SLT1HbiuZkPF/hTIQTUcDt9zils4ZNKBcoCkIPg1VYUG pb31WYfqxuW+HIi+ikySFU9GJWO51GmIF9UCcPd1ixiGDZ770f0VrMP+Fe7mbWTHuh/M S/EQhCXc2ezj8vlKzGnVXv08/exPZvpSvbcLlZVXjZ/oG3plfhPaE4UBeb5xcKZjlLVX gCVLLsYv8TL/crRpzG7/Rhd997LaFkuMOVbjz44tPI6Uff50Ec8fQVYw47Gsbep4OcFZ 7HJ9/rIZBstvB/RRiuX9n66YHnBLWsa5jW0RWfePBSLTqG9VOj4J5BRSCjmXM7q1+JQ1 8oFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767114202; x=1767719002; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=U/WEOACPXuz2v8eCCxwXJfIP8bRHqqSF490HJaExyDI=; b=IHdQRPfIJospwQTsSCHrJn+eK5wMQ2Sje55sX5rOnett6GOI9NEclwq46ftL5q8Vev Bw/XaLF81zcTA65o+fnzIhUtIY7RS+eSHpJG2YftSOJD+kh1iW9YbX0kauNIov5V70pE JZ0m9AfyamR4jkWE2P+W0VBEYVxe00wEPa4jMFE4NQq3vPzpC74GQtfQTzSErkFGncOs 5sF1BT+sn6ndWMpeIjKyJyIuBrUxZ5qOex9Bh/rEK7TLN4fxK6aRmgk88jE0gZhyf7vd y5ZdmtCSPo62avHp/BfnRzMV9EJFe3tKjRL2Y77l1/d6axNZKpljePlNo673ej6xRiE6 ZjrQ== X-Forwarded-Encrypted: i=1; AJvYcCW5g4NUWjSr0QA/o+jlJ82WCGv0MMqGPe1x1+5BejsRVKHnwyxhzYc6syO9huRWw/8D4xWEJISdnLphRXQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxxV5MiOjf7HtELDmsBsJERiDBRLjyjTFrNOzt0n5+4Vz8rQfOr DeTfZDtGBNazFRxIGWVCk0vbqOceTOJKaQ2FCmKnj6u6lnsJs7rBzjMfvVsRu6dxRG9Bj0cY0uS K+iXHwI6dAu+ouk9780Tycwiah9uDC7zOeanipjegTNBQkcgwSvUs40lUk0LF4PlEmTkckHe71E 4= X-Gm-Gg: AY/fxX6q15PFYq9oQb2uHGluyHgTt5JbX/8ZmC8ki7iUBg++VREyHTO/5TcFAr8QNJ7 wDMeP8CKv7WeQSVa14NNyLXKOs+uAuoJqsO8OZGikfikTYzC+3rVNv+Zbpd6SB2ObSoFU5QBPBu tj+TLEJb63fFhDF8hIZ1jcYACmE7XuZDeJNANzxsd0FyF2FNqSrNeKq5QLmypIKyCsken6ggJib LH1H7ekkxWymxPdPfG97vRvAg8tLqpTALOawDYYMCFKVynysgrn3JK/RYMA5YbAuQ0hTex28hQ2 4u2ZE2FanvROziZpMapFTAdmG6kEYhssz0hJRu3hL0Ha8o3YYw7sAf1N1LLFKL8hcpMRMSZ88zx Arcqhv6tobsjCtrEt3RC2Qb3SiCMX+rxr9QtckJpXjDX+6Ab2ia3Ejseqna3tC0c9bLcGghQbot UR4ABYVFC+Cg4IgzyfyVTjqZ8p3R/3otgx8hfcTi0B X-Received: by 2002:a53:e18c:0:b0:644:4625:8853 with SMTP id 956f58d0204a3-6466a847258mr20117769d50.34.1767114202317; Tue, 30 Dec 2025 09:03:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IHy7BfSa3UN/TFpEWlcJ/RfJR8aNQfRjlb1bnTg8p5j/l85AX6oqRJWvGcHnoWq+bCokGLRzw== X-Received: by 2002:a53:e18c:0:b0:644:4625:8853 with SMTP id 956f58d0204a3-6466a847258mr20117746d50.34.1767114201901; Tue, 30 Dec 2025 09:03:21 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037a5bdb9sm3776086266b.7.2025.12.30.09.03.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Dec 2025 09:03:21 -0800 (PST) From: Hans de Goede Date: Tue, 30 Dec 2025 18:03:05 +0100 Subject: [PATCH v5 08/14] media: mt9m114: Add and use mt9m114_ifp_get_border() helper function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251230-mt9m114-atomisp-v5-8-763539e76094@oss.qualcomm.com> References: <20251230-mt9m114-atomisp-v5-0-763539e76094@oss.qualcomm.com> In-Reply-To: <20251230-mt9m114-atomisp-v5-0-763539e76094@oss.qualcomm.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Hans de Goede X-Mailer: b4 0.14.2 X-Authority-Analysis: v=2.4 cv=POcCOPqC c=1 sm=1 tr=0 ts=695405dc cx=c_pps a=J+5FMm3BkXb42VdG8aMU9w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=i4UVPg6hQqdO0Jw5UB8A:9 a=QEXdDO2ut3YA:10 a=Epx66wHExT0cjJnnR-oj:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-ORIG-GUID: 9ywmAIuYHAT4D9JoT8IBlugGJnU4PZyL X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjMwMDE1MyBTYWx0ZWRfX0/0TRXk52RyJ 6xhjTlmP+CmYArL/VcdQy0W7gvR7GUZgUL2ReAK10BCzBicBl9Q4xuwsUvinGnpCd3zIhmvLQc3 upxdmq5em/nraTw+42nl0TF/RtvG+aL4wBxpXaNqcFAIkrawc6Spv6fegyTBvU/gmQTr7C2Wqm9 Gh5hnGQ8iTYCuZf9wychxueLFWbpnkT2ESW0KoC+NJuIkqdI7BQTv/3wG0aYHsH5Zz1sk81wXDX pmAT7T+jWEJ3eB8TWJTV/cThIwePZCDtYXnV+we7eDAR2CZRH9nhPXviDv8fCi/Zg5psQU5//xv h8U1638tW0hgKqBSEKOPAdTSVCT9ABCw5Stb5dB3Ooe4vO93ps6SkDZZIvoMpZMbUyI9eaOPLRt W5bxVgZQ8qmdzldryWcFW+1GnkzzVZhfI5LEFu3uhq0z/UJzzaWyBeKqScn5PmHYmH7MITuqQ7r BYhHma7FSfnwOJm6BIw== X-Proofpoint-GUID: 9ywmAIuYHAT4D9JoT8IBlugGJnU4PZyL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-30_02,2025-12-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 bulkscore=0 phishscore=0 clxscore=1015 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512300153 Normally the IFP removes a 4 pixel border all around its sink format size for demosaicing. But in RAW10 mode it does not do this. Add a new mt9m114_ifp_get_border() helper function to get the border size (4 or 0) and use this where applicable instead of hardcoding a border of 4 pixels everywhere. Reviewed-by: Laurent Pinchart Signed-off-by: Hans de Goede --- Changes in v4: - Address comments from Laurent about commit message and comment wording Changes in v3: - New patch in v3 of this patch-set --- drivers/media/i2c/mt9m114.c | 62 ++++++++++++++++++++++++++++++-----------= ---- 1 file changed, 42 insertions(+), 20 deletions(-) diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c index 948074e976bb124470d6a8677a24e096c3033f71..4529320ab920145dd7055eec87a= 9bcb52e91a54b 100644 --- a/drivers/media/i2c/mt9m114.c +++ b/drivers/media/i2c/mt9m114.c @@ -851,6 +851,18 @@ static int mt9m114_configure_pa(struct mt9m114 *sensor, return ret; } =20 +/* + * For source pad formats other then RAW10 the IFP removes a 4 pixel borde= r from + * its sink pad format size for demosaicing. + */ +static int mt9m114_ifp_get_border(struct v4l2_subdev_state *state) +{ + const struct v4l2_mbus_framefmt *format =3D + v4l2_subdev_state_get_format(state, 1); + + return format->code =3D=3D MEDIA_BUS_FMT_SGRBG10_1X10 ? 0 : 4; +} + static int mt9m114_configure_ifp(struct mt9m114 *sensor, struct v4l2_subdev_state *state) { @@ -858,6 +870,7 @@ static int mt9m114_configure_ifp(struct mt9m114 *sensor, const struct v4l2_mbus_framefmt *format; const struct v4l2_rect *crop; const struct v4l2_rect *compose; + unsigned int border; u64 output_format; int ret =3D 0; =20 @@ -872,15 +885,18 @@ static int mt9m114_configure_ifp(struct mt9m114 *sens= or, return ret; =20 /* - * Color pipeline (IFP) cropping and scaling. Subtract 4 from the left - * and top coordinates to compensate for the lines and columns removed - * by demosaicing that are taken into account in the crop rectangle but - * not in the hardware. + * Color pipeline (IFP) cropping and scaling. The crop window registers + * apply cropping after demosaicing, which itself consumes 4 pixels on + * each side of the image. The crop rectangle exposed to userspace + * includes that demosaicing border, subtract it from the left and top + * coordinates to configure the crop window. */ + border =3D mt9m114_ifp_get_border(state); + cci_write(sensor->regmap, MT9M114_CAM_CROP_WINDOW_XOFFSET, - crop->left - 4, &ret); + crop->left - border, &ret); cci_write(sensor->regmap, MT9M114_CAM_CROP_WINDOW_YOFFSET, - crop->top - 4, &ret); + crop->top - border, &ret); cci_write(sensor->regmap, MT9M114_CAM_CROP_WINDOW_WIDTH, crop->width, &ret); cci_write(sensor->regmap, MT9M114_CAM_CROP_WINDOW_HEIGHT, @@ -1865,6 +1881,7 @@ static int mt9m114_ifp_get_selection(struct v4l2_subd= ev *sd, { const struct v4l2_mbus_framefmt *format; const struct v4l2_rect *crop; + unsigned int border; int ret =3D 0; =20 /* Crop and compose are only supported on the sink pad. */ @@ -1879,15 +1896,17 @@ static int mt9m114_ifp_get_selection(struct v4l2_su= bdev *sd, case V4L2_SEL_TGT_CROP_DEFAULT: case V4L2_SEL_TGT_CROP_BOUNDS: /* - * The crop default and bounds are equal to the sink - * format size minus 4 pixels on each side for demosaicing. + * Crop defaults and bounds are equal to the sink format size. + * For source pad formats other then RAW10 this gets reduced + * by 4 pixels on each side for demosaicing. */ format =3D v4l2_subdev_state_get_format(state, 0); + border =3D mt9m114_ifp_get_border(state); =20 - sel->r.left =3D 4; - sel->r.top =3D 4; - sel->r.width =3D format->width - 8; - sel->r.height =3D format->height - 8; + sel->r.left =3D border; + sel->r.top =3D border; + sel->r.width =3D format->width - 2 * border; + sel->r.height =3D format->height - 2 * border; break; =20 case V4L2_SEL_TGT_COMPOSE: @@ -1922,6 +1941,7 @@ static int mt9m114_ifp_set_selection(struct v4l2_subd= ev *sd, struct v4l2_mbus_framefmt *format; struct v4l2_rect *crop; struct v4l2_rect *compose; + unsigned int border; =20 if (sel->target !=3D V4L2_SEL_TGT_CROP && sel->target !=3D V4L2_SEL_TGT_COMPOSE) @@ -1937,21 +1957,23 @@ static int mt9m114_ifp_set_selection(struct v4l2_su= bdev *sd, =20 if (sel->target =3D=3D V4L2_SEL_TGT_CROP) { /* - * Clamp the crop rectangle. Demosaicing removes 4 pixels on - * each side of the image. + * Clamp the crop rectangle. For source pad formats other then + * RAW10 demosaicing removes 4 pixels on each side of the image. */ - crop->left =3D clamp_t(unsigned int, ALIGN(sel->r.left, 2), 4, - format->width - 4 - + border =3D mt9m114_ifp_get_border(state); + + crop->left =3D clamp_t(unsigned int, ALIGN(sel->r.left, 2), border, + format->width - border - MT9M114_SCALER_CROPPED_INPUT_WIDTH); - crop->top =3D clamp_t(unsigned int, ALIGN(sel->r.top, 2), 4, - format->height - 4 - + crop->top =3D clamp_t(unsigned int, ALIGN(sel->r.top, 2), border, + format->height - border - MT9M114_SCALER_CROPPED_INPUT_HEIGHT); crop->width =3D clamp_t(unsigned int, ALIGN(sel->r.width, 2), MT9M114_SCALER_CROPPED_INPUT_WIDTH, - format->width - 4 - crop->left); + format->width - border - crop->left); crop->height =3D clamp_t(unsigned int, ALIGN(sel->r.height, 2), MT9M114_SCALER_CROPPED_INPUT_HEIGHT, - format->height - 4 - crop->top); + format->height - border - crop->top); =20 sel->r =3D *crop; =20 --=20 2.52.0