From nobody Mon Feb 9 09:09:11 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07A5B322B9D for ; Tue, 30 Dec 2025 17:03:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767114203; cv=none; b=l0J1l5EQGG04l9lSngImduHY89aWXbkgkPRZ09d+vDc8fsjcs411pkZFtw4roGGnphCiy/vZTY5/RDy+9ai/3yRzzxUo5BK3YX31p3vCMPZS0ytKugUgZl/KskzsoFqOIoi6YsXAcK8VqIheSNKcnrY7fI99pc746fRr+A9R03o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767114203; c=relaxed/simple; bh=UCis1fko66KzZ+L6ClmuRfXXvUzWLabDwbCJizpiy08=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RDl+xgtDIQvLXcP0GIdLhXSawndsBDLENompkC65kP6oSJ32ahATtAqs39WDYvmYoCtzQT/8kF3w3SaMzkbteUhT3LFSDjylKGTTeFF9fxwhED2H3APf2TyaxbDwhP0yAIVww0NbWz4UbuyngfzFC6l/qjM7H636TOqFlCHUerQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=giGSEiNU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SMM7xsrM; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="giGSEiNU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SMM7xsrM" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BUEplWu898837 for ; Tue, 30 Dec 2025 17:03:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HbwNW9LRtglxUm2Bf6AsaFVw+CZYAV4zcyYuRhRwcqE=; b=giGSEiNUXN0JMYFc Ns9879oE2yqNSLegG+qvWPad7zrwM2yn2V/6wHX2f/1RINQIi0Zpl6OBH1pgKgd+ Xu+gJbkWhpvJ8UdRph7lUDus0a6bC48O61EIaanAejWihuiQ71nwzC9jBiX+ekvW xG2bl67NOoKfMVs12LQSWfZtArF/j5b4U2VEyOSqUSv2NeIvkqYuAVXxJos7tNWK 9KqNaIPBbcsiV42xCd9+EOdgt809+GevlC4eywlNLMzyz2V0AE+JYAg+0LT4+N8x +D1FePyIU5jaUsWwqglss3Xbey9rzsuS3mfODtE8AxXWdGAoHVJUzd6SK4308erw y+sxoQ== Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bc8ky1jrx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Dec 2025 17:03:21 +0000 (GMT) Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-78fc63a4637so90033147b3.3 for ; Tue, 30 Dec 2025 09:03:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767114200; x=1767719000; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HbwNW9LRtglxUm2Bf6AsaFVw+CZYAV4zcyYuRhRwcqE=; b=SMM7xsrMNx6l0O25amzYRiJUuHG7BDPpqEgaLT/Klfu11NTWK04xCf/rrXd3gmJ5D4 UbwqQG4fteNIy7ZyIv4X+R4ljndWqVy+4oAMJ7njKoBcxMhZip6Sj7PMrktYpskj9dKS 1kPch3NqUaQudlCJLHzj3jF0K0Xx4h77OA6WKlbDkCkoIv65Gvdkyp581gkXx9G7vGm2 KZPhBs0ATNllGb8/agnu2Ac8i7fWr772NrLN2Qu45FArdPawsQJVGsYWb46oM5aKf9k1 f5jiXCOlm/Ryqdt/WO5PtuKdm+bUSCnJa9vDOPDqSweTjOXXSHEbbiNdEqox/Jr4qMmA RudA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767114200; x=1767719000; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=HbwNW9LRtglxUm2Bf6AsaFVw+CZYAV4zcyYuRhRwcqE=; b=XBh3c3Ck/cJyQOmDTod9vymSXCLUJFDGthvXRP5sN7AAKtycM3oxB6/JpT8P/JM9J+ 2r1CRp1Ku0+aPzLsz3JTzRuEJkZZ8vVbF9RtSO2Df+CzE3cBKgtkOyVlyRz0maqDexMD SCYOZ1pD7iCS6McxzQlvyOBQgNh3GYK7E9GXDkpdtL1oP9QYhd/yHJ4oaYM4/VFpVoXj auZJbE/8rut/LiO/QR89DqlAw3H63omGCNKAHOtaFEg49wrgKX+qIdEZV0VVadHk/3Eu XWjhPWSHHdR8np9FmpVNUueu5RjKCRpiqj4DTo7I8sXcHgOI9Eu/oc5RdcENGrva36nq gKGg== X-Forwarded-Encrypted: i=1; AJvYcCUO8VVU7+xoOaj9YRg8/cZsqSmgQ49P7snyRJD6XbYKt3nlrmFn2VaXFGNhY6Enh7Ekn0N0xjAyl2FT0fw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/2PSp5yDQGqH/kmZZsiUNdjWd+ieKgo/hFPuanv3G3XFjf8dR UKrryYER9FGwD2ImmASxGl+cKYZyvqkaQsppe2bxX4jB6TcASKJSddGssfsLquM3rKXfE+ZuuaL TgVjvdD8KJw7pqC1T/ybldeVM+GUNVwpqnNjXbVPKmwpj/gub6pXO0fTMH4GCjLQZDqs= X-Gm-Gg: AY/fxX6qyQWlKcu93hKF5nB5vsBbIh+uO04RV3DtkPXqirPT/qHz009TZBuv0kLn/4B p076PiC1Mz/F0r84igS7+RDZuWAFBIf4r6v6tgjnFC1QfmcffUIx0KNjZOYLfjEoNi7TcHGbEj8 cwRRF3TeBKYVfPtMMbvIJeRy358YZN8KrRpPgxuRj3BOrvJOLkz3Eet04L7WPmNFzmW5tJ89WU+ V8k796SPiv6L/28+OavJ1a4f71iJJdQwSg+U8WaVFUd2Iw2pnbQdIL/TEffDS40T450NAhO3Rl8 rVjenaexDOh+Bj6Mg9VzS47sdeQi1GES4ZteLsK61IsBw9B+xrtY+wfkBfgHlnpqlFS6wVwXqDq HdXPR12n9RhWmeXudGad2+DfpRmtIEjKd7ezGFdudDTd6GaP0HmcLC6onEqq76ZH3NV0f5ruRcu E2XM1p+wT0uPm8mrImieCzTuGLp6VbYd1NMfshEhlU X-Received: by 2002:a05:690c:9c0a:b0:78f:a872:fabc with SMTP id 00721157ae682-78fb3efa10amr317708627b3.11.1767114200250; Tue, 30 Dec 2025 09:03:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IEl4lQHYh7DWs+x05wWfdtOKSLXV4LCN7QQWlMMcMXElXg0Bn0inderbFtuyFE61LHfQXIL9g== X-Received: by 2002:a05:690c:9c0a:b0:78f:a872:fabc with SMTP id 00721157ae682-78fb3efa10amr317708227b3.11.1767114199801; Tue, 30 Dec 2025 09:03:19 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037a5bdb9sm3776086266b.7.2025.12.30.09.03.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Dec 2025 09:03:19 -0800 (PST) From: Hans de Goede Date: Tue, 30 Dec 2025 18:03:03 +0100 Subject: [PATCH v5 06/14] media: mt9m114: Avoid a reset low spike during probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251230-mt9m114-atomisp-v5-6-763539e76094@oss.qualcomm.com> References: <20251230-mt9m114-atomisp-v5-0-763539e76094@oss.qualcomm.com> In-Reply-To: <20251230-mt9m114-atomisp-v5-0-763539e76094@oss.qualcomm.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Hans de Goede X-Mailer: b4 0.14.2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjMwMDE1MyBTYWx0ZWRfX5aW9JUKqs6xg eCu4gpE1aeETSEe4fATVpxLmMBcsUmJDzqSLYq9m3Ica0Jb+bqX0Tno+z7GfE3pV7mbIW1YeXQ5 KkIKqPiSffUxd5e99JWeexxqO//LWCdO2WkNKrwJBHiM3oTdG31mIl8T0LMHnsJYuVyk+kY/gsn c7KjEjgu5DZAa+9JqOmlxmznWsJTVVLLzWabSugHT8JR1Cky4xuZT2d9XzpoFYp9fRO4eNPVIKp RmY9x7VCnTb++mMRkyZWASrqXZKvMk1su93LYdxgTY4doSIPuayn7JjPasf/zh1lDjm+MabJvsV ehld0SjXUgv/WIfdlApeK5IyRZAaAydXslXdrDk4+ioMJhepHHVl9ox+Pp9Z2oMoLensm13ER3H 0JbLNvJ0l7/EhYLNQdspFvIyrSfaRUx0sJuvw7gqB460dzBZhYIFEPY3EFGt2VxOHLXEflspGP1 4PsWMiR0zQ4BanRU4xQ== X-Proofpoint-ORIG-GUID: 3mTomVlTf4GwUcQs2T0AStg42ZxJgnD4 X-Authority-Analysis: v=2.4 cv=BuuQAIX5 c=1 sm=1 tr=0 ts=695405d9 cx=c_pps a=0mLRTIufkjop4KoA/9S1MA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=RFAlwJ6oiccnoQ4oFZsA:9 a=QEXdDO2ut3YA:10 a=WgItmB6HBUc_1uVUp3mg:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-GUID: 3mTomVlTf4GwUcQs2T0AStg42ZxJgnD4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-30_02,2025-12-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 spamscore=0 adultscore=0 bulkscore=0 suspectscore=0 clxscore=1015 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512300153 mt9m114_probe() requests the reset GPIO in output low state: sensor->reset =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); and then almost immediately afterwards calls mt9m114_power_on() which does: gpiod_set_value(sensor->reset, 1); fsleep(duration); gpiod_set_value(sensor->reset, 0); which means that if the reset pin was high before this code runs that it will very briefly be driven low because of passing GPIOD_OUT_LOW when requesting the GPIO only to be driven high again possibly directly after that. Such a very brief driving low of the reset pin may put the chip in a confused state. Request the GPIO in high (reset the chip) state instead to avoid this, turning the initial gpiod_set_value() in mt9m114_power_on() into a no-op. and the fsleep() ensures that it will stay high long enough to properly reset the chip. Reviewed-by: Laurent Pinchart Signed-off-by: Hans de Goede --- drivers/media/i2c/mt9m114.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c index b588b9d013ca8b41f9827cd12c0fcf56bb34bc38..8cabe04a1a64619c97edbaba09e= 6286b1a514604 100644 --- a/drivers/media/i2c/mt9m114.c +++ b/drivers/media/i2c/mt9m114.c @@ -2467,7 +2467,7 @@ static int mt9m114_probe(struct i2c_client *client) goto error_ep_free; } =20 - sensor->reset =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); + sensor->reset =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); if (IS_ERR(sensor->reset)) { ret =3D PTR_ERR(sensor->reset); dev_err_probe(dev, ret, "Failed to get reset GPIO\n"); --=20 2.52.0