From nobody Mon Feb 9 14:14:15 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 754BA32FA3C for ; Tue, 30 Dec 2025 17:03:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767114210; cv=none; b=W9p2nC/og4wSMGqcYdS9k4SWEDXAJyxWuSBvFUG2U7ZreGts1T3mU0yFrUK5mFWB52Qp7h+GIUdONd/VBND+c7KxQbG7dj4uHq767PzFnvNv1SAfiODbrMHpIloPymX2tBjuXkToXGqnr0gJIB1VAwHIkKmWLqLpUdn+K5w6eTo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767114210; c=relaxed/simple; bh=kA1N2hOuLQrj/EaUF95l88PLLc5P0t4Cl5tmXihS2sI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=P+J7zOudIcBkqobDlV/FZvT/tnI8ViVDh+XtQt+tndUUbl6pDGmB68O4BIMvVtnX4VqvlgsAS6pGG3sWtZTmCqSf3S7RpEmu8HcQ4cqUtVi7wwoU84yIWL29gHy2T3x50YxAdio6NnEmna4fwi4GL+iF17EmtxMlQmZqsb7WQ9o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=o82qzU75; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MkehyYhf; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="o82qzU75"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MkehyYhf" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BUEKkPP3539728 for ; Tue, 30 Dec 2025 17:03:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gf2M/z0Ttme8n6CVO3CwrC/GTtTad5tzePlYQsx+38Y=; b=o82qzU75gXhbRpdG wcQM/eamZdmrpLq+RwBjPP2zyIpvCxOKN/MlKo+ZhAhb1ifztPvyjj4DMbF+bY9f OnQb17jWCf0/jTtPtNU+dXDOtq9PAOCf0/G/2MbMEAjwtAXEBvH9c7KrFInM43fZ ePSX0gKRZ3NMc7KYAbUSXlzpNu5o7oTRBuC4sIKXgiv8RRMkHph3e32jJMiPZO9i yHxi18aighDZxfZqG+AXPdRpt+PzRiXkmHuxBt4CNroh/3FJggZ5hHXNr6XOyjtZ gK4NLB3rnJtlphbaZkItVDWtDXF0hBLuMMQuqFsmeevbqDjb3m1MqTNGVCsPjaMP ksuXkw== Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bc88yhna5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Dec 2025 17:03:27 +0000 (GMT) Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-78fbae83badso122569647b3.1 for ; Tue, 30 Dec 2025 09:03:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767114206; x=1767719006; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gf2M/z0Ttme8n6CVO3CwrC/GTtTad5tzePlYQsx+38Y=; b=MkehyYhfG7lG4CJQC4dfTl9z7rVX5cHNsECVnTvj7W+inigxXZXObY2rwXs9tAICQE OyDyoV50dO5xwYKvR0vCMqzkBGTyu72E9TAnoGzPmYvK0aRLiMb8WeGzSKUVuqu1gdmz UlNq9LPfVdc13K+gqzvkNhdXFejYB1tPE9MxYH/5UHDAz0ZsU0mWxU7V5wX0UhXYAWjo ca+gvFa+MKNuYFSMgr9x554xxyzB1+Gyr5hwT9MacQIJlm+lRtgTJshkm/EhjUXzQQij n/7lGY6TeIl/4wB33ZLFL/kkWxCNeIpb//GdbDcoyOn27b/mG+yxEBasAJB2ytAMnpeO HVtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767114206; x=1767719006; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=gf2M/z0Ttme8n6CVO3CwrC/GTtTad5tzePlYQsx+38Y=; b=inpdY3coFr95vNwPQrVNb555J8DMyHaU6X3UL+59CjQ0K7w62mSamtLJ6MCNQrUDtF xxGGkhKFWcpDKe873/rDYfbLkpUW8H2p3gz1JgUYfKQ5Z8un5G4xdPQMlxmIIgodXJdJ vkpR4ChO8YONdFQ+cv+lUoz2Bh64BXFxfh+qRbRcG2PflUpkDRwqbR4bMGTNFEjxw3IA ojzipb4IAdDvImcWRN1CLbIWjvoNupuyc7glypAv8zbT77HBReJRXTw3smNbD+ntiNnw 4roc3NQw/vdNeiVIgVy/6RhBHzu/4XMrmGcY0WEkWP1FFY14P/iJYwQxmeNUfex3qLtK fNkw== X-Forwarded-Encrypted: i=1; AJvYcCUATViqHkoe7iPKBODSe6Akv9VBIVuu8Tg/DHTPio/yVEWXEUc7j+0qYheJsPG3EMrPUABLvqKCMRDuB0U=@vger.kernel.org X-Gm-Message-State: AOJu0YyheR2PwfEIYvcnf4pXCK2pyvskUKWoWojkPIQWqR8OyI7Y74+M C6NfgTQnDpheLz5oSGIy8ODbjxW2zZVLWbWvi7YX89aLCvdNjGfWk5sTJcyB8eE0Vxcb3D6pdJN bIbd6rMqWFTbizuh5ZkHCYTuKoUlaQX4fR+DsN2JI6X7PRKc7AO7NQnbQ9plPA5gzTkcnpBv5zB Y= X-Gm-Gg: AY/fxX5DcgV9Slo1FSLiDw9sbZUkpWOoBbluHWWWpH/TXjz48TrIUsr4URYhA+aiFSc Oxny07VTkuHwbPzWLgb/zn5XGaDgvfukBzOgsOl4SV+7gxExIxLONJkzwJAnAn9/tIwrDVyfWR/ GpUQwm6OrWalrwko0xDT87zkZPPRQueeHIUN7VxhQ8p//mTDmAmQGxozINorjZSIPLkJ0yVeg0x PiakEoHVbtr6O74/mUN+btIj96wcKKGdskPtOsvmIr74zdIVtSq/Cu/Bnc9+KphsdSfZDJj5Yzq gpVkl6WH1W1FIYJvWZOCYsJuilh4knKMJ/qMpZetQKJS+YmqAu9MLTsgawcejpcR01W0dbHxd1/ RuJtfijzgIXQSJQt1zmiY6NYSfiqj/sfviL9pdBNQoA9CAExRwh3zYVi9zH2y+vg5bSZZ0ASGJH 5NrutDUbqOE2blG0LiHzuigldvXZtj2KSTWLSsYQfZ X-Received: by 2002:a53:bf89:0:b0:644:457e:a58a with SMTP id 956f58d0204a3-6466a8443f6mr21716457d50.7.1767114206525; Tue, 30 Dec 2025 09:03:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IEiL4SgoIsztZDtlVQfOtybYtaReJL9rnPrj4hpvD2o4RhoYZuFv0cTAfrROPJhzn/Ejkqnxw== X-Received: by 2002:a53:bf89:0:b0:644:457e:a58a with SMTP id 956f58d0204a3-6466a8443f6mr21716426d50.7.1767114205935; Tue, 30 Dec 2025 09:03:25 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037a5bdb9sm3776086266b.7.2025.12.30.09.03.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Dec 2025 09:03:25 -0800 (PST) From: Hans de Goede Date: Tue, 30 Dec 2025 18:03:09 +0100 Subject: [PATCH v5 12/14] media: mt9m114: Drop start-, stop-streaming sequence from initialize Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251230-mt9m114-atomisp-v5-12-763539e76094@oss.qualcomm.com> References: <20251230-mt9m114-atomisp-v5-0-763539e76094@oss.qualcomm.com> In-Reply-To: <20251230-mt9m114-atomisp-v5-0-763539e76094@oss.qualcomm.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Hans de Goede X-Mailer: b4 0.14.2 X-Authority-Analysis: v=2.4 cv=POcCOPqC c=1 sm=1 tr=0 ts=695405df cx=c_pps a=72HoHk1woDtn7btP4rdmlg==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=hSCjdWxdfPpt4Nx0-uUA:9 a=QEXdDO2ut3YA:10 a=kA6IBgd4cpdPkAWqgNAz:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-ORIG-GUID: ubPF9gJuUUc5yPfHLkA8qPlToHVsKxF1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjMwMDE1MyBTYWx0ZWRfX2tkT13LgnkVh AT9YEOAxPmHOEa6sGgFiLcO6UAZuA2hgwFdccEZKt7ZBY/L7MtI9G20B/gVMmtnpZVlqIgiMgGZ fgwB7H9RuYMPa6qZKiYbGPlDqoB2kN/71o+KSHTFp9fNzA+aS1Blmod7fz8jg8Aco54UunSUyKn +67mSP2FxPmEl9LFpeiiKeg9tMlt98zWLR5O3ADGL4pzbLsosjrj4zl7MlPSWZ4jgHgIEkaIKDt ZT9S/UMtg+2oqqfO6HQPvtTFrSzcScuVfMdSMm045IJx5FmdADykNxVshzWaA8+LelvloTRPqf1 151K/jpLQt91P4jYQX55iyiQeiKI8PzdEJlqBhvRD2qyFPSp8hzE2WnCFcDwd5BN8uhQXSYVsG1 YBK3Ife9gj7K+HIHbysIfCkUuGqhLsXjASZ6VF1Kt1SY4PewdLNoyMolQJL7VcuWsMjC8+SAsuZ 3lox2BRoN0EIlu2YQ8A== X-Proofpoint-GUID: ubPF9gJuUUc5yPfHLkA8qPlToHVsKxF1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-30_02,2025-12-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 bulkscore=0 phishscore=0 clxscore=1015 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512300153 Drop the start-, stop-streaming sequence from initialize. When streaming is started with a runtime-suspended sensor, mt9m114_start_streaming() will runtime-resume the sensor which calls mt9m114_initialize() immediately followed by calling mt9m114_set_state(ENTER_CONFIG_CHANGE). This results in the following state changes in quick succession: mt9m114_set_state(ENTER_CONFIG_CHANGE) -> transitions to STREAMING mt9m114_set_state(ENTER_SUSPEND) -> transitions to SUSPENDED mt9m114_set_state(ENTER_CONFIG_CHANGE) -> transitions to STREAMING these quick state changes confuses the CSI receiver on atomisp devices causing streaming to not work. Drop the state changes from mt9m114_initialize() and move the mt9m114_initialize() call to mt9m114_start_streaming() so that only a single mt9m114_set_state(ENTER_CONFIG_CHANGE) call is made when streaming is started with a runtime-suspend sensor. Reviewed-by: Laurent Pinchart Signed-off-by: Hans de Goede --- Changes in v5: - Drop "and identify it " from comment in probe() Changes in v4: - Move the mt9m114_initialize() call to mt9m114_start_streaming() and drop the config_change_pending flag --- drivers/media/i2c/mt9m114.c | 33 +++++++-------------------------- 1 file changed, 7 insertions(+), 26 deletions(-) diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c index 5e0fbc34921023e1e7a69ec3d098f936eba93ebb..18fcf1a105a4268a501f517a155= f12def0753929 100644 --- a/drivers/media/i2c/mt9m114.c +++ b/drivers/media/i2c/mt9m114.c @@ -789,14 +789,6 @@ static int mt9m114_initialize(struct mt9m114 *sensor) if (ret < 0) return ret; =20 - ret =3D mt9m114_set_state(sensor, MT9M114_SYS_STATE_ENTER_CONFIG_CHANGE); - if (ret < 0) - return ret; - - ret =3D mt9m114_set_state(sensor, MT9M114_SYS_STATE_ENTER_SUSPEND); - if (ret < 0) - return ret; - return 0; } =20 @@ -967,6 +959,10 @@ static int mt9m114_start_streaming(struct mt9m114 *sen= sor, if (ret) return ret; =20 + ret =3D mt9m114_initialize(sensor); + if (ret) + goto error; + ret =3D mt9m114_configure_ifp(sensor, ifp_state); if (ret) goto error; @@ -2318,19 +2314,8 @@ static int __maybe_unused mt9m114_runtime_resume(str= uct device *dev) { struct v4l2_subdev *sd =3D dev_get_drvdata(dev); struct mt9m114 *sensor =3D ifp_to_mt9m114(sd); - int ret; =20 - ret =3D mt9m114_power_on(sensor); - if (ret) - return ret; - - ret =3D mt9m114_initialize(sensor); - if (ret) { - mt9m114_power_off(sensor); - return ret; - } - - return 0; + return mt9m114_power_on(sensor); } =20 static int __maybe_unused mt9m114_runtime_suspend(struct device *dev) @@ -2574,8 +2559,8 @@ static int mt9m114_probe(struct i2c_client *client) /* * Identify the sensor. The driver supports runtime PM, but needs to * work when runtime PM is disabled in the kernel. To that end, power - * the sensor on manually here, and initialize it after identification - * to reach the same state as if resumed through runtime PM. + * the sensor on manually here to reach the same state as if resumed + * through runtime PM. */ ret =3D mt9m114_power_on(sensor); if (ret < 0) { @@ -2587,10 +2572,6 @@ static int mt9m114_probe(struct i2c_client *client) if (ret < 0) goto error_power_off; =20 - ret =3D mt9m114_initialize(sensor); - if (ret < 0) - goto error_power_off; - /* * Enable runtime PM with autosuspend. As the device has been powered * manually, mark it as active, and increase the usage count without --=20 2.52.0