From nobody Mon Feb 9 14:14:16 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6971232BF2E for ; Tue, 30 Dec 2025 17:03:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767114209; cv=none; b=q/t5Yi4S+/MVl9HSNBtrtZJ7a7ogjOCxWsGCLy/PtdnT53bh+EIsx+Ve+CE2TxaT+crnsVYYTKosKWYD1VC7lR72YtbAbeJ9k3v4edGJFFlsSKUaSb22SBwQNhfQqU1BWbdeNthqjMzgOtnSWAaEct7ZVCHSBn5iVWmKESy4zdQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767114209; c=relaxed/simple; bh=GAEYvp3W0KSl1TDifaa6L8tfxr38bL0Dcxr0BViSuq4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VWgeHlefhSNqki6mz+K2X1PBRmIwZXbaKohMt8ya5dAGBbJ9IV4LOtSmKTQhkbBmeQ9CTGJUukzh/SBVkaFXyTe7KqVYhNPIQNckU4AjvUAK2RHgCxFybYVU5Z8nTs21t/49U5GeGEReJ7nDs/TfCJ+fXM3gaFMynsvIqs2920E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gwr9UFQH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gn2USVno; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gwr9UFQH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gn2USVno" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BUAFDNB2557810 for ; Tue, 30 Dec 2025 17:03:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zOf0kuvuEBaHXAfQ+YC93H7I4ZGEiW36M69f0BMm6CU=; b=gwr9UFQHSpDv597F IgkmIyFxKeFIPjD+FfR1kA9bcGJs/dfj4NfrtuT8EE+2aZrzmue5ISA1UVWe6FqK Zbl7in06noFwbn9UWXDu1r1/mojSfxSp1Uk+ovd3TCvAcMeK5j9HyjRoJK0NQZdm Ef2Z6kfxj0cgSWC3s6bSIYhwRZPctQFIeMRX+vYT58hhl3qqvyM2uKETT3RIzx3b DBLzTVB5frycOpbuE8hlVRX//gemHKgrMxztG+I/T2fy9E5hO3+CyE8QUHZaJq5l 1/ltUntp56PR7v6OwK3Yh2qGbVRSte7+YXhw9qd0p6+mahFH24Bsw2UWsJ7aA3HH 77JtJQ== Received: from mail-yx1-f69.google.com (mail-yx1-f69.google.com [74.125.224.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bbqk1bsbg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Dec 2025 17:03:26 +0000 (GMT) Received: by mail-yx1-f69.google.com with SMTP id 956f58d0204a3-64680de9f05so10748564d50.3 for ; Tue, 30 Dec 2025 09:03:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767114206; x=1767719006; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=zOf0kuvuEBaHXAfQ+YC93H7I4ZGEiW36M69f0BMm6CU=; b=gn2USVnoSKoSdCH2AECuYmD5Rt9zZo3D6502DPqF9B16K2OeFcRwdzVWWJMH/OPPa3 gOTPdS5msydWCfABI5GuYrSHgemhloddEOfxQku9rZhLPDPBwOh0CJnwRiQBsWVvti1u kPx8uWBibDzxflgV1LefUg9vczR9uNl+I6XTw5vpZ3kl4BLeGjN+tfZh4++Csz8/wqY+ 6iAVeAfrAN8STXFk2WEhn00RN8iQ09bxb8/nCxoNGTQskp5Pxic3HnrPyWGGGrtzK/vT dmnIVJOe8N75/xwNvOO3aGgILWoHLXGAht4TbF5CUuJSZAQqsy6HZGd+oBU0zDxV+Z1C 7LwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767114206; x=1767719006; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=zOf0kuvuEBaHXAfQ+YC93H7I4ZGEiW36M69f0BMm6CU=; b=bo1XOENNChI5cxJxJ/dT3s/ArdtsxrNBHd9b+QJsKdJAqHlez9/TJHJeoL89k5eSUs A8zjPuTV2Rhfxo/OnVP0CiKYMm3EAmStxLsZem8UBuBfZLHTsqnVTehI2/ctbv77eLW/ j9Y3AKVtHW6HUsAb8bekwsc7PivKKb3dismDGtzeUyCvvPbYSUvLcOIVC5tcdrbQnjkT rO7TXnKAGX6kdHwLmXKz59Mv3G66MffnTTQFRkT3NFF7ofuN7h3B+PPcvlPD4g87AW8s 287o8R1wkeHkHGzV/EVZ9siwwUCxxlHiHLnBu44LcTq/1v4fBAz1y/l8tf52c46fKBnD Io8w== X-Forwarded-Encrypted: i=1; AJvYcCUmOKXqmKGVmkUMJcSlpHoMilcZiWXor6Qhrn7AZ3vAw8+Tiyhr/k9ga0OHZ6xMEQbQVPuxQHcZ79N+Cjg=@vger.kernel.org X-Gm-Message-State: AOJu0YxVkxcLUa1bLjIpbyUar5vym+CZH3LFTjMAUx+JeT+/HPmeyfYW 5fljS0zWT7SO35JUb+Z89W2XXaf94EShcfkHZIjJbxss8dpgaRRw09Ny1L1BcQ1Qbd69rJ7dFR9 WVtdMTZCx4n2T+5LnhQo8VdTRwuiQjepTRPM0YXy+pnOmMmti5cXatD7w37jfqKxchlI= X-Gm-Gg: AY/fxX5S47M+BvjJhM/0uqg2lfTIW9PAySQnEcpgxikljjOd7hJSgIvG1XEui+MTBik JzzzBe7pu9nxcBSlBUqo0DzYSpFSmb9fxUdIJzPXtZGxm3hCiRQqWVKh7+AYkFMzSQyDfjrmSjV LKO6K4CMEBQgzT1BRlNMyTQHGdU+H/z3NDJmRoh4bj2SG+xwVHcy2csq3SQAZGjfPTlEGiuTmaB +/B/scyvZhYm/jifOgaBG/Fu2/ehg7ABweyxtZL/8TNnWlIwtN4LVgCOEO6cmw0KpF0pQlcdJzS cLWxAG/E0mshh5HEDFXuwGaB5rmLFBjFjRtgj1tw79/eOxWGsgYl+5YclrrNbUnAfTU3XhXZUpO wxxxRFxiGFwdAVmpA/r84JDI0wyiyclR+noC/CzDj0xYzZVea6kV9QW23ySIUoYGAsYjwiJNQiP u6Lc2h4BW6yiOLR0WVL277oKNmAULofW66ELFN3qgj X-Received: by 2002:a05:690e:2101:b0:641:f5bc:69a6 with SMTP id 956f58d0204a3-6466a8d2f31mr18696293d50.84.1767114205454; Tue, 30 Dec 2025 09:03:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IHYeOD07as/XBeCYJwqhLI3N605Dzx8wPU8dDwklpMUKRy+jTAZHIwXbzua4HPo3h3az0orUQ== X-Received: by 2002:a05:690e:2101:b0:641:f5bc:69a6 with SMTP id 956f58d0204a3-6466a8d2f31mr18696271d50.84.1767114204901; Tue, 30 Dec 2025 09:03:24 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037a5bdb9sm3776086266b.7.2025.12.30.09.03.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Dec 2025 09:03:24 -0800 (PST) From: Hans de Goede Date: Tue, 30 Dec 2025 18:03:08 +0100 Subject: [PATCH v5 11/14] media: mt9m114: Don't allow changing the IFP crop/compose selections when bypassing the scaler Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251230-mt9m114-atomisp-v5-11-763539e76094@oss.qualcomm.com> References: <20251230-mt9m114-atomisp-v5-0-763539e76094@oss.qualcomm.com> In-Reply-To: <20251230-mt9m114-atomisp-v5-0-763539e76094@oss.qualcomm.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Hans de Goede X-Mailer: b4 0.14.2 X-Proofpoint-ORIG-GUID: ORsR8OhHVcC9QXqs2wuvvqPER6KOw7qW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjMwMDE1MyBTYWx0ZWRfXwYAuwztcYRzC nTgT6eYK7+PGALcXDdxkdu7LWNxPiwDgy+PSyFrIVL+sgZG5fJ1oGr/IVP3dGGCKy+fEmNmD7EV oAcp4TH1bMw7vBKslmsx4u8THji5YDO125Maipry2jHCJVDJjpijJkWpIlDjSTOnrgYyKEPXCye 4EvFCbUlSUBlmYtpN/UKoTLCRR72yOqg4o5EVg/p6S8fSnKbGCU2fEHPoZLTETaETtxUfm63O77 A3tANtrDK7MvKNqL/0eNu/QhmdIpngQ/1dYHXPwUzV0VUbVq6iQtIB7R7VOMPiZSeKgzpav7hZ7 wyRepLrV7KT08nKtg446wmys2TdW8WIFoRaSE5/yf+I4+P7f89DP/Zi9xvSqkt6KV94Ax3aaejC wlntQqTLuJZWOMYB0Y9bqUyDBKU56HwF46We0wElFhs7zxWjHMCfqh/S2O4kThtKaYZ9DuC2eNE g/xtX8wpYj7cR/m1/7A== X-Authority-Analysis: v=2.4 cv=Tf6bdBQh c=1 sm=1 tr=0 ts=695405de cx=c_pps a=J+5FMm3BkXb42VdG8aMU9w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=FI8FN61yIa-P2m5uk4AA:9 a=QEXdDO2ut3YA:10 a=Epx66wHExT0cjJnnR-oj:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-GUID: ORsR8OhHVcC9QXqs2wuvvqPER6KOw7qW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-30_02,2025-12-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 impostorscore=0 suspectscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512300153 The scaler is bypassed when the ISP source/output pad's pixel-format is set to MEDIA_BUS_FMT_SGRBG10_1X10. Don't allow changing the IFP crop and/or compose selections when in this mode. Instead of returning -EINVAL simply return the current (noop) crop and compose rectangles. Reviewed-by: Laurent Pinchart Signed-off-by: Hans de Goede --- Changes in v4: - Move crop =3D v4l2_subdev_state_get_crop(state, 0); up a couple of lines to avoid having to call it twice Changes in v3: - This is a new patch in v3 of this patch-set, which comes from splitting up "media: mt9m114: Fix scaler bypass mode" into multiple patches - Add src_format local variable --- drivers/media/i2c/mt9m114.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c index d111f9e45d2d9c47de315d06ee8a6adb28700146..5e0fbc34921023e1e7a69ec3d09= 8f936eba93ebb 100644 --- a/drivers/media/i2c/mt9m114.c +++ b/drivers/media/i2c/mt9m114.c @@ -1984,7 +1984,7 @@ static int mt9m114_ifp_set_selection(struct v4l2_subd= ev *sd, struct v4l2_subdev_state *state, struct v4l2_subdev_selection *sel) { - struct v4l2_mbus_framefmt *format; + struct v4l2_mbus_framefmt *format, *src_format; struct v4l2_rect *crop; struct v4l2_rect *compose; unsigned int border; @@ -1997,8 +1997,16 @@ static int mt9m114_ifp_set_selection(struct v4l2_sub= dev *sd, if (sel->pad !=3D 0) return -EINVAL; =20 - format =3D v4l2_subdev_state_get_format(state, 0); crop =3D v4l2_subdev_state_get_crop(state, 0); + + /* Crop and compose cannot be changed when bypassing the scaler. */ + src_format =3D v4l2_subdev_state_get_format(state, 1); + if (src_format->code =3D=3D MEDIA_BUS_FMT_SGRBG10_1X10) { + sel->r =3D *crop; + return 0; + } + + format =3D v4l2_subdev_state_get_format(state, 0); compose =3D v4l2_subdev_state_get_compose(state, 0); =20 if (sel->target =3D=3D V4L2_SEL_TGT_CROP) { @@ -2043,9 +2051,8 @@ static int mt9m114_ifp_set_selection(struct v4l2_subd= ev *sd, } =20 /* Propagate the compose rectangle to the source format. */ - format =3D v4l2_subdev_state_get_format(state, 1); - format->width =3D compose->width; - format->height =3D compose->height; + src_format->width =3D compose->width; + src_format->height =3D compose->height; =20 return 0; } --=20 2.52.0