From nobody Sun Feb 8 20:13:04 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3464627A107 for ; Mon, 29 Dec 2025 17:14:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767028469; cv=none; b=TBnvwCn4h0F1cPSOWPsNqbfhmCO0H5DQ0fNV7V1VLVoVupen7jyA6YdOrR27BvBdpSfilZPS4gQtAEGhIBKsRyNt2vgDJVynbByy1t8nXHMNe/xCFiVkEHL4Y+xeqMGqhnUxkj8q80BpYlMNjPj6Pot/PdXLG3AKEcqdoWAzVbM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767028469; c=relaxed/simple; bh=W6aUeOEN1SgFtWQZemlJwqK1F1smQGCcFNxoAevcZJ0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=tsOzQJ+MpnZE1cUrqAe5ERpzNiGIrRXAWeGFQugPzjmgaF2tVEnHAGtH6X1w8mmQlnBdGnqu/kPw7AfC0kKuHa9UeRcGP+6hMRQZzCOyRxbFNDG3GF3scFacw44/baWOqwzK5lI1Xo2O7XMopGSep7iCH2jJ4W0lR0YxXBb1uTs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dvVnM5rd; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dvVnM5rd" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-7bc248dc16aso7279559b3a.0 for ; Mon, 29 Dec 2025 09:14:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767028467; x=1767633267; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=5NK6dp2s8X6NtEpLJQM+0l1rM8deukQbR1S/tTFRVRA=; b=dvVnM5rd/jX/Ai4hZK7yFww5FH7uhh6LGZXiiKIP48o5dkkUtM/QVUqq8kxg6gxDuR h4MoI3TW+ApwVBtmHumq5EySJbungMQ3xmXqaQ8O8CaFK6XKPY8IkSIm800RI8zRV7oq OV4X84JKgoxxSoof8ShyOYlnPnya94/IIj3B2nzU6mq78IJ+GvaFZ5Y6KVTGssDjs2e2 /2/q33MIhmCqSjFQL58aERPtyH4Ea8lERMqHQ7thp2q/bkjr3++A0MxlM74oD11EdS0a b33/HiInivdxkoYftQrdxtrjEVSTNRHqKNM5ovhNN91L74NEWgOUh/D9c9Q5VVjJ/pNr oE/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767028467; x=1767633267; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5NK6dp2s8X6NtEpLJQM+0l1rM8deukQbR1S/tTFRVRA=; b=KnMSYPljj1QwuqpZk3D6MHmCDqkmt8ZJERz0vF0NVxrL9bCkBRhm+Iw8aNMuNi00LN 2Tr0vJwregYWsba/fZVPVDsPxn/8du8JVZcM9sXa7ka/er7H1+8KO7Wo/iMjNwywIRcL 5aPYe8w6vQwPHwED9n/7AeqkMrbt5mPWLsny4XoqLPJlHkQXzlssPXBRQ11cEBIgph1V K1lNAHCPdYhvK9lNlknUJ55U4Vi27tUf50t8Gq2fK+BH3dBqRQG4W2ktvRjh6AwqTGYw RXQ5kALDI3w9E9wqDkZVRi1KU8UAoxiwtJgK7xZfcwYMF15jfDeSlbU/oub11Tz7RdCe FHcw== X-Forwarded-Encrypted: i=1; AJvYcCXy8HRftMlrNdf39wwbHxWBvBV2ryOqz332tAiSaoMz7TfB/+h15ZyEgW2Owc0+lUvsxwcR5Mek9w3konk=@vger.kernel.org X-Gm-Message-State: AOJu0Ywx4FG9IY6XE4SIkbJdgQ3HMhEkPni3V4Gdj7uBt/joIX+mdObS 358Unr7MgghXkA9ADB8tqhinwi5fiR8k8HpYmTNmhP6f46a8wGCMCpLS X-Gm-Gg: AY/fxX6OfCiLt1+XEmhrwHevjXDiORJRRougZDX2rsUHCsmQNAhxO7JgchCo8r8tW/x ufftYPKgHhOMluOIGcE5VHanEZoybOQhLxfkQdof2XmOcXRudTyvQSJKBWpg1srA0Wix3zgfBNk xN6EtaQQNScVIOzeEYj+bzwV9OHPDFJCei8knFvGJf7IIebeH9DamO+VsNCbzRD6UZAy21FAt/2 TleTJIZ/Hm61zTRVUzBCRlk/gSe7SkBnSNKqMCT1ZdQbQn5PmiI/jDEBRe+YDL9wY1KD3HA5SNq z83fhJXkeYU8UHUgPEmU4c9QtzM1DYmYSN63gHwZ2nECemXeuWw2Uj8wm/VBCESbD5yN6U4wQVJ qlTi7W2MIP1Q7An8rcYA+x4+4EqAxAACQKKrxyZ0E4gNjlvKJ9kRgp3qR/6jvOQbvuWxKV0nt+/ 1vxzZN6IehDvLOwGZjxsM= X-Google-Smtp-Source: AGHT+IE0UQafWJtzQnLvkcd4tjvwk6WEjuZXQW80bW7BYX7qVp8/RiTlljt2VidyeoCSfiVHLlor+g== X-Received: by 2002:a05:6a00:1f0c:b0:7e8:4587:e8c4 with SMTP id d2e1a72fcca58-7ff66479a55mr26456010b3a.55.1767028467371; Mon, 29 Dec 2025 09:14:27 -0800 (PST) Received: from [172.16.80.107] ([210.228.119.9]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e48cffesm29656429b3a.49.2025.12.29.09.14.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Dec 2025 09:14:26 -0800 (PST) From: Ryota Sakamoto Date: Tue, 30 Dec 2025 02:12:51 +0900 Subject: [PATCH] gfs2: Fix use-after-free in gfs2_fill_super Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251230-fix-use-after-free-gfs2-v1-1-ef0e46db6ec9@gmail.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/x2MQQqDUAwFryJZG9B8lOJVShdf+6LZWElaEcS7+ +lyYGZOCrghaKhOcuwW9lkLtHVF05LXGWzvwiSNdK2khtUO/gU46xfO6gDPGsJ9P+kISWPODyr 15ijq//x8XdcNrx2XbmkAAAA= X-Change-ID: 20251230-fix-use-after-free-gfs2-66cfbe23baa8 To: Andreas Gruenbacher Cc: gfs2@lists.linux.dev, linux-kernel@vger.kernel.org, syzbot+4cb0d0336db6bc6930e9@syzkaller.appspotmail.com, stable@vger.kernel.org, Ryota Sakamoto X-Mailer: b4 0.14.2 The issue occurs when gfs2_freeze_lock_shared() fails in gfs2_fill_super(). If !sb_rdonly(sb), threads for the quotad and logd were started, however, in the error path for gfs2_freeze_lock_shared(), the threads are not stopped by gfs2_destroy_threads() before jumping to fail_per_node. This patch introduces fail_threads to handle stopping the threads if the threads were started. Reported-by: syzbot+4cb0d0336db6bc6930e9@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3D4cb0d0336db6bc6930e9 Fixes: a28dc123fa66 ("gfs2: init system threads before freeze lock") Cc: stable@vger.kernel.org Signed-off-by: Ryota Sakamoto --- fs/gfs2/ops_fstype.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c index e7a88b717991ae3647c1da039636daef7005a7f0..4b5ac1a7050f1fd34e10be4100a= 2bc381f49c83d 100644 --- a/fs/gfs2/ops_fstype.c +++ b/fs/gfs2/ops_fstype.c @@ -1269,21 +1269,23 @@ static int gfs2_fill_super(struct super_block *sb, = struct fs_context *fc) =20 error =3D gfs2_freeze_lock_shared(sdp); if (error) - goto fail_per_node; + goto fail_threads; =20 if (!sb_rdonly(sb)) error =3D gfs2_make_fs_rw(sdp); =20 if (error) { gfs2_freeze_unlock(sdp); - gfs2_destroy_threads(sdp); fs_err(sdp, "can't make FS RW: %d\n", error); - goto fail_per_node; + goto fail_threads; } gfs2_glock_dq_uninit(&mount_gh); gfs2_online_uevent(sdp); return 0; =20 +fail_threads: + if (!sb_rdonly(sb)) + gfs2_destroy_threads(sdp); fail_per_node: init_per_node(sdp, UNDO); fail_inodes: --- base-commit: 7839932417dd53bb09eb5a585a7a92781dfd7cb2 change-id: 20251230-fix-use-after-free-gfs2-66cfbe23baa8 Best regards, --=20 Ryota Sakamoto