From nobody Mon Feb 9 03:30:56 2026 Received: from mail-m155101.qiye.163.com (mail-m155101.qiye.163.com [101.71.155.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1A76315D22 for ; Mon, 29 Dec 2025 15:22:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=101.71.155.101 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767021738; cv=none; b=bBQNMISSwJYz8qK1LonlCNpRMCdIKZPm7mNy1p+SSI1FBLzvXASmUu+VbSiwXwv0vB/hZ+waLGiKUtK/t7qrhNEQO7faGZ6zE4d7z6R3EVGwUHBlZ+UZM7r/pZldww/VKX3P4HUdNwuZgAbsTP2Yzmp2pH2S/YFRk0oKNCVOk3A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767021738; c=relaxed/simple; bh=V5lyIaiQWaWq5mO9oFWqG/pcEhcvln43C63rmC/j+N8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=pVeuchYwv/F6jCxP1H/EsTfGUEXx1qtR3NuEvWX6t248mAlQJUe3izuDqbFoX7a8f8YvFGMNRbVM+lcgdzzAefysYUUlndg7wP+E2NrHw8px5mOMDPah68Mtg0riIMn60000NRD9BptdVb7OOSLUR7u6QtqroCOXUP/hhe5rFLo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=seu.edu.cn; spf=pass smtp.mailfrom=seu.edu.cn; dkim=pass (1024-bit key) header.d=seu.edu.cn header.i=@seu.edu.cn header.b=DaxC+j9e; arc=none smtp.client-ip=101.71.155.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=seu.edu.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=seu.edu.cn Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=seu.edu.cn header.i=@seu.edu.cn header.b="DaxC+j9e" Received: from LAPTOP-N070L597.localdomain (unknown [58.241.16.34]) by smtp.qiye.163.com (Hmail) with ESMTP id 2eeaefa0a; Mon, 29 Dec 2025 23:22:05 +0800 (GMT+08:00) From: Zilin Guan To: dpenkler@gmail.com Cc: gregkh@linuxfoundation.org, matchstick@neverthere.org, mingo@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, Zilin Guan , Jianhao Xu Subject: [PATCH v2] staging: gpib: Fix memory leak in ni_usb_init() Date: Mon, 29 Dec 2025 15:22:03 +0000 Message-Id: <20251229152203.475658-1-zilin@seu.edu.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-HM-Tid: 0a9b6ab3c7ad03a1kunmf0f5c6c1127474 X-HM-MType: 10 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWS1ZQUlXWQ8JGhUIEh9ZQVlDHk5JVh1NQk5OTxkaGk0fHlYeHw5VEwETFhoSFy QUDg9ZV1kYEgtZQVlOQ1VJT0pVSk1VSE9ZV1kWGg8SFR0UWUFZT0tIVUpLSUJDQ0xVSktLVUtZBg ++ DKIM-Signature: a=rsa-sha256; b=DaxC+j9eAtXr3jgtfWrEZZAzg/EVpIzXFll1m75O9blRfl4vu9YhKRZnIhJdHBmYrMjE70lrY1Rzoi+FNutjRaVhbpiPb/4ufefmYucxmy7cWKz7I+FlJS+xFTNF7Y1JWb/YzIG+EfsBeK0UdBzAyZJtwM+T6SjIWJ98QdtCzT0=; s=default; c=relaxed/relaxed; d=seu.edu.cn; v=1; bh=8DuJ2WpOfm0gYV81MQGWZORnLVabUNN02w3Kw1n1yFE=; h=date:mime-version:subject:message-id:from; Content-Type: text/plain; charset="utf-8" In ni_usb_init(), if ni_usb_setup_init() fails, the function returns immediately without freeing the allocated memory for writes, leading to a memory leak. Fix this by freeing writes before returning the error code. Fixes: 4e127de14fa7 ("staging: gpib: Add National Instruments USB GPIB driv= er") Suggested-by: Dave Penkler Co-developed-by: Jianhao Xu Signed-off-by: Jianhao Xu Signed-off-by: Zilin Guan --- Changes in v2: - Use early return to simplify error handling logic. drivers/gpib/ni_usb/ni_usb_gpib.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpib/ni_usb/ni_usb_gpib.c b/drivers/gpib/ni_usb/ni_usb= _gpib.c index 1f8412de9fa3..2352c6817440 100644 --- a/drivers/gpib/ni_usb/ni_usb_gpib.c +++ b/drivers/gpib/ni_usb/ni_usb_gpib.c @@ -1799,10 +1799,12 @@ static int ni_usb_init(struct gpib_board *board) return -ENOMEM; =20 writes_len =3D ni_usb_setup_init(board, writes); - if (writes_len) - retval =3D ni_usb_write_registers(ni_priv, writes, writes_len, &ibsta); - else + if (!writes_len) { + kfree(writes); return -EFAULT; + } + + retval =3D ni_usb_write_registers(ni_priv, writes, writes_len, &ibsta); kfree(writes); if (retval) { dev_err(&usb_dev->dev, "register write failed, retval=3D%i\n", retval); --=20 2.34.1