From nobody Sat Feb 7 11:38:15 2026 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 205BC26C38C for ; Mon, 29 Dec 2025 13:59:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767016755; cv=none; b=oaCWfHuUBujtA139KjUjggxLdpiyYhrzRN9Fi9QBfLDFdeqc8WxjgPTIVB6rtUFGYmjA8TLecBkFmEjWxCTPeTqwGa2LmmXEQyW/mwzRCaB8QWbi0Dpu3DySFAjo7bwhvuxxXYT07ND8vJyTk8zIbzGKEMPxMft4FNDqJqtLVQc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767016755; c=relaxed/simple; bh=k257uZ3HPDKFfAze/hz1Hfmw8/7Hf+9ogZi61Nyan10=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=a0ZpElldPCe4vBRF9/Fh3gspEanZhJZqmxFhVeq4jGst8gAHdiUKD0yWjS0bPDi2m693uvgldbK6OGE8de/44rHxVwcxonoG52N9T9IGRhAFz8cK51zAnS1pwiJRqJvzCB70fIX5erUG5VraEH1VftVaTulwhBuKOwXc/5UtVrU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Jb4vi6OU; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Jb4vi6OU" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-430f38c7d4eso645264f8f.3 for ; Mon, 29 Dec 2025 05:59:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767016752; x=1767621552; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jnurlv5ZkeGevc2yEP3yL2OMFl89R04sLNUEhoXlc4A=; b=Jb4vi6OUmolZ4NXViQlAkeq0JttPiAGs85sSgTroLRQN6PTW3eJ0Qx3lk4q4uljvuw hY9QD7hSwXfbp/I/Uuldx6Pou/8Kv8NqMzpG1+EEMTiaOxSHjdDOUPMdooPJvLO3bgrQ fCL2C1VDR+wLBEildF9gD831DPeJGwNsvtKw2eWJOCRVAgEIEVwo1HVLcH+aXZV4KGRO DZX1zoLxHJ7+zgAsrUl5a+N7J5DC9d3PYmD1CsE1BDztKcCSRKebIWEKm//NvNf/38rp ohxAD8pFkM6X7cwgMPp7NlvYiagUcfRxNBB2dPAcNvO1i8nCJWNeGB+GRHYYwDMjZv6u z8bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767016752; x=1767621552; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jnurlv5ZkeGevc2yEP3yL2OMFl89R04sLNUEhoXlc4A=; b=VLcBr+0OWfrpVaUfjjDvrNfk7SMBqS2FGj0GRuSlclorj0RoqNSbzeS/RdU7bSPfn1 M5szEH+V1Z//ALryp6b9+38h+kVWx6CSyUcciM+weGyFa1ipVaidTAN0H+8FY+kNY9w/ NsZNXOnGmIkHcxUMbiFIr0TxZUXFZiRjLzxzBBLpFAuKU2Ty3mtBv0XYke4vTuXaPLmh w25TONcWs2pE7bpePhToAnQ2BfGtO7P0MH1z1LR/TIUAIHbhXNwhpDxxtL7uiTof0O0J 9RtDyZdmjPa+1uaJjkvGocXKZJmalAIQyhcildcrd2zrfDL4dDLxw+L0CdOx69yrDQZF 16XA== X-Forwarded-Encrypted: i=1; AJvYcCXBrgl7IMxn5VMdgBuZhNI5Ie61JLP2FHbmWjuQNwUJYsk0bgtAUFgNsJESBMc99nAlxBe+HDcy72bpb4g=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4YCwpPA3CHPcduRrwHXjHpGXnP+NVwD4OgUo5quLmOXwFqAjC w9OFMXSoHWLszb+c7mmqceZo/19DgUDfjuXDXtFdFywsbsx3UGLYOoMc X-Gm-Gg: AY/fxX7/8VAGewdLgu3YCUMCx371seRDn/f7I2f3W1mTFeQqpyVh2Edl15lknqwRVFA rWrg4aDw8xbP9+j4oY8vzBjnjZFxeWIKsdmbfQDfUJ2VUSu0Vw5y3y7Wb+K1a6eEoxVdw8UwA4u NxDROFcdaH6iAPCD1DnB8RfAdS02hlwrorVw03AHWLOEmKIKlVmt3p37YGaRCg/yQmsLzsu8GWl PI3tfHGHPYel35WH1jeylub3W9iT0+D96GvJJniDYBRlaJ6IUx2+5+ADDptKe+QxssChVOOA2Nl I8snXKK/U5sAWdqbycUgud0tA9tvrx3p3rsQDTQwi5+kj9f9Gvvru7GnBhRxVuQ6g1+LRww08WF xX0MeSxeShj53h9MLoyQkMT+8T/EB9VEc22+xLkl/k6JthefiR2EfXma83ka0OGnTFbxa60qj3c Y7A4HYw47wBdPBYQPtxZzvZ8ZrrZSeoOpDrAjllkFopv2CMyoODtuh+VCqql9tf4FnP3BP+1suO 6MyUW4= X-Google-Smtp-Source: AGHT+IG9xRAmZubwF+oTURx72QKNS8IBmfurtixzLyk4corHAwr+82eB/ZvmEfCyKAkZ8m72tcMOWQ== X-Received: by 2002:a05:600c:3ba4:b0:468:7a5a:14cc with SMTP id 5b1f17b1804b1-47d1957af0emr232438825e9.3.1767016752121; Mon, 29 Dec 2025 05:59:12 -0800 (PST) Received: from thomas-precision3591.paris.inria.fr (wifi-pro-83-215.paris.inria.fr. [128.93.83.215]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-4324ea1b1bdsm61881417f8f.8.2025.12.29.05.59.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Dec 2025 05:59:11 -0800 (PST) From: Thomas Fourier To: Cc: Thomas Fourier , stable@vger.kernel.org, Greg Kroah-Hartman , Thierry Reding , Jonathan Hunter , Wayne Chang , Haotien Hsu , "Russell King (Oracle)" , Liao Yuanhong , Nagarjuna Kristam , Felipe Balbi , linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] usb: gadget: Fix trb_virt_to_phys() error value Date: Mon, 29 Dec 2025 14:58:49 +0100 Message-ID: <20251229135853.33222-1-fourier.thomas@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" 0 is a valid DMA address, so returning DMA_MAPPING_ERROR in trb_virt_to_phys(). Also, dma_mapping_error() wouldn't flag 0 as an error address. Checking the return value directly because the dma_addr does not come directly from dma_map(). Fixes: 49db427232fe ("usb: gadget: Add UDC driver for tegra XUSB device mod= e controller") Cc: Signed-off-by: Thomas Fourier --- v1->v2: - Add Cc: tag drivers/usb/gadget/udc/tegra-xudc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/udc/tegra-xudc.c b/drivers/usb/gadget/udc/t= egra-xudc.c index 9d2007f448c0..63f7eeddb401 100644 --- a/drivers/usb/gadget/udc/tegra-xudc.c +++ b/drivers/usb/gadget/udc/tegra-xudc.c @@ -904,7 +904,7 @@ static dma_addr_t trb_virt_to_phys(struct tegra_xudc_ep= *ep, index =3D trb - ep->transfer_ring; =20 if (WARN_ON(index >=3D XUDC_TRANSFER_RING_SIZE)) - return 0; + return DMA_MAPPING_ERROR; =20 return (ep->transfer_ring_phys + index * sizeof(*trb)); } @@ -1484,7 +1484,7 @@ __tegra_xudc_ep_dequeue(struct tegra_xudc_ep *ep, deq_ptr =3D trb_virt_to_phys(ep, &ep->transfer_ring[ep->enq_ptr]); =20 - if (dma_mapping_error(xudc->dev, deq_ptr)) { + if (deq_ptr =3D=3D DMA_MAPPING_ERROR) { ret =3D -EINVAL; } else { ep_ctx_write_deq_ptr(ep->context, deq_ptr); @@ -2834,7 +2834,7 @@ static void tegra_xudc_reset(struct tegra_xudc *xudc) =20 deq_ptr =3D trb_virt_to_phys(ep0, &ep0->transfer_ring[ep0->deq_ptr]); =20 - if (!dma_mapping_error(xudc->dev, deq_ptr)) { + if (deq_ptr !=3D DMA_MAPPING_ERROR) { ep_ctx_write_deq_ptr(ep0->context, deq_ptr); ep_ctx_write_dcs(ep0->context, ep0->pcs); } --=20 2.43.0