From nobody Sat Feb 7 18:21:10 2026 Received: from out30-119.freemail.mail.aliyun.com (out30-119.freemail.mail.aliyun.com [115.124.30.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44C858821 for ; Mon, 29 Dec 2025 10:05:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.119 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767002725; cv=none; b=nkMPrGUxQdK82rAQdndbrd/cyF+MEpRBAOyzqBfsp1SKqDH0i/FifunYq1nmhqBZFNREC/3TiONj2x6x9vRmTPSW84u8T5Uc5VUHXyhhukkOsww7yuUcvhVZdkgTJx0ODRcXYJlDaM52ftvcvZxeK3thaku000d82VYO8Gqdlbc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767002725; c=relaxed/simple; bh=nTJX4eaUaOr0KzXVLFNruytdki7by+H3i4rBRqiZC4A=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=kmI8O6C+f/Vs6j5N3EALaQ9QZ3vQIN49VkKysSKnLs9o+sfkxR0964bBTMqNDcQFLtDmL8/1mnKtXPqWsUVcUAEwGpGKhSC7z2NbBQcLxALK/bVy4wDBvpweS/dwqfiJlNTmjffCO7mDkHNFjhjYvPUiUmq4NbzD4nGCrkDnBeY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=JHeYkvr7; arc=none smtp.client-ip=115.124.30.119 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="JHeYkvr7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1767002719; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=1FFSI7l0ZOXZyB8p+x/GzISO2FctJEjGqFqb2Via1JA=; b=JHeYkvr7zLa2nS5S5/4nsFr/E/zr7yWgRixgaHk1YOz/kcNRZU8J/cfglKkgLYRztuR2oYenVP+nm9nbp0X3GyRjG8LgFMobszgOw8CRwipOVMIMSfdi3sDmDTbYH+SQhHUfPIIWgfUvUl48zLZM4cbM5RILAZYrhdXr9vhKJT4= Received: from j66c13357.sqa.eu95.tbsite.net(mailfrom:mengferry@linux.alibaba.com fp:SMTPD_---0WvrWbjh_1767002716 cluster:ay36) by smtp.aliyun-inc.com; Mon, 29 Dec 2025 18:05:19 +0800 From: Ferry Meng To: linux-erofs@lists.ozlabs.org Cc: LKML , Ferry Meng Subject: [PATCH] erofs: remove useless src in erofs_xattr_copy_to_buffer() Date: Mon, 29 Dec 2025 18:05:15 +0800 Message-Id: <20251229100515.111287-1-mengferry@linux.alibaba.com> X-Mailer: git-send-email 2.19.1.6.gb485710b Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use it->kaddr directly. Signed-off-by: Ferry Meng Reviewed-by: Chao Yu Reviewed-by: Gao Xiang --- fs/erofs/xattr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/erofs/xattr.c b/fs/erofs/xattr.c index 396536d9a862..c5c481b3f32d 100644 --- a/fs/erofs/xattr.c +++ b/fs/erofs/xattr.c @@ -182,17 +182,15 @@ static int erofs_xattr_copy_to_buffer(struct erofs_xa= ttr_iter *it, { unsigned int slice, processed; struct super_block *sb =3D it->sb; - void *src; =20 for (processed =3D 0; processed < len; processed +=3D slice) { it->kaddr =3D erofs_bread(&it->buf, it->pos, true); if (IS_ERR(it->kaddr)) return PTR_ERR(it->kaddr); =20 - src =3D it->kaddr; slice =3D min_t(unsigned int, sb->s_blocksize - erofs_blkoff(sb, it->pos), len - processed); - memcpy(it->buffer + it->buffer_ofs, src, slice); + memcpy(it->buffer + it->buffer_ofs, it->kaddr, slice); it->buffer_ofs +=3D slice; it->pos +=3D slice; } --=20 2.19.1.6.gb485710b