From nobody Sun Feb 8 09:12:41 2026 Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B5FA2580DE for ; Mon, 29 Dec 2025 07:52:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766994751; cv=none; b=ZMQxhoF3m13HS5/Sbk0dW6pMJfhRHYouBA8GbtkELLESYHjIMpE5Tb9//zOeWQDJnq9h+fQ+tk+H1HKdsLwxR0UgYIr3P/PuHDf52d8DMNKjBFRvHwthWsP112+X1NDh0z/xObWrI3apGppRZtl8ayM6QAOTWRyte8luTq2rnNQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766994751; c=relaxed/simple; bh=uJDU7774F/XHA0B0XTRONQLG1mBUzool/kLyuvfVWYc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gqiVOxZUfQIBt8MItyqzQfF6Ziu1+iqrnX202Zsbdx4pOcgC/dZuAC6b0gZGaxy2yoQB2Fg4cHcLhrUnyV/rprzPxWnj0PniaaqTiHXODbNiUyQOrEPvr1YuWaynTZWOvSeZyswL1kqTfnJQk0tzZMmC6EtXH3/CdE8A3SI+ZtI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BC1vgVry; arc=none smtp.client-ip=209.85.208.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BC1vgVry" Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-37fccf7035aso71257941fa.1 for ; Sun, 28 Dec 2025 23:52:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766994748; x=1767599548; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=W9rs18lnfFY/HykoHJUbNuPfbr0n92mG5VNAEHVdWKA=; b=BC1vgVryNW8/YK2PLm9waay29X1ECg7IYlH/GftvFDPbXLn1cmUxRxJ5tDBhvLAXD5 tRbbicNmOd6zHj+c0sIslfaXzZMNNKefNHBljxshAySzl+0127Cv5TC22MC5TYrnUKBy NS+aR+U92QGyILOR5eZcJm3fq4efkeUiHKYBccMr8arMzgs+KILIPrUiCSsnlhUn1U0V E8knvOpbcEKrySDHcNESvGPSJIBYdVbyyPW5OWyey7A1Zi9XwVwj907+jREdXhklCBLR Vg4UfdEUUNDTPBXsk+VmbCuHsg0Az8MBizD24hPUi3W5DQT7TxR0fcV7GDXVU5CkoQz1 +38Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766994748; x=1767599548; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=W9rs18lnfFY/HykoHJUbNuPfbr0n92mG5VNAEHVdWKA=; b=GhaIQ/G5LWFpqHNt87MlIlBc2KA5w9cZI/H8Q5hUkFRYsXmlDS3Q9/SpJ+Je0bPiN/ FWHgZKE1jWibD704FxVHZ76VpujSR+GFMZy88oAkQ6JTq9LQ1/LSSpgkVVybU2xvYeII n8gz2Oz9hBsB5QDIQBqcMInK/FZ7sUFiInH+lQMV/wQLkFvZQXPv4JNh7r5Hb/WiJgUY AtdWotlZWAurPioZ9WBxUS0AcxFMCF8AgwDeHCRMM8J7eBXiH2rJngGNN/wtL7dfIcZL qr1frcN/u8IhKdJtjuFAetR0lqX4HzK3stYJVKb0rH/3JQmC3DKEtKgHcHWS2RBeXf6k 14bA== X-Forwarded-Encrypted: i=1; AJvYcCXGRXrVlzGNMxAhsJ/KlwiWXovr9lB5cKKV+vpf6YZtpVE4CovfKgwpp/rkTC1sLwuxGodEYVGTKFf+QCs=@vger.kernel.org X-Gm-Message-State: AOJu0YzTq0HTM33EUxG6sw3SyIs+Sg3BMoC8wKBCweW+qKaAJq7uoXe4 qJXYPpxybFOLPUqmEIn4aGAa5l9NopO6luddYQcE+QMD+CNSVqerGhId X-Gm-Gg: AY/fxX4Jt4cSNm4vrHsq//ucxrcCD81M5GrOWOva1IBEdnBheTbK9vJ4LFtCUdmwFd4 U7Z927hxm/OE2fuToMjEmF2LD283yL6ExXb9I9NSf6BnUJW35rm9Y1vcl+pSFQQad8LbqS4dwQF x5ek4dYLgsEtpC4Hwtam6e5Z4VEoGVcEcZTpvfffUkZmphwXod0j1yym4Nq+5U6OuLS7YbcCT8n QbIsLXGxFpdRYaAz1dBiY6hlcfAgrHKe6HEt6k6gdVOwM3acRVDEOo+xninotCRp5Aa9o1c9EL6 Q3iVYlU1Z27Fq/nZ1AoGOJqHgUy8L4bvjGoE33Y2j4xusjW0bG8pHgPT2hRhk8cKkiYFS/5uJ0n KonuB2FWU7nrQAOBOpzcGVLJXKWya/InRFXVY9Sn6LshWIvP06LDiGzJhkdxOByUZ0CWimuZoUa fEMECZ1zx9qHTe7vyrzSovccOyg5w= X-Google-Smtp-Source: AGHT+IFBqmjeNgh+c60lum29DrLVr2dbfNlizQapILb6hM0WEBpPRqHwp9gGkFB2ObIIJ9QEFgNRww== X-Received: by 2002:a2e:a595:0:b0:37b:9e0b:e0d8 with SMTP id 38308e7fff4ca-3812159c5cemr81261581fa.14.1766994748017; Sun, 28 Dec 2025 23:52:28 -0800 (PST) Received: from localhost.localdomain ([176.33.65.121]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-382861ef4ccsm13496141fa.23.2025.12.28.23.52.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Dec 2025 23:52:27 -0800 (PST) From: Alper Ak To: bryan.odonoghue@linaro.org Cc: alperyasinak1@gmail.com, hverkuil@kernel.org, jonathan@marek.ca, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, mchehab@kernel.org, rfoss@kernel.org, todor.too@gmail.com, vladimir.zapolskiy@linaro.org Subject: [PATCH v2] media: qcom: camss: vfe: Fix out-of-bounds access in vfe_isr_reg_update() Date: Mon, 29 Dec 2025 10:52:17 +0300 Message-ID: <20251229075217.24679-1-alperyasinak1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <8d260d93-38cc-459d-b8f5-40bec5497277@linaro.org> References: <8d260d93-38cc-459d-b8f5-40bec5497277@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" vfe_isr() iterates using MSM_VFE_IMAGE_MASTERS_NUM(7) as the loop bound and passes the index to vfe_isr_reg_update(). However, vfe->line[] array is defined with VFE_LINE_NUM_MAX(4): struct vfe_line line[VFE_LINE_NUM_MAX]; When index is 4, 5, 6, the access to vfe->line[line_id] exceeds the array bounds and resulting in out-of-bounds memory access. Fix this by using separate loops for output lines and write masters. Fixes: 4edc8eae715c ("media: camss: Add initial support for VFE hardware ve= rsion Titan 480") Signed-off-by: Alper Ak Reviewed-by: Bryan O'Donoghue --- drivers/media/platform/qcom/camss/camss-vfe-480.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss-vfe-480.c b/drivers/me= dia/platform/qcom/camss/camss-vfe-480.c index 4feea590a47b..d73f733fde04 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe-480.c +++ b/drivers/media/platform/qcom/camss/camss-vfe-480.c @@ -202,11 +202,13 @@ static irqreturn_t vfe_isr(int irq, void *dev) writel_relaxed(status, vfe->base + VFE_BUS_IRQ_CLEAR(0)); writel_relaxed(1, vfe->base + VFE_BUS_IRQ_CLEAR_GLOBAL); =20 - /* Loop through all WMs IRQs */ - for (i =3D 0; i < MSM_VFE_IMAGE_MASTERS_NUM; i++) { + for (i =3D 0; i < MAX_VFE_OUTPUT_LINES; i++) { if (status & BUS_IRQ_MASK_0_RDI_RUP(vfe, i)) vfe_isr_reg_update(vfe, i); + } =20 + /* Loop through all WMs IRQs */ + for (i =3D 0; i < MSM_VFE_IMAGE_MASTERS_NUM; i++) { if (status & BUS_IRQ_MASK_0_COMP_DONE(vfe, RDI_COMP_GROUP(i))) vfe_buf_done(vfe, i); } --=20 2.43.0