From nobody Tue Feb 10 00:21:35 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A352A21A453 for ; Mon, 29 Dec 2025 04:55:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766984109; cv=none; b=Kc9peAq/JlLTpljyXAQhWczprmFAw9bddaFY3xDH3eJ2EOMz0enD7c7W2VYlJPw6UXYMYYcVOoWx+bksRtMaOL7sMI9YJZLKAEPZTdBAsReO9gJHhbkf6ZGiEgd/LVLyfSZYh1K7lrH9rxXLzMctPhpnzXSAAXjHh9hwJsQqx8M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766984109; c=relaxed/simple; bh=Eck/D6KmwOrBysTJIIaZmSoFBAq/RlW1moTUSu+Xl3I=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=eFTQagwgiIG+TP3FprP265JuoO6ie/0zlxx8/NaQGy4lXSrFPWPs3ev1ZOq7iHi/XYBk/NF5FtSY1UHN6GwxU+s0pwZlet7V4yb9rDUp+MpD6+AZktMganxV0h79bcn/8OEa70B7VgrV/ipb02pV7mqkVDNKnsv8YHGqTFyFf2A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZB8fK9/W; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eKLChU5w; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZB8fK9/W"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eKLChU5w" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BSNfdGj3371288 for ; Mon, 29 Dec 2025 04:55:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=KnpiwG0d//X /Doe7m+7TdtdTnhg6HQ3OqoiGCkLu8T8=; b=ZB8fK9/WjSMwS99I+WaJEF6AfQ1 0DM+dTPlcQ/AqnCfDy0VF6O60j72hrQV4Zf4N0XfHLSbCM15V8nOyOayL9IIaeH0 2b5hCxNvVX6GX+YSdgY5kpH+1/jaPUULqQg/DRy01tbAnESqHrl3g84rp3zCNm0P cAn9VRjdXnuGOdMLPdW0xHayXk9plgEaUwqgEbIdjSfb61PJTdPAuJj4/tCKaCrT W69s6t6WAeGMPQ2NI0UgUVPns856N6lSxTC3pQ6DBq81dGVS6jeRFY62TvvAqKaJ a0sWsrdiMT6/Z9X1XSGo7xlLSGRDsQUO/Mpoqd81szWjjqGVqgWCbI2yD4w== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ba4tnujm5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Dec 2025 04:55:06 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-8088be744afso1915124b3a.0 for ; Sun, 28 Dec 2025 20:55:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766984105; x=1767588905; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KnpiwG0d//X/Doe7m+7TdtdTnhg6HQ3OqoiGCkLu8T8=; b=eKLChU5wrcWDZSyZqhfVfFt4pZ4ChJPSrkmUswfQy9TmQQTvAS9Zf8weKwZ32+eqWo diwOiRZdZcvFYvBemQ8zKg/mu/X+CqmKYoDVI/TRZnWudsCh61UTxnc1IKDXAoPmZisA vBn+GjT2sPdbseBV4/QiD39PNueTNUf12jx6y/IjC5hwAstPtLPSYzgyc23EjmfmlL+x 6piB8DNKns1rflVpJEC6u2FFkgfnV5sYMeC2ISZl1XMeFZkt8S7GQbJFvdlGHo69nU51 CvXKWBdsnKbZr6uKRrtHLnmf0ih+8uYH/diV6EHIT0VhbkskCyWyjJX7+wjam7RSARRt Gp7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766984105; x=1767588905; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=KnpiwG0d//X/Doe7m+7TdtdTnhg6HQ3OqoiGCkLu8T8=; b=TLgH65EAgS5pRYCVfzr6yB7A7hdyaiBPKTzzez9+NDrCJ53Mk4qRPzhIWkJJKZTUqq YFZYfvRLX4e67RRdsHDuTivuV0JuCwv0zxYTv6AQ3y1PqFOc7+TXTZ+pZT/HYVxC6h5C bivJFxk8lAau66x3HcG0Te9r3Pr9pelfV1kW+UyxOmm4POI6eYw5ad33L/agQU9isCTW nNSVD02eJ+zheoxAoTCCquALntNk9UCBflEu4sjrwjdU2u25/Sfx3zkAcel9O4AjDScT NcPTfu7zEuoA7fMcwwG8Tb8Q9wBThVx/lt8qP4/NZDaA34hFHJrY1OBEIjmldNY5tb5R Jtaw== X-Forwarded-Encrypted: i=1; AJvYcCX6U7rbe82TpRn2IAruF9977wJVoTfAGooTKJp80WsBU2f1ctId19L1K74uVUV7teG+yFrYjjYwQ2ei3oQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyLqvwJn6wUYyBCZgYIDQYVt8GxhbFxuxB71XpT3PtXfJ7QtXUo p7aXCNq+CXBf9k6+89p2559iYWntjcPRh6lFEqSjdSHxtkxjKUOAZ8hQP7XKpffkvwfW29z5O75 QtRKrLzR+bbTQz4s0y3JmYvEc1a7AKdgAYFJ4F7MeT4JPm4BSlJVz3k839x9BZcGu7Zc= X-Gm-Gg: AY/fxX74el3KWsKqN7jzJTmZZucLSqz32FRqCPMVh81ba6yQGiLFA6kWJG6vQvkH5f1 hx7oc+sdooO+49FYwRtZl5De0Wj6fjoDA0Eklb1YMaVcu5+H3Y4VgoLerarzbYbxxtBomywm9mh e0VtGkm+LpgQBquJpFClsq/Cgm4MchVap6NFoqVGLls4rClNliO+zpMrLSTFXzo3OKo0c+KWVNP 6X4famg+a/qmxvjyGpgtwwDD0f07WuLd04XmBzkONegp1ZVTibdl06VcZrokiIV/EEXPfQ27fuL UegDAFkYXVdHCPbNsScbFeLbisWo48RVFNkLpsTjYS5p5CQw+hDovSKC4MPTVdhZZ/h9McRRw73 DcnXiazXQlEa+xLEtuu30HPwmwgeH4GBOWYWu+ZMZb0U= X-Received: by 2002:a05:6a00:3014:b0:7b9:9ed7:538e with SMTP id d2e1a72fcca58-7ff5284dbfcmr23117380b3a.4.1766984105369; Sun, 28 Dec 2025 20:55:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IGGA+ojqnMT0CK88BaGx451YRPBiqYCNxKV9loJofxmWkWSa9imhXwL8/X0UFmMvdGgSGCMHg== X-Received: by 2002:a05:6a00:3014:b0:7b9:9ed7:538e with SMTP id d2e1a72fcca58-7ff5284dbfcmr23117363b3a.4.1766984104791; Sun, 28 Dec 2025 20:55:04 -0800 (PST) Received: from hu-ptalari-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7dfac29bsm27902080b3a.39.2025.12.28.20.54.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Dec 2025 20:55:04 -0800 (PST) From: Praveen Talari To: Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , Praveen Talari , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alexey.klimov@linaro.org, krzk@kernel.org, bryan.odonoghue@linaro.org, jorge.ramirez@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com Cc: psodagud@quicinc.com, djaggi@quicinc.com, quic_msavaliy@quicinc.com, quic_vtanuku@quicinc.com, quic_arandive@quicinc.com, quic_shazhuss@quicinc.com, quic_cchiluve@quicinc.com, Konrad Dybcio Subject: [PATCH v2 01/12] soc: qcom: geni-se: Refactor geni_icc_get() and make qup-memory ICC path optional Date: Mon, 29 Dec 2025 10:24:35 +0530 Message-Id: <20251229045446.3227667-2-praveen.talari@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251229045446.3227667-1-praveen.talari@oss.qualcomm.com> References: <20251229045446.3227667-1-praveen.talari@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=G+YR0tk5 c=1 sm=1 tr=0 ts=695209aa cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=Wptve8LSCQjy2B8HgooA:9 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-GUID: vEBm8RsBjiJVAYJe2fRvG0tpZJEbqVdE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI5MDA0MiBTYWx0ZWRfX/+KyWydH6ViF lKwXFDxSdthMWQf/bGQrFe/RJx2YjCtjIAImQeVKjGJNtfoKWh2xCMfRC0lnbZVOdJ0bWfqWUI2 OkwnpJGXuNHN21kXcQjvDyN6EcF5iFIIN8b3VbNqj0Ly1m30+kgi7kCMRGOh6pvzn93gxayh/MY jGsmPWao6m8FZ/VZ+6wcz84s3N686lTYw41d2fPv0PWbmA+dx3BdyrOJFx72eO/RnMnryshPWhm ve4ddPPhvv5IOUQ4h6rcX5iWZaj9tXkaHLv9Hn23IQbMRf9KIUreVniK4Kh5ME7XQdvTZKobzAh O14QzCTEVqai9uD9nIsIMoN3RSVLazHmcdxvtON683H0vq4NKv8YTWYRzc6AWJNnf7CL88VdM8w Ihta1u1YpXkXgbv9xD1TZsQ0cw4Vp6u54Zav6jettCbMXq7gz8BuMNoluiyLUNk+aLOZ3iwdmlM kPzNUSiAAna1AxPZwCA== X-Proofpoint-ORIG-GUID: vEBm8RsBjiJVAYJe2fRvG0tpZJEbqVdE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-29_01,2025-12-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 bulkscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512290042 Content-Type: text/plain; charset="utf-8" The "qup-memory" interconnect path is optional and may not be defined in all device trees. Unroll the loop-based ICC path initialization to allow specific error handling for each path type. The "qup-core" and "qup-config" paths remain mandatory and will fail probe if missing, while "qup-memory" is now handled as optional and skipped when not present in the device tree. Co-developed-by: Konrad Dybcio Signed-off-by: Konrad Dybcio Signed-off-by: Praveen Talari --- v1->v2: Bjorn: - Updated commit text. - Used local variable for more readable. --- drivers/soc/qcom/qcom-geni-se.c | 36 +++++++++++++++++---------------- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-s= e.c index cd1779b6a91a..b6167b968ef6 100644 --- a/drivers/soc/qcom/qcom-geni-se.c +++ b/drivers/soc/qcom/qcom-geni-se.c @@ -899,30 +899,32 @@ EXPORT_SYMBOL_GPL(geni_se_rx_dma_unprep); =20 int geni_icc_get(struct geni_se *se, const char *icc_ddr) { - int i, err; - const char *icc_names[] =3D {"qup-core", "qup-config", icc_ddr}; + struct geni_icc_path *icc_paths =3D se->icc_paths; =20 if (has_acpi_companion(se->dev)) return 0; =20 - for (i =3D 0; i < ARRAY_SIZE(se->icc_paths); i++) { - if (!icc_names[i]) - continue; - - se->icc_paths[i].path =3D devm_of_icc_get(se->dev, icc_names[i]); - if (IS_ERR(se->icc_paths[i].path)) - goto err; + icc_paths[GENI_TO_CORE].path =3D devm_of_icc_get(se->dev, "qup-core"); + if (IS_ERR(icc_paths[GENI_TO_CORE].path)) + return dev_err_probe(se->dev, PTR_ERR(icc_paths[GENI_TO_CORE].path), + "Failed to get 'qup-core' ICC path\n"); + + icc_paths[CPU_TO_GENI].path =3D devm_of_icc_get(se->dev, "qup-config"); + if (IS_ERR(icc_paths[CPU_TO_GENI].path)) + return dev_err_probe(se->dev, PTR_ERR(icc_paths[CPU_TO_GENI].path), + "Failed to get 'qup-config' ICC path\n"); + + /* The DDR path is optional, depending on protocol and hw capabilities */ + icc_paths[GENI_TO_DDR].path =3D devm_of_icc_get(se->dev, "qup-memory"); + if (IS_ERR(icc_paths[GENI_TO_DDR].path)) { + if (PTR_ERR(icc_paths[GENI_TO_DDR].path) =3D=3D -ENODATA) + icc_paths[GENI_TO_DDR].path =3D NULL; + else + return dev_err_probe(se->dev, PTR_ERR(icc_paths[GENI_TO_DDR].path), + "Failed to get 'qup-memory' ICC path\n"); } =20 return 0; - -err: - err =3D PTR_ERR(se->icc_paths[i].path); - if (err !=3D -EPROBE_DEFER) - dev_err_ratelimited(se->dev, "Failed to get ICC path '%s': %d\n", - icc_names[i], err); - return err; - } EXPORT_SYMBOL_GPL(geni_icc_get); =20 --=20 2.34.1