From nobody Sun Feb 8 12:37:43 2026 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8045263F4A for ; Mon, 29 Dec 2025 03:18:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766978285; cv=none; b=mZAnd5IVFTRJjS60iki9hMEFh4ctD/SaS6EtydgIa3fhQHIDPMf91IXtaB9zhFZsFQVwYFSxi8LNH6/kzBRYYlqiB3MWSMxWNJbMJGiDnqM7Kra/VOK723qkWSjWzuaVLz8VP4DXcp4H7MqUPKgC6Z21TtJfwiaVyQiquimEHVw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766978285; c=relaxed/simple; bh=jyYAuYoqThQ9IaQhCI0DxLxP8eJMA3q2OZLB0+BZ01U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S2x7jKuFRs/KwP4GgXDjDkIVINfaXHTP4+8zhl+ywtPfvLt0lcooEDTG3Z54DskwXP6sxeR7OzxL9S3JUiK05lVsAmeQRNo/LOAg4+dA3E3UC4fo58oCODEFd6mpe/cr6gg9GTodAERzdNAuqwvCJRnd0ceAhJ9aiJOnm57E39k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d5pCa1VH; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d5pCa1VH" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-bc2abdcfc6fso4929523a12.2 for ; Sun, 28 Dec 2025 19:18:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766978282; x=1767583082; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MKgim0dSrRrM4iK8owH+2zFzPvmukRMS6uSeUVSPKuE=; b=d5pCa1VHFZz62R22BxR0NlOKtSWIA7w9ZQLirVUgg6ITzSz2E0gubI0aOGg5wTu891 3x5BpTLiZvMB7B0G+vlOFq7kRnYDeXaLEnri7vST9Aj8FJagwhrqtllZnulmX5SCMmZL tBfTbppNLkgW8hk6yLaDz0V1Ygy6nopgA2VEFOPwYN3vUU18WxVF6iP541XZyWIaNFr5 W4DPoMYt2r+cmGyuhbFTBa8XT4ahv9N+eJjaG8b1yfORwn2gNPWVJ8aAnsZQ/yXp191g pUmhGu7Y7f7NRftJvB9jK2U/4Aeh04kKFtB4rDAQFHlM172UPUFhZSYrZ4+F7SvbCxa2 gJTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766978282; x=1767583082; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MKgim0dSrRrM4iK8owH+2zFzPvmukRMS6uSeUVSPKuE=; b=ZEAjeOM/dKuBdm4xsozzfdjdT2yMDFp3oXuc7V/Ma0K9GXYL+8YH0+rgvlhKe3NYwC dNtQUtH2lvFZTJ73AWYqAcytm3MkDi1L5T3tHRhkbOum6gsHBFAsMSj8e+CTTCQVlxiG 3oqZTe3UuWXAsDu1SGjKJRaA+DoGgI6/xDTceOdJU/3d9d8BZpt/Bo4LmX9zKM62o071 jAxl1uQBvtO0Io/8cuqAPxHElvAywPZ5so6cqn/jP6ZquJYneuuXw4WNncuyX0slY9jn h37TPQ4rF2EswZQDQmXgwEuv1To8kmkAgW4EskZ6AtozjgrPayRHLp2VeW++ouNn8Rie +tfA== X-Forwarded-Encrypted: i=1; AJvYcCXggynlASCk91diWvWgwa5YcbdArjIDEsNWK++vBioxTUaCycb4tteVIBKTJd1uRfQ6hznyDnSXzUvxJnU=@vger.kernel.org X-Gm-Message-State: AOJu0YyWDpZNF4nWls+F0/IwGMKJRPwCyH+zWpqcNoyDarECTsHuMcYn e8FMqmxKrDtiU9FT7puUZDJ2zuejOE1iKHWhFyRZl3MBJF3nG4yHJ2xv X-Gm-Gg: AY/fxX4TEItVFMC/95L8AG1xp2VMlw2qSpsWrwFnrS2PppmfFmid8bRIhVI+tcIdBLz f+uaZgRcrdMNWkzHA235a15nQ11ogEOSG6rHP9LLwclu+dqnWY8Ahh18H0mTsOJ09gS9ANmdD9F ++5som+RjPmY/iGWt93SpeQm7Ww7Io8QPnnxAfFpcgFlSq6ig8CZkKx8hY9cOBAfO57ZPTtBgUT eUDCe/Vg60RrMw09M9BJoOouknFOgp7qGXFoH18OvxjDGfJNCo5fkjiHtToG662r3eFiTenmsw4 621VZsZK2DZLQskVJqFLRTWSyeOzkFges0O/mBC8+/NsS0tiyRzGwkZZeiQw8HWnoiZnt3pbrV2 6RYMGbaNj3iyNZBR1iWbXx7ERXSPS6IGyn4BHL1d2YQHu6yUZWkGc0cw6QxM7W5MA4e59QCz7jM YVMpWIWBGeI2ziQ/yxLmRml+ffhsSrhK4Wm92HeWGsx2/BG9GUBSMSZd6fjx4Z2wo= X-Google-Smtp-Source: AGHT+IHVhOYhQDnqD/Ev9sZ5WdVWs7wFjrnerdhiVF/Dq4HNgfa6258s0mR5YjktP8ulmxxOSTmzLA== X-Received: by 2002:a05:7022:924:b0:11b:923d:7753 with SMTP id a92af1059eb24-121721aab49mr35160631c88.3.1766978281939; Sun, 28 Dec 2025 19:18:01 -0800 (PST) Received: from lappy (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-121724dd7f5sm112992785c88.5.2025.12.28.19.18.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Dec 2025 19:18:01 -0800 (PST) From: "Derek J. Clark" To: Jiri Kosina , Benjamin Tissoires Cc: Mario Limonciello , Zhixin Zhang , Mia Shao , Mark Pearson , "Pierre-Loup A . Griffais" , "Derek J . Clark" , linux-input@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 05/16] HID: hid-lenovo-go: Add FPS Mode DPI settings Date: Mon, 29 Dec 2025 03:17:42 +0000 Message-ID: <20251229031753.581664-6-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251229031753.581664-1-derekjohn.clark@gmail.com> References: <20251229031753.581664-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Adds attribute that enables selection of the DPI of the optical sensor when the right handle toggle is set to FPS mode. Signed-off-by: Derek J. Clark --- drivers/hid/hid-lenovo-go.c | 68 +++++++++++++++++++++++++++++++++++++ 1 file changed, 68 insertions(+) diff --git a/drivers/hid/hid-lenovo-go.c b/drivers/hid/hid-lenovo-go.c index 7d8bd1dba7ce..96f16ba5526c 100644 --- a/drivers/hid/hid-lenovo-go.c +++ b/drivers/hid/hid-lenovo-go.c @@ -64,6 +64,7 @@ struct hid_go_cfg { u32 mcu_version_hardware; u32 mcu_version_product; u32 mcu_version_protocol; + u32 mouse_dpi; u8 rgb_en; u8 tp_en; u8 tp_vibration_en; @@ -217,6 +218,8 @@ static const char *const rumble_mode_text[] =3D { [RUMBLE_MODE_RPG] =3D "rpg", }; =20 +#define FPS_MODE_DPI 0x02 + static int hid_go_version_event(struct command_report *cmd_rep) { switch (cmd_rep->sub_cmd) { @@ -424,6 +427,16 @@ static int hid_go_motor_event(struct command_report *c= md_rep) return -EINVAL; } =20 +static int hid_go_fps_dpi_event(struct command_report *cmd_rep) +{ + if (cmd_rep->sub_cmd !=3D FPS_MODE_DPI) + return -EINVAL; + + drvdata.mouse_dpi =3D get_unaligned_le32(cmd_rep->data); + + return 0; +} + static int hid_go_set_event_return(struct command_report *cmd_rep) { if (cmd_rep->data[0] !=3D 0) @@ -474,8 +487,12 @@ static int hid_go_raw_event(struct hid_device *hdev, s= truct hid_report *report, case GET_MOTOR_CFG: ret =3D hid_go_motor_event(cmd_rep); break; + case GET_DPI_CFG: + ret =3D hid_go_fps_dpi_event(cmd_rep); + break; case SET_FEATURE_STATUS: case SET_MOTOR_CFG: + case SET_DPI_CFG: ret =3D hid_go_set_event_return(cmd_rep); break; default: @@ -1014,6 +1031,52 @@ static ssize_t motor_config_options(struct device *d= ev, return count; } =20 +static ssize_t fps_mode_dpi_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count) + +{ + size_t size =3D 4; + u32 value; + u8 val[4]; + int ret; + + ret =3D kstrtou32(buf, 10, &value); + if (ret) + return ret; + + if (value !=3D 500 && value !=3D 800 && value !=3D 1200 && value !=3D 180= 0) + return -EINVAL; + + put_unaligned_le32(value, val); + + ret =3D mcu_property_out(drvdata.hdev, MCU_CONFIG_DATA, SET_DPI_CFG, + FPS_MODE_DPI, UNSPECIFIED, val, size); + if (ret < 0) + return ret; + + return count; +} + +static ssize_t fps_mode_dpi_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + int ret; + + ret =3D mcu_property_out(drvdata.hdev, MCU_CONFIG_DATA, GET_DPI_CFG, + FPS_MODE_DPI, UNSPECIFIED, 0, 0); + if (ret < 0) + return ret; + + return sysfs_emit(buf, "%u\n", drvdata.mouse_dpi); +} + +static ssize_t fps_mode_dpi_index_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + return sysfs_emit(buf, "500 800 1200 1800\n"); +} + #define LEGO_DEVICE_ATTR_RW(_name, _attrname, _dtype, _rtype, _group) = \ static ssize_t _name##_store(struct device *dev, \ struct device_attribute *attr, \ @@ -1085,7 +1148,12 @@ LEGO_DEVICE_ATTR_RW(gamepad_rumble_intensity, "rumbl= e_intensity", UNSPECIFIED, static DEVICE_ATTR_RO_NAMED(gamepad_rumble_intensity_index, "rumble_intensity_index"); =20 +static DEVICE_ATTR_RW(fps_mode_dpi); +static DEVICE_ATTR_RO(fps_mode_dpi_index); + static struct attribute *mcu_attrs[] =3D { + &dev_attr_fps_mode_dpi.attr, + &dev_attr_fps_mode_dpi_index.attr, &dev_attr_fps_switch_status.attr, &dev_attr_gamepad_mode.attr, &dev_attr_gamepad_mode_index.attr, --=20 2.51.2