From nobody Sun Feb 8 23:25:20 2026 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C45C272801 for ; Mon, 29 Dec 2025 03:18:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766978292; cv=none; b=cKABKQucfT6OQZ3m3YRDKybdPF+oYOwVQvTDmy/hs9VxQC0U0enfUisXOxTnkyQve9a3h1qx/U/8T/4s9RHd49XaH88cSYqJoYSaQioJZ04zoHcXXFZTsbPHjGrj2MGvKC/VnZKDnjq579u1Lz0ibr2IkxfUZULyZho9A4dLYLY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766978292; c=relaxed/simple; bh=TjcLc8b1McUidwujjfQYTR+PxKrP04JoWpS4YYDWZFQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mt+Ml9vKyNguwQti7+vRBhoXilF+BValNf9n/QW0D7tsHbRDbLqwDZgNYieTuyH3g+IRWBD1xD9z5gxELrXF5O2/AbtEPpLrWca9S1X+qpc9lL4gVVIWVJD4adBZAfhsTkS7P6KX8CN7k0ywLkI/m5ZaEJBKByuvropD1lMwZ7k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HkP6IAn6; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HkP6IAn6" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-34c84dc332cso7421495a91.0 for ; Sun, 28 Dec 2025 19:18:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766978287; x=1767583087; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/SSUxFyBlljVoOkyziM9cW6Mg4NT0OL48ryA8PfVXFE=; b=HkP6IAn6hb8KTMz8wco1lzO4nCbWQg9wRNByiD/OCLaFO5c/Q6RHXszvMAdIyD5BPN 1c4GtSurswFEubrW7rFD6QGn7IG9h40VdZPJnSHcOjpaXTkMfiEQUElsko2bvjQWLOBJ U6w5u82xLrOc/JPCBtltuIIrXDZkEWBsOcGa9pEzEIcupjCw/b1cKEl7w55YWXyB4blA /FV/BUYE0EBHyTFJWsrOCImSNdD3lexnVYc1p3Nez0TSVAtnBqGPDu7ZvtAh6N7wgrNc benGBB/fPb5SM//viPfZhLo5+FceDh/5d/P0ijQQiNyrexnr1HbC8oeAuJ8/KmuD5MCV 5D5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766978287; x=1767583087; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/SSUxFyBlljVoOkyziM9cW6Mg4NT0OL48ryA8PfVXFE=; b=h6RihERKa1l926Na2oVx8pYcn+FuR92iJ/NiXplST+AkqzOxZTp/bOu3Cycgshjh+F 0ycKdHlgcD5dFP74cKQBawJoLTrQuHzL71caafNJoqPALRcrotmd12bFaoheGPrPU9St BNKBcZNz33Az6v30qdj2gLc/vxX9KOHlQbvVQqbqQvWox5jPUl5XJr+9SsSc6gQxfxOc Bd0R1Wy3CSq+iDlun/pGGGRl/MSsq/9h/F6+OXDeyJpMgUpg127yGKuT2q239tK8Ekgx 3Cfj+jl+5SILz2t32BmXzy4rLA9KSyVQIGbKWPFwAG64Ydlkf6n2i9beOaGaD6ZAHVoB VvFg== X-Forwarded-Encrypted: i=1; AJvYcCUjInpuo/r+II1uhroGmJ9nySdRCKy0t8Yed6hLeo2FATSFOz4V7WRQksLd8N7X+L+aUC36m6Qs1/BUdcA=@vger.kernel.org X-Gm-Message-State: AOJu0YwNwUdEY6AzMzb8XObqLDI17oEc4oPa/gbM3JiWWlkcSbbe91yL ATzG9S+DkEF+jsK7nZGKf2h24tm1FE4JzxzwOC35DrSGowMooiNckWGT X-Gm-Gg: AY/fxX4dCPgbkJ7kyfc4vUJ2W525oY3LypkwvyPU0f8G3IvD8kajfMzpMiut0ZCV2YM 0NdeGss6bDgQ0QzC6w+cSIPcIAMbNbq47Uy1kYh2vlUB6c2DlB9xayB+hGMSuLGe1TaKmbhVCz+ fubvezg+9wnqBnan2Uxe/L8dpmav0LlovkwU3HfX6I3TGRPc2pJLwq+Na5MYXdCUGZvxKmuQTOX H+032Ximg2//TozeGYQGiVdVLSYHEEuM5y3p8MBgmfqNUsLm46g/NZroIaY2ql7l6hLVugEBHwv t3DC2SlTYY/IeMBXeR5BYZDjwLD5NaT79RXdIA3YpBDuv2btwpWr+s9EIOPn47eGjsXbGQoPWnV QLH44MSGqwI4mMq89FjJZjDSgis/LAIMsTJeOMTr/kdyIzonHQfyqf3zIW+D6UDGvmvslt8cNCr acIzxLl7h7yUaQWvMfyEsD/e91nr47P1Uv/7pQtCUfmaeDg6pmu6HmB8LfctpK6Io= X-Google-Smtp-Source: AGHT+IFy6JlhPUmYZyhP9/6iKZQqnm4h0/gpD7xRl7MJ8NcHJHy2QxB6lQ6mbz7HEpi07optHW5p6Q== X-Received: by 2002:a05:7022:eac1:b0:11b:9b9f:426b with SMTP id a92af1059eb24-121722c3d35mr27502722c88.20.1766978287185; Sun, 28 Dec 2025 19:18:07 -0800 (PST) Received: from lappy (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-121724dd7f5sm112992785c88.5.2025.12.28.19.18.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Dec 2025 19:18:06 -0800 (PST) From: "Derek J. Clark" To: Jiri Kosina , Benjamin Tissoires Cc: Mario Limonciello , Zhixin Zhang , Mia Shao , Mark Pearson , "Pierre-Loup A . Griffais" , "Derek J . Clark" , linux-input@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 12/16] HID: hid-lenovo-go-s: Add Feature Status Attributes Date: Mon, 29 Dec 2025 03:17:49 +0000 Message-ID: <20251229031753.581664-13-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251229031753.581664-1-derekjohn.clark@gmail.com> References: <20251229031753.581664-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Adds features status attributes for the gamepad, MCU, touchpad/mouse, and IMU devices. Signed-off-by: Derek J. Clark --- drivers/hid/hid-lenovo-go-s.c | 524 +++++++++++++++++++++++++++++++++- 1 file changed, 523 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-lenovo-go-s.c b/drivers/hid/hid-lenovo-go-s.c index 36cee6c3d4cc..076afdaa9628 100644 --- a/drivers/hid/hid-lenovo-go-s.c +++ b/drivers/hid/hid-lenovo-go-s.c @@ -14,6 +14,7 @@ #include #include #include +#include #include #include #include @@ -35,7 +36,17 @@ struct hid_gos_cfg { struct completion send_cmd_complete; struct hid_device *hdev; struct mutex cfg_mutex; /*ensure single synchronous output report*/ + u8 gp_auto_sleep_time; + u8 gp_dpad_mode; + u8 gp_mode; + u8 gp_poll_rate; + u8 imu_bypass_en; + u8 imu_sensor_en; u8 mcu_id[12]; + u8 mouse_step; + u8 os_mode; + u8 rgb_en; + u8 tp_en; } drvdata; =20 struct gos_cfg_attr { @@ -66,7 +77,73 @@ enum mcu_command_index { GET_PL_TEST =3D 0xdf, }; =20 -#define FEATURE_NONE 0x00 +enum feature_enabled_index { + FEATURE_DISABLED, + FEATURE_ENABLED, +}; + +static const char *const feature_enabled_text[] =3D { + [FEATURE_DISABLED] =3D "false", + [FEATURE_ENABLED] =3D "true", +}; + +enum feature_status_index { + FEATURE_NONE =3D 0x00, + FEATURE_GAMEPAD_MODE =3D 0x01, + FEATURE_AUTO_SLEEP_TIME =3D 0x04, + FEATURE_IMU_BYPASS, + FEATURE_RGB_ENABLE, + FEATURE_IMU_ENABLE, + FEATURE_TOUCHPAD_ENABLE, + FEATURE_OS_MODE =3D 0x0A, + FEATURE_POLL_RATE =3D 0x10, + FEATURE_DPAD_MODE, + FEATURE_MOUSE_WHEEL_STEP, +}; + +enum gamepad_mode_index { + XINPUT, + DINPUT, +}; + +static const char *const gamepad_mode_text[] =3D { + [XINPUT] =3D "xinput", + [DINPUT] =3D "dinput", +}; + +enum os_type_index { + WINDOWS, + LINUX, +}; + +static const char *const os_type_text[] =3D { + [WINDOWS] =3D "windows", + [LINUX] =3D "linux", +}; + +enum poll_rate_index { + HZ125, + HZ250, + HZ500, + HZ1000, +}; + +static const char *const poll_rate_text[] =3D { + [HZ125] =3D "125", + [HZ250] =3D "250", + [HZ500] =3D "500", + [HZ1000] =3D "1000", +}; + +enum dpad_mode_index { + DIR8, + DIR4, +}; + +static const char *const dpad_mode_text[] =3D { + [DIR8] =3D "8-way", + [DIR4] =3D "4-way", +}; =20 static int hid_gos_version_event(u8 *data) { @@ -84,6 +161,57 @@ static int hid_gos_mcu_id_event(struct command_report *= cmd_rep) return 0; } =20 +static int hid_gos_gamepad_cfg_event(struct command_report *cmd_rep) +{ + int ret =3D 0; + + switch (cmd_rep->sub_cmd) { + case FEATURE_GAMEPAD_MODE: + drvdata.gp_mode =3D cmd_rep->data[0]; + break; + case FEATURE_AUTO_SLEEP_TIME: + drvdata.gp_auto_sleep_time =3D cmd_rep->data[0]; + break; + case FEATURE_IMU_BYPASS: + drvdata.imu_bypass_en =3D cmd_rep->data[0]; + break; + case FEATURE_RGB_ENABLE: + drvdata.rgb_en =3D cmd_rep->data[0]; + break; + case FEATURE_IMU_ENABLE: + drvdata.imu_sensor_en =3D cmd_rep->data[0]; + break; + case FEATURE_TOUCHPAD_ENABLE: + drvdata.tp_en =3D cmd_rep->data[0]; + break; + case FEATURE_OS_MODE: + drvdata.os_mode =3D cmd_rep->data[0]; + break; + case FEATURE_POLL_RATE: + drvdata.gp_poll_rate =3D cmd_rep->data[0]; + break; + case FEATURE_DPAD_MODE: + drvdata.gp_dpad_mode =3D cmd_rep->data[0]; + break; + case FEATURE_MOUSE_WHEEL_STEP: + drvdata.mouse_step =3D cmd_rep->data[0]; + break; + default: + ret =3D -EINVAL; + break; + } + + return ret; +} + +static int hid_gos_set_event_return(struct command_report *cmd_rep) +{ + if (cmd_rep->data[0] !=3D 0) + return -EIO; + + return 0; +} + static u8 get_endpoint_address(struct hid_device *hdev) { struct usb_interface *intf =3D to_usb_interface(hdev->dev.parent); @@ -120,6 +248,12 @@ static int hid_gos_raw_event(struct hid_device *hdev, = struct hid_report *report, case GET_MCU_ID: ret =3D hid_gos_mcu_id_event(cmd_rep); break; + case GET_GAMEPAD_CFG: + ret =3D hid_gos_gamepad_cfg_event(cmd_rep); + break; + case SET_GAMEPAD_CFG: + ret =3D hid_gos_set_event_return(cmd_rep); + break; default: ret =3D -EINVAL; break; @@ -177,17 +311,333 @@ static int mcu_property_out(struct hid_device *hdev,= u8 command, u8 index, return ret; } =20 +static ssize_t gamepad_property_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count, + enum feature_status_index index) +{ + size_t size =3D 1; + u8 val =3D 0; + int ret; + + switch (index) { + case FEATURE_GAMEPAD_MODE: + ret =3D sysfs_match_string(gamepad_mode_text, buf); + if (ret < 0) + return ret; + val =3D ret; + break; + case FEATURE_AUTO_SLEEP_TIME: + ret =3D kstrtou8(buf, 10, &val); + if (ret) + return ret; + + if (val < 0 || val > 255) + return -EINVAL; + break; + case FEATURE_IMU_ENABLE: + ret =3D sysfs_match_string(feature_enabled_text, buf); + if (ret < 0) + return ret; + val =3D ret; + break; + case FEATURE_IMU_BYPASS: + ret =3D sysfs_match_string(feature_enabled_text, buf); + if (ret < 0) + return ret; + val =3D ret; + break; + case FEATURE_RGB_ENABLE: + ret =3D sysfs_match_string(feature_enabled_text, buf); + if (ret < 0) + return ret; + val =3D ret; + break; + case FEATURE_TOUCHPAD_ENABLE: + ret =3D sysfs_match_string(feature_enabled_text, buf); + if (ret < 0) + return ret; + val =3D ret; + break; + case FEATURE_OS_MODE: + ret =3D sysfs_match_string(os_type_text, buf); + if (ret < 0) + return ret; + val =3D ret; + drvdata.os_mode =3D val; + break; + case FEATURE_POLL_RATE: + ret =3D sysfs_match_string(poll_rate_text, buf); + if (ret < 0) + return ret; + val =3D ret; + break; + case FEATURE_DPAD_MODE: + ret =3D sysfs_match_string(dpad_mode_text, buf); + if (ret < 0) + return ret; + val =3D ret; + break; + case FEATURE_MOUSE_WHEEL_STEP: + ret =3D kstrtou8(buf, 10, &val); + if (ret) + return ret; + if (val < 1 || val > 127) + return -EINVAL; + break; + default: + return -EINVAL; + } + + if (!val) + size =3D 0; + + ret =3D mcu_property_out(drvdata.hdev, SET_GAMEPAD_CFG, index, &val, + size); + if (ret < 0) + return ret; + + return count; +} + +static ssize_t gamepad_property_show(struct device *dev, + struct device_attribute *attr, char *buf, + enum feature_status_index index) +{ + size_t count =3D 0; + u8 i; + + count =3D mcu_property_out(drvdata.hdev, GET_GAMEPAD_CFG, index, 0, 0); + if (count < 0) + return count; + + switch (index) { + case FEATURE_GAMEPAD_MODE: + i =3D drvdata.gp_mode; + if (i >=3D ARRAY_SIZE(gamepad_mode_text)) + return -EINVAL; + count =3D sysfs_emit(buf, "%s\n", gamepad_mode_text[i]); + break; + case FEATURE_AUTO_SLEEP_TIME: + count =3D sysfs_emit(buf, "%u\n", drvdata.gp_auto_sleep_time); + break; + case FEATURE_IMU_ENABLE: + i =3D drvdata.imu_sensor_en; + if (i >=3D ARRAY_SIZE(feature_enabled_text)) + return -EINVAL; + count =3D sysfs_emit(buf, "%s\n", feature_enabled_text[i]); + break; + case FEATURE_IMU_BYPASS: + i =3D drvdata.imu_bypass_en; + if (i >=3D ARRAY_SIZE(feature_enabled_text)) + return -EINVAL; + count =3D sysfs_emit(buf, "%s\n", feature_enabled_text[i]); + break; + case FEATURE_RGB_ENABLE: + i =3D drvdata.rgb_en; + if (i >=3D ARRAY_SIZE(feature_enabled_text)) + return -EINVAL; + count =3D sysfs_emit(buf, "%s\n", feature_enabled_text[i]); + break; + case FEATURE_TOUCHPAD_ENABLE: + i =3D drvdata.tp_en; + if (i >=3D ARRAY_SIZE(feature_enabled_text)) + return -EINVAL; + count =3D sysfs_emit(buf, "%s\n", feature_enabled_text[i]); + break; + case FEATURE_OS_MODE: + i =3D drvdata.os_mode; + if (i >=3D ARRAY_SIZE(os_type_text)) + return -EINVAL; + count =3D sysfs_emit(buf, "%s\n", os_type_text[i]); + break; + case FEATURE_POLL_RATE: + i =3D drvdata.gp_poll_rate; + if (i >=3D ARRAY_SIZE(poll_rate_text)) + return -EINVAL; + count =3D sysfs_emit(buf, "%s\n", poll_rate_text[i]); + break; + case FEATURE_DPAD_MODE: + i =3D drvdata.gp_dpad_mode; + if (i >=3D ARRAY_SIZE(dpad_mode_text)) + return -EINVAL; + count =3D sysfs_emit(buf, "%s\n", dpad_mode_text[i]); + break; + case FEATURE_MOUSE_WHEEL_STEP: + i =3D drvdata.mouse_step; + if (i < 1 || i > 127) + return -EINVAL; + count =3D sysfs_emit(buf, "%u\n", i); + break; + default: + return -EINVAL; + } + + return count; +} + +static ssize_t gamepad_property_options(struct device *dev, + struct device_attribute *attr, + char *buf, + enum feature_status_index index) +{ + size_t count =3D 0; + unsigned int i; + + switch (index) { + case FEATURE_GAMEPAD_MODE: + for (i =3D 0; i < ARRAY_SIZE(gamepad_mode_text); i++) { + count +=3D sysfs_emit_at(buf, count, "%s ", + gamepad_mode_text[i]); + } + break; + case FEATURE_AUTO_SLEEP_TIME: + return sysfs_emit(buf, "0-255\n"); + case FEATURE_IMU_ENABLE: + for (i =3D 0; i < ARRAY_SIZE(feature_enabled_text); i++) { + count +=3D sysfs_emit_at(buf, count, "%s ", + feature_enabled_text[i]); + } + break; + case FEATURE_IMU_BYPASS: + case FEATURE_RGB_ENABLE: + case FEATURE_TOUCHPAD_ENABLE: + for (i =3D 0; i < ARRAY_SIZE(feature_enabled_text); i++) { + count +=3D sysfs_emit_at(buf, count, "%s ", + feature_enabled_text[i]); + } + break; + case FEATURE_OS_MODE: + for (i =3D 0; i < ARRAY_SIZE(os_type_text); i++) { + count +=3D sysfs_emit_at(buf, count, "%s ", + os_type_text[i]); + } + break; + case FEATURE_POLL_RATE: + for (i =3D 0; i < ARRAY_SIZE(poll_rate_text); i++) { + count +=3D sysfs_emit_at(buf, count, "%s ", + poll_rate_text[i]); + } + break; + case FEATURE_DPAD_MODE: + for (i =3D 0; i < ARRAY_SIZE(dpad_mode_text); i++) { + count +=3D sysfs_emit_at(buf, count, "%s ", + dpad_mode_text[i]); + } + break; + case FEATURE_MOUSE_WHEEL_STEP: + return sysfs_emit(buf, "1-127\n"); + default: + return count; + } + + if (count) + buf[count - 1] =3D '\n'; + + return count; +} + static ssize_t mcu_id_show(struct device *dev, struct device_attribute *at= tr, char *buf) { return sysfs_emit(buf, "%*phN\n", 12, &drvdata.mcu_id); } =20 +#define LEGOS_DEVICE_ATTR_RW(_name, _attrname, _rtype, _group) = \ + static ssize_t _name##_store(struct device *dev, \ + struct device_attribute *attr, \ + const char *buf, size_t count) \ + { \ + return _group##_property_store(dev, attr, buf, count, \ + _name.index); \ + } \ + static ssize_t _name##_show(struct device *dev, \ + struct device_attribute *attr, char *buf) \ + { \ + return _group##_property_show(dev, attr, buf, _name.index); \ + } \ + static ssize_t _name##_##_rtype##_show( \ + struct device *dev, struct device_attribute *attr, char *buf) \ + { \ + return _group##_property_options(dev, attr, buf, _name.index); \ + } \ + static DEVICE_ATTR_RW_NAMED(_name, _attrname) + +#define LEGOS_DEVICE_ATTR_RO(_name, _attrname, _group) = \ + static ssize_t _name##_show(struct device *dev, \ + struct device_attribute *attr, char *buf) \ + { \ + return _group##_property_show(dev, attr, buf, _name.index); \ + } \ + static DEVICE_ATTR_RO_NAMED(_name, _attrname) + +/* Gamepad */ +struct gos_cfg_attr auto_sleep_time =3D { FEATURE_AUTO_SLEEP_TIME }; +LEGOS_DEVICE_ATTR_RW(auto_sleep_time, "auto_sleep_time", range, gamepad); +static DEVICE_ATTR_RO(auto_sleep_time_range); + +struct gos_cfg_attr dpad_mode =3D { FEATURE_DPAD_MODE }; +LEGOS_DEVICE_ATTR_RW(dpad_mode, "dpad_mode", index, gamepad); +static DEVICE_ATTR_RO(dpad_mode_index); + +struct gos_cfg_attr gamepad_mode =3D { FEATURE_GAMEPAD_MODE }; +LEGOS_DEVICE_ATTR_RW(gamepad_mode, "mode", index, gamepad); +static DEVICE_ATTR_RO_NAMED(gamepad_mode_index, "mode_index"); + +struct gos_cfg_attr gamepad_poll_rate =3D { FEATURE_POLL_RATE }; +LEGOS_DEVICE_ATTR_RW(gamepad_poll_rate, "poll_rate", index, gamepad); +static DEVICE_ATTR_RO_NAMED(gamepad_poll_rate_index, "poll_rate_index"); + +static struct attribute *legos_gamepad_attrs[] =3D { + &dev_attr_auto_sleep_time.attr, + &dev_attr_auto_sleep_time_range.attr, + &dev_attr_dpad_mode.attr, + &dev_attr_dpad_mode_index.attr, + &dev_attr_gamepad_mode.attr, + &dev_attr_gamepad_mode_index.attr, + &dev_attr_gamepad_poll_rate.attr, + &dev_attr_gamepad_poll_rate_index.attr, + NULL, +}; + +static const struct attribute_group gamepad_attr_group =3D { + .name =3D "gamepad", + .attrs =3D legos_gamepad_attrs, +}; + +/* IMU */ +struct gos_cfg_attr imu_bypass_enabled =3D { FEATURE_IMU_BYPASS }; +LEGOS_DEVICE_ATTR_RW(imu_bypass_enabled, "bypass_enabled", index, gamepad); +static DEVICE_ATTR_RO_NAMED(imu_bypass_enabled_index, "bypass_enabled_inde= x"); + +struct gos_cfg_attr imu_sensor_enabled =3D { FEATURE_IMU_ENABLE }; +LEGOS_DEVICE_ATTR_RW(imu_sensor_enabled, "sensor_enabled", index, gamepad); +static DEVICE_ATTR_RO_NAMED(imu_sensor_enabled_index, "sensor_enabled_inde= x"); + +static struct attribute *legos_imu_attrs[] =3D { + &dev_attr_imu_bypass_enabled.attr, + &dev_attr_imu_bypass_enabled_index.attr, + &dev_attr_imu_sensor_enabled.attr, + &dev_attr_imu_sensor_enabled_index.attr, + NULL, +}; + +static const struct attribute_group imu_attr_group =3D { + .name =3D "imu", + .attrs =3D legos_imu_attrs, +}; + /* MCU */ static DEVICE_ATTR_RO(mcu_id); =20 +struct gos_cfg_attr os_mode =3D { FEATURE_OS_MODE }; +LEGOS_DEVICE_ATTR_RW(os_mode, "os_mode", index, gamepad); +static DEVICE_ATTR_RO(os_mode_index); + static struct attribute *legos_mcu_attrs[] =3D { &dev_attr_mcu_id.attr, + &dev_attr_os_mode.attr, + &dev_attr_os_mode_index.attr, NULL, }; =20 @@ -195,8 +645,44 @@ static const struct attribute_group mcu_attr_group =3D= { .attrs =3D legos_mcu_attrs, }; =20 +/* Mouse */ +struct gos_cfg_attr mouse_wheel_step =3D { FEATURE_MOUSE_WHEEL_STEP }; +LEGOS_DEVICE_ATTR_RW(mouse_wheel_step, "step", range, gamepad); +static DEVICE_ATTR_RO_NAMED(mouse_wheel_step_range, "step_range"); + +static struct attribute *legos_mouse_attrs[] =3D { + &dev_attr_mouse_wheel_step.attr, + &dev_attr_mouse_wheel_step_range.attr, + NULL, +}; + +static const struct attribute_group mouse_attr_group =3D { + .name =3D "mouse", + .attrs =3D legos_mouse_attrs, +}; + +/* Touchpad */ +struct gos_cfg_attr touchpad_enabled =3D { FEATURE_TOUCHPAD_ENABLE }; +LEGOS_DEVICE_ATTR_RW(touchpad_enabled, "enabled", index, gamepad); +static DEVICE_ATTR_RO_NAMED(touchpad_enabled_index, "enabled_index"); + +static struct attribute *legos_touchpad_attrs[] =3D { + &dev_attr_touchpad_enabled.attr, + &dev_attr_touchpad_enabled_index.attr, + NULL, +}; + +static const struct attribute_group touchpad_attr_group =3D { + .name =3D "touchpad", + .attrs =3D legos_touchpad_attrs, +}; + static const struct attribute_group *top_level_attr_groups[] =3D { + &gamepad_attr_group, + &imu_attr_group, &mcu_attr_group, + &mouse_attr_group, + &touchpad_attr_group, NULL, }; =20 @@ -268,6 +754,27 @@ static void hid_gos_cfg_remove(struct hid_device *hdev) hid_set_drvdata(hdev, NULL); } =20 +static int hid_gos_cfg_reset_resume(struct hid_device *hdev) +{ + u8 os_mode =3D drvdata.os_mode; + int ret; + + ret =3D mcu_property_out(drvdata.hdev, SET_GAMEPAD_CFG, FEATURE_OS_MODE, + &os_mode, 1); + if (ret < 0) + return ret; + + ret =3D mcu_property_out(drvdata.hdev, GET_GAMEPAD_CFG, FEATURE_OS_MODE, = 0, + 0); + if (ret < 0) + return ret; + + if (drvdata.os_mode !=3D os_mode) + return -ENODEV; + + return 0; +} + static int hid_gos_probe(struct hid_device *hdev, const struct hid_device_id *id) { @@ -326,6 +833,20 @@ static void hid_gos_remove(struct hid_device *hdev) } } =20 +static int hid_gos_reset_resume(struct hid_device *hdev) +{ + int ep =3D get_endpoint_address(hdev); + + switch (ep) { + case GO_S_CFG_INTF_IN: + return hid_gos_cfg_reset_resume(hdev); + default: + break; + } + + return 0; +} + static const struct hid_device_id hid_gos_devices[] =3D { { HID_USB_DEVICE(USB_VENDOR_ID_QHE, USB_DEVICE_ID_LENOVO_LEGION_GO_S_XINPUT) }, @@ -340,6 +861,7 @@ static struct hid_driver hid_lenovo_go_s =3D { .id_table =3D hid_gos_devices, .probe =3D hid_gos_probe, .remove =3D hid_gos_remove, + .reset_resume =3D hid_gos_reset_resume, .raw_event =3D hid_gos_raw_event, }; module_hid_driver(hid_lenovo_go_s); --=20 2.51.2