From nobody Sun Feb 8 16:31:16 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 986C82494FE for ; Mon, 29 Dec 2025 03:18:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766978291; cv=none; b=KHMyJzWzZUfbSnnUi9h/z8zNaWtrzE9RYYodj03JSxkfq3R9E/Zc8DTrMR78Y8JZDa3eW4S42oJ7QeCQRcQoJMOwhqmMcuPC1+DgY38ESf/4NICdqV03d/PQrFNz4suPkyVMNHiATUOz3X3nGZ5YMfzanHybuQzVKdYEqFiUwWU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766978291; c=relaxed/simple; bh=X263MocZ1Dz5lSyiIa/ApKNLtn8LzJpAs2PJ0aYdw1E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gRqPPlynqur1yDig++5t34bIGECqVUvAHQcGgnmGZJ3d3523O1vkyaJsFxr638T29OA8iFR7ulFcOl2pnjBDzV84LklcgQd7pp6R71xIzUHFQwGdXMjAcdWdU1WJzftIedz66AL3WEYl/o+Z4et11BCGYE/oYulTR52yFoOKt3M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iacaLUk3; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iacaLUk3" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2a0d6f647e2so141190915ad.1 for ; Sun, 28 Dec 2025 19:18:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766978286; x=1767583086; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MrGC9JWDCaxJgv6rvmu39tdxxA/sQpLqKQTMa9mrb4s=; b=iacaLUk3nMfNHEybQMMsLwlCv2tL/ICNvpWzHsIAAFohD/w1Pm7wt42SFubR/SWenb u5JgG2ss622uIMUyDCe+couOewqlI2xXKrZ73j8n4xehVS6Xzr+RaD1l/aO+AmGEkP/+ w+yGCSKsXXX+9lmp2z48lIqVZiMHCx7RmxONjl7Q5RAFLD3kY3G98V8vO9QPGYA4Gnwt WmAx3T+9xL4Ljt597TJpwuQRbhtBcPan5S7oE1aboGM+g/Wy+soE8d3FA7c19hjlJiHy lA47rnjBGieXC2zNbHr+kpGtfdtMcp1aKRihOQWbu9bJt8QJ2BTIaQtQ2jRqwO9KUx7j z60Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766978286; x=1767583086; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MrGC9JWDCaxJgv6rvmu39tdxxA/sQpLqKQTMa9mrb4s=; b=Ta8+bpAHUuHJMaJS0ACNRTJM0fLo5P9v0Ko/0GaPdeag5+3UjjlcJHgiyoazUPv7N8 K9gpVmcfPySkIETioT8d4U55o7TXlt/a//qBqnEkwoSfpDHAWwISYyp2ScL5DRnoNOj4 m4boCsMS1yMFuvkwvtypY5Mc8dzvj1Kyk8VRnX5gqRr4BB2XrO323ICQJMu8gPf5x7X1 cGyapFxW3yvsGL8tpDoz7axjDdrQaKp/5cfrjfrB9ADS5OqLLBTXP8vcyFiebKOVc22z qhq6zezrkzOHMQESiHcAtjF3kKmI5CRWzw4ptCIFRwde4Z0dLBaX6pcXUYVqlpoaX6xG 1+qw== X-Forwarded-Encrypted: i=1; AJvYcCUEQJPG37RlAGgXAbNbVPiD2XxnEalSRJn4KByx901Wmh3cyqRUeIkt6VUk66gVcq4s6ImTm++yV2r9g3I=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6CZuTKVdUeCeaT5Zl31rR4dFK2h8VH5l/GZ113eRDWnxioo0Q Wc3UFkG35+JWcx4zRU++hZc6FJ7322z7+vhs89C2Jop7ulOSiusmFJku X-Gm-Gg: AY/fxX68w3HO3JJm+BoF8aIgAk3qfp4Il5RtRSJF9kblNJ4rPb/wZjC4frlWvyzUSKn Vk+OT3KUTPtT/Qmj91rvtzT9GQtRpqo/QEG1L7eZNkjiOUxjZsTOeE4sjmLeBf5AJHa0ZcJxZBS Di7Nk+x+052TzAuK5d7HgnbtN4Upg+oJj3pPJQ3U1gNQ0nI/SAmNZZdZL0dZqjcRnxPTT3sKn3V sJoDoAvVHgtLDcDjTsxHras67yobH4IgZ3hvDZiaiLsEe02DGR71G+uGe/AgM2yL+TkvNIzMBBb O76Tbrh5gxS/ZpYZF2OOUPG5CPm4fSD3H/MRp9QTmbvovbHP2k/zoT6bEjEdhh7LIzfkbjGOw/W l6H7gEjqI9ieBXUC0hxLITNl5gTt81qnyxb/Tk73kuOsg/vfXmOKkC9D+XQO95ujpSVKrn/wVG/ ZhfPsX9w+KS3Ge9waL3JiCkXsgZRs9scDbNky8w+BQtLDEoZEoVLJjs0uA22V0ua1ZQ/Z75g35m A== X-Google-Smtp-Source: AGHT+IEM02CMJY2VQsw38v3sA96MHZUfuoCRegT+hQCz1o5/LKIzBteu28U364+Nmkl6le9V8oo7Jg== X-Received: by 2002:a05:7022:150d:b0:11b:9386:7ecd with SMTP id a92af1059eb24-121722fa7c2mr27864612c88.42.1766978286401; Sun, 28 Dec 2025 19:18:06 -0800 (PST) Received: from lappy (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-121724dd7f5sm112992785c88.5.2025.12.28.19.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Dec 2025 19:18:06 -0800 (PST) From: "Derek J. Clark" To: Jiri Kosina , Benjamin Tissoires Cc: Mario Limonciello , Zhixin Zhang , Mia Shao , Mark Pearson , "Pierre-Loup A . Griffais" , "Derek J . Clark" , linux-input@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 11/16] HID: hid-lenovo-go-s: Add MCU ID Attribute Date: Mon, 29 Dec 2025 03:17:48 +0000 Message-ID: <20251229031753.581664-12-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251229031753.581664-1-derekjohn.clark@gmail.com> References: <20251229031753.581664-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Adds command to probe for the MCU ID of the Lenovo Legion Go S Controller and assign it to a device attribute. Signed-off-by: Derek J. Clark --- drivers/hid/hid-lenovo-go-s.c | 56 +++++++++++++++++++++++++++++++++++ 1 file changed, 56 insertions(+) diff --git a/drivers/hid/hid-lenovo-go-s.c b/drivers/hid/hid-lenovo-go-s.c index 3e9041e746df..36cee6c3d4cc 100644 --- a/drivers/hid/hid-lenovo-go-s.c +++ b/drivers/hid/hid-lenovo-go-s.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include @@ -34,8 +35,13 @@ struct hid_gos_cfg { struct completion send_cmd_complete; struct hid_device *hdev; struct mutex cfg_mutex; /*ensure single synchronous output report*/ + u8 mcu_id[12]; } drvdata; =20 +struct gos_cfg_attr { + u8 index; +}; + struct command_report { u8 cmd; u8 sub_cmd; @@ -70,6 +76,14 @@ static int hid_gos_version_event(u8 *data) return 0; } =20 +static int hid_gos_mcu_id_event(struct command_report *cmd_rep) +{ + drvdata.mcu_id[0] =3D cmd_rep->sub_cmd; + memcpy(&drvdata.mcu_id[1], cmd_rep->data, 11); + + return 0; +} + static u8 get_endpoint_address(struct hid_device *hdev) { struct usb_interface *intf =3D to_usb_interface(hdev->dev.parent); @@ -103,6 +117,9 @@ static int hid_gos_raw_event(struct hid_device *hdev, s= truct hid_report *report, case GET_VERSION: ret =3D hid_gos_version_event(data); break; + case GET_MCU_ID: + ret =3D hid_gos_mcu_id_event(cmd_rep); + break; default: ret =3D -EINVAL; break; @@ -160,10 +177,41 @@ static int mcu_property_out(struct hid_device *hdev, = u8 command, u8 index, return ret; } =20 +static ssize_t mcu_id_show(struct device *dev, struct device_attribute *at= tr, + char *buf) +{ + return sysfs_emit(buf, "%*phN\n", 12, &drvdata.mcu_id); +} + +/* MCU */ +static DEVICE_ATTR_RO(mcu_id); + +static struct attribute *legos_mcu_attrs[] =3D { + &dev_attr_mcu_id.attr, + NULL, +}; + +static const struct attribute_group mcu_attr_group =3D { + .attrs =3D legos_mcu_attrs, +}; + +static const struct attribute_group *top_level_attr_groups[] =3D { + &mcu_attr_group, + NULL, +}; + static void cfg_setup(struct work_struct *work) { int ret; =20 + /* MCU */ + ret =3D mcu_property_out(drvdata.hdev, GET_MCU_ID, FEATURE_NONE, 0, 0); + if (ret) { + dev_err(&drvdata.hdev->dev, "Failed to retrieve MCU ID: %i\n", + ret); + return; + } + ret =3D mcu_property_out(drvdata.hdev, GET_VERSION, FEATURE_NONE, 0, 0); if (ret) { dev_err(&drvdata.hdev->dev, @@ -187,6 +235,13 @@ static int hid_gos_cfg_probe(struct hid_device *hdev, drvdata.hdev =3D hdev; mutex_init(&drvdata.cfg_mutex); =20 + ret =3D sysfs_create_groups(&hdev->dev.kobj, top_level_attr_groups); + if (ret) { + dev_err_probe(&hdev->dev, ret, + "Failed to create gamepad configuration attributes\n"); + return ret; + } + init_completion(&drvdata.send_cmd_complete); =20 /* Executing calls prior to returning from probe will lock the MCU. Sched= ule @@ -207,6 +262,7 @@ static void hid_gos_cfg_remove(struct hid_device *hdev) { guard(mutex)(&drvdata.cfg_mutex); cancel_delayed_work_sync(&drvdata.gos_cfg_setup); + sysfs_remove_groups(&hdev->dev.kobj, top_level_attr_groups); hid_hw_close(hdev); hid_hw_stop(hdev); hid_set_drvdata(hdev, NULL); --=20 2.51.2