From nobody Tue Feb 10 01:19:11 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF4E7331229; Mon, 29 Dec 2025 17:27:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767029226; cv=none; b=Lp/JDYLEFqf4RMbhA3CRCycLFTCVJi4FIaSxJeJwXUVyiU1Df6XWkH94LxzoJ8J4bus3VsqJkL1ezqruRc6rgR9jhnHnw+ceb2geoF14aaFXj0H/Yh4e3hWHaRx9YvnCOMDaKQ+a0+7NqnyD9YFhWM8sxnDldA5V3ZwYVjF5CYM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767029226; c=relaxed/simple; bh=TfI9cF+i19rjT6swT8jDbAqZ8xwCcYe+DskRWJClOio=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kU5YQW1BRi4/7ffqAjxwYcdsQ4no744SZEiUCPiro+25sYB9vhL/ZS6Iu6iKhE95vozEc2IP7XA0RCedV8xMZMKy8QmoNNr643YCwd8TqcVz6iJozJ+vovMke6UFxxzfciqi7OCf5dryusM6GT+o20rV32ISeYs13mLgw5YjDFU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bQgRpWjF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bQgRpWjF" Received: by smtp.kernel.org (Postfix) with ESMTPS id 6E2E1C2BCB2; Mon, 29 Dec 2025 17:27:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767029226; bh=TfI9cF+i19rjT6swT8jDbAqZ8xwCcYe+DskRWJClOio=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=bQgRpWjF/AWIuumSYQUf1tQcCxdzrH5v19Oo7P0z71KPTLA0OHRzKxl1TIH5zklX1 MgjYSsyWr3VCeMPCi1E0GnrSNbSC4Yjpj3g8i/CUKhsdk64VVKYXZeC4cIc/F60Sbe yApxF7b47IqMe+nJL7k21ZsxgcnDu4IqVA0GWcnyvEYdRY+U9s/GlyHSvKMci+cGyA p6Wi7T546naoXGNZmeLeKC9LP4zsa4YEinzBT8j6BbY+FUaHt7LqgcAwriIMUPU6YI pzPFLrn6xs9/ZKdVC8S25euxrDBtgHJOsSQVHvlihYK0ykNf94XEXIzji/L9TuhfXc rXSYD7G8iVMQg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DB44E9273E; Mon, 29 Dec 2025 17:27:06 +0000 (UTC) From: Manivannan Sadhasivam via B4 Relay Date: Mon, 29 Dec 2025 22:56:57 +0530 Subject: [PATCH v3 6/7] PCI: qcom: Drop the assert_perst() callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251229-pci-pwrctrl-rework-v3-6-c7d5918cd0db@oss.qualcomm.com> References: <20251229-pci-pwrctrl-rework-v3-0-c7d5918cd0db@oss.qualcomm.com> In-Reply-To: <20251229-pci-pwrctrl-rework-v3-0-c7d5918cd0db@oss.qualcomm.com> To: Manivannan Sadhasivam , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Bartosz Golaszewski Cc: linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Chen-Yu Tsai , Brian Norris , Krishna Chaitanya Chundru , Niklas Cassel , Alex Elder , Bartosz Golaszewski , Manivannan Sadhasivam X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3712; i=manivannan.sadhasivam@oss.qualcomm.com; h=from:subject:message-id; bh=OxqbBaot5sb3RNdkBfSCmREAquDem1+SJOzo41RQjOs=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBpUrnmP+nu1ihn6rmt7HAaYQo8uKEdf/ZEG2DSc Z4I0D6eg42JATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCaVK55gAKCRBVnxHm/pHO 9Um0CACKWr2CxTV/7MzzNxY/3V6I/yfE5K3/Od/TTsExLfnl2cOhNRv/bhrp5QQQ6IWNCBZAuuB on8vEc9IMG3e9O776iWj5xGYf3VDF/vrxJCHZlkWCmr718w5LLmP7pKFIPIZ9vEMCo76zzeoAA8 x0sP39XJeT48rkonT+wJcv/fXKWjBcYHz/+Z90rbtooT7B8xApU0DZnan1wdAR86+bbOMO904E4 6afJAAQnU2yqn2H13kmQOn/a2HYdlk5p+UcVl5VQ40eTo5WR2tICFB+Pacog1ZpsOE+S46ylBP2 TcktPxFAuoX8W2yyu/quLlBxuN56yrkDf5NQCYAXmyp1vmD7 X-Developer-Key: i=manivannan.sadhasivam@oss.qualcomm.com; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 X-Endpoint-Received: by B4 Relay for manivannan.sadhasivam@oss.qualcomm.com/default with auth_id=461 X-Original-From: Manivannan Sadhasivam Reply-To: manivannan.sadhasivam@oss.qualcomm.com From: Manivannan Sadhasivam Now that the TC9563 Pwrctrl driver is converted to use the new Pwrctrl design, there is no need for these assert_perst() callbacks. With the new design, TC9563 will be powered on before PERST# deassert. So explicit PERST# handling from the TC9563 driver is not needed. Hence, drop the callbacks. Signed-off-by: Manivannan Sadhasivam --- drivers/pci/controller/dwc/pcie-designware-host.c | 9 --------- drivers/pci/controller/dwc/pcie-designware.h | 8 -------- drivers/pci/controller/dwc/pcie-qcom.c | 13 ------------- include/linux/pci.h | 1 - 4 files changed, 31 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pc= i/controller/dwc/pcie-designware-host.c index 372207c33a85..4862a3a059c7 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -857,19 +857,10 @@ static void __iomem *dw_pcie_ecam_conf_map_bus(struct= pci_bus *bus, unsigned int return pci->dbi_base + where; } =20 -static int dw_pcie_op_assert_perst(struct pci_bus *bus, bool assert) -{ - struct dw_pcie_rp *pp =3D bus->sysdata; - struct dw_pcie *pci =3D to_dw_pcie_from_pp(pp); - - return dw_pcie_assert_perst(pci, assert); -} - static struct pci_ops dw_pcie_ops =3D { .map_bus =3D dw_pcie_own_conf_map_bus, .read =3D pci_generic_config_read, .write =3D pci_generic_config_write, - .assert_perst =3D dw_pcie_op_assert_perst, }; =20 static struct pci_ops dw_pcie_ecam_ops =3D { diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/con= troller/dwc/pcie-designware.h index 31685951a080..d24abdb9edaa 100644 --- a/drivers/pci/controller/dwc/pcie-designware.h +++ b/drivers/pci/controller/dwc/pcie-designware.h @@ -798,14 +798,6 @@ static inline void dw_pcie_stop_link(struct dw_pcie *p= ci) pci->ops->stop_link(pci); } =20 -static inline int dw_pcie_assert_perst(struct dw_pcie *pci, bool assert) -{ - if (pci->ops && pci->ops->assert_perst) - return pci->ops->assert_perst(pci, assert); - - return 0; -} - static inline enum dw_pcie_ltssm dw_pcie_get_ltssm(struct dw_pcie *pci) { u32 val; diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controlle= r/dwc/pcie-qcom.c index 198befb5be2c..6de3ff555b9d 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -650,18 +650,6 @@ static int qcom_pcie_post_init_1_0_0(struct qcom_pcie = *pcie) return 0; } =20 -static int qcom_pcie_assert_perst(struct dw_pcie *pci, bool assert) -{ - struct qcom_pcie *pcie =3D to_qcom_pcie(pci); - - if (assert) - qcom_ep_reset_assert(pcie); - else - qcom_ep_reset_deassert(pcie); - - return 0; -} - static void qcom_pcie_2_3_2_ltssm_enable(struct qcom_pcie *pcie) { u32 val; @@ -1523,7 +1511,6 @@ static const struct qcom_pcie_cfg cfg_fw_managed =3D { static const struct dw_pcie_ops dw_pcie_ops =3D { .link_up =3D qcom_pcie_link_up, .start_link =3D qcom_pcie_start_link, - .assert_perst =3D qcom_pcie_assert_perst, }; =20 static int qcom_pcie_icc_init(struct qcom_pcie *pcie) diff --git a/include/linux/pci.h b/include/linux/pci.h index 864775651c6f..3eb8fd975ad9 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -854,7 +854,6 @@ struct pci_ops { void __iomem *(*map_bus)(struct pci_bus *bus, unsigned int devfn, int whe= re); int (*read)(struct pci_bus *bus, unsigned int devfn, int where, int size,= u32 *val); int (*write)(struct pci_bus *bus, unsigned int devfn, int where, int size= , u32 val); - int (*assert_perst)(struct pci_bus *bus, bool assert); }; =20 /* --=20 2.48.1