From nobody Mon Feb 9 02:28:50 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF7AA2D0C8B for ; Mon, 29 Dec 2025 06:32:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766989925; cv=none; b=ILqL0VwzHRPYKF+qtUGnDtsgnzj6JrdIqfuVd6Q+TIOYbXAc9GG9SG/hyVy9WZxpaZxXW1P5MIu6yFTsrOnThV4ZiotVAUDqQyi4Z3HbZ9pac47G/vS5z04nJ6qvU09xWqGDJS8EwPWAcRozFJs63uWOAsH4euQKfnbp+O+BiTI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766989925; c=relaxed/simple; bh=veRINet6awseWXYxyYZwNw5ZPUP0TfC17AyTv/ndWhU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AajPRwPKVc+lGNd196vRh/67x20HqB1Zq/dBfL/9q4YzH387H56EzIXdwl3LACvmSnmNo8RcLAIO7M5Zznm1/ZUziAyPqHbT2s2MDdEzIy4t16ml9hXEoK+Cf/FSdgclu6x1hRS39RblM6RXyjSX9h8z6PlWCSxlnvc3Iin32wE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QVNi23eL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=F1ruviQZ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QVNi23eL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="F1ruviQZ" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BSMxDw64087696 for ; Mon, 29 Dec 2025 06:32:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uNmr2Qd+7VE+ZXIXnd9eWAuqPwXoo5DhvxtgK5dWg7k=; b=QVNi23eL1jVD6PLB +PZR4NtMBlXbBD0TX/zDtQzoJZMgMKebRr1UqbyW0CWco22dtHdq69PVTDrnuT+J 8qIpabcrzvOa6mUJRKAWqEldyPrz54TlldXp7SHk9BMrosf42XE/zvSCVSTYgV/d GRWv1gGb0VgfWQ1iTUI5P6nZY9Z03oR3PtLf7RAROZtdqMPfC11UGVX4R12N+MSY didDoE3lkrA/t9OVMcO+dPMwuEb+8qGmNna+v+G1Zx0e//xklshYxHxMpKX1kn0y 2QhGr73hCDDayv6OblFZaY3Dz4zJKaEkHf/J11oiAGlNgVbSlnz/PO19uQsLJ9Ao BUZR8w== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ba7hsbjt2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Dec 2025 06:32:02 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-7d5564057d0so20918905b3a.0 for ; Sun, 28 Dec 2025 22:32:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766989921; x=1767594721; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=uNmr2Qd+7VE+ZXIXnd9eWAuqPwXoo5DhvxtgK5dWg7k=; b=F1ruviQZ9IDZQ7+MNAUZMCGHMYmWr2gq0ZYU2ybWXqdq5qTUmhQoXMm7quMiGq13E2 WBLHnIPzgEfsodLLUQdKZHV84NY5uVvKgmC/Q37rMsAWRJBcIZvYJwCw0qQe1jB1SxLL RFyoB7i8o+rOFaqEJSyXrBCBXGeLa3Qe5NcDaerm9OQX8FiNiG03qSiCnWsObEQQ2ci3 MoDfYNr/CK45alVID9KfpQcL8ttIeaBhwsHnJiPy3PkyyJisYNm24LSqwDmLxCB2+TrB ONg3iL5tH6cg/0b1faX6CFse5UmlU4c11TGDwPTcVWxxrHoyiT/jF6X0pj7kguDhElcO uJKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766989921; x=1767594721; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=uNmr2Qd+7VE+ZXIXnd9eWAuqPwXoo5DhvxtgK5dWg7k=; b=mUQ5Tdx84uHTk9Do+rR1YWUwnNHuVkpGFo3OlclnW4zfkBM5pEmlDf3WgT2h2bX+SZ Ysh5vjN6Car0XO3oker+ohPv3wVsyHlWczJjqBbqFfnmJ9LMqr0HmAHAYTURbWiO8tEK E69sEEsbhIYZYU+3DIKUmojV3cRix0Jn7EoOAK5zhBAoKQSxHPDLdokZirn3jpR7Uls+ n5i8gMesUuCb0cFNbLkDqOTfN50EQqUkzV6oPA0wuU1ml6W3y22S8lgnZZMyu0WbFteN iU8U0Z9yXNdqS8F2kwQHf4x2lyfK0Bmdd7Obp+ds7DECbW+KfZDmFhqBxeitMoWfACPx CT7g== X-Forwarded-Encrypted: i=1; AJvYcCWxi8Ms2KSQDlLXsbxUlvnmlkiszBmIODfo0Bl1g71iyz6dDVXOlQacyeDFeL3dprZyXn9nzSrzUKJQeBo=@vger.kernel.org X-Gm-Message-State: AOJu0YxdUZFDYiUDGm13DhBwkYpIpY5er5RHgx3HLzf3LpcElBAX2oA8 /CbJUqcgqEVEN3IdClr06TWX+RvoCCkpaQpAtYxtrGy+PeDNYYhEMRh00JMDklZyVVE9J0ndm/d Kq3I2Aqc1y15CDg6RWie9E8QZur2H702Oj/Q5v99ieVCb7PpcnBsIMJVyfRgEF2hzTyg= X-Gm-Gg: AY/fxX5123VacAEWPATpPsCN1wMmk5Jqsr4HdzU2eBw1S2X6+Du43FB1omh0xFYcnKg qyUIlMyw+Sgz60JnbF6wNCNUcq0gBBGvG0GO9hNEh84yclrPxXbhueKYjTo4mPl1CSj96eiGe9k EjDHYOe8wvdLQ5Pc3tA/lDQtjw1mNGvkUQnvyR8qxcS3bVBWrp6FnbsPQcIVj1BUnxirPSafODw 8xdoeoM9NmzdsDar4sdOt8D90+3C5dJ8wl8on3WGbyI29kiD7L/NWFdPJGtwOt0bmKTlvtCkmFS BJfZZFVQcJgjr9kx+nyHPIGF0OcL87Ghvcrj/vny31kY7mC8EgEtkdc8UkRDApLonDFo9aqUO+o OIG1R7/2zJ7qGxPeTPl1mlsLKRkGLxGiDcYdJdIz1r1JI1aI= X-Received: by 2002:a05:6a00:8014:b0:7aa:e5f2:617d with SMTP id d2e1a72fcca58-7ff651c3519mr28501222b3a.30.1766989921327; Sun, 28 Dec 2025 22:32:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IEuWNnJoqqmKSK7EBdRRCNpr9qpD2VwNZsE7kTp8/v1msgyAvsObPIWGy+/LSRKXlLFzuuqKQ== X-Received: by 2002:a05:6a00:8014:b0:7aa:e5f2:617d with SMTP id d2e1a72fcca58-7ff651c3519mr28501191b3a.30.1766989920730; Sun, 28 Dec 2025 22:32:00 -0800 (PST) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e797ab9sm28308962b3a.59.2025.12.28.22.31.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Dec 2025 22:32:00 -0800 (PST) From: Dikshita Agarwal Date: Mon, 29 Dec 2025 12:01:25 +0530 Subject: [PATCH v2 6/6] media: iris: Prevent output buffer queuing before stream-on completes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251229-iris-fixes-v2-6-6dce2063d782@oss.qualcomm.com> References: <20251229-iris-fixes-v2-0-6dce2063d782@oss.qualcomm.com> In-Reply-To: <20251229-iris-fixes-v2-0-6dce2063d782@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Wangao Wang Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal , Vishnu Reddy X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1766989894; l=2070; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=ToSP8yw7UHrhfrl6kjhmcJJUW4s5zMFqgwQlqSSUXTg=; b=BBGTPZuqvbZVANhDb1b6tnEdSuZz3vjpRe1l8N0jbAO4T0nOyAX42ahp0+jMiyrVleaN7FZiT F7wbzFHue8kBksFbC4KBNJeQf3YQurHCrnGVmD3tnkzh15mCx6Lzefj X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-GUID: 6KLZAvsfP7VVUeBxifK5U2ARoxeGFO-r X-Authority-Analysis: v=2.4 cv=O4o0fR9W c=1 sm=1 tr=0 ts=69522062 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=k0qMZAR7W_WzNVtuHNoA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-ORIG-GUID: 6KLZAvsfP7VVUeBxifK5U2ARoxeGFO-r X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI5MDA1NyBTYWx0ZWRfX/4duiUvQOF24 t6vZFUeqtAb76gnANdh1BknOkcL7bp8EzRPvcZKoJ1bbsmob3T1bhjyco4padSkzXdyJRDE8GR6 l7N8c8U9Q1lMW862tjMMM/hGDdv/It0aJanfcBnAnxvxn2wZ2tg8EVxnUqaZZOL0moVYVpZtY19 kL+vaWHahnNvbZjjocBlSGkd2RKN5KC7bsLBGCVWX3vZrbI3uj+wkAdPuUye95DcaW178UF/Txj o0X3CqBe6EASV5kvVjqrxpn35MJDlbSjWHpFabokoHvdpbeTBv8nI9A7BYQcfbTlHphotOkizFO Bv8FjGdJqE96F4axo7m7EtKZmHqJhpDuBW+e6e7NlOn6/xIcuo6P4/JcH+4GBAvYXH7lpPiPLVR LZuYaK1qOgzQiYjwJJgY6RMYR89hBEkwsEWJm0MogvZmmyNqwAFLFDt4EKD/VzCmYrIhHdGzyM8 SYAnHV9wlwSWSL4m4lw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-29_01,2025-12-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512290057 From: Vishnu Reddy During normal playback, stream-on for input is followed by output, and only after input stream-on does actual streaming begin. However, when gst-play performs a seek, both input and output streams are stopped, and on restart, output stream-on occurs first. At this point, firmware has not yet started streaming. Queuing output buffers before the firmware begins streaming causes it to process buffers in an invalid state, leading to an error response. These buffers are returned to the driver as errors, forcing the driver into an error state and stopping playback. Fix this by deferring output buffer queuing until stream-on completes. Input buffers can still be queued before stream-on as required. Fixes: 92e007ca5ab6 ("media: iris: Add V4L2 streaming support for encoder v= ideo device") Signed-off-by: Vishnu Reddy Signed-off-by: Dikshita Agarwal Reviewed-by: Vikash Garodia --- drivers/media/platform/qcom/iris/iris_vb2.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_vb2.c b/drivers/media/pl= atform/qcom/iris/iris_vb2.c index 139b821f7952feb33b21a7045aef9e8a4782aa3c..bf0b8400996ece5c9d449b99609= a302da726bf9a 100644 --- a/drivers/media/platform/qcom/iris/iris_vb2.c +++ b/drivers/media/platform/qcom/iris/iris_vb2.c @@ -193,10 +193,14 @@ int iris_vb2_start_streaming(struct vb2_queue *q, uns= igned int count) buf_type =3D iris_v4l2_type_to_driver(q->type); =20 if (inst->domain =3D=3D DECODER) { - if (inst->state =3D=3D IRIS_INST_STREAMING) + if (buf_type =3D=3D BUF_INPUT) + ret =3D iris_queue_deferred_buffers(inst, BUF_INPUT); + + if (!ret && inst->state =3D=3D IRIS_INST_STREAMING) { ret =3D iris_queue_internal_deferred_buffers(inst, BUF_DPB); - if (!ret) - ret =3D iris_queue_deferred_buffers(inst, buf_type); + if (!ret) + ret =3D iris_queue_deferred_buffers(inst, BUF_OUTPUT); + } } else { if (inst->state =3D=3D IRIS_INST_STREAMING) { ret =3D iris_queue_deferred_buffers(inst, BUF_INPUT); --=20 2.34.1