From nobody Mon Feb 9 23:15:56 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDB3F2D062F for ; Mon, 29 Dec 2025 06:31:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766989912; cv=none; b=VIENnxxSIRCLdh4Vr5mp8eyQUfj40h7Wuwu9pXc7UTZarE8VrdkSU0S0qkVUmHs41t8N8Y7q/pt2+v1uWAv+yhlaHB2zCDQOAGH9Ee5TEhJuYeIXBwfzptujSJMp3Zid9KpPqw5dKi1wNks6KzB4xWsBh5K1NSy8MpACOSGvo/s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766989912; c=relaxed/simple; bh=MEV2/qVVd99QWuTtE5bIxAoEdRDy3ULlE8nZBM2UNsw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=D9IoOQq4bL97UYXifaZuZB2x7htxFCYb2i7ungw7Ep2HIZ5IZZRvlmaNKBi1YdwtKdnNcNCgXvOPWsqzp+ob9b7PMx500BJX3ExmYvNiKygNO9Sk60jxLir31fS6ylgiBStKsay3Wb/up2xmNlQ6j3TVFqtUxb1YlrIbhuC1qEE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NMG/if0U; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FhauOmzm; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NMG/if0U"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FhauOmzm" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BSKD5A61055500 for ; Mon, 29 Dec 2025 06:31:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3iZ4W4e1iDrWQWlO3LPsVRbwj84Rm21UBb36ptgETvc=; b=NMG/if0UzZivJsfX sakulDhkt9bNepDQ/GyN2+g4V7fKZK47CoEgsAQVIiQXKb00wq0TL+fTixjWutOJ h3XO8I8LqQrgAqe8PzCWbVssXN7ozJeM7XLFHtUh1QFCDBtEn06O/Ka/t7xtKeCB fdvSouTYZQAP+kGf+Sg1AXcDc33CCtmPUv480+0RlnlsLBzQL3AFsMoHiKL3Uddw C2ToyItwcPFe4VJnKCujxwdcepbgIzYWjn+jvrfisZcy7kp9XoeGyJHUW+IBaXVg gdQ7Jw8d2EUpKkTAUtAt+NOyyAXgcQwAqfW/DWJsMnNOlsBi2z5aP860PeDUmilO IIfYrw== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bavrj20n7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Dec 2025 06:31:50 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-7ba9c366057so22931200b3a.1 for ; Sun, 28 Dec 2025 22:31:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766989909; x=1767594709; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3iZ4W4e1iDrWQWlO3LPsVRbwj84Rm21UBb36ptgETvc=; b=FhauOmzm31EU8bEv9kkxBujgLxlHor8j65zk47M2KZsL842IvvxKE9N9IbugfFFbWU YirOuFwfM65XrGyO6s1uYHTAzUCZKT2CAb+BrXo7IlKinkK0KM6W2FoFySGECpV0iG61 s18pVPo3IggstJRNYj94NrapJzmNvSmmFnZcL9bAx+AkxrWodZc7juirq4BpR1pIepOB u0ZxC1MAceeUBNYFQ8trvjUN1o4G3L5p404yaZcZrysXEAw7oJSwyIlXSB3WT1qewawH nRS0EUm/RwypfTi8iYXxrFnFuEShtjOHt00ULuThDhQ21jMLSGjMx26Mb9cPdwLucxhO Gd6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766989910; x=1767594710; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=3iZ4W4e1iDrWQWlO3LPsVRbwj84Rm21UBb36ptgETvc=; b=nUzX5HMv6hEljgsFSRZm8YlKcAFibFgw5FUCTSI1b6XRG14knoDQWoYu8SGDj2xubZ /QB3W2DYp98u24SbTyoMEewWDXrb9au3qDmhg84zf39J+cOVsIoc5ByPFaDk7dIevHIA h/dT2NZC1m/WN6l5tvC87+K7bdJgHuFaNyg7irickLB1AKe9Iv3tpOvGCEL+EgyTZhOA 0ymU1uICSaCECPfUldO5rLnEEUKiksGuZQwusNJNlvgIAEQG0RQzlQpJs7vTEI1Ile3S KuOD60aOgOoXiVJpLx3gXnS6cOhWXU+o9d/Ca6Ryl5ni44GLORlebUUwU5sIfHuBtuUU /6+Q== X-Forwarded-Encrypted: i=1; AJvYcCVTWFlmL2mE3GBUY3vTY7BurERwXB78QTzzsasX3cTZfioTAWTvgsrmI2n2SO9GQemY666Yr2C7AemxFUM=@vger.kernel.org X-Gm-Message-State: AOJu0YywyJl73cpYRUrIOHUzgYk6656Cw/YPmfUO9ugy+gdulHnAAK8j 0lAvI0XWeBfAyalDweYMeC1vLEPXa4WFRNRC0LlMwuKKs880Xzgo//rnwVBzVlD+uqKoX0YwTHp /2YQs0yU8C0GsbOau3JkPVZ4pIZ4cY82p7jsh4bcHVI5TU0Lc9wbg48yURv6TqiBfKQM= X-Gm-Gg: AY/fxX7kK533UBU6unWHcjKhJBdbJwvRwjorQdHabDG5LZ+JFjY56kIPkVDohr7ffZc cLKi09j7y3vGWUL/nRrQbjYctDyp/cRd4cXDehp39PncnoZ1G7DqsR/m++EPadlib3TiXqkptTl YZ4yKVd12wYE4zddQLZr3KSGCdrsvrY9inl8Dl/l1AtRIgwmIkrnutfA0vGL3X1humPgt5ruoij WYfYXVnT1ekauh0nxbXJPUzG7KmCqnBoriTAXUIp0zDFCOpprDmeURCBDWOnwyQBxHkh/60RR6l wq9o0HWtM9B4ogKH0TvafzBYhFhTau0LF2XoqNzhUTCHkThBXHOzdnO6IghRWEXhKvP43tthhY/ uh12mQXAxLv1nv+eGey+ftLyFLh6D/isQV6nAl33KZ8nqDg4= X-Received: by 2002:a05:6a00:3286:b0:7e2:839e:84e0 with SMTP id d2e1a72fcca58-7ff64cd429dmr23873608b3a.17.1766989909588; Sun, 28 Dec 2025 22:31:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IHaxbeyexC70WN43ELJxd4EwRUh/WhI8QxlmMzJXYH9f1Bscl31v4+tELm+vI8DjSSdwqUJyQ== X-Received: by 2002:a05:6a00:3286:b0:7e2:839e:84e0 with SMTP id d2e1a72fcca58-7ff64cd429dmr23873587b3a.17.1766989909193; Sun, 28 Dec 2025 22:31:49 -0800 (PST) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e797ab9sm28308962b3a.59.2025.12.28.22.31.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Dec 2025 22:31:48 -0800 (PST) From: Dikshita Agarwal Date: Mon, 29 Dec 2025 12:01:22 +0530 Subject: [PATCH v2 3/6] media: iris: gen1: Destroy internal buffers after FW releases Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251229-iris-fixes-v2-3-6dce2063d782@oss.qualcomm.com> References: <20251229-iris-fixes-v2-0-6dce2063d782@oss.qualcomm.com> In-Reply-To: <20251229-iris-fixes-v2-0-6dce2063d782@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Wangao Wang Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1766989894; l=1336; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=MEV2/qVVd99QWuTtE5bIxAoEdRDy3ULlE8nZBM2UNsw=; b=IaRfzLARxFmFZs+06nVP6qXfmpdn/HGQKiRpqWvOUZKtj+oojXCHmnXdE09bQ+8JKXtQLg7D8 RPFpdcQQ8RZAl/+hpZM5n/M5XK7LGrVZPhWd0dxQwWO+U8x66GP4Oz4 X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-ORIG-GUID: yaibLzJ4q04Hdm3hgRD9kuwsv1BsLAr8 X-Proofpoint-GUID: yaibLzJ4q04Hdm3hgRD9kuwsv1BsLAr8 X-Authority-Analysis: v=2.4 cv=coiWUl4i c=1 sm=1 tr=0 ts=69522056 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=ClRbyBwZYeV4lDUphtoA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI5MDA1NyBTYWx0ZWRfX98cxtgOi6fL8 46iJjaRh4Xg1T2P2KcUBE73BaO7Dw74MVO6nxaGIQm/jYfuV7ZKYjeRcKaiiOHt2PfFoIof+4TT sXS4i7GQQ6Vl6D+fRGdRGK+usCoI8sFQnVMJkZ7CiqKKfw/CkXmI1ojPsdoOFP2PMm/EPIVQF/z TwmMnu4s0Y9GyJvesFCAQq58/32dEvj4ZgQ2W4neFk5yahah+jofWZIlChduCQdHJjK7WaC53Z/ qna7fhi+8LsakhkP3Tas4+KwMXqNZfDDTck6SEBDw6ywg4DMQCBax0IlPWKHQNd5SQrpUWAj08o eae1xcg+lw+a8oVWEfj36Eq6WFRdiwlA+KqhiPluTFt7cPm1WnvpMRAxnbOLNhraH3/Q8cQAySP g/RuLHv9ubz4fNp8BOE7GeAC/FzlJF/5J8+9q2+EdqYVnB0tcQ0Y/XiyeOOVzZbw93Rnv1QszTR 0qKZ+ISpunh4JTUhzGw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-29_01,2025-12-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 malwarescore=0 phishscore=0 adultscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512290057 After the firmware releases internal buffers, the driver was not destroying them. This left stale allocations that were no longer used, especially across resolution changes where new buffers are allocated per the updated requirements. As a result, memory was wasted until session close. Destroy internal buffers once the release response is received from the firmware. Fixes: 73702f45db81 ("media: iris: allocate, initialize and queue internal = buffers") Reviewed-by: Bryan O'Donoghue Signed-off-by: Dikshita Agarwal Reviewed-by: Vikash Garodia --- drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c b/dri= vers/media/platform/qcom/iris/iris_hfi_gen1_command.c index 5087e51daa842515e9d62730680fb237bf274efa..5ff71e25597b61587c674142feb= 99626e402c893 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c @@ -441,6 +441,8 @@ static int iris_hfi_gen1_session_unset_buffers(struct i= ris_inst *inst, struct ir goto exit; =20 ret =3D iris_wait_for_session_response(inst, false); + if (!ret) + ret =3D iris_destroy_internal_buffer(inst, buf); =20 exit: kfree(pkt); --=20 2.34.1