From nobody Mon Feb 9 03:12:16 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CEF32D0C66 for ; Mon, 29 Dec 2025 06:31:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766989905; cv=none; b=DGfSDXU+rinyLvqR+oq41QhMR9/27CPLsNPCP79lsnFfPGcOgiGRnq8OW/DerrINXA2bscXGVo9/ySvhq/YJuGsBBKZIUpeRUHLrvDjB7kR8peF/Kg6dxIw+dp26Pso69zmxi5jRTJq1L/eKTc63Hkip4lyilscle7mAva13/wg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766989905; c=relaxed/simple; bh=NIZo+UdWxMsX7ox29/TZ4OoER1qNAvVTp1tlRL72/j0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LgXIKUdGqvr5la9WkzO8F9azhMGhsYxF8DO0IJ4B61d2w2VSBmgIunlq/E/R8bB6MP7Utspmo+mvACMGgF1EbV+Gk9Hk7La0PUjgXRiHBbNcPamAfNMl6hBT/phfnskrjhAvxDjynxZo8O4jKpFIDIy9UqTMrwNCqGswOnWMO+Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Mvz4dUr4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jTnEUKRX; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Mvz4dUr4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jTnEUKRX" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BSMNe2w3661918 for ; Mon, 29 Dec 2025 06:31:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= puyFVl7m3pv6DrUbueGqXDplOqSDhPlOzaE+s3URf88=; b=Mvz4dUr4HANaRmme WNVif7l0G2q0e4imL/tBSqN7XYcj27MdROpftwfCLJLhyW8sQCB/i3r/MKLNDw3F hBPj9e9dyyoiGH0aRdvGaywFI0jr5AgKYa8VEv9zL4usyKVi7z+F/Vuu3fcTcrSu ZFoKXY/1BZ6PoPo9A2VLjuHJW3VxaR0MQzCrLu8lSqLXYvoSsPoWIH/HV7UvYWIE zqzCatHD9VMAMEaVuX43ETcmnZJdHP9b+MQCwlLGOZQl1V5y3VgU2hPl9T2n5T6d 9x+o4GLjbLX8AhSXp39JjoBXvau8YfIn3/xJBQyd8BG4XAZ1frqmBQybDsQMmstD oTmdaA== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bbc8yrt1w-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Dec 2025 06:31:42 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-7f046e16d50so14842766b3a.3 for ; Sun, 28 Dec 2025 22:31:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766989902; x=1767594702; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=puyFVl7m3pv6DrUbueGqXDplOqSDhPlOzaE+s3URf88=; b=jTnEUKRXa28A98xnoStzOkt2QX8T0X46jAN9zSTk/BRVVlJoFEiUqWwYBjbN7rzRei Q6ByY+xVRhn/svg6zvncaGSNek5QxC28Ps6YUsAH2WXND3zVXECVZA63PmOjsQ8odlU5 P5KA0C8FZ4li2t5ceSqBWG0CKpQnlTBpHVNum//S8Ydav+vju/hUlmKG7IBvHtXVIRfD Ot1I8FJCD0cl2z4WnKwxeSLNOnlL8iXBQY9M51YRswGO2hUjWkYsN+/awNitzoRHJ+hU 8ewMTcIubK6w3lB+dCuEJJLF7xJtNa8hocKc7C0xUeviy3lF5YmwQkfMHxJJVxSgsaav 4nGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766989902; x=1767594702; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=puyFVl7m3pv6DrUbueGqXDplOqSDhPlOzaE+s3URf88=; b=QqwJ3M43qS1KUjzuW6OHck3WptNHjPeU2CacnApv7ZDw/24bhqklVsv7qNreeCmMOL yFj81WPNYaVC17D47grT8dJT1r8oHJT+0Rylm5An3tkjVI3pU8Z7+phk5IllEzYzaa3i 2xH1RVjNr7pEOrDmETQAMkO+tA4je+ehRxBESE76qXpHs1d2DzwGQlOe4FkLnGgvkBj1 QYleEFj8HWbzRClDfjEx5sGtaWbPv91+oJIl83WQYWufztdm/g89IO9UbaqSUKt2rl5x uhu8nqODsgeZHB1BM3TTR8H8klxaY5FoiYAoghw3vvm5sX3FCIJkmF02o/3oQCuPcwoA ybaw== X-Forwarded-Encrypted: i=1; AJvYcCWhJwwIIQtwgqjSBw73V47oUBiikQwBfOHqT0oZmxn5bYc966Mmfkn3tbLeJR5OQUVzcJZAHeEv1P2s+IY=@vger.kernel.org X-Gm-Message-State: AOJu0YxN/hBQJaROAXAGtrhQPkC+zWeb44/yOKKKHpggVLIz4shrDYGs MO9EJrTgNSb6Kmd6GJZJ+aWG3fhKkKr1nsgCl8WqCYa1IsyzyVv+pTphEkLOBHrePS6VP/dDOsZ ja/o3CH7YZGOl/g+ae1Gh+xsMjo42wRT9SecvIEYakslDf5L+OV7MftmiGaCMMRBX0VqD9SelgV 4= X-Gm-Gg: AY/fxX5i1eHLHFOPX+4g7nmSFTT/qFLorPdsRlxroC5BxTE3HuJZNFJgglMV/gYCkpJ xY28p0x+33D3j7vGj1OgIhVL/TLAmWglbzRSlAs+CcDeE5Sf3EyDgi4HG1JN1TdkdelAkQjW3xN ipFDuPKRvcYqpCet7FhpsKyGJfpkgMFXRamEFLUkWlCDc39JjF+FTPMoIMc5/HD6X4v9nAIOKin ZSosSEFxYgB0yxzRD36/Gp81/ViamHzikRdOzEM7VYKyxB6rmVsRbsErrCHKhkXrnn2wPTLv5eN AXipr8h96XzQaL3ht4nh0RYEpYatfLI70pPJeLqs7xkNGaQ8Hc02x1eh/3Gy4TEkfXPAy3qiXl+ HqETih4FwVPrnwMTjwry+3+8fM9LInC90IekvRtNy5/+zmyA= X-Received: by 2002:a05:6a00:4008:b0:7fd:ec0b:d862 with SMTP id d2e1a72fcca58-7ff66d60f18mr25851932b3a.70.1766989902230; Sun, 28 Dec 2025 22:31:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IGGZQ5cnkKUjD4tXmSK82kKPrjN6ad2VkmLap8XjncOPShkeGs1Z6h1MdvlxjE1Eoa8er9/xA== X-Received: by 2002:a05:6a00:4008:b0:7fd:ec0b:d862 with SMTP id d2e1a72fcca58-7ff66d60f18mr25851911b3a.70.1766989901806; Sun, 28 Dec 2025 22:31:41 -0800 (PST) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e797ab9sm28308962b3a.59.2025.12.28.22.31.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Dec 2025 22:31:41 -0800 (PST) From: Dikshita Agarwal Date: Mon, 29 Dec 2025 12:01:20 +0530 Subject: [PATCH v2 1/6] media: iris: Add buffer to list only after successful allocation Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251229-iris-fixes-v2-1-6dce2063d782@oss.qualcomm.com> References: <20251229-iris-fixes-v2-0-6dce2063d782@oss.qualcomm.com> In-Reply-To: <20251229-iris-fixes-v2-0-6dce2063d782@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Wangao Wang Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1766989894; l=1730; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=NIZo+UdWxMsX7ox29/TZ4OoER1qNAvVTp1tlRL72/j0=; b=DKk77KO9RQxdDUQpyxO1gZXFQ77O+KuvCAr8O6tGIiLwVqSriRxZbLQUB8s/+IJx3dh4kwZUC vDKPAF4JSywDDaufUWSNEPyIrFNLfai9CtnzZ+TPjVjvVEvDNhkcCxg X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI5MDA1NyBTYWx0ZWRfX0U/7PV8ZkHfZ 3PyorCfEhn8ktX26Qw4Z7syjeuys4Sab20fsQ/ls18WglfiLFM3eEQ8FvcfTRDMJnS8JuVNJ+dl NaqoM1od7PSRexQaF+2DlF3JnBGnX3Y8JmuNnqjKTF1xqQka1cGe8IYt7mA55z/w18YxC79bvqS SBiMbdmzEYKyHpQPFaabGyDQkn/oonyyMH/CWMN5YYV75kfNh7iEj+bpzGNgtSy1ItmmZvMxpur 035Ei/ZjXPiXzGMouYeP0LJgzFXrUzUqp9cKDOeUn5UPYI+EwI4ga/MJvbQSb1ujQsKVLuNDqdF 8GA8qKCmVAwruDnkIbUU+NsdfanzMzDbeaYAeQp/6i97BcFMC2r3H4E/y+9kmN7RdoAC1BX4G/d oDzNm74hYbZQcya15+EIAxtklWC+8Clhehu6OBgTAhcSDhVu/tCJt2U1uIQ/loxD7zausrm21T4 SdtQ5EpBK/PtcIz72oA== X-Authority-Analysis: v=2.4 cv=cP7tc1eN c=1 sm=1 tr=0 ts=6952204f cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=H7qzw8hXFCepVgrFcaUA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-ORIG-GUID: 8g15DTdpYdSjavJaeQYP97FsLdZRTaUM X-Proofpoint-GUID: 8g15DTdpYdSjavJaeQYP97FsLdZRTaUM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-29_01,2025-12-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 malwarescore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 bulkscore=0 suspectscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512290057 Move `list_add_tail()` to after `dma_alloc_attrs()` succeeds when creating internal buffers. Previously, the buffer was enqueued in `buffers->list` before the DMA allocation. If the allocation failed, the function returned `-ENOMEM` while leaving a partially initialized buffer in the list, which could lead to inconsistent state and potential leaks. By adding the buffer to the list only after `dma_alloc_attrs()` succeeds, we ensure the list contains only valid, fully initialized buffers. Fixes: 73702f45db81 ("media: iris: allocate, initialize and queue internal = buffers") Reviewed-by: Bryan O'Donoghue Signed-off-by: Dikshita Agarwal Reviewed-by: Vikash Garodia --- drivers/media/platform/qcom/iris/iris_buffer.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_buffer.c b/drivers/media= /platform/qcom/iris/iris_buffer.c index b89b1ee06cce151e7c04a80956380d154643c116..f1f003a787bf22db6f048c9e682= ba8ed2f39bc21 100644 --- a/drivers/media/platform/qcom/iris/iris_buffer.c +++ b/drivers/media/platform/qcom/iris/iris_buffer.c @@ -351,12 +351,15 @@ static int iris_create_internal_buffer(struct iris_in= st *inst, buffer->index =3D index; buffer->buffer_size =3D buffers->size; buffer->dma_attrs =3D DMA_ATTR_WRITE_COMBINE | DMA_ATTR_NO_KERNEL_MAPPING; - list_add_tail(&buffer->list, &buffers->list); =20 buffer->kvaddr =3D dma_alloc_attrs(core->dev, buffer->buffer_size, &buffer->device_addr, GFP_KERNEL, buffer->dma_attrs); - if (!buffer->kvaddr) + if (!buffer->kvaddr) { + kfree(buffer); return -ENOMEM; + } + + list_add_tail(&buffer->list, &buffers->list); =20 return 0; } --=20 2.34.1