From nobody Sun Feb 8 02:41:36 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CEF32D0C66 for ; Mon, 29 Dec 2025 06:31:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766989905; cv=none; b=DGfSDXU+rinyLvqR+oq41QhMR9/27CPLsNPCP79lsnFfPGcOgiGRnq8OW/DerrINXA2bscXGVo9/ySvhq/YJuGsBBKZIUpeRUHLrvDjB7kR8peF/Kg6dxIw+dp26Pso69zmxi5jRTJq1L/eKTc63Hkip4lyilscle7mAva13/wg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766989905; c=relaxed/simple; bh=NIZo+UdWxMsX7ox29/TZ4OoER1qNAvVTp1tlRL72/j0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LgXIKUdGqvr5la9WkzO8F9azhMGhsYxF8DO0IJ4B61d2w2VSBmgIunlq/E/R8bB6MP7Utspmo+mvACMGgF1EbV+Gk9Hk7La0PUjgXRiHBbNcPamAfNMl6hBT/phfnskrjhAvxDjynxZo8O4jKpFIDIy9UqTMrwNCqGswOnWMO+Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Mvz4dUr4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jTnEUKRX; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Mvz4dUr4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jTnEUKRX" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BSMNe2w3661918 for ; Mon, 29 Dec 2025 06:31:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= puyFVl7m3pv6DrUbueGqXDplOqSDhPlOzaE+s3URf88=; b=Mvz4dUr4HANaRmme WNVif7l0G2q0e4imL/tBSqN7XYcj27MdROpftwfCLJLhyW8sQCB/i3r/MKLNDw3F hBPj9e9dyyoiGH0aRdvGaywFI0jr5AgKYa8VEv9zL4usyKVi7z+F/Vuu3fcTcrSu ZFoKXY/1BZ6PoPo9A2VLjuHJW3VxaR0MQzCrLu8lSqLXYvoSsPoWIH/HV7UvYWIE zqzCatHD9VMAMEaVuX43ETcmnZJdHP9b+MQCwlLGOZQl1V5y3VgU2hPl9T2n5T6d 9x+o4GLjbLX8AhSXp39JjoBXvau8YfIn3/xJBQyd8BG4XAZ1frqmBQybDsQMmstD oTmdaA== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bbc8yrt1w-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Dec 2025 06:31:42 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-7f046e16d50so14842766b3a.3 for ; Sun, 28 Dec 2025 22:31:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766989902; x=1767594702; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=puyFVl7m3pv6DrUbueGqXDplOqSDhPlOzaE+s3URf88=; b=jTnEUKRXa28A98xnoStzOkt2QX8T0X46jAN9zSTk/BRVVlJoFEiUqWwYBjbN7rzRei Q6ByY+xVRhn/svg6zvncaGSNek5QxC28Ps6YUsAH2WXND3zVXECVZA63PmOjsQ8odlU5 P5KA0C8FZ4li2t5ceSqBWG0CKpQnlTBpHVNum//S8Ydav+vju/hUlmKG7IBvHtXVIRfD Ot1I8FJCD0cl2z4WnKwxeSLNOnlL8iXBQY9M51YRswGO2hUjWkYsN+/awNitzoRHJ+hU 8ewMTcIubK6w3lB+dCuEJJLF7xJtNa8hocKc7C0xUeviy3lF5YmwQkfMHxJJVxSgsaav 4nGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766989902; x=1767594702; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=puyFVl7m3pv6DrUbueGqXDplOqSDhPlOzaE+s3URf88=; b=QqwJ3M43qS1KUjzuW6OHck3WptNHjPeU2CacnApv7ZDw/24bhqklVsv7qNreeCmMOL yFj81WPNYaVC17D47grT8dJT1r8oHJT+0Rylm5An3tkjVI3pU8Z7+phk5IllEzYzaa3i 2xH1RVjNr7pEOrDmETQAMkO+tA4je+ehRxBESE76qXpHs1d2DzwGQlOe4FkLnGgvkBj1 QYleEFj8HWbzRClDfjEx5sGtaWbPv91+oJIl83WQYWufztdm/g89IO9UbaqSUKt2rl5x uhu8nqODsgeZHB1BM3TTR8H8klxaY5FoiYAoghw3vvm5sX3FCIJkmF02o/3oQCuPcwoA ybaw== X-Forwarded-Encrypted: i=1; AJvYcCWhJwwIIQtwgqjSBw73V47oUBiikQwBfOHqT0oZmxn5bYc966Mmfkn3tbLeJR5OQUVzcJZAHeEv1P2s+IY=@vger.kernel.org X-Gm-Message-State: AOJu0YxN/hBQJaROAXAGtrhQPkC+zWeb44/yOKKKHpggVLIz4shrDYGs MO9EJrTgNSb6Kmd6GJZJ+aWG3fhKkKr1nsgCl8WqCYa1IsyzyVv+pTphEkLOBHrePS6VP/dDOsZ ja/o3CH7YZGOl/g+ae1Gh+xsMjo42wRT9SecvIEYakslDf5L+OV7MftmiGaCMMRBX0VqD9SelgV 4= X-Gm-Gg: AY/fxX5i1eHLHFOPX+4g7nmSFTT/qFLorPdsRlxroC5BxTE3HuJZNFJgglMV/gYCkpJ xY28p0x+33D3j7vGj1OgIhVL/TLAmWglbzRSlAs+CcDeE5Sf3EyDgi4HG1JN1TdkdelAkQjW3xN ipFDuPKRvcYqpCet7FhpsKyGJfpkgMFXRamEFLUkWlCDc39JjF+FTPMoIMc5/HD6X4v9nAIOKin ZSosSEFxYgB0yxzRD36/Gp81/ViamHzikRdOzEM7VYKyxB6rmVsRbsErrCHKhkXrnn2wPTLv5eN AXipr8h96XzQaL3ht4nh0RYEpYatfLI70pPJeLqs7xkNGaQ8Hc02x1eh/3Gy4TEkfXPAy3qiXl+ HqETih4FwVPrnwMTjwry+3+8fM9LInC90IekvRtNy5/+zmyA= X-Received: by 2002:a05:6a00:4008:b0:7fd:ec0b:d862 with SMTP id d2e1a72fcca58-7ff66d60f18mr25851932b3a.70.1766989902230; Sun, 28 Dec 2025 22:31:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IGGZQ5cnkKUjD4tXmSK82kKPrjN6ad2VkmLap8XjncOPShkeGs1Z6h1MdvlxjE1Eoa8er9/xA== X-Received: by 2002:a05:6a00:4008:b0:7fd:ec0b:d862 with SMTP id d2e1a72fcca58-7ff66d60f18mr25851911b3a.70.1766989901806; Sun, 28 Dec 2025 22:31:41 -0800 (PST) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e797ab9sm28308962b3a.59.2025.12.28.22.31.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Dec 2025 22:31:41 -0800 (PST) From: Dikshita Agarwal Date: Mon, 29 Dec 2025 12:01:20 +0530 Subject: [PATCH v2 1/6] media: iris: Add buffer to list only after successful allocation Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251229-iris-fixes-v2-1-6dce2063d782@oss.qualcomm.com> References: <20251229-iris-fixes-v2-0-6dce2063d782@oss.qualcomm.com> In-Reply-To: <20251229-iris-fixes-v2-0-6dce2063d782@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Wangao Wang Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1766989894; l=1730; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=NIZo+UdWxMsX7ox29/TZ4OoER1qNAvVTp1tlRL72/j0=; b=DKk77KO9RQxdDUQpyxO1gZXFQ77O+KuvCAr8O6tGIiLwVqSriRxZbLQUB8s/+IJx3dh4kwZUC vDKPAF4JSywDDaufUWSNEPyIrFNLfai9CtnzZ+TPjVjvVEvDNhkcCxg X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI5MDA1NyBTYWx0ZWRfX0U/7PV8ZkHfZ 3PyorCfEhn8ktX26Qw4Z7syjeuys4Sab20fsQ/ls18WglfiLFM3eEQ8FvcfTRDMJnS8JuVNJ+dl NaqoM1od7PSRexQaF+2DlF3JnBGnX3Y8JmuNnqjKTF1xqQka1cGe8IYt7mA55z/w18YxC79bvqS SBiMbdmzEYKyHpQPFaabGyDQkn/oonyyMH/CWMN5YYV75kfNh7iEj+bpzGNgtSy1ItmmZvMxpur 035Ei/ZjXPiXzGMouYeP0LJgzFXrUzUqp9cKDOeUn5UPYI+EwI4ga/MJvbQSb1ujQsKVLuNDqdF 8GA8qKCmVAwruDnkIbUU+NsdfanzMzDbeaYAeQp/6i97BcFMC2r3H4E/y+9kmN7RdoAC1BX4G/d oDzNm74hYbZQcya15+EIAxtklWC+8Clhehu6OBgTAhcSDhVu/tCJt2U1uIQ/loxD7zausrm21T4 SdtQ5EpBK/PtcIz72oA== X-Authority-Analysis: v=2.4 cv=cP7tc1eN c=1 sm=1 tr=0 ts=6952204f cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=H7qzw8hXFCepVgrFcaUA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-ORIG-GUID: 8g15DTdpYdSjavJaeQYP97FsLdZRTaUM X-Proofpoint-GUID: 8g15DTdpYdSjavJaeQYP97FsLdZRTaUM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-29_01,2025-12-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 malwarescore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 bulkscore=0 suspectscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512290057 Move `list_add_tail()` to after `dma_alloc_attrs()` succeeds when creating internal buffers. Previously, the buffer was enqueued in `buffers->list` before the DMA allocation. If the allocation failed, the function returned `-ENOMEM` while leaving a partially initialized buffer in the list, which could lead to inconsistent state and potential leaks. By adding the buffer to the list only after `dma_alloc_attrs()` succeeds, we ensure the list contains only valid, fully initialized buffers. Fixes: 73702f45db81 ("media: iris: allocate, initialize and queue internal = buffers") Reviewed-by: Bryan O'Donoghue Signed-off-by: Dikshita Agarwal Reviewed-by: Vikash Garodia --- drivers/media/platform/qcom/iris/iris_buffer.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_buffer.c b/drivers/media= /platform/qcom/iris/iris_buffer.c index b89b1ee06cce151e7c04a80956380d154643c116..f1f003a787bf22db6f048c9e682= ba8ed2f39bc21 100644 --- a/drivers/media/platform/qcom/iris/iris_buffer.c +++ b/drivers/media/platform/qcom/iris/iris_buffer.c @@ -351,12 +351,15 @@ static int iris_create_internal_buffer(struct iris_in= st *inst, buffer->index =3D index; buffer->buffer_size =3D buffers->size; buffer->dma_attrs =3D DMA_ATTR_WRITE_COMBINE | DMA_ATTR_NO_KERNEL_MAPPING; - list_add_tail(&buffer->list, &buffers->list); =20 buffer->kvaddr =3D dma_alloc_attrs(core->dev, buffer->buffer_size, &buffer->device_addr, GFP_KERNEL, buffer->dma_attrs); - if (!buffer->kvaddr) + if (!buffer->kvaddr) { + kfree(buffer); return -ENOMEM; + } + + list_add_tail(&buffer->list, &buffers->list); =20 return 0; } --=20 2.34.1 From nobody Sun Feb 8 02:41:36 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEF9A2D0C6C for ; Mon, 29 Dec 2025 06:31:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766989909; cv=none; b=TTj/2e2XiKzN8V8FjrBJqwuURAz/kNzSQsEUfz/4AUhJO43aq8uEMufBeTtg0luAUF3Dc688VhqjcGpUNfLa5muk63QJ16pg3reiJ9B5MI83Om5ikELFyKpt4fXY/suf/eZLVs28Kmxsboyanju93++ngQCCu+NH/H10umZTwgY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766989909; c=relaxed/simple; bh=+rL4lRzTGUatVxR2IU5B50u9WgYSm4OhmK8lABIkEUw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HquzulmTug9OtYdkSxcaXcWHS3TtCtze1E8YrMZmvMNz3WGWIAZnu4jkq3v8naXo8qIlYQTadKN17YpnQYbrRmNdRRZnipMyLmS2dUGVd6+p3xbfhZlWw+Peb4rueJxidc7UthFqDT5/t0CvSYwqA03gv+XBc+OslDEa+mZMooY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dMGmGyFi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ew2Wz/yP; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dMGmGyFi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ew2Wz/yP" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BSJq1iA3427818 for ; Mon, 29 Dec 2025 06:31:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= CSTdKndo2CG1ApifCcfjmKKwiWM5Dk3UzJnk6Vq5Q0w=; b=dMGmGyFipzSeUG7/ zm6u2nd2RIZ5NROThQXSYAM6iL5Pu/d2nHAfT9MxM41TnWQyb9XE2SaOOeAdU7sz 7aFEXa7+/4YM9fJOq6nZrwVerChuRIykdo6qyXHBLyooCLQr2V0cZ+IlH9XA9rzQ BKELwKBYgkOLg0Rd3T5GQPIgobTWhG0RpikArF+2GUuljGTZvuhgbTmopHkuVMNE Q2YJ44S7PqZxJskOLk6CmSFXu5uZNPpZEpwXbypUeJzM5homl7BqrM7PFWiJ6xNO 9PlfmrPBp7K5lXdlk5oJnOFPZwyqTPHgc9rp3RYbHqEY4YSWypkZCe644+jy1260 fy4N8w== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ba55e3rf3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Dec 2025 06:31:46 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-7aa148105a2so8518139b3a.1 for ; Sun, 28 Dec 2025 22:31:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766989906; x=1767594706; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CSTdKndo2CG1ApifCcfjmKKwiWM5Dk3UzJnk6Vq5Q0w=; b=Ew2Wz/yPqUGTIdkhJgC2hpynYklWggWu0KHFj1v+BlVZldLY7OORNMcEpV2JiAPr21 /CBiU0wwtvMGmlVMi8vi67rD5v0MIHhz6yWSQVSWNed1PxU4E82ytcci+LMV/EeInDjl Uc0wKCU38KoLff+RMsn+Rz7QhrJx4nKWmiAZ4L1OpO3b4NJoromg7NJhQgk5rs1LG9bG +dVA6qHj90dh34GvI97tKtZvhIdbHTUzOC6EmAz2Gd8G1FgbCK60sl+tlip1yBUtyd5k SubFY8rz2AJjXyr4ubrigTTt6/CdBsR9t1CRBGjkFlFO8di14OZ7npeQN1fX+2Gk5xfe 2Yiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766989906; x=1767594706; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=CSTdKndo2CG1ApifCcfjmKKwiWM5Dk3UzJnk6Vq5Q0w=; b=XnqifzANN5kGUteECann+UEaIvBheCnzLVo10nhO5lL0dLlWmoiO4DWzkHQXePETSR sXjzpddLZp13/mvmqP0FUGJpj70+nWPzHY7fILROmRe/Il37r3KtPWJRFCnHrByUdBDi ypDfTLxhwYokZD77gczMJf0cv0/NqiRbMplHrreIaZzZGDT40DIRnzcvkJ/XdRZCx8fM t7PIapmSR6shimgmsGV6BJ/WNN7WNER9IpYVV+PUyxRja68CSHLkYp6aNCO4DeUXQXFy YxJYTE6I96L8BEc9yP/GhW9Qbe8YLRQAjzF0LMs3XlRhUydD6pzZkSsIfsrl+qhq0QnA oSUg== X-Forwarded-Encrypted: i=1; AJvYcCWnMxfPR5BcLR6rCFRxizyaVbtDG3kxzO5uFzXYufKdHFrto/0ThpmV32i9mPKSxuCwNqGM+qu1H2ksy74=@vger.kernel.org X-Gm-Message-State: AOJu0YxdWoCnlmWv/h8GvzrVGWmMkU8dBUW+xHctg4f9ayJTGNm8Lcse JQTtLf8huvPco+iaH6xndtlnv1dF7RI9I7cXvxx6WM0DxwcKir5zbbcPVD9rpisNZtreVef+sjK /N1LTQdEIw7PAqqa6Y6JumQY/K5ERa7UbgHfYSklDBdouQbgoORuU5XG8cakYs+u4UVo= X-Gm-Gg: AY/fxX5lzZuKZq1FwtUM6omb++sEWraj+OvFBWBqwHv5KnQ0x5EgJ8HQFLbvgUMMJZk VTbxVzmroQtuK+0e8Ae4Nyus9odFmuLiHRyULDDpZF8fSE82JWka6vI4ue9+5CzdN4stfPoX4O4 MNISpLoVrycqEOG1fsQGzdUB2TkT1KUZzEf3hi6MyAKEDSt7zMnpuXPYNIo7tSRts1rDus7uEl9 sw/uJw7dAkuDhwOlruDxCOrx+SWT0TeFQQvPQD6XRGKejeuVWZgC2cG1Nn6/xVbsywt/H4rC/To 7qPasaNwxyw6/jtMkrWEBxv5YzqXEVA1FvnDNCfSLODA9Mys+8BaBLDZUiECvEgGbLfw1c4l2Dr 81mJu3WhYZepX8VrHF6++H9M1Q9OhfWm79ek+n0P5iprtJGI= X-Received: by 2002:a05:6a00:4105:b0:7f0:d758:3143 with SMTP id d2e1a72fcca58-7ff654b8108mr24578317b3a.20.1766989905978; Sun, 28 Dec 2025 22:31:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IHDInxSUa0oM3ki/aI3H6HGzs0EMPDzJPVYX8xu8sOQ+UZegnvmeo2DVlJYFXbYykF5SxlGIA== X-Received: by 2002:a05:6a00:4105:b0:7f0:d758:3143 with SMTP id d2e1a72fcca58-7ff654b8108mr24578290b3a.20.1766989905477; Sun, 28 Dec 2025 22:31:45 -0800 (PST) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e797ab9sm28308962b3a.59.2025.12.28.22.31.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Dec 2025 22:31:45 -0800 (PST) From: Dikshita Agarwal Date: Mon, 29 Dec 2025 12:01:21 +0530 Subject: [PATCH v2 2/6] media: iris: Skip resolution set on first IPSC Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251229-iris-fixes-v2-2-6dce2063d782@oss.qualcomm.com> References: <20251229-iris-fixes-v2-0-6dce2063d782@oss.qualcomm.com> In-Reply-To: <20251229-iris-fixes-v2-0-6dce2063d782@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Wangao Wang Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1766989894; l=1386; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=+rL4lRzTGUatVxR2IU5B50u9WgYSm4OhmK8lABIkEUw=; b=cvCwCsa2e0WzLjbz4pz1dOqr9BVp8LWqEaYF9etAPKZHg5cz+zc1B7dUbW1ONpKMy/7hwooV3 AMQOJvKRWlgD/Yg5EEgfBvhzbh0RcD2h2OWsXQUJsFfFrrhfeY5R4ca X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI5MDA1NyBTYWx0ZWRfX0lEsZqIYLHbI d8G51ZJmDAsJr+Q+6CelmRZXXHmZf9ECZpDDqjCR/hXHh3+qtSuLc5os0HfrzrbibmdXaXT4MYF 5kY5u/YSegQpnLA3ZbD5pqmPqIKAFPj4cZfZOEyb0MFFIeSGEcrThSWDuAGypwIGvqnH/RMtfed 2nfZbV3J7BNd3lSXAhviA0XVFOtyfhoZmvX9pdEnu7AkMhXqbZDp0s24YWUzpIs381bhnIxt15A WcTlE0Xtdl46p6/eYWD27RxLDaYJFH93+OfPuaKEP49zcISa4tQc1nk059iC7pdNZPbwnp5cLfA kMDyoAqNpWHepjn3wJW0QOi9YZ1ABwHKetaT+GToDUVCiU6rmsk+n2eZLTEEYoMmXYct4svrpm1 NyuYI04E+XwwenootGSQcEJYIXq8QvgRFOOEh6KugLo7ql7nSuhb8hHfyq4sPl7AYm1zucyqEMY 1qjFtVaLcTQBEzeCDrw== X-Authority-Analysis: v=2.4 cv=UMDQ3Sfy c=1 sm=1 tr=0 ts=69522052 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=Ed8qMULA6z6kmPtfi8MA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-ORIG-GUID: P05pP_uiXItsavWrPp2h5PwYegRArU-n X-Proofpoint-GUID: P05pP_uiXItsavWrPp2h5PwYegRArU-n X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-29_01,2025-12-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 phishscore=0 adultscore=0 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512290057 The resolution property is not supposed to be set during reconfig. Existing iris_drc_pending(inst) check is insufficient, as it doesn't cover the first port setting change. Extend the conditional check to also skip resolution setting when the instance is in IRIS_INST_SUB_FIRST_IPSC. Fixes: caf205548769 ("media: iris: Avoid updating frame size to firmware du= ring reconfig") Reviewed-by: Bryan O'Donoghue Signed-off-by: Dikshita Agarwal Reviewed-by: Vikash Garodia --- drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c b/dri= vers/media/platform/qcom/iris/iris_hfi_gen1_command.c index 52da7ef7bab08fb1cb2ac804ccc6e3c7f9677890..5087e51daa842515e9d62730680= fb237bf274efa 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c @@ -733,7 +733,7 @@ static int iris_hfi_gen1_set_resolution(struct iris_ins= t *inst, u32 plane) struct hfi_framesize fs; int ret; =20 - if (!iris_drc_pending(inst)) { + if (!iris_drc_pending(inst) && !(inst->sub_state & IRIS_INST_SUB_FIRST_IP= SC)) { fs.buffer_type =3D HFI_BUFFER_INPUT; fs.width =3D inst->fmt_src->fmt.pix_mp.width; fs.height =3D inst->fmt_src->fmt.pix_mp.height; --=20 2.34.1 From nobody Sun Feb 8 02:41:36 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDB3F2D062F for ; Mon, 29 Dec 2025 06:31:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766989912; cv=none; b=VIENnxxSIRCLdh4Vr5mp8eyQUfj40h7Wuwu9pXc7UTZarE8VrdkSU0S0qkVUmHs41t8N8Y7q/pt2+v1uWAv+yhlaHB2zCDQOAGH9Ee5TEhJuYeIXBwfzptujSJMp3Zid9KpPqw5dKi1wNks6KzB4xWsBh5K1NSy8MpACOSGvo/s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766989912; c=relaxed/simple; bh=MEV2/qVVd99QWuTtE5bIxAoEdRDy3ULlE8nZBM2UNsw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=D9IoOQq4bL97UYXifaZuZB2x7htxFCYb2i7ungw7Ep2HIZ5IZZRvlmaNKBi1YdwtKdnNcNCgXvOPWsqzp+ob9b7PMx500BJX3ExmYvNiKygNO9Sk60jxLir31fS6ylgiBStKsay3Wb/up2xmNlQ6j3TVFqtUxb1YlrIbhuC1qEE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NMG/if0U; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FhauOmzm; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NMG/if0U"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FhauOmzm" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BSKD5A61055500 for ; Mon, 29 Dec 2025 06:31:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3iZ4W4e1iDrWQWlO3LPsVRbwj84Rm21UBb36ptgETvc=; b=NMG/if0UzZivJsfX sakulDhkt9bNepDQ/GyN2+g4V7fKZK47CoEgsAQVIiQXKb00wq0TL+fTixjWutOJ h3XO8I8LqQrgAqe8PzCWbVssXN7ozJeM7XLFHtUh1QFCDBtEn06O/Ka/t7xtKeCB fdvSouTYZQAP+kGf+Sg1AXcDc33CCtmPUv480+0RlnlsLBzQL3AFsMoHiKL3Uddw C2ToyItwcPFe4VJnKCujxwdcepbgIzYWjn+jvrfisZcy7kp9XoeGyJHUW+IBaXVg gdQ7Jw8d2EUpKkTAUtAt+NOyyAXgcQwAqfW/DWJsMnNOlsBi2z5aP860PeDUmilO IIfYrw== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bavrj20n7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Dec 2025 06:31:50 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-7ba9c366057so22931200b3a.1 for ; Sun, 28 Dec 2025 22:31:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766989909; x=1767594709; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3iZ4W4e1iDrWQWlO3LPsVRbwj84Rm21UBb36ptgETvc=; b=FhauOmzm31EU8bEv9kkxBujgLxlHor8j65zk47M2KZsL842IvvxKE9N9IbugfFFbWU YirOuFwfM65XrGyO6s1uYHTAzUCZKT2CAb+BrXo7IlKinkK0KM6W2FoFySGECpV0iG61 s18pVPo3IggstJRNYj94NrapJzmNvSmmFnZcL9bAx+AkxrWodZc7juirq4BpR1pIepOB u0ZxC1MAceeUBNYFQ8trvjUN1o4G3L5p404yaZcZrysXEAw7oJSwyIlXSB3WT1qewawH nRS0EUm/RwypfTi8iYXxrFnFuEShtjOHt00ULuThDhQ21jMLSGjMx26Mb9cPdwLucxhO Gd6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766989910; x=1767594710; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=3iZ4W4e1iDrWQWlO3LPsVRbwj84Rm21UBb36ptgETvc=; b=nUzX5HMv6hEljgsFSRZm8YlKcAFibFgw5FUCTSI1b6XRG14knoDQWoYu8SGDj2xubZ /QB3W2DYp98u24SbTyoMEewWDXrb9au3qDmhg84zf39J+cOVsIoc5ByPFaDk7dIevHIA h/dT2NZC1m/WN6l5tvC87+K7bdJgHuFaNyg7irickLB1AKe9Iv3tpOvGCEL+EgyTZhOA 0ymU1uICSaCECPfUldO5rLnEEUKiksGuZQwusNJNlvgIAEQG0RQzlQpJs7vTEI1Ile3S KuOD60aOgOoXiVJpLx3gXnS6cOhWXU+o9d/Ca6Ryl5ni44GLORlebUUwU5sIfHuBtuUU /6+Q== X-Forwarded-Encrypted: i=1; AJvYcCVTWFlmL2mE3GBUY3vTY7BurERwXB78QTzzsasX3cTZfioTAWTvgsrmI2n2SO9GQemY666Yr2C7AemxFUM=@vger.kernel.org X-Gm-Message-State: AOJu0YywyJl73cpYRUrIOHUzgYk6656Cw/YPmfUO9ugy+gdulHnAAK8j 0lAvI0XWeBfAyalDweYMeC1vLEPXa4WFRNRC0LlMwuKKs880Xzgo//rnwVBzVlD+uqKoX0YwTHp /2YQs0yU8C0GsbOau3JkPVZ4pIZ4cY82p7jsh4bcHVI5TU0Lc9wbg48yURv6TqiBfKQM= X-Gm-Gg: AY/fxX7kK533UBU6unWHcjKhJBdbJwvRwjorQdHabDG5LZ+JFjY56kIPkVDohr7ffZc cLKi09j7y3vGWUL/nRrQbjYctDyp/cRd4cXDehp39PncnoZ1G7DqsR/m++EPadlib3TiXqkptTl YZ4yKVd12wYE4zddQLZr3KSGCdrsvrY9inl8Dl/l1AtRIgwmIkrnutfA0vGL3X1humPgt5ruoij WYfYXVnT1ekauh0nxbXJPUzG7KmCqnBoriTAXUIp0zDFCOpprDmeURCBDWOnwyQBxHkh/60RR6l wq9o0HWtM9B4ogKH0TvafzBYhFhTau0LF2XoqNzhUTCHkThBXHOzdnO6IghRWEXhKvP43tthhY/ uh12mQXAxLv1nv+eGey+ftLyFLh6D/isQV6nAl33KZ8nqDg4= X-Received: by 2002:a05:6a00:3286:b0:7e2:839e:84e0 with SMTP id d2e1a72fcca58-7ff64cd429dmr23873608b3a.17.1766989909588; Sun, 28 Dec 2025 22:31:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IHaxbeyexC70WN43ELJxd4EwRUh/WhI8QxlmMzJXYH9f1Bscl31v4+tELm+vI8DjSSdwqUJyQ== X-Received: by 2002:a05:6a00:3286:b0:7e2:839e:84e0 with SMTP id d2e1a72fcca58-7ff64cd429dmr23873587b3a.17.1766989909193; Sun, 28 Dec 2025 22:31:49 -0800 (PST) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e797ab9sm28308962b3a.59.2025.12.28.22.31.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Dec 2025 22:31:48 -0800 (PST) From: Dikshita Agarwal Date: Mon, 29 Dec 2025 12:01:22 +0530 Subject: [PATCH v2 3/6] media: iris: gen1: Destroy internal buffers after FW releases Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251229-iris-fixes-v2-3-6dce2063d782@oss.qualcomm.com> References: <20251229-iris-fixes-v2-0-6dce2063d782@oss.qualcomm.com> In-Reply-To: <20251229-iris-fixes-v2-0-6dce2063d782@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Wangao Wang Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1766989894; l=1336; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=MEV2/qVVd99QWuTtE5bIxAoEdRDy3ULlE8nZBM2UNsw=; b=IaRfzLARxFmFZs+06nVP6qXfmpdn/HGQKiRpqWvOUZKtj+oojXCHmnXdE09bQ+8JKXtQLg7D8 RPFpdcQQ8RZAl/+hpZM5n/M5XK7LGrVZPhWd0dxQwWO+U8x66GP4Oz4 X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-ORIG-GUID: yaibLzJ4q04Hdm3hgRD9kuwsv1BsLAr8 X-Proofpoint-GUID: yaibLzJ4q04Hdm3hgRD9kuwsv1BsLAr8 X-Authority-Analysis: v=2.4 cv=coiWUl4i c=1 sm=1 tr=0 ts=69522056 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=ClRbyBwZYeV4lDUphtoA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI5MDA1NyBTYWx0ZWRfX98cxtgOi6fL8 46iJjaRh4Xg1T2P2KcUBE73BaO7Dw74MVO6nxaGIQm/jYfuV7ZKYjeRcKaiiOHt2PfFoIof+4TT sXS4i7GQQ6Vl6D+fRGdRGK+usCoI8sFQnVMJkZ7CiqKKfw/CkXmI1ojPsdoOFP2PMm/EPIVQF/z TwmMnu4s0Y9GyJvesFCAQq58/32dEvj4ZgQ2W4neFk5yahah+jofWZIlChduCQdHJjK7WaC53Z/ qna7fhi+8LsakhkP3Tas4+KwMXqNZfDDTck6SEBDw6ywg4DMQCBax0IlPWKHQNd5SQrpUWAj08o eae1xcg+lw+a8oVWEfj36Eq6WFRdiwlA+KqhiPluTFt7cPm1WnvpMRAxnbOLNhraH3/Q8cQAySP g/RuLHv9ubz4fNp8BOE7GeAC/FzlJF/5J8+9q2+EdqYVnB0tcQ0Y/XiyeOOVzZbw93Rnv1QszTR 0qKZ+ISpunh4JTUhzGw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-29_01,2025-12-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 malwarescore=0 phishscore=0 adultscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512290057 After the firmware releases internal buffers, the driver was not destroying them. This left stale allocations that were no longer used, especially across resolution changes where new buffers are allocated per the updated requirements. As a result, memory was wasted until session close. Destroy internal buffers once the release response is received from the firmware. Fixes: 73702f45db81 ("media: iris: allocate, initialize and queue internal = buffers") Reviewed-by: Bryan O'Donoghue Signed-off-by: Dikshita Agarwal Reviewed-by: Vikash Garodia --- drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c b/dri= vers/media/platform/qcom/iris/iris_hfi_gen1_command.c index 5087e51daa842515e9d62730680fb237bf274efa..5ff71e25597b61587c674142feb= 99626e402c893 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c @@ -441,6 +441,8 @@ static int iris_hfi_gen1_session_unset_buffers(struct i= ris_inst *inst, struct ir goto exit; =20 ret =3D iris_wait_for_session_response(inst, false); + if (!ret) + ret =3D iris_destroy_internal_buffer(inst, buf); =20 exit: kfree(pkt); --=20 2.34.1 From nobody Sun Feb 8 02:41:36 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F9201F1315 for ; Mon, 29 Dec 2025 06:31:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766989916; cv=none; b=NSNVliVw5Ft6AyVSSy+P2EHmfRFypjR2vVwKdF9uL9b52wAoWfeyjO5b/9jI+obX9TpSI/wS+4LUIaFYWSnJw207UQfSCIAnZh323tMpjmT1GuIMmebRD2GlvIMNtTw0AzR8DntDsmF/R9hZJ2DW/1JZcVRlF+akAiAjBqC7saI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766989916; c=relaxed/simple; bh=WnRTSzPX7v2ew+XjFwuVlCLDf6VD9eOAqwv7XC3gI2U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SM1iYyfTx3wC5h2oVZozQjsk9YkNQ00dmhB+u4lvGtws8S4EMqndXmKab3L584mgghn3Qf8iWaHL1r+NxLPqfbiqE0qB+GA8/kheaQiZE6NCdOVvMdVHeGGp1ZjYnMzQJE3BZPBTeg2bMLS8A0GT0j3nr/4+HeFEPmt/XYU7eKY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IJ3d1yeK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HybyqjO3; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IJ3d1yeK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HybyqjO3" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BSLHPuh3590633 for ; Mon, 29 Dec 2025 06:31:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= z4kGK+44l58UGutVX6T4zr6zgIMspksNRCZEaJaRexw=; b=IJ3d1yeKl285Qo5J oyksJj2KFOMPOmEbH9hgmWR3yyCb+du7Cz+fgj6Fq/1gmdspMl0evCH1b96GPAJx 2e3vase/or6OFCw6FuaeP/tKx6cRRZsIza+OzYBFAq3qJ+rqAl+LEMBYapVVjzU+ L3N2Bl30APRs13PbPZdy9YPQ+pSUTWxmqcW8bpBpasFDMP8PvR/g9YysLq+FdGnk RPfjoeMyRSUTtIls/Ie2aU0WWIyBcSd2KxhsQqQn+ij8l+UFuWa/7eM7jMTJG4gt nQd1Nki/TfUSan+q8v9W92arGqTFCd71sGuurwvq3HtnMF5Kqto2bxXFCDPHdM5O D0Dojg== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ba55e3rff-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Dec 2025 06:31:53 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-7b80de683efso16804099b3a.3 for ; Sun, 28 Dec 2025 22:31:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766989913; x=1767594713; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=z4kGK+44l58UGutVX6T4zr6zgIMspksNRCZEaJaRexw=; b=HybyqjO3LQEZW54fSiS4A2PlYGDDBuYcAIyuPpR4tNqrmKvEfbxwRLp11d9641Ha4D irmSYWtCLIoKe67Bo/PDwNpNaNaWemgtmHW3/xeAFNfCxct5Jqn+P/1SrXpPSZ3yk8ax k1hcGwyJjl6GUCg8w/F+HGUGdpyih6LkXaj11DFB4PCt4OxvQhtCp4ln7aEEQBQP9Deb 0LFaL2O+ScoTTNmhpz3OrHepocjy8Kqe7mwIm0R86HbpX46xGsGNGyNGY88bZJpRpbka dkDvGkdZ3KoFPg5mWolvNXzOZutnHWokU9JF/Za8KunlKb+i3Q93LbwipSE1riqSCMAB HiYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766989913; x=1767594713; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=z4kGK+44l58UGutVX6T4zr6zgIMspksNRCZEaJaRexw=; b=Q98XhermnkblAuEpPhMZ2wSQ+dAFXhmzPxTHWkgxsvsRYiHX5pVj/EEajHrWOpc5c4 AF2fMxqRvuIlR4IyhhVvbHDutsLsqPcD8pSxrtG0Y5r2Ed/TOOIyNGRtH7ayOKr4x/Uo mZgOZnGzNC6Lk1IekP+L3yx4YJgTZa+jDIoJsYbHyIofE3n4CPdZn4QJcDRUNw7jJuGD z4TXWEiQ15GoJmt6pD9H8vzEgen3s7hlwYsi6LEsb69fdz+qsEUEc0n2ZoeSqcdk1doH A5QR+GhrIe423rbBFHABchkj5Q2zneSd2Ze0ghs1xbUN/zZancMSAMNyy//6e3iGdoXf 6gtQ== X-Forwarded-Encrypted: i=1; AJvYcCV/p8qwUwPci35J1hCvU68HdE8Cnfq0OUJ+7rGkR6iC3mZlPpcVc65TYTXefkpsLVbZZv4qu9YtykFkowQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzOKcuN2AcFhXCo5eVNaaaH8R1UpF52oJNPi+ITQc7BKGYtz/7V eCuq4+EB5XvAVnuAljsAQuabOOdk2CwkVZvTybSUNBIE5B5pFUTnr+pSAqls8DVTG4+LIVDQVtj MQct9/LbbHSuqpl+NhdzsfPJK8VOGDyrIDfAW97ej7HR9o6CwLNYhQg5V6dYjElIvtpQ= X-Gm-Gg: AY/fxX5RsaaHCbYIaHl3vCPH3KSbjlohTbYAZD5hnCmvigqayyNwJumVsrTDBEZ+cV4 +3i3OisrA74/Vu45b9DXzLyE/gzkrpLhCi/r9s4HtBTDXgej/+ALPP444kkypn0HhE/D2oztRno KZr5xKQRrdIJkL5QmUNZg0JxMDk4JggnzRLDFzNCJ9xjXnPJ2Ztj15uXfFhCPJVWBhJ78obCXg2 JgkiLqvCMEyWAePuBECTEKQYC3dqe6rOmILYklFKleyZkA3Vek1cwdVe4YvhVExHHyiDaabEeog iXAZLijAj6jUlUxAwB6pzu86xtnI1NOox1DC01f5K6sRrph3ywJJITkBcbHEOEHKjgorNgkRiTp 6zyR123GIDawxi2vn6eM/P6Ibw8F6OJ9X9LzyXis3fryVqV0= X-Received: by 2002:a05:6a00:3e2a:b0:7ff:9657:d6c8 with SMTP id d2e1a72fcca58-7ff9657d93bmr28312816b3a.27.1766989913308; Sun, 28 Dec 2025 22:31:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IEHJRw93o1Mu/bxzeZ0T78s/9VVpmIWJ/3GzW8Pdfcb1wUzPtC/9Fcpocb48Dd0PHZQGwaUHw== X-Received: by 2002:a05:6a00:3e2a:b0:7ff:9657:d6c8 with SMTP id d2e1a72fcca58-7ff9657d93bmr28312788b3a.27.1766989912821; Sun, 28 Dec 2025 22:31:52 -0800 (PST) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e797ab9sm28308962b3a.59.2025.12.28.22.31.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Dec 2025 22:31:52 -0800 (PST) From: Dikshita Agarwal Date: Mon, 29 Dec 2025 12:01:23 +0530 Subject: [PATCH v2 4/6] Revert "media: iris: Add sanity check for stop streaming" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251229-iris-fixes-v2-4-6dce2063d782@oss.qualcomm.com> References: <20251229-iris-fixes-v2-0-6dce2063d782@oss.qualcomm.com> In-Reply-To: <20251229-iris-fixes-v2-0-6dce2063d782@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Wangao Wang Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1766989894; l=1786; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=WnRTSzPX7v2ew+XjFwuVlCLDf6VD9eOAqwv7XC3gI2U=; b=VOCuOT+DWm3oykxxHTdN0yd/G4XMeijEfhGx3Pd7X/pmo6NApRAA5OTa8XluOJAmVDCMAhj9v LoMGDeklgmUBg0mjpvV7Y4TOEGpu2WDhYGUvk+ofPNDkmMo1+06H2dC X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI5MDA1NyBTYWx0ZWRfX6XZopaXFRrRZ jqqnnX1ADsOr89zO9JBUDUogAENGSmVuTefnayfN/TTu7GVJUIwkSun4t0pLM7b46dlH4+oTFVn tFvReXEdhnjvFLYi3pm2qewz0PXonbOqs0HmA/Is+Aj0TAvB0y8IDeRZD4lhRO5t+SND6D/DBj+ XThrjzVTkbci0qHEexgut3+yHjOe5P2Msdnch6vcwwgupE4Hj8s+qrJ642OX64ErtwcpbENmgu5 fiho/mBKkxIW858n4gUhu2RB5C6R8wH5L+gwTpOTj+vQsTLLzhPkTDLupqR/WfNqt1JiMC2Cjpq xsEze1jCedWlSR0u+d+msvrM/cAMojVlN3pAjATPBpOdc+6ft+bOOJK0swDb1ih7Mf980DhEipi BbpvZ2INqcBbhW+3TBVg24QKKVtI2f45uDyWw8rV2fWuNvCGO22ayxlSa+c/o2GzWSbrmWpIQmy ebpDMvCA0oamw76Jcmg== X-Authority-Analysis: v=2.4 cv=UMDQ3Sfy c=1 sm=1 tr=0 ts=69522059 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=miAyyWkRVIhBFoa6HtIA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-ORIG-GUID: QaKn4DexXyrWC7T_a4rsBZVk4ccVPnu5 X-Proofpoint-GUID: QaKn4DexXyrWC7T_a4rsBZVk4ccVPnu5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-29_01,2025-12-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 phishscore=0 adultscore=0 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512290057 Revert the check that skipped stop_streaming when the instance was in IRIS_INST_ERROR, as it caused multiple regressions: 1. Buffers were not returned to vb2 when the instance was already in error state, triggering warnings in the vb2 core because buffer completion was skipped. 2. If a session failed early (e.g. unsupported configuration), the instance transitioned to IRIS_INST_ERROR. When userspace attempted to stop streaming for cleanup, stop_streaming was skipped due to the added check, preventing proper teardown and leaving the firmware in an inconsistent state. Fixes: ad699fa78b59 ("media: iris: Add sanity check for stop streaming") Signed-off-by: Dikshita Agarwal Reviewed-by: Vikash Garodia --- drivers/media/platform/qcom/iris/iris_vb2.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_vb2.c b/drivers/media/pl= atform/qcom/iris/iris_vb2.c index db8768d8a8f61c9ceb04e423d0a769d35114e20e..139b821f7952feb33b21a7045ae= f9e8a4782aa3c 100644 --- a/drivers/media/platform/qcom/iris/iris_vb2.c +++ b/drivers/media/platform/qcom/iris/iris_vb2.c @@ -231,8 +231,6 @@ void iris_vb2_stop_streaming(struct vb2_queue *q) return; =20 mutex_lock(&inst->lock); - if (inst->state =3D=3D IRIS_INST_ERROR) - goto exit; =20 if (!V4L2_TYPE_IS_OUTPUT(q->type) && !V4L2_TYPE_IS_CAPTURE(q->type)) @@ -243,10 +241,10 @@ void iris_vb2_stop_streaming(struct vb2_queue *q) goto exit; =20 exit: - if (ret) { - iris_helper_buffers_done(inst, q->type, VB2_BUF_STATE_ERROR); + iris_helper_buffers_done(inst, q->type, VB2_BUF_STATE_ERROR); + if (ret) iris_inst_change_state(inst, IRIS_INST_ERROR); - } + mutex_unlock(&inst->lock); } =20 --=20 2.34.1 From nobody Sun Feb 8 02:41:36 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C97B62853F2 for ; Mon, 29 Dec 2025 06:31:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766989921; cv=none; b=OXc6ED1SfOc5KGWd+ORj4YZNTxTeToQlsKvcbuMgQZz5puNhfGi5QtqUGgpegH59qPFORm04LFt6Z4U0v6skLuJdi/31q4s9ugfTtnEMnD+PIjJ6/dxdnwF9nw2QqZWzYC2RCWVIIf7XxLVFiwWsTRjfOMYjDsZCsnMit952qrs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766989921; c=relaxed/simple; bh=v55TNg//wC4XAcaHWZTXoCk9GlnNzZOSKMtmlhh/99s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dm3p8CtC+AtYiSlYL05PQGyGQ4hc46qsLB7qXqYIWHs/Vz7VplUcBXzsUVfJHyyhFmxpE1aMqscmstNsDcm0P5CRPrt0QAZTZ0I26YYBgZ4lcVqIsm4eTjXdNpRREtiOJTCJpdD8ZXqp9TY4CHj0XZdtdu8PWvx0P5fl5pyqZiM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HkmE7Aug; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=e0UsHvOe; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HkmE7Aug"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="e0UsHvOe" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BSJn1Uf3721871 for ; Mon, 29 Dec 2025 06:31:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= aaVi6kTxKFVUUN+LstLP4rB1bASy8KXXeuDqCkR8A3c=; b=HkmE7AugOxT9WlqZ z4vMJHPDN1YMVhBrOqgb8GwUUg+VK+8r/aTQ1FKP3T0VI22dWL5Wo+6EznHE/MhS 7db0ooXdMQQUMGZW8aStYKvEfgk06oQSqZHODoia9XtD2ilmnx5FMq+ujHrdjx+I IZBczZbRfI4BdJCeP2kYloStkyiF3DxV2B8QP1Aw++hr559MPncTSDHGt0rO5RVs 664uCrKTnYSTlpBvsC27EkYEMMUyJolLI6uvr70nyWnFWCrAyg9XGcbOVse/KhH+ LhloOoHsEnpF5xFVlUmOgCLWkzep1GsYHvuvWbBqAlX+98A3agzdwjUzUDOFMvoB YslxLg== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ba7hsbjsq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Dec 2025 06:31:58 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-7bf5cdef41dso15317992b3a.0 for ; Sun, 28 Dec 2025 22:31:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766989917; x=1767594717; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=aaVi6kTxKFVUUN+LstLP4rB1bASy8KXXeuDqCkR8A3c=; b=e0UsHvOehd9+Y+5Ve9NJF2nBWG4tnZYtNB+VrOVTExW/QEzT01yWVoi4HqBoQ7SNlW b32UzqZ0eB1K8VxigcjyMQjcfvfn45vs1vCLsuG0MxPxGtmOKzoDhpt3rPZdI+QUR1Nt wDZnIniRm6ES6YMPxtPdcAuoPPT0tZa10Z80zj/zWBbl5pXsQGnbe4VC9ZM/u+0k90xh I8FTxkIcNlMHqVdbxHPeiJmREt2IO/D80q8WOj/XVdTbxiZFUD4AYK9mIX0oopRG8JDD pOG34VbzcvFCxmrDULF2Uiyg0d7pnDybA2o7IgzT6kcDo2vSRxEuWir1GW4h7IGeXtaw kvKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766989917; x=1767594717; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=aaVi6kTxKFVUUN+LstLP4rB1bASy8KXXeuDqCkR8A3c=; b=sW9DhIOPUCM3np26V3PVC9x0knOHh7T4cIT+BpqDgFZFzhV657fvxEMZrGMyG/PlYL znFTpxlxqO2JVg8lL8ql8XqktrJDzEYJqMj5niPXgTFlozDj/niqXmklaSy6Xe9anXzk +nB7MZj3YgtPJZNdQd0Ga5ealkyRh8bogV/kvQ81NhhrqooHMD3cxxXOeDTpYHk6XhAY yBMWnsBjjEScwHgHGrGzDXwot6ZzuXpr/brzp6lhASx1Y7zb6DFYvD++IFW/iPFeO6pC RnrXH/bRPg04NgcFHgqWR79ex0pN1Deripj13PwtWhCsWlYwk9tYhrXGdXK32Whe/AvM GBVQ== X-Forwarded-Encrypted: i=1; AJvYcCXpYaMKdow63MVHjkfLMsCoY409hldIkB8crfxgfQZYQPdiuaogOuEi6aI40Ls4/7sCxPXRMoiZbVn0TbU=@vger.kernel.org X-Gm-Message-State: AOJu0YyATse8DHH6kgZEa95LRcfGcmB7PH9md8jJvn893XdI64Kv7uWp QgDwb0dLrIh0b1mR2N0RgKvtsGkCVuGXpbhW+SysnNL2QH9prUBGyOOio/aJtTfbHetVFNH061C Svn1FXx/m+lLtEYjm5jeEqEOeoGXUtQl44vSMO8IKf8psj7hvbHnrOvuhw2iCBQpar0Y= X-Gm-Gg: AY/fxX62zEHP6YuFOGTdema75/IkEtW2RPiFDnq82RLfosFv85YjiFVEa8Gfoa906hJ XbZj1MJyHMDl0u3CK/L7kbzNIBfgOQ2jSoWJ00xEwcp+wEqfEKr0o+ITCIN9jVjvL9VX9jtgDj3 yM0NQTnaB+m/Yi3RF4gtl8XnjNVas7Hqj3DUZQR5nTdcjUOlkoXyvOw38V1yyV6wBR7hnRp2K8e KCqKf3KzT7ZSP8TsXLWxq/owwySgbmkbF6GMEajXyasTUVtVWVtIRZRd4zOA8r5RDtouOUbrgvr jRNc4y+EWQYEUp9qMLD05NI7Kd86QWcK8fS9nawjt7cVBuYgHMlWfVkIdkDJfr6g8pxShdW7DyX J9qX4js7Qqg9E3dxxDuHMpSsdP4njw+eqiWIJNZYbI0Ur1ks= X-Received: by 2002:a05:6a00:90a2:b0:7e8:4471:ae5c with SMTP id d2e1a72fcca58-7ff67456c12mr24865576b3a.40.1766989917346; Sun, 28 Dec 2025 22:31:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IFX0ThBZeW+BigEL8dzVjUuDuXkQS9otcnHN3QgmHmuY+Fxw19HAteXH2bjW3/rRGKbh+msgQ== X-Received: by 2002:a05:6a00:90a2:b0:7e8:4471:ae5c with SMTP id d2e1a72fcca58-7ff67456c12mr24865542b3a.40.1766989916512; Sun, 28 Dec 2025 22:31:56 -0800 (PST) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e797ab9sm28308962b3a.59.2025.12.28.22.31.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Dec 2025 22:31:56 -0800 (PST) From: Dikshita Agarwal Date: Mon, 29 Dec 2025 12:01:24 +0530 Subject: [PATCH v2 5/6] media: iris: gen2: Add sanity check for session stop Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251229-iris-fixes-v2-5-6dce2063d782@oss.qualcomm.com> References: <20251229-iris-fixes-v2-0-6dce2063d782@oss.qualcomm.com> In-Reply-To: <20251229-iris-fixes-v2-0-6dce2063d782@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Wangao Wang Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1766989894; l=1244; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=v55TNg//wC4XAcaHWZTXoCk9GlnNzZOSKMtmlhh/99s=; b=56U9/cpxgd6FqwYiSraU5YRmgQlKZvQjxUwJu9bnWBH4JEI/08y9dFRLPfHh/+xjtF+B+JGfa NF/6E/wSsUaCkusbqS9QCk8PZnYWdaoDaGsRTI4lYzhdNj5QXhj5WnQ X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-GUID: rjT1sHOPXN9cIUVL5UqS_qiLEclBjHm_ X-Authority-Analysis: v=2.4 cv=O4o0fR9W c=1 sm=1 tr=0 ts=6952205e cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=hJpQIKcYsydMz8RtK9gA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-ORIG-GUID: rjT1sHOPXN9cIUVL5UqS_qiLEclBjHm_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI5MDA1NyBTYWx0ZWRfX4sewc9xdQi+G ZGYVvP/ioF6u4+OhZVbRinozMWWY5RUJzsSnRraeB8JNp5papUercGAjqF2Afz0ktCiH5WIGfuW vTVFNvgNWYheDT/bB3Qv7m5PB1AJ6lt+us4mf1g+9vikXaT1UAv81eYaQsxg4tWtaCF8I2NocPQ naRrsmW+XAgA5VDszc9jedWVupoPX23VV5XU8gnKq6sPtvuEE0NB/jDz0wSQjFMl/KqSXePz+13 F6hsHeaCS142QQ4B911+S9e9KF+JQo9GPCgSf4QxjXDd8MAMibs3dLB+JN9gJ0y2ogSVcWfDORv liJnLCUSrcZzjaFYHh1YAGQN13xRY6jEceN1rUgRr+Q1ceUoBi56BTn7F3A2JdisTcc2K9GQkv7 R/KaxJ5ouGsyIpdAEnaCyzilOTYBoiuegqYr49vn6mP9HXXg4kn4y1eCKIxAoHzQVAtlFfLMGA9 BWGB0W13kVr0YbVtOGw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-29_01,2025-12-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512290057 In iris_kill_session, inst->state is set to IRIS_INST_ERROR and session_close is executed, which will kfree(inst_hfi_gen2->packet). If stop_streaming is called afterward, it will cause a crash. Add a NULL check for inst_hfi_gen2->packet before sendling STOP packet to firmware to fix that. Fixes: 11712ce70f8e ("media: iris: implement vb2 streaming ops") Signed-off-by: Dikshita Agarwal Reviewed-by: Vikash Garodia --- drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c b/dri= vers/media/platform/qcom/iris/iris_hfi_gen2_command.c index 6a772db2ec33fb002d8884753a41dc98b3a8439d..59e41adcce9aadd7c60bb1d369d= 68a4954f62aef 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c @@ -963,6 +963,9 @@ static int iris_hfi_gen2_session_stop(struct iris_inst = *inst, u32 plane) struct iris_inst_hfi_gen2 *inst_hfi_gen2 =3D to_iris_inst_hfi_gen2(inst); int ret =3D 0; =20 + if (!inst_hfi_gen2->packet) + return -EINVAL; + reinit_completion(&inst->completion); =20 iris_hfi_gen2_packet_session_command(inst, --=20 2.34.1 From nobody Sun Feb 8 02:41:36 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF7AA2D0C8B for ; Mon, 29 Dec 2025 06:32:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766989925; cv=none; b=ILqL0VwzHRPYKF+qtUGnDtsgnzj6JrdIqfuVd6Q+TIOYbXAc9GG9SG/hyVy9WZxpaZxXW1P5MIu6yFTsrOnThV4ZiotVAUDqQyi4Z3HbZ9pac47G/vS5z04nJ6qvU09xWqGDJS8EwPWAcRozFJs63uWOAsH4euQKfnbp+O+BiTI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766989925; c=relaxed/simple; bh=veRINet6awseWXYxyYZwNw5ZPUP0TfC17AyTv/ndWhU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AajPRwPKVc+lGNd196vRh/67x20HqB1Zq/dBfL/9q4YzH387H56EzIXdwl3LACvmSnmNo8RcLAIO7M5Zznm1/ZUziAyPqHbT2s2MDdEzIy4t16ml9hXEoK+Cf/FSdgclu6x1hRS39RblM6RXyjSX9h8z6PlWCSxlnvc3Iin32wE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QVNi23eL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=F1ruviQZ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QVNi23eL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="F1ruviQZ" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BSMxDw64087696 for ; Mon, 29 Dec 2025 06:32:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uNmr2Qd+7VE+ZXIXnd9eWAuqPwXoo5DhvxtgK5dWg7k=; b=QVNi23eL1jVD6PLB +PZR4NtMBlXbBD0TX/zDtQzoJZMgMKebRr1UqbyW0CWco22dtHdq69PVTDrnuT+J 8qIpabcrzvOa6mUJRKAWqEldyPrz54TlldXp7SHk9BMrosf42XE/zvSCVSTYgV/d GRWv1gGb0VgfWQ1iTUI5P6nZY9Z03oR3PtLf7RAROZtdqMPfC11UGVX4R12N+MSY didDoE3lkrA/t9OVMcO+dPMwuEb+8qGmNna+v+G1Zx0e//xklshYxHxMpKX1kn0y 2QhGr73hCDDayv6OblFZaY3Dz4zJKaEkHf/J11oiAGlNgVbSlnz/PO19uQsLJ9Ao BUZR8w== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ba7hsbjt2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Dec 2025 06:32:02 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-7d5564057d0so20918905b3a.0 for ; Sun, 28 Dec 2025 22:32:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766989921; x=1767594721; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=uNmr2Qd+7VE+ZXIXnd9eWAuqPwXoo5DhvxtgK5dWg7k=; b=F1ruviQZ9IDZQ7+MNAUZMCGHMYmWr2gq0ZYU2ybWXqdq5qTUmhQoXMm7quMiGq13E2 WBLHnIPzgEfsodLLUQdKZHV84NY5uVvKgmC/Q37rMsAWRJBcIZvYJwCw0qQe1jB1SxLL RFyoB7i8o+rOFaqEJSyXrBCBXGeLa3Qe5NcDaerm9OQX8FiNiG03qSiCnWsObEQQ2ci3 MoDfYNr/CK45alVID9KfpQcL8ttIeaBhwsHnJiPy3PkyyJisYNm24LSqwDmLxCB2+TrB ONg3iL5tH6cg/0b1faX6CFse5UmlU4c11TGDwPTcVWxxrHoyiT/jF6X0pj7kguDhElcO uJKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766989921; x=1767594721; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=uNmr2Qd+7VE+ZXIXnd9eWAuqPwXoo5DhvxtgK5dWg7k=; b=mUQ5Tdx84uHTk9Do+rR1YWUwnNHuVkpGFo3OlclnW4zfkBM5pEmlDf3WgT2h2bX+SZ Ysh5vjN6Car0XO3oker+ohPv3wVsyHlWczJjqBbqFfnmJ9LMqr0HmAHAYTURbWiO8tEK E69sEEsbhIYZYU+3DIKUmojV3cRix0Jn7EoOAK5zhBAoKQSxHPDLdokZirn3jpR7Uls+ n5i8gMesUuCb0cFNbLkDqOTfN50EQqUkzV6oPA0wuU1ml6W3y22S8lgnZZMyu0WbFteN iU8U0Z9yXNdqS8F2kwQHf4x2lyfK0Bmdd7Obp+ds7DECbW+KfZDmFhqBxeitMoWfACPx CT7g== X-Forwarded-Encrypted: i=1; AJvYcCWxi8Ms2KSQDlLXsbxUlvnmlkiszBmIODfo0Bl1g71iyz6dDVXOlQacyeDFeL3dprZyXn9nzSrzUKJQeBo=@vger.kernel.org X-Gm-Message-State: AOJu0YxdUZFDYiUDGm13DhBwkYpIpY5er5RHgx3HLzf3LpcElBAX2oA8 /CbJUqcgqEVEN3IdClr06TWX+RvoCCkpaQpAtYxtrGy+PeDNYYhEMRh00JMDklZyVVE9J0ndm/d Kq3I2Aqc1y15CDg6RWie9E8QZur2H702Oj/Q5v99ieVCb7PpcnBsIMJVyfRgEF2hzTyg= X-Gm-Gg: AY/fxX5123VacAEWPATpPsCN1wMmk5Jqsr4HdzU2eBw1S2X6+Du43FB1omh0xFYcnKg qyUIlMyw+Sgz60JnbF6wNCNUcq0gBBGvG0GO9hNEh84yclrPxXbhueKYjTo4mPl1CSj96eiGe9k EjDHYOe8wvdLQ5Pc3tA/lDQtjw1mNGvkUQnvyR8qxcS3bVBWrp6FnbsPQcIVj1BUnxirPSafODw 8xdoeoM9NmzdsDar4sdOt8D90+3C5dJ8wl8on3WGbyI29kiD7L/NWFdPJGtwOt0bmKTlvtCkmFS BJfZZFVQcJgjr9kx+nyHPIGF0OcL87Ghvcrj/vny31kY7mC8EgEtkdc8UkRDApLonDFo9aqUO+o OIG1R7/2zJ7qGxPeTPl1mlsLKRkGLxGiDcYdJdIz1r1JI1aI= X-Received: by 2002:a05:6a00:8014:b0:7aa:e5f2:617d with SMTP id d2e1a72fcca58-7ff651c3519mr28501222b3a.30.1766989921327; Sun, 28 Dec 2025 22:32:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IEuWNnJoqqmKSK7EBdRRCNpr9qpD2VwNZsE7kTp8/v1msgyAvsObPIWGy+/LSRKXlLFzuuqKQ== X-Received: by 2002:a05:6a00:8014:b0:7aa:e5f2:617d with SMTP id d2e1a72fcca58-7ff651c3519mr28501191b3a.30.1766989920730; Sun, 28 Dec 2025 22:32:00 -0800 (PST) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e797ab9sm28308962b3a.59.2025.12.28.22.31.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Dec 2025 22:32:00 -0800 (PST) From: Dikshita Agarwal Date: Mon, 29 Dec 2025 12:01:25 +0530 Subject: [PATCH v2 6/6] media: iris: Prevent output buffer queuing before stream-on completes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251229-iris-fixes-v2-6-6dce2063d782@oss.qualcomm.com> References: <20251229-iris-fixes-v2-0-6dce2063d782@oss.qualcomm.com> In-Reply-To: <20251229-iris-fixes-v2-0-6dce2063d782@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Wangao Wang Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal , Vishnu Reddy X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1766989894; l=2070; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=ToSP8yw7UHrhfrl6kjhmcJJUW4s5zMFqgwQlqSSUXTg=; b=BBGTPZuqvbZVANhDb1b6tnEdSuZz3vjpRe1l8N0jbAO4T0nOyAX42ahp0+jMiyrVleaN7FZiT F7wbzFHue8kBksFbC4KBNJeQf3YQurHCrnGVmD3tnkzh15mCx6Lzefj X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-GUID: 6KLZAvsfP7VVUeBxifK5U2ARoxeGFO-r X-Authority-Analysis: v=2.4 cv=O4o0fR9W c=1 sm=1 tr=0 ts=69522062 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=k0qMZAR7W_WzNVtuHNoA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-ORIG-GUID: 6KLZAvsfP7VVUeBxifK5U2ARoxeGFO-r X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI5MDA1NyBTYWx0ZWRfX/4duiUvQOF24 t6vZFUeqtAb76gnANdh1BknOkcL7bp8EzRPvcZKoJ1bbsmob3T1bhjyco4padSkzXdyJRDE8GR6 l7N8c8U9Q1lMW862tjMMM/hGDdv/It0aJanfcBnAnxvxn2wZ2tg8EVxnUqaZZOL0moVYVpZtY19 kL+vaWHahnNvbZjjocBlSGkd2RKN5KC7bsLBGCVWX3vZrbI3uj+wkAdPuUye95DcaW178UF/Txj o0X3CqBe6EASV5kvVjqrxpn35MJDlbSjWHpFabokoHvdpbeTBv8nI9A7BYQcfbTlHphotOkizFO Bv8FjGdJqE96F4axo7m7EtKZmHqJhpDuBW+e6e7NlOn6/xIcuo6P4/JcH+4GBAvYXH7lpPiPLVR LZuYaK1qOgzQiYjwJJgY6RMYR89hBEkwsEWJm0MogvZmmyNqwAFLFDt4EKD/VzCmYrIhHdGzyM8 SYAnHV9wlwSWSL4m4lw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-29_01,2025-12-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512290057 From: Vishnu Reddy During normal playback, stream-on for input is followed by output, and only after input stream-on does actual streaming begin. However, when gst-play performs a seek, both input and output streams are stopped, and on restart, output stream-on occurs first. At this point, firmware has not yet started streaming. Queuing output buffers before the firmware begins streaming causes it to process buffers in an invalid state, leading to an error response. These buffers are returned to the driver as errors, forcing the driver into an error state and stopping playback. Fix this by deferring output buffer queuing until stream-on completes. Input buffers can still be queued before stream-on as required. Fixes: 92e007ca5ab6 ("media: iris: Add V4L2 streaming support for encoder v= ideo device") Signed-off-by: Vishnu Reddy Signed-off-by: Dikshita Agarwal Reviewed-by: Vikash Garodia --- drivers/media/platform/qcom/iris/iris_vb2.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_vb2.c b/drivers/media/pl= atform/qcom/iris/iris_vb2.c index 139b821f7952feb33b21a7045aef9e8a4782aa3c..bf0b8400996ece5c9d449b99609= a302da726bf9a 100644 --- a/drivers/media/platform/qcom/iris/iris_vb2.c +++ b/drivers/media/platform/qcom/iris/iris_vb2.c @@ -193,10 +193,14 @@ int iris_vb2_start_streaming(struct vb2_queue *q, uns= igned int count) buf_type =3D iris_v4l2_type_to_driver(q->type); =20 if (inst->domain =3D=3D DECODER) { - if (inst->state =3D=3D IRIS_INST_STREAMING) + if (buf_type =3D=3D BUF_INPUT) + ret =3D iris_queue_deferred_buffers(inst, BUF_INPUT); + + if (!ret && inst->state =3D=3D IRIS_INST_STREAMING) { ret =3D iris_queue_internal_deferred_buffers(inst, BUF_DPB); - if (!ret) - ret =3D iris_queue_deferred_buffers(inst, buf_type); + if (!ret) + ret =3D iris_queue_deferred_buffers(inst, BUF_OUTPUT); + } } else { if (inst->state =3D=3D IRIS_INST_STREAMING) { ret =3D iris_queue_deferred_buffers(inst, BUF_INPUT); --=20 2.34.1