From nobody Mon Feb 9 08:36:47 2026 Received: from mail-m49197.qiye.163.com (mail-m49197.qiye.163.com [45.254.49.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 758933A1E7C for ; Sun, 28 Dec 2025 12:52:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.254.49.197 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766926361; cv=none; b=G2xAFVOP1/fLazijfeIrwTAOWyjS93lgSnwc0XswUtUHM3kUXSJldP4dW2EI8/2YxHDFIci2MwbgcU0GytZ4U779Kzq8+Y5dAWooI1ymuD3mhfG3Gk1kb/gtue3n1tybHEe2VDJ0ksaBfc6qJxrAvEasA8I0Nf6Xy/fXH6R38+E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766926361; c=relaxed/simple; bh=OvoUsiw8LRPSZzZAK6HpVc0yCoum+zweWRY+jEicICs=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=iFDeA4fHygFwFwxhdYk/reo+s/+p0KgJiNHZHZmhp9I1F8P1q596eAS4DQPMCVNOqepWaQLMSWLrMjiq9Glqymrq30zdZ3EMqIMF0YEjAwrahn55lX/tlS+JEa4BrWBO3sLUVjIuiHYHVQymwvYuSd6OPdHWhRSJM4i2Jlhe8C8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=seu.edu.cn; spf=pass smtp.mailfrom=seu.edu.cn; dkim=pass (1024-bit key) header.d=seu.edu.cn header.i=@seu.edu.cn header.b=OAnEa3Es; arc=none smtp.client-ip=45.254.49.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=seu.edu.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=seu.edu.cn Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=seu.edu.cn header.i=@seu.edu.cn header.b="OAnEa3Es" Received: from LAPTOP-N070L597.localdomain (unknown [222.191.246.242]) by smtp.qiye.163.com (Hmail) with ESMTP id 2eca68e63; Sun, 28 Dec 2025 20:52:29 +0800 (GMT+08:00) From: Zilin Guan To: matthias.bgg@gmail.com Cc: angelogioacchino.delregno@collabora.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Zilin Guan , Jianhao Xu Subject: [PATCH] soc: mediatek: SVS: Fix memory leak in svs_enable_debug_write() Date: Sun, 28 Dec 2025 12:52:26 +0000 Message-Id: <20251228125226.3684517-1-zilin@seu.edu.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-HM-Tid: 0a9b6504738503a1kunm2087d54ba59a2 X-HM-MType: 10 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWS1ZQUlXWQ8JGhUIEh9ZQVkZTR8YVkNMSUgaShkaGk4dGVYeHw5VEwETFhoSFy QUDg9ZV1kYEgtZQVlJSUlVSkJKVUlPTVVJT0lZV1kWGg8SFR0UWUFZT0tIVUpLSUhOQ0NVSktLVU tZBg++ DKIM-Signature: a=rsa-sha256; b=OAnEa3Esg5F/RuDPMWXgpWTgHSbt651V78flXM57uULzuZ7dmeIP+CqB6Do3B4n99tEQU98nBYY9BVQN+cnhAfm9pMtspYgTaX664IU9ZA2lW6oPKcLLDzDt1W5xaNpWlK9hljyoh3UklcPazEuFkfwW35eV7F1x4QFE41klpek=; s=default; c=relaxed/relaxed; d=seu.edu.cn; v=1; bh=RXjIvzU1gbf8TI2izoZUqVMwlk1JSJtF8HkNxMEyl3I=; h=date:mime-version:subject:message-id:from; Content-Type: text/plain; charset="utf-8" In svs_enable_debug_write(), the buf is allocated via memdup_user_nul(). If kstrtoint() fails, the function returns directly without freeing the allocated memory, leading to a memory leak. Fix this by freeing buf before returning the error code. Fixes: 13f1bbcfb582 ("soc: mediatek: SVS: add debug commands") Co-developed-by: Jianhao Xu Signed-off-by: Jianhao Xu Signed-off-by: Zilin Guan --- drivers/soc/mediatek/mtk-svs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c index f45537546553..691e7e6be654 100644 --- a/drivers/soc/mediatek/mtk-svs.c +++ b/drivers/soc/mediatek/mtk-svs.c @@ -799,8 +799,10 @@ static ssize_t svs_enable_debug_write(struct file *fil= p, return PTR_ERR(buf); =20 ret =3D kstrtoint(buf, 10, &enabled); - if (ret) + if (ret) { + kfree(buf); return ret; + } =20 if (!enabled) { svs_bank_disable_and_restore_default_volts(svsp, svsb); --=20 2.34.1