From nobody Mon Feb 9 12:04:32 2026 Received: from mail-m155101.qiye.163.com (mail-m155101.qiye.163.com [101.71.155.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A05AA2D838E for ; Sun, 28 Dec 2025 12:55:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=101.71.155.101 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766926539; cv=none; b=oekDDUplnVMhHZyYeHhg353g74YfOnXQ6oxwJy+jtWEPzPXCzeLRjG+HmH4UNVkoFOv0o6o0hdO/ygrcBp0jXnRjt1HhK/2VvjHpzWD48zk7Gf40fo7+g1A8Um37q0MUuysIKrjW0r3ynLc0K23SuwuNXp4vYz0irGKsVTJyLoQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766926539; c=relaxed/simple; bh=oisHyFdC/FZAnAmV1N5rMd6XwAnmsCSCXoAbrWYp4Q4=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Z1LKOr0xIL/6IFFrINkRjnlx40dFd54eBTwtO3YEemNKkN1/NzD9iUVn7RkEiciUAHgBCtXDu52OxgJ7FMkkWpdAcXckUlMMhhtg4TH7AAqWerBNYJhqw7rusB3pEm0EspuOm9HwXYqLJtMY+FYFnCEoAqYV5zBK+K8WHTXXY6A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=seu.edu.cn; spf=pass smtp.mailfrom=seu.edu.cn; dkim=pass (1024-bit key) header.d=seu.edu.cn header.i=@seu.edu.cn header.b=S6sLSv2U; arc=none smtp.client-ip=101.71.155.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=seu.edu.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=seu.edu.cn Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=seu.edu.cn header.i=@seu.edu.cn header.b="S6sLSv2U" Received: from LAPTOP-N070L597.localdomain (unknown [222.191.246.242]) by smtp.qiye.163.com (Hmail) with ESMTP id 2ec859ee5; Sun, 28 Dec 2025 16:19:30 +0800 (GMT+08:00) From: Zilin Guan To: dpenkler@gmail.com Cc: gregkh@linuxfoundation.org, matchstick@neverthere.org, mingo@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, jianhao.xu@seu.edu.cn, Zilin Guan Subject: [PATCH] staging: gpib: Fix memory leak in ni_usb_init() Date: Sun, 28 Dec 2025 08:19:26 +0000 Message-Id: <20251228081926.3503643-1-zilin@seu.edu.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-HM-Tid: 0a9b640a869d03a1kunmfda3ed949aeaa X-HM-MType: 10 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWS1ZQUlXWQ8JGhUIEh9ZQVlDTRhPVklJH0pKQxpOHkhNTVYeHw5VEwETFhoSFy QUDg9ZV1kYEgtZQVlJSUlVSkJKVUlPTVVJT0lZV1kWGg8SFR0UWUFZT0tIVUpLSUhOQ0NVSktLVU tZBg++ DKIM-Signature: a=rsa-sha256; b=S6sLSv2UhVr5aWIRewNYKlyxyw2arbVU35OiRZofxITXNSIZlpq5kaqgEOPDv0XaWhVx6nF3Q+aZM80Wrpf8DhE9TOnAdEl+WgRRvuu3SjqiMYhRI2xQ5ONDnNhO7kCy6S80nzb3tiaVtCKbhVNfrJxrGocXYejxedSlw3RkYrc=; s=default; c=relaxed/relaxed; d=seu.edu.cn; v=1; bh=r/GcHQ5oQ3LBmxTQqwj7K9hy+uOkryUD7/3mkiJTALI=; h=date:mime-version:subject:message-id:from; Content-Type: text/plain; charset="utf-8" In ni_usb_init(), if ni_usb_setup_init() fails, the function returns immediately without freeing the allocated memory for writes, leading to a memory leak. Fix this by jumping to the out label to ensure the memory is properly freed. Fixes: 4e127de14fa7 ("staging: gpib: Add National Instruments USB GPIB driv= er") Co-developed-by: Jianhao Xu Signed-off-by: Jianhao Xu Signed-off-by: Zilin Guan --- drivers/gpib/ni_usb/ni_usb_gpib.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpib/ni_usb/ni_usb_gpib.c b/drivers/gpib/ni_usb/ni_usb= _gpib.c index 1f8412de9fa3..4cf45e94c750 100644 --- a/drivers/gpib/ni_usb/ni_usb_gpib.c +++ b/drivers/gpib/ni_usb/ni_usb_gpib.c @@ -1802,7 +1802,7 @@ static int ni_usb_init(struct gpib_board *board) if (writes_len) retval =3D ni_usb_write_registers(ni_priv, writes, writes_len, &ibsta); else - return -EFAULT; + goto out; kfree(writes); if (retval) { dev_err(&usb_dev->dev, "register write failed, retval=3D%i\n", retval); @@ -1810,6 +1810,10 @@ static int ni_usb_init(struct gpib_board *board) } ni_usb_soft_update_status(board, ibsta, 0); return 0; + +out: + kfree(writes); + return -EFAULT; } =20 static void ni_usb_interrupt_complete(struct urb *urb) --=20 2.34.1