From nobody Mon Feb 9 14:15:38 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 129E12D73A8 for ; Sun, 28 Dec 2025 17:21:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766942518; cv=none; b=LBxEvJV+QUVJHGvTRN6Gk000CngcS4e2eMSM8MdJ9C57Xyz2rEKZgYZstuPSlx4nRy/8o+tIGgxZPThGwo8iXVWBHvrYB0vuV5FweCNs60xq2EManlOMYBb8fWNgNe65pX6vCzomXFmINff+WXEsB5pooj8v+5JFMaw8Jnei9RY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766942518; c=relaxed/simple; bh=H3BLuh7aucG+4twvP/0GQJX85YA5nUk09wN5sJ0vud4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Whje3g7t9Zli7v3/IC8xY+4oQmm7zvx6oPiFD0iy4YSJ9lRtrjXf6+aMrLP4L1c3h+dFBQWTTvm4CPBy11+x8Jn6eobqf+GVnZERuC/IAN4vFHeF7NcK7lqPeTmnVZ/7LPVi6FzQCN1Z37PXGoY3Lbm+5yFnvFiVkRG49gqmAok= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JEih0MQJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VD0N/aOd; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JEih0MQJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VD0N/aOd" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BSGpWP32583476 for ; Sun, 28 Dec 2025 17:21:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= M990uSOPBnzSQyXKdb+7ZT9yeTvRXfVYC9QFNhhhHfQ=; b=JEih0MQJoOeD/dP0 6h70r8Oejwzp8CNd2hman62RK6uLIxo7z2CKaj/HxKVt+r64Xusv1zB/iSx+CmZo hdhUQtT4P3IckCAHmmOTPHD1D5z8qQHCvP7MqBaqE+rrkXOCfiPDYQG4SDhYVM/w Bz3HJzMLJVvI8/YNNMJpbDYO57srM/rfrCuVPTLD7ov3aG4ehTE7zNiw11U0ZVRr BcnuXEu27tfIXlas0c+C2jY58VMbjtsO0LllKdrlf9ctMk3pNKVdGWXWAsdr4suk 5r+nsg6p2aeG1DtjcaidznjhQt+Wk/Ug4EGYjSpxy+X//cM24jKmvaV+XLBhku4c fSfR1g== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ba4tntpar-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 28 Dec 2025 17:21:55 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-88a3929171bso176776316d6.3 for ; Sun, 28 Dec 2025 09:21:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766942515; x=1767547315; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=M990uSOPBnzSQyXKdb+7ZT9yeTvRXfVYC9QFNhhhHfQ=; b=VD0N/aOddRjOal8j/nd3mSV28hOFuUVpBjta/ulDZTLTp9GtZoURzzPwl8HZrm2QON dLdxVnL37sazQ+l2Pp7p+KMjYrVsx/rKC/Oq2K0Jk4iTp/Et9lqdHrWCjc37xL7LqTBW rXpUd5kdTaFubguJJmULave4eB+HIPwhceJYP8HCdg99+oOuS2f5MP4bpzTJNQqSjg3u vuYPU/oKOrnzqRqbiPDM1l9mNuc3a0/538oXNuIMsSQB4wwMfe3OyJOysZ0x1DFeu9PU VxlpCkx+wJr6IK1dRHeUfRX6U32v37pDIbsqKhXg4JPvAEYmLL+YnhduXgeQ3z6mI8rg D5Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766942515; x=1767547315; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=M990uSOPBnzSQyXKdb+7ZT9yeTvRXfVYC9QFNhhhHfQ=; b=UBnt9G8oR3uD5N35weUFO2yt+n7Cmc4uttCxHEJ29kOGcDD9GL1lbUCjhMpIsJ29EU qBaoiXcKjOD+I5P4fGFUYE2apmwWomCZd7psKD4AWgsyH2z+AVuels30ZmLmwxcLL9Kh PmcD0V1EBAOy2fFmCFa4K+utyFXyXAtslPT8Yble42lkuYOAJmuYuDckDk90P45Zztz1 NnV5XFr8gcCOfsU2EgY/Q0lUhmvozaXyIRwVZn9tJfIcFYIovZTX2QueqswQJVy51eJb 3zrwoWRnnMKU5v7YFZeDrfvcEFwNTy9CmoPvNgUA2Xw7qJTx0k9TZb4pK2fCZL5g5zTS ghdA== X-Forwarded-Encrypted: i=1; AJvYcCXwl9NoxROJiuQnemPuX3Uazuz/vnlieRFXfoqT8/adHYyRIQaJ8F1ORu1Z906r6Kt1by2R8Sa5NEKLdTU=@vger.kernel.org X-Gm-Message-State: AOJu0YxxER4KA9YeVNSUFNxYHySceKnBIMuigZsuCG4++gIX8c0k2Txx hiMbO9SUE5TPDrfrhfjxnoCBq5Iz06Nps9KfTQfpa5KrFyohy5yWiYkYqeDs/+e8a3yJTM+wRJQ oA3u2FONIkb6DF1SfkuG0bognw0JThXW5HZ/hgw/nYsZf+00ESmld3uHCe37To4EFVmA= X-Gm-Gg: AY/fxX7I43/7qpPEhA4y71GpzL235P+FmJFDPqWIp2kp3vGVsfPpLDG/BTMcvNne3cZ IXVpW3e8Ri75g+/boYae7K/CBDTbK0/21eXTHnyZXATE4V/W84pQsKKN3wPXCzqTfyjHi3s9xPC HSnu0G5TsIlnMCTMymehWwTht2EP8nGmz/+8SE107+cGxBSH0CI0ujxkygfJvnNZfA/45DUOQsc NE2ugcJYR4hwCh8nHpg2Pb8qzS9JITtkdYxq4xpKNCjL4rGqJ5471pYx7DSCInhQG9Ys3Biig0h FxzU3THGpudi5TVAurNjlxSy2Rs9Va3ccv3ZlYsM3DNkUV6+qonjjBdawRqzSxzETbk/oOC3dea xR3+4yhOZsI2BPG2p3b6tNBGmRfLqM+lrldpxiEotatv2msGbM6MnheWT2A/FbE5eb9u9Jo3JoH Mu51KM5YyTp3VmZxV7OP+azBo= X-Received: by 2002:a05:6214:498d:b0:888:81ad:16b0 with SMTP id 6a1803df08f44-88d83d65945mr487316546d6.53.1766942515420; Sun, 28 Dec 2025 09:21:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IGcvwcNsJxfckigfIUDZG6GhjNkeQtH1Am+DpUUIQ8I+HISHgd+uxyslQbQQtyZyzXMCQbCGA== X-Received: by 2002:a05:6214:498d:b0:888:81ad:16b0 with SMTP id 6a1803df08f44-88d83d65945mr487316036d6.53.1766942514996; Sun, 28 Dec 2025 09:21:54 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3812251cfffsm76871031fa.19.2025.12.28.09.21.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Dec 2025 09:21:50 -0800 (PST) From: Dmitry Baryshkov Date: Sun, 28 Dec 2025 19:21:39 +0200 Subject: [PATCH v4 7/8] drm: writeback: drop excess connector initialization functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251228-wb-drop-encoder-v4-7-58d28e668901@oss.qualcomm.com> References: <20251228-wb-drop-encoder-v4-0-58d28e668901@oss.qualcomm.com> In-Reply-To: <20251228-wb-drop-encoder-v4-0-58d28e668901@oss.qualcomm.com> To: Jani Nikula , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Christophe JAILLET , Jessica Zhang , Louis Chauvet Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Suraj Kandpal X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4480; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=H3BLuh7aucG+4twvP/0GQJX85YA5nUk09wN5sJ0vud4=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpUWciJUZdvn/acE82l+E9R4nQ4JakRQmCYafIQ s1/38m2bxOJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaVFnIgAKCRCLPIo+Aiko 1QADB/94vJUoLDr35ABGIIs+eO+dZA4cM5aet0Kwybz4Cjxp3N51brjCEaXdsDgsZ/90lPqKS0W b+f3i+yY8HvyVuJgS9YBnxcf9atoRGg8FzThjUU/oStVtsQ57eyRwG8DI125wLXdZsp23qPsGoI 9XvypdYZSQ5t4C33IrSsOQMEFDw8piZrNPTp1bNE0W4vlz2GHGZIeTDYqMHRtUBWSVXw3NHwxLJ jGLBjX26NQPfhMfNzJVJOndj/8vSZedyk9Sfl3/5SKYZuUKicSdIb0f5pkEXuSiSRIGdDJtJw81 tOc2aBGjkj95fKSJpzHX/TM82L48RAYFfNuvGKSYaw59kw40 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=G+YR0tk5 c=1 sm=1 tr=0 ts=69516734 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=3owybDqXPaZAjLikVYcA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-GUID: mVcKFiHc8LuPKvh9xurulUT3QWEBYyUJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI4MDE1OSBTYWx0ZWRfX55J2fB8JSBJp vh3esDhGPHA0tRD5AtQzIAInEaHhAzrHuHmlpymtq5uEn1FzQe4F9rQzzut2xQQC9OPlFGC8LeY YJvnBP3n58kusoyWtwu3mnQ9SMSyl1J3StonlcPkropOkG+3VSy0Haa0xwy6nnTFCDoc+lNtDEJ BcwbqVJLbMhYRsTwusR5mGoraplzCpjTGfas9LiUlZVVlRCLYHWgqMlgHRff1XplwDi69s4TOeE gkW7+z5Nb5o862bFZWNOf3j3b0L2t50JVlvvyE08+bfcA7IMY2r4/1UhwDyHk+j9qixoVoZaaBS 793ixECMIUlzbXtp6AQs7RHiqF1e96k6M0Im/mYJtiM4O16QijrhQW4dmG9WfHCaDIGkrAqPmGm okymy2swUYUVMZfUZR/8xZBQ9ANibuAzaJnjs6n8b3IH7y6QbY1ohXrPL7zP07UnEjuPJYBaqKa aQKds1LemFjO5SyrK1w== X-Proofpoint-ORIG-GUID: mVcKFiHc8LuPKvh9xurulUT3QWEBYyUJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-28_06,2025-12-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 bulkscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512280159 Now as all drivers have been converted to drmm_writeback_connector_init(), drop drm_writeback_connector_init() and drm_writeback_connector::encoder field, they are unused now. Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_writeback.c | 55 -------------------------------------= ---- include/drm/drm_writeback.h | 18 -------------- 2 files changed, 73 deletions(-) diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writebac= k.c index 95b8a2e4bda6..1a01df91b2c5 100644 --- a/drivers/gpu/drm/drm_writeback.c +++ b/drivers/gpu/drm/drm_writeback.c @@ -142,61 +142,6 @@ static int create_writeback_properties(struct drm_devi= ce *dev) return 0; } =20 -static const struct drm_encoder_funcs drm_writeback_encoder_funcs =3D { - .destroy =3D drm_encoder_cleanup, -}; - -/** - * drm_writeback_connector_init - Initialize a writeback connector and its= properties - * @dev: DRM device - * @wb_connector: Writeback connector to initialize - * @con_funcs: Connector funcs vtable - * @enc_helper_funcs: Encoder helper funcs vtable to be used by the intern= al encoder - * @formats: Array of supported pixel formats for the writeback engine - * @n_formats: Length of the formats array - * @possible_crtcs: possible crtcs for the internal writeback encoder - * - * This function creates the writeback-connector-specific properties if th= ey - * have not been already created, initializes the connector as - * type DRM_MODE_CONNECTOR_WRITEBACK, and correctly initializes the proper= ty - * values. It will also create an internal encoder associated with the - * drm_writeback_connector and set it to use the @enc_helper_funcs vtable = for - * the encoder helper. - * - * Drivers should always use this function instead of drm_connector_init()= to - * set up writeback connectors. - * - * Returns: 0 on success, or a negative error code - */ -int drm_writeback_connector_init(struct drm_device *dev, - struct drm_writeback_connector *wb_connector, - const struct drm_connector_funcs *con_funcs, - const struct drm_encoder_helper_funcs *enc_helper_funcs, - const u32 *formats, int n_formats, - u32 possible_crtcs) -{ - int ret =3D 0; - - drm_encoder_helper_add(&wb_connector->encoder, enc_helper_funcs); - - wb_connector->encoder.possible_crtcs =3D possible_crtcs; - - ret =3D drm_encoder_init(dev, &wb_connector->encoder, - &drm_writeback_encoder_funcs, - DRM_MODE_ENCODER_VIRTUAL, NULL); - if (ret) - return ret; - - ret =3D drm_writeback_connector_init_with_encoder(dev, wb_connector, &wb_= connector->encoder, - con_funcs, formats, n_formats); - - if (ret) - drm_encoder_cleanup(&wb_connector->encoder); - - return ret; -} -EXPORT_SYMBOL(drm_writeback_connector_init); - static void delete_writeback_properties(struct drm_device *dev) { if (dev->mode_config.writeback_pixel_formats_property) { diff --git a/include/drm/drm_writeback.h b/include/drm/drm_writeback.h index c380a7b8f55a..879ca103320c 100644 --- a/include/drm/drm_writeback.h +++ b/include/drm/drm_writeback.h @@ -24,17 +24,6 @@ struct drm_writeback_connector { */ struct drm_connector base; =20 - /** - * @encoder: Internal encoder used by the connector to fulfill - * the DRM framework requirements. The users of the - * @drm_writeback_connector control the behaviour of the @encoder - * by passing the @enc_funcs parameter to drm_writeback_connector_init() - * function. - * For users of drm_writeback_connector_init_with_encoder(), this field - * is not valid as the encoder is managed within their drivers. - */ - struct drm_encoder encoder; - /** * @pixel_formats_blob_ptr: * @@ -148,13 +137,6 @@ drm_connector_to_writeback(struct drm_connector *conne= ctor) return container_of(connector, struct drm_writeback_connector, base); } =20 -int drm_writeback_connector_init(struct drm_device *dev, - struct drm_writeback_connector *wb_connector, - const struct drm_connector_funcs *con_funcs, - const struct drm_encoder_helper_funcs *enc_helper_funcs, - const u32 *formats, int n_formats, - u32 possible_crtcs); - int drm_writeback_connector_init_with_encoder(struct drm_device *dev, struct drm_writeback_connector *wb_connector, struct drm_encoder *enc, --=20 2.47.3