From nobody Mon Feb 9 14:15:38 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 542C2242D9E for ; Sun, 28 Dec 2025 17:21:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766942508; cv=none; b=KUMi8fxM4J0v9mRdNvezrlJ5bzvY6AvHXvHX36SvvXj27fsu1Srp7XZMDGK1Cw7Vn2U/ZoFtXKj1uTOYoYDEx3XmmJnGQKl7QbAcufM/aA3Nh03zgfUjqIl2XXx+L2eZ9vz72W9PLL8y0F0AXc9PXyS4YZm+lrOCiEw/fqOjnSw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766942508; c=relaxed/simple; bh=eBzpPbb7DQH4mV13wWJlrn34m8m6zEyV2uFIH/bk69w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fB+rQ5S8KmVfQ2HZsa/1rjsTZFWg8p4G+QaaqBriv10dL7RuF7hXbmxI9qRHIJPIWAe9ksRPdr1qOdb034NFTTcgV/XTwhE2ljvofUR2mzUhPAg9duVDTx2Nz+Cqk8VrUbH0CiLz6K0rDIZ7COee9vVt0qUCL1JkXSouvN1xTuU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Uf/tp21T; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dqiP1XnD; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Uf/tp21T"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dqiP1XnD" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BSGP1qw3490932 for ; Sun, 28 Dec 2025 17:21:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= CGyPL6KHRYRMQ39eO9G7zyY0TeTIkBgeR3+nmWeanBE=; b=Uf/tp21TzmBWEvgP Ggk1niZyXxbf3GCIJK5GcXRvaAkv7i15eT7pfYRdqlr+bTqB4vqzeGeFWOsLhWqi 5TWVSKDykWL7DoizFvJHUYoviNu7DsrrYV1ELCE8T/aiP2xhE2v3i24MxhDUvc61 BoK4EoM+GkX+OyrS8tQg+geE1N9uzYEut/MxxrFuFJvfVys8oYCjRk5O9jfXB+om ZdKQKF7Autqrftsos78szIQt9s2xwHC0eeMn7PLgTZ7CbyCvNuZdnwzboCHZjGWI 3VT2PqngpmzH5liozgleHWSiYMDgm0OeBDK/MtqJzEpK79/QThu/ObH/qINGTsQy 2SKz5Q== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ba71wtgac-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 28 Dec 2025 17:21:45 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4eff973c491so214233591cf.1 for ; Sun, 28 Dec 2025 09:21:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766942504; x=1767547304; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CGyPL6KHRYRMQ39eO9G7zyY0TeTIkBgeR3+nmWeanBE=; b=dqiP1XnDhk68dhOuxWLRZcwfVVbYqffGEOjNjbnfTUDR9BX+ZQuntbklBMtQ2NjBVj oHQUJoLh9Ajs8yGXKuzmP2qR2ctTCZEuFwAzcs7zWVKkEbB7I/9fGPsF5Rb/qoRO6Eya 0uS+HeiNHOGyoYaO6R7EPxtxSozG6gdzFnsImM8pQWFMKMwfgvoK2d2oV7W3bHqfI50z gnGF9tDPvBqzdLDFuF4BxPdXczAC2ERdH2IDLGDK2dQGAq8Wy3YXhgHqPOpw0OJ0voHb XZtgEj18z0b4aGRjyDthILk4IaZuNgt6b+cxrAUQq3IiBgiRxHnpGPOSZBjqWgaoSDbg 837Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766942504; x=1767547304; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=CGyPL6KHRYRMQ39eO9G7zyY0TeTIkBgeR3+nmWeanBE=; b=seOKFTJOvUzBwbOvD6lgPqGHfCnvTGnDCy8kseMFOb5A3awHVeGDQcqkruUwJDfZM3 T40HBn6gTwCYE5PGpgK85Nsqfd8tcyh44aNr+FRcpzL+7GontM7DsJmXp8AVG/RNT6+5 R1O2OHgJs5/AFzTidXlOJjUo38ZJTMFPO7AqXwxdJkjQVCrsuHpq5Ch/g2RRrgNkhbU5 B5c6Kc70SZjtsswqiR5NaMjyAqcfyLGYXM9c7kk5vPndYV6YtR4Qs0Msm4XD+cKyy93V zNmDweewY0zTXclAgexuOzrlTJnofS/MS8tTMiCMQRmN2cGwmV+llc3FKAow+OlMpIc0 AOeQ== X-Forwarded-Encrypted: i=1; AJvYcCXaiJ6YQSI8fVhadxWOpPdzSYtNjk68B5rCVAk6ANuzUWJV493dCgpCivz8kLxZk4xZWKYZSS9MRGuRuX0=@vger.kernel.org X-Gm-Message-State: AOJu0YxOBEkv/xsSS8PLpg95VYWVuzVvPtYKtvmIBkCjnE6FRFipVtx1 K0iHi5m0D2DTk8eg00XnNbpJg+hr/PxY/Mm2vj5Lp5nVlhKMgoAOYRLuFtO486MG1ZpQjKDdODW w973lUApUs2ydTe9XGLR0H1SJQObAWjvZEo8MSXFh4Hpn9RSJ567vSFLy6ZKxOXZs+LE= X-Gm-Gg: AY/fxX7wfGFBBAKsCjEi8KeU4NmDF+/VuWF63qzwi3orCHbQlo3XbPseyQ2mgzH9xNd WVtGopk3FzKpoalkh8QZPTI3JchNm2gG5NKPkcGpMe0CX74B91CUgMsuzdNxcAfghnBCGZHqkQ8 l60ynIxs/RNv/1gGi5dssNqOdHchKRInJtdTDgwywsfwQhR7+Z53FhDEMTbBSYbA9jaCo4SI0OW qreDc8GeHXP8c38EfdJaknq33wQGznEI2rkmCdr8loss7sGg69VeTJ62uO9Y7waRFPf7vRnK6jY dZ2PXYrJmjJEabjhcRHC6c0+473iCoP9rB77USlcNUX6mEHeNKG0jl6wRCPcvF8UJryJBbZcnFf baaXaN1BcVoJ3CeRZIZeQCkU2h3RQJ7BoiIb2A5tWyvXJmwaxVS+oMmtOwZNO6qQh8qOsEmFxU2 eaG5mnFHZ81swhAXeEfD8ueQo= X-Received: by 2002:a05:622a:180b:b0:4f3:58e4:a35a with SMTP id d75a77b69052e-4f4abde3e12mr414052991cf.76.1766942504523; Sun, 28 Dec 2025 09:21:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IECq0Qmt0XAxFswq1cu73NAKtByntaPjKWodblDIcL0xgfkkSH03R1wkbkJ182GBH0vNXPH7g== X-Received: by 2002:a05:622a:180b:b0:4f3:58e4:a35a with SMTP id d75a77b69052e-4f4abde3e12mr414052511cf.76.1766942504089; Sun, 28 Dec 2025 09:21:44 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3812251cfffsm76871031fa.19.2025.12.28.09.21.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Dec 2025 09:21:43 -0800 (PST) From: Dmitry Baryshkov Date: Sun, 28 Dec 2025 19:21:35 +0200 Subject: [PATCH v4 3/8] drm/komeda: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251228-wb-drop-encoder-v4-3-58d28e668901@oss.qualcomm.com> References: <20251228-wb-drop-encoder-v4-0-58d28e668901@oss.qualcomm.com> In-Reply-To: <20251228-wb-drop-encoder-v4-0-58d28e668901@oss.qualcomm.com> To: Jani Nikula , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Christophe JAILLET , Jessica Zhang , Louis Chauvet Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Suraj Kandpal X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2957; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=eBzpPbb7DQH4mV13wWJlrn34m8m6zEyV2uFIH/bk69w=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpUWciAKlQsujWkOpLqHFrKD2XVuk+2pZawHVG4 1UF4s0FzrOJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaVFnIgAKCRCLPIo+Aiko 1Un0B/9wVD3LDimX5fzl+PflgjNQGNawH3LkDsOTuXS6mmAMJoOmVBnrZPVZmArDidHcXXPDeRQ 8L712inmPVorbB+TBGXSGmaOjgkijlxEn4yrVivkSySd64MuuYqFe9fCR/0h1pzO5Ah/fhgDG/H NhtHHzJ0PSJsRjGwjplpouC5WpwouFW8FP3+Ow29Cw0LfLlTjzohyH28PwIrOy8YKDF3wBpFmZa klWf9iaFvj1N9WY2IZoSXXmrXNcuce8p/EVkjV2hsRb82YJX9P9Y4iZNXVKGkwMcHtP3Gp2P+w1 OpGRCWk9mpNvLaUoTirYlk2vfUZrrS/pK+A5WUQwDR+Rvf9Z X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI4MDE1OSBTYWx0ZWRfX9fZt7F4vzb8A IQIJV+kxr/TYF7Vk2+RKsjEKIw5Tl6wtbojNar2AfLb2oiXu5mcpx+adVzaIWySgm0bnQp53dhm 8liFMDivRXMboYTcrbqusVet7z/1Ghd9LRmHdL4ZqhkyH6VK5XBGpG4yYYsEH4ayv4CgL6CZvF9 7n5Oycib6f5+0x4RXWizSYnu468TSeBh/fW3+vth7+fzKfV1vnTrM9XYutH7f/lky0/3nZMp371 PSoY3w/DkNSOfq06SPbjeK/Z8n7V2KFUMrW854cyNdlw00ZxenhI+yHEIT0JHJvirxmlvxWWrdm f0sc5BE9OmWCHg72gXX5BgmSKvFXY0MokvenAFjm98N2QDhdrkcGXkgf1T4LhOgXVRofJIGfBtW NLoQFlTR/zjOnpo8DOFyMfJ0M8YGLAUYC4ZPwsTu0HlF3EjV2P1r/9weITDOCpK7n/CCm5VQ/bn ARB78T4qdUr1YJtjt4g== X-Proofpoint-ORIG-GUID: vVOcCnkaP73L_QLwS6ywxB13tH0Q5ueN X-Proofpoint-GUID: vVOcCnkaP73L_QLwS6ywxB13tH0Q5ueN X-Authority-Analysis: v=2.4 cv=CK4nnBrD c=1 sm=1 tr=0 ts=69516729 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=EE5oNXVUeA2ILyHCr4wA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-28_06,2025-12-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 adultscore=0 suspectscore=0 priorityscore=1501 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512280159 Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov --- .../drm/arm/display/komeda/komeda_wb_connector.c | 30 ++++++++++++------= ---- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/dri= vers/gpu/drm/arm/display/komeda/komeda_wb_connector.c index 875cdbff18c9..bcc53d4015f1 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c @@ -5,6 +5,7 @@ * */ #include +#include #include "komeda_dev.h" #include "komeda_kms.h" =20 @@ -121,17 +122,10 @@ komeda_wb_connector_fill_modes(struct drm_connector *= connector, return 0; } =20 -static void komeda_wb_connector_destroy(struct drm_connector *connector) -{ - drm_connector_cleanup(connector); - kfree(to_kconn(to_wb_conn(connector))); -} - static const struct drm_connector_funcs komeda_wb_connector_funcs =3D { .reset =3D drm_atomic_helper_connector_reset, .detect =3D komeda_wb_connector_detect, .fill_modes =3D komeda_wb_connector_fill_modes, - .destroy =3D komeda_wb_connector_destroy, .atomic_duplicate_state =3D drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, }; @@ -143,13 +137,15 @@ static int komeda_wb_connector_add(struct komeda_kms_= dev *kms, struct komeda_wb_connector *kwb_conn; struct drm_writeback_connector *wb_conn; struct drm_display_info *info; + struct drm_encoder *encoder; + u32 *formats, n_formats =3D 0; int err; =20 if (!kcrtc->master->wb_layer) return 0; =20 - kwb_conn =3D kzalloc(sizeof(*kwb_conn), GFP_KERNEL); + kwb_conn =3D drmm_kzalloc(&kms->base, sizeof(*kwb_conn), GFP_KERNEL); if (!kwb_conn) return -ENOMEM; =20 @@ -165,11 +161,19 @@ static int komeda_wb_connector_add(struct komeda_kms_= dev *kms, return -ENOMEM; } =20 - err =3D drm_writeback_connector_init(&kms->base, wb_conn, - &komeda_wb_connector_funcs, - &komeda_wb_encoder_helper_funcs, - formats, n_formats, - BIT(drm_crtc_index(&kcrtc->base))); + encoder =3D drmm_plain_encoder_alloc(&kms->base, NULL, + DRM_MODE_ENCODER_VIRTUAL, NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &komeda_wb_encoder_helper_funcs); + + encoder->possible_crtcs =3D drm_crtc_mask(&kcrtc->base); + + err =3D drmm_writeback_connector_init(&kms->base, wb_conn, + &komeda_wb_connector_funcs, + encoder, + formats, n_formats); komeda_put_fourcc_list(formats); if (err) { kfree(kwb_conn); --=20 2.47.3