From nobody Sun Feb 8 04:18:04 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9B30221F06 for ; Sun, 28 Dec 2025 17:21:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766942505; cv=none; b=Pwd/N/NJ2St5TSPWOpVoij9W9yajBlsxR+Q3FhkLbIW3QDBoSvt71B1+pGMl0pdwKzIZAf7+m6mGapuRaWYSBDauyA0xWZGCoL/fFCsP2M9h2raQChiC+DWu0xYGN4DFK0JEl6exDBIB1B6PLXAxmncIAdp9/ya9TKtcmEe6pcE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766942505; c=relaxed/simple; bh=N79ubxZoT9CfhEWVCl9adki2rUcnDYw7kQ2VYonzkiU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PqZpUFadrzq2e2n/wqovk2cYc1az/MAchD7i+1UzhCwsjjBAm0QUThhVuOaMtaN+hqwKjRbvD+fohfto1UwByAI1LDbi8Jx0Rm8dEctr1gw4y4/XR2EnC+SCCi9qD44tZA6bfMTPCHGdOUHrXN2f7ikYH/qf1+7/wMhgA/pKyOE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=T/F//Ujv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cdrhQiNw; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="T/F//Ujv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cdrhQiNw" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BSGpWOx2583476 for ; Sun, 28 Dec 2025 17:21:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YkjBaOunrqEoX2Aau4llqSA27ldPBblRpj5Ewz68DB8=; b=T/F//Ujvln3gn+P3 xOTPowAJSfTTwwFxlzL0T2R2oiXeryHK+Fyk1S2VBZgd/Io0JkZezo6cU2moSey/ udFWpNHB54jXt7AEDoqh31Ruc3b7T5vc+ADw2SWF/Mg9S6ysnJuaUP81JYmrRCu4 H9FVAxSXaT4Bzy0xLNEy+/mj1E6FJG4MGH1JVMBMY1BGJfQWo6UozKjtPnjljYkK UzA40jm1YBofWOfWF7bm3KI3TPGcWdAwnx71TKo2+nPJOREOPLkporxuoMlW04tn soEjaZKTAdzcLUwpsnS5diHPQB2DBYtCH11dq4sCsog0tUU4dJLryMgQg1OW67Gw EeSbYg== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ba4tntp9d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 28 Dec 2025 17:21:42 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-88a31ce8214so216765406d6.2 for ; Sun, 28 Dec 2025 09:21:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766942502; x=1767547302; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=YkjBaOunrqEoX2Aau4llqSA27ldPBblRpj5Ewz68DB8=; b=cdrhQiNwLrneu2wlr7kYpZdht73JqYMXf55Y+CC6GGcXuv6jL2eyRmJ/WvsKMGHG2n tlt5uge3hBeVph14Tp4Ajp/8/WmLG6ojEZSVp/o8OUeRIywIUsFXOCFRR2CI4fLk0t7M zyCwyFcBEUqK8KO1b2dOuHIduqpwUaN91KQmee2H/nkznOwqPab8Qy9xogg8cHD0p823 C3lxQ+33VwYdYlNctIhBfGYbjBXwA9/Nr2Nvc2rTSWMx0UYGiuEI4Pm2uAaUp9v+beee h139+7a6SYS1wuE837yTQ9twTgLC2qW/6A7G9N9cpjYB91QPA3YfG+lOnM0ZLnXb+pfz AmTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766942502; x=1767547302; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=YkjBaOunrqEoX2Aau4llqSA27ldPBblRpj5Ewz68DB8=; b=uOyI4OOzSGuVOX/HpcMfUpQd13Jj0rvxhtplaOZyqhAyFfWJEVMKpjVJB+XW07fkg0 gPdye7glDfWqOfGe6NIa8PiOLYo3csBPs8+LxrCzzJ8QUPYWH/MImKNbU3/Y0DsbSZDO nVy+33nlXhIRS5U5FSZQ+oO8azeUbsT38bKmj8PodMQ18QhVurMe5e1Q/0alPHe6+g2+ QRBFfX78rZfKJhtC7P+/9R4+oxSbOcd7zovlyYb/0oHW84HQzzn54w1tUYNQX/ccfZSp W/Nejh7FdaEHYFG3ukzLRVFkNxAw1NvJ9yp4BNU22ZUSWh+crFpGsyBBbGUCkdn1fUha izyg== X-Forwarded-Encrypted: i=1; AJvYcCUERJ/t4p1oPvPwHs9vp4qZ8b1tiu13gYYlCOv1NBCmsh/SFopFBvytGDfBGgKGDowYAgqoPAJiooSs2Gk=@vger.kernel.org X-Gm-Message-State: AOJu0YzEKDB6OP4g6aemx+hxLu7I4zXPpIiiWuK9U9l/xmUxyvpzPxhB AEyKCNY6WKdYonW9SxQEySDcusluMcandt/xPhJeWWIXZCOwLEaz/E0P8VboNXpjlWE3O516cJZ kCGKyj8/zlNgWE+haPJqPT5aZfqPfklVtxQRr5jm2oH8zRmpbhVTTESslnH6nsM7ezCw= X-Gm-Gg: AY/fxX5opshE7dsH9ANsrZRR/gkYydU5YRisTmoYy3yJfP5CFNXpu0pdBtg+/MKwPVG anVEgEBh2gtLDQ+kd3RXCPzBJU6hwa5wEUZV3b1+hcswL0ee440v8uMHQbaF9598oIS4eXQ2ltw wbRwX3ShQavkbuGU9hKtmpOwRRtRdBWZopoZYOA2+uTNNThr4q81cNGbJXyKgdeLVb4jedDfPeu oL9rFOje2nRS4tp69wSCAHMmUNo8YsbRzQV91jfvA/B73dLmMuebQmyEPbnpZ+Z0KzFJgH1rOgM x/VAtiyzOUK6vEDsyVWSY7wLj3PJdepyJkLbOl5l5nMf64OHtgle9sIpd2tr713Z/FIywWZec1I NgIsuA/woJbYX1wKIiXfGIG0oe43CRwsvch5lLYPsUAuLFWXuIC+XU7igyJSnKgDlElmJpumIHN ngY2bCalTQxE1l8jG5c7Es10U= X-Received: by 2002:a0c:f807:0:b0:880:501f:608 with SMTP id 6a1803df08f44-88d83983b64mr336330786d6.46.1766942502082; Sun, 28 Dec 2025 09:21:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IFg43kpYtqQZC5vFkhsCgSUI1Pebt5euGVk/sNLrkaiCbN3dCq7BIF7cHpcCE/NR34DsmS7ZA== X-Received: by 2002:a0c:f807:0:b0:880:501f:608 with SMTP id 6a1803df08f44-88d83983b64mr336330486d6.46.1766942501641; Sun, 28 Dec 2025 09:21:41 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3812251cfffsm76871031fa.19.2025.12.28.09.21.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Dec 2025 09:21:40 -0800 (PST) From: Dmitry Baryshkov Date: Sun, 28 Dec 2025 19:21:33 +0200 Subject: [PATCH v4 1/8] drm/msm/dpu: don't mix devm and drmm functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251228-wb-drop-encoder-v4-1-58d28e668901@oss.qualcomm.com> References: <20251228-wb-drop-encoder-v4-0-58d28e668901@oss.qualcomm.com> In-Reply-To: <20251228-wb-drop-encoder-v4-0-58d28e668901@oss.qualcomm.com> To: Jani Nikula , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Christophe JAILLET , Jessica Zhang , Louis Chauvet Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1278; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=N79ubxZoT9CfhEWVCl9adki2rUcnDYw7kQ2VYonzkiU=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ2ZgumJldFiuRbQyP4/3zJUTcu747q2+ukG72IgpoPrMo t3GCgqdjMYsDIxcDLJiiiw+BS1TYzYlh33YMbUeZhArE8gUBi5OAZiIhhL7P+X/QXtbmFRSF3G/ enRO6WLlSfcCx4q+Dy9WTttzNlYztvRzWNqmu2r2XAl6zAm/NtvMrpOuli368lZN7r1CZeFtYxl 73u+SLg0r35oyiRYeVDBn/NxhPMlYKaRyfnlYmHZk9yF14cQdG6WEdn+ZGzDnd2bk7vkGV+U7FC 0XLeqb1XfGYWrVF9k4NofewBzWj4FfvS+tVFF8v/lWXmqagcOFKHPzq98XPnh/+WV10FmeS3JF3 y2OqGdHfXrT9CK2fe1UyckNDHLs1y7nfOmaXrybP2TV4RO8e050r74mWe0/obqO9Unq7fMqm5gL Ag/yLp+jbV6hfFZ/3VfHkCPWjeuiz3+ZcnzhY5H4Q+l/AQ== X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=G+YR0tk5 c=1 sm=1 tr=0 ts=69516726 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=LvVPTXtSEabqDirTlLwA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-GUID: DnP9jwvqNsucf7OHfBEm9UXlEmDJQrqF X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI4MDE1OSBTYWx0ZWRfXwclfapgx1gU0 QxRjDjSclpHemHfT/kvpYTSA8yPGw/34tBoPTy9vL+/uGGhxiunOfNNHXrqjilBgWydD+CCdb4h dzw2R/S+0CldGsTcVvMVF2NFfZ2QCBqLtVIUVdu5hLE+95zfCRfssX3v0QC2MNZQAshb7egfolh h/DQhRJNYIuKJLmTpSL8NRo0cJF06haFIIsaPJaJEq9NDcsNCSpl0kVwhRu4GSG0paMk4vgku5z JHeudaKB/fYEDJKqry2jDB8SvevXe6Uj81bguEjTeJhE2BPNmKomnWNYULCLK2IQrM/teCq4We2 2AtMYmL8Wu4pcaNfSnJ32Kx+jYDobzwfssdlg6s73MT+Tw9IQuU5qsAsRF8Q1GmudGK2iGDUvv3 wHUOv9qk6NnB3Vt1bwHq13m841VqJ39WVWoy6tR7vbc+84cymD2sS7w7KlrCL+tAZN7E4P+A8zZ CAYgnv7Qz+fUm7U0I2Q== X-Proofpoint-ORIG-GUID: DnP9jwvqNsucf7OHfBEm9UXlEmDJQrqF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-28_06,2025-12-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 bulkscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512280159 Mixing devm and drmm functions can result in a use-after-free errors. Change dpu_writeback_init() to use drmm_ Fixes: 0b37ac63fc9d ("drm/msm/dpu: use drmm_writeback_connector_init()") Reported-by: Christophe JAILLET Closes: https://lore.kernel.org/r/78c764b8-44cf-4db5-88e7-807a85954518@wana= doo.fr Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c b/drivers/gpu/dr= m/msm/disp/dpu1/dpu_writeback.c index 7545c0293efb..6f2370c9dd98 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c @@ -5,6 +5,7 @@ =20 #include #include +#include =20 #include "dpu_writeback.h" =20 @@ -125,7 +126,7 @@ int dpu_writeback_init(struct drm_device *dev, struct d= rm_encoder *enc, struct dpu_wb_connector *dpu_wb_conn; int rc =3D 0; =20 - dpu_wb_conn =3D devm_kzalloc(dev->dev, sizeof(*dpu_wb_conn), GFP_KERNEL); + dpu_wb_conn =3D drmm_kzalloc(dev, sizeof(*dpu_wb_conn), GFP_KERNEL); if (!dpu_wb_conn) return -ENOMEM; =20 --=20 2.47.3 From nobody Sun Feb 8 04:18:04 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FEEA215F7D for ; Sun, 28 Dec 2025 17:21:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766942507; cv=none; b=MC/S6l2Avv+HmJnMSMmzytdFCaWx8BDLCEO8xKp4kjJeYuFFtNJ7A/8ese0xnzKBRnXN8RInpG9StIP38H5tEpyjLvAcvKVulYlOb45pNnNfuGAVIIiBJ9/QMmyLC3iBmmRD6nky94iWXxwGudvRYkJSq74beNBSd5qbSXVK/O0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766942507; c=relaxed/simple; bh=AhjL5n0KqMn00LisHx2T5B6vTrBvTjUUJYkgUx2rS80=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ApJht1vjY7Bz5Ic8lJKiE11o4+/Vvdv0uaus26HKXGewqDnlqtXGk3gUGfzE6M/zSb7GHP1G3qZzUYqmvR4wjFlHrlJbMKCw22cc9HfzA9e0hVgrL5pK07PUQFLUbeM2Zzqxu/woRn525Y8fHX4Usw7exmfBNuXF/1HD6CLs3+A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BEwij8f4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=d8PyeuOv; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BEwij8f4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="d8PyeuOv" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BSBuhOD3152483 for ; Sun, 28 Dec 2025 17:21:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QwKCOLaLwEVYb/ydqismQTZCLmcdjRauyMNTqQmx16w=; b=BEwij8f468punwq6 urKJB9CgqrOEhjKjBPwBBQXG2Ilhu1me2Y8M2L+iFIkvhgwNJybHYhrBCyDkvzOp jVx5gZ00XNtkC7J/J7VguH7FjCj78ZFy2j+LVOhNLFfRYXYTgJ62udHdIwgIo3sr 3221YP2zI1V5Au/JthDmcXGCuik8AcGoq9kLIAP5RwhdRtLDvAsp2zc/T8vqth+1 eZtJvqyr0V+idOdxnbYqL2mGH3JXZ4lAuNnt09lwMr06yJ0lIQB3RdC93fqswMGB xXPfIvwWnEvqC4V8o1z544t+W/lrFu15e9AQzQWVPOQhTxXnDdZ4JsqLkdRg3Z+3 lEga1A== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ba6f62jak-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 28 Dec 2025 17:21:43 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-88a2d8b7ea5so107393436d6.0 for ; Sun, 28 Dec 2025 09:21:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766942503; x=1767547303; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=QwKCOLaLwEVYb/ydqismQTZCLmcdjRauyMNTqQmx16w=; b=d8PyeuOvzpi1qCXISrbPC+J9ocsh3DPUo5xcekUlpznDd6TFBNVKZ9pVjgn2hRhdLH KuikzENFjmc6b65KdSIkPriSti4tqSAPkxOQUBPwp6fr3wXjiValpLoPJ4PYNWCEYdmE AMyU5wLAS9ilTnvHxM4jdKiH1zdxKmfkwD6BjVFkZBcmwcOCs9E3VjY7Z9Js/DwbRrAV gqcOmtIfGe0zwAJ174bntI9OuIjzqQ1RFnxPeKE32tXft8wrWWT0EfjLmEFmF1Fumsae Sf6N9U72VkZ0CVV08qD2CKgZcCWv2Glg1U2t9NU5d+usp0g05tGjr4W044dx3SX7UHaD i5AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766942503; x=1767547303; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=QwKCOLaLwEVYb/ydqismQTZCLmcdjRauyMNTqQmx16w=; b=e8An/1e63RBDj7J2xj5klGuyAfTGN2F8ZO9VBPz0CRdPcFrIr7dmbz9kMGZyIJPYX3 Yrf0PKlj2k/o3DV5E7xgA4+Syw/rC4h2FropYuM94v46rO+DuaxRmIj+QpPmfsP28xqQ 5IyKCmbFSKf40OKPkWxzOPPGCcmchDcyVtawiBFR6Gn98nUjOwH4LU10mDIOEFe9p1xD gubG/4oYnC28JWGkA5+IYUPu2n+ok+G2bbxeqBUwxm68wE+wVwhvZSule9Gkd1xtRcgw 0LYlultXFRiCebvteEPP8HhLuaVjdt++hfbirtsiCTI0q0s3kdEsyjQmuBOa12d2kH6w viJw== X-Forwarded-Encrypted: i=1; AJvYcCXh9OXPB1d/HPI/QFW0Xjo2IKI6P+ISSI+N//KQX9DEJLTNmE05hmE8TDAxikn9ZxC/SNnuvTyu4d0GXi4=@vger.kernel.org X-Gm-Message-State: AOJu0YxOtXghKfmdECuSOgaLp2K+2ao8ElhDfAzuQeP2JTByCjdJBm+/ eXqIsi0H01f0jN5F+a5Z5PqR47BI8vKMBFOXjt0nyMmXgR1R1YvZDhzPqZHCbutEynbVPb2DZio CkKwCxF47uMT5CJiHKwBq+T2J1BQ5nUv7Xbu8gl6qushasG6xwaFaAEXwPsRht5QGo0Y= X-Gm-Gg: AY/fxX4RVJ4fr24eKqIhnaOZ+2F0SFdtthRYv1gyZFQ9uz/jzG8xNlPHIxrsuPGejMA GgUbbFHHrRxD1WTupD3bpYySj9s+IriG/k0K53jvsBV9lmCeLp5ofv8ND9564mTPyBdtjCMIXXp 4yptwLmQSjDgroJnpUDtwphhchaP/mpyW/cUCFNk8RupKeaG2rkXkW8XrzvbRx02auUK03ucu6S 8nGRGW6KeeA+hZypS9c83OJEfiyIxJB/8KAtojuUk3DmSNq3V+O601Hw4sODL2kRosOoSTCzhnW vgJaUHZnOapIZCbe/xt3DJAD9d5yLTz7CgtKu1hNZAOfqp2T8t6h+ozjephU4kxzKMcILKuiIm4 moEb7CMYB4rHEk6ZABoV957io3+L75fKPpza5Il8YhLsbNMMyT8PGn0MvV2UJyBAvlholQzbH80 480np1KmXNrVIAxAzXLJ8eKYQ= X-Received: by 2002:a05:6214:14ac:b0:880:48bc:e08f with SMTP id 6a1803df08f44-88d83793405mr311516346d6.40.1766942503349; Sun, 28 Dec 2025 09:21:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IE5EUG88eN7xWHCQu1kB/Om4DasLN+n2uCUeGVvVxm3AjAOh3j8JLRR73QWpq6YGG91jGc5zw== X-Received: by 2002:a05:6214:14ac:b0:880:48bc:e08f with SMTP id 6a1803df08f44-88d83793405mr311516016d6.40.1766942502851; Sun, 28 Dec 2025 09:21:42 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3812251cfffsm76871031fa.19.2025.12.28.09.21.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Dec 2025 09:21:42 -0800 (PST) From: Dmitry Baryshkov Date: Sun, 28 Dec 2025 19:21:34 +0200 Subject: [PATCH v4 2/8] drm/amd/display: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251228-wb-drop-encoder-v4-2-58d28e668901@oss.qualcomm.com> References: <20251228-wb-drop-encoder-v4-0-58d28e668901@oss.qualcomm.com> In-Reply-To: <20251228-wb-drop-encoder-v4-0-58d28e668901@oss.qualcomm.com> To: Jani Nikula , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Christophe JAILLET , Jessica Zhang , Louis Chauvet Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Suraj Kandpal X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2978; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=AhjL5n0KqMn00LisHx2T5B6vTrBvTjUUJYkgUx2rS80=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpUWciqEro/DFsCfKaexLHG7KTjaJzdmaEO/86Q /tztctUKI2JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaVFnIgAKCRCLPIo+Aiko 1ajxCACH793b0lsnrCbvP33cFhq6yL0q59eHuPMhmnMl4PbAf74U2q6vkmuhCLbqWCyjjympkm2 F/QcVzF6/2fMsBgWaxsNYMVRtMEayNK7VupJM/1PgLNA0wAVIhFcD1nGQ9aAoIUL3hD0ssjtLSE 9+AjggpuA2/LVew7AVfi28UvHarYVEjG/cdGTOH+shJS4pH7Uc7xY64PV2WAV7gcxdIF6LMqZF8 zVkVffrU80TTqtUmnaNTLFzL5KTn2ydJbita7NEyIvP5RCWD2I94OLeJHb90rtbkm2B4OL7NFwl y1FdVeZNaoJYHJgm5XqKdUx1uN271EkIn8vhU3oofzZ79v+n X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: e-v4Uq0DRxyyuvl_0-EsOH9wGKK76XGs X-Proofpoint-ORIG-GUID: e-v4Uq0DRxyyuvl_0-EsOH9wGKK76XGs X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI4MDE1OCBTYWx0ZWRfX5Ele/m4rRaJg nKNe+OmJytkdQiV/3lNvWlojaiF1rZdYPCpnLLqJYKjMO6HjUAFr0rarYaIWkJIKmjrCC51Q5QS uN3yZP0xXsjLNFLT3Xk6/TNQ9LVGn7Obde0Vq663+JMKWR2/4ApU+atNqxZz4SaWOXpscc/FJ8f FlbBRJEHxWm+n2JxMU08EMRURJlwiitXkHhDARW1SKOLb7PECCDh4EJ/PfUquRzYdCD0h9FYmXf PFlGJC50kcTA2XfMj7F+v0lzMQvfhuxZn2EywHGtVirkvwBPQOzyzNGjhD//LgZx7Lz7yYuMIQF nWzmL1r4j4vI8IU2umvE7RYJLanxOsqnOlY/ilZyYg0cfYiBur3fCTsMPcQnAejv231TgdleODE lHQ5BPdPJYfM+uRtdfT/LyJXeem8Tx5dM5ROurM5GQONaLE6uTcpGdRBWtIBoASrVls7DypSwn0 EfzhxRB7Ib9ztmYVi6A== X-Authority-Analysis: v=2.4 cv=YuEChoYX c=1 sm=1 tr=0 ts=69516728 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P-IC7800AAAA:8 a=QyXUC8HyAAAA:8 a=EUspDBNiAAAA:8 a=8cP71iSYcfV9S7Y4u-4A:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-28_06,2025-12-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 adultscore=0 phishscore=0 spamscore=0 clxscore=1015 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512280158 Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Louis Chauvet Reviewed-by: Suraj Kandpal Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c | 18 +++++++++++++---= -- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gp= u/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 740711ac1037..45b3c8f16b23 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -10570,7 +10570,7 @@ static void dm_set_writeback(struct amdgpu_display_= manager *dm, return; } =20 - acrtc =3D to_amdgpu_crtc(wb_conn->encoder.crtc); + acrtc =3D to_amdgpu_crtc(crtc_state->base.crtc); if (!acrtc) { drm_err(adev_to_drm(adev), "no amdgpu_crtc found\n"); kfree(wb_info); diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c b/drivers= /gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c index d9527c05fc87..80c37487ca77 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c @@ -171,7 +171,6 @@ static const struct drm_encoder_helper_funcs amdgpu_dm_= wb_encoder_helper_funcs =3D =20 static const struct drm_connector_funcs amdgpu_dm_wb_connector_funcs =3D { .fill_modes =3D drm_helper_probe_single_connector_modes, - .destroy =3D drm_connector_cleanup, .reset =3D amdgpu_dm_connector_funcs_reset, .atomic_duplicate_state =3D amdgpu_dm_connector_atomic_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, @@ -190,17 +189,26 @@ int amdgpu_dm_wb_connector_init(struct amdgpu_display= _manager *dm, struct dc *dc =3D dm->dc; struct dc_link *link =3D dc_get_link_at_index(dc, link_index); int res =3D 0; + struct drm_encoder *encoder; + + encoder =3D drmm_plain_encoder_alloc(&dm->adev->ddev, NULL, + DRM_MODE_ENCODER_VIRTUAL, NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &amdgpu_dm_wb_encoder_helper_funcs); + + encoder->possible_crtcs =3D amdgpu_dm_get_encoder_crtc_mask(dm->adev); =20 wbcon->link =3D link; =20 drm_connector_helper_add(&wbcon->base.base, &amdgpu_dm_wb_conn_helper_fun= cs); =20 - res =3D drm_writeback_connector_init(&dm->adev->ddev, &wbcon->base, + res =3D drmm_writeback_connector_init(&dm->adev->ddev, &wbcon->base, &amdgpu_dm_wb_connector_funcs, - &amdgpu_dm_wb_encoder_helper_funcs, + encoder, amdgpu_dm_wb_formats, - ARRAY_SIZE(amdgpu_dm_wb_formats), - amdgpu_dm_get_encoder_crtc_mask(dm->adev)); + ARRAY_SIZE(amdgpu_dm_wb_formats)); =20 if (res) return res; --=20 2.47.3 From nobody Sun Feb 8 04:18:04 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 542C2242D9E for ; Sun, 28 Dec 2025 17:21:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766942508; cv=none; b=KUMi8fxM4J0v9mRdNvezrlJ5bzvY6AvHXvHX36SvvXj27fsu1Srp7XZMDGK1Cw7Vn2U/ZoFtXKj1uTOYoYDEx3XmmJnGQKl7QbAcufM/aA3Nh03zgfUjqIl2XXx+L2eZ9vz72W9PLL8y0F0AXc9PXyS4YZm+lrOCiEw/fqOjnSw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766942508; c=relaxed/simple; bh=eBzpPbb7DQH4mV13wWJlrn34m8m6zEyV2uFIH/bk69w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fB+rQ5S8KmVfQ2HZsa/1rjsTZFWg8p4G+QaaqBriv10dL7RuF7hXbmxI9qRHIJPIWAe9ksRPdr1qOdb034NFTTcgV/XTwhE2ljvofUR2mzUhPAg9duVDTx2Nz+Cqk8VrUbH0CiLz6K0rDIZ7COee9vVt0qUCL1JkXSouvN1xTuU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Uf/tp21T; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dqiP1XnD; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Uf/tp21T"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dqiP1XnD" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BSGP1qw3490932 for ; Sun, 28 Dec 2025 17:21:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= CGyPL6KHRYRMQ39eO9G7zyY0TeTIkBgeR3+nmWeanBE=; b=Uf/tp21TzmBWEvgP Ggk1niZyXxbf3GCIJK5GcXRvaAkv7i15eT7pfYRdqlr+bTqB4vqzeGeFWOsLhWqi 5TWVSKDykWL7DoizFvJHUYoviNu7DsrrYV1ELCE8T/aiP2xhE2v3i24MxhDUvc61 BoK4EoM+GkX+OyrS8tQg+geE1N9uzYEut/MxxrFuFJvfVys8oYCjRk5O9jfXB+om ZdKQKF7Autqrftsos78szIQt9s2xwHC0eeMn7PLgTZ7CbyCvNuZdnwzboCHZjGWI 3VT2PqngpmzH5liozgleHWSiYMDgm0OeBDK/MtqJzEpK79/QThu/ObH/qINGTsQy 2SKz5Q== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ba71wtgac-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 28 Dec 2025 17:21:45 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4eff973c491so214233591cf.1 for ; Sun, 28 Dec 2025 09:21:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766942504; x=1767547304; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CGyPL6KHRYRMQ39eO9G7zyY0TeTIkBgeR3+nmWeanBE=; b=dqiP1XnDhk68dhOuxWLRZcwfVVbYqffGEOjNjbnfTUDR9BX+ZQuntbklBMtQ2NjBVj oHQUJoLh9Ajs8yGXKuzmP2qR2ctTCZEuFwAzcs7zWVKkEbB7I/9fGPsF5Rb/qoRO6Eya 0uS+HeiNHOGyoYaO6R7EPxtxSozG6gdzFnsImM8pQWFMKMwfgvoK2d2oV7W3bHqfI50z gnGF9tDPvBqzdLDFuF4BxPdXczAC2ERdH2IDLGDK2dQGAq8Wy3YXhgHqPOpw0OJ0voHb XZtgEj18z0b4aGRjyDthILk4IaZuNgt6b+cxrAUQq3IiBgiRxHnpGPOSZBjqWgaoSDbg 837Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766942504; x=1767547304; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=CGyPL6KHRYRMQ39eO9G7zyY0TeTIkBgeR3+nmWeanBE=; b=seOKFTJOvUzBwbOvD6lgPqGHfCnvTGnDCy8kseMFOb5A3awHVeGDQcqkruUwJDfZM3 T40HBn6gTwCYE5PGpgK85Nsqfd8tcyh44aNr+FRcpzL+7GontM7DsJmXp8AVG/RNT6+5 R1O2OHgJs5/AFzTidXlOJjUo38ZJTMFPO7AqXwxdJkjQVCrsuHpq5Ch/g2RRrgNkhbU5 B5c6Kc70SZjtsswqiR5NaMjyAqcfyLGYXM9c7kk5vPndYV6YtR4Qs0Msm4XD+cKyy93V zNmDweewY0zTXclAgexuOzrlTJnofS/MS8tTMiCMQRmN2cGwmV+llc3FKAow+OlMpIc0 AOeQ== X-Forwarded-Encrypted: i=1; AJvYcCXaiJ6YQSI8fVhadxWOpPdzSYtNjk68B5rCVAk6ANuzUWJV493dCgpCivz8kLxZk4xZWKYZSS9MRGuRuX0=@vger.kernel.org X-Gm-Message-State: AOJu0YxOBEkv/xsSS8PLpg95VYWVuzVvPtYKtvmIBkCjnE6FRFipVtx1 K0iHi5m0D2DTk8eg00XnNbpJg+hr/PxY/Mm2vj5Lp5nVlhKMgoAOYRLuFtO486MG1ZpQjKDdODW w973lUApUs2ydTe9XGLR0H1SJQObAWjvZEo8MSXFh4Hpn9RSJ567vSFLy6ZKxOXZs+LE= X-Gm-Gg: AY/fxX7wfGFBBAKsCjEi8KeU4NmDF+/VuWF63qzwi3orCHbQlo3XbPseyQ2mgzH9xNd WVtGopk3FzKpoalkh8QZPTI3JchNm2gG5NKPkcGpMe0CX74B91CUgMsuzdNxcAfghnBCGZHqkQ8 l60ynIxs/RNv/1gGi5dssNqOdHchKRInJtdTDgwywsfwQhR7+Z53FhDEMTbBSYbA9jaCo4SI0OW qreDc8GeHXP8c38EfdJaknq33wQGznEI2rkmCdr8loss7sGg69VeTJ62uO9Y7waRFPf7vRnK6jY dZ2PXYrJmjJEabjhcRHC6c0+473iCoP9rB77USlcNUX6mEHeNKG0jl6wRCPcvF8UJryJBbZcnFf baaXaN1BcVoJ3CeRZIZeQCkU2h3RQJ7BoiIb2A5tWyvXJmwaxVS+oMmtOwZNO6qQh8qOsEmFxU2 eaG5mnFHZ81swhAXeEfD8ueQo= X-Received: by 2002:a05:622a:180b:b0:4f3:58e4:a35a with SMTP id d75a77b69052e-4f4abde3e12mr414052991cf.76.1766942504523; Sun, 28 Dec 2025 09:21:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IECq0Qmt0XAxFswq1cu73NAKtByntaPjKWodblDIcL0xgfkkSH03R1wkbkJ182GBH0vNXPH7g== X-Received: by 2002:a05:622a:180b:b0:4f3:58e4:a35a with SMTP id d75a77b69052e-4f4abde3e12mr414052511cf.76.1766942504089; Sun, 28 Dec 2025 09:21:44 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3812251cfffsm76871031fa.19.2025.12.28.09.21.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Dec 2025 09:21:43 -0800 (PST) From: Dmitry Baryshkov Date: Sun, 28 Dec 2025 19:21:35 +0200 Subject: [PATCH v4 3/8] drm/komeda: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251228-wb-drop-encoder-v4-3-58d28e668901@oss.qualcomm.com> References: <20251228-wb-drop-encoder-v4-0-58d28e668901@oss.qualcomm.com> In-Reply-To: <20251228-wb-drop-encoder-v4-0-58d28e668901@oss.qualcomm.com> To: Jani Nikula , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Christophe JAILLET , Jessica Zhang , Louis Chauvet Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Suraj Kandpal X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2957; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=eBzpPbb7DQH4mV13wWJlrn34m8m6zEyV2uFIH/bk69w=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpUWciAKlQsujWkOpLqHFrKD2XVuk+2pZawHVG4 1UF4s0FzrOJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaVFnIgAKCRCLPIo+Aiko 1Un0B/9wVD3LDimX5fzl+PflgjNQGNawH3LkDsOTuXS6mmAMJoOmVBnrZPVZmArDidHcXXPDeRQ 8L712inmPVorbB+TBGXSGmaOjgkijlxEn4yrVivkSySd64MuuYqFe9fCR/0h1pzO5Ah/fhgDG/H NhtHHzJ0PSJsRjGwjplpouC5WpwouFW8FP3+Ow29Cw0LfLlTjzohyH28PwIrOy8YKDF3wBpFmZa klWf9iaFvj1N9WY2IZoSXXmrXNcuce8p/EVkjV2hsRb82YJX9P9Y4iZNXVKGkwMcHtP3Gp2P+w1 OpGRCWk9mpNvLaUoTirYlk2vfUZrrS/pK+A5WUQwDR+Rvf9Z X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI4MDE1OSBTYWx0ZWRfX9fZt7F4vzb8A IQIJV+kxr/TYF7Vk2+RKsjEKIw5Tl6wtbojNar2AfLb2oiXu5mcpx+adVzaIWySgm0bnQp53dhm 8liFMDivRXMboYTcrbqusVet7z/1Ghd9LRmHdL4ZqhkyH6VK5XBGpG4yYYsEH4ayv4CgL6CZvF9 7n5Oycib6f5+0x4RXWizSYnu468TSeBh/fW3+vth7+fzKfV1vnTrM9XYutH7f/lky0/3nZMp371 PSoY3w/DkNSOfq06SPbjeK/Z8n7V2KFUMrW854cyNdlw00ZxenhI+yHEIT0JHJvirxmlvxWWrdm f0sc5BE9OmWCHg72gXX5BgmSKvFXY0MokvenAFjm98N2QDhdrkcGXkgf1T4LhOgXVRofJIGfBtW NLoQFlTR/zjOnpo8DOFyMfJ0M8YGLAUYC4ZPwsTu0HlF3EjV2P1r/9weITDOCpK7n/CCm5VQ/bn ARB78T4qdUr1YJtjt4g== X-Proofpoint-ORIG-GUID: vVOcCnkaP73L_QLwS6ywxB13tH0Q5ueN X-Proofpoint-GUID: vVOcCnkaP73L_QLwS6ywxB13tH0Q5ueN X-Authority-Analysis: v=2.4 cv=CK4nnBrD c=1 sm=1 tr=0 ts=69516729 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=EE5oNXVUeA2ILyHCr4wA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-28_06,2025-12-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 adultscore=0 suspectscore=0 priorityscore=1501 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512280159 Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov --- .../drm/arm/display/komeda/komeda_wb_connector.c | 30 ++++++++++++------= ---- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/dri= vers/gpu/drm/arm/display/komeda/komeda_wb_connector.c index 875cdbff18c9..bcc53d4015f1 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c @@ -5,6 +5,7 @@ * */ #include +#include #include "komeda_dev.h" #include "komeda_kms.h" =20 @@ -121,17 +122,10 @@ komeda_wb_connector_fill_modes(struct drm_connector *= connector, return 0; } =20 -static void komeda_wb_connector_destroy(struct drm_connector *connector) -{ - drm_connector_cleanup(connector); - kfree(to_kconn(to_wb_conn(connector))); -} - static const struct drm_connector_funcs komeda_wb_connector_funcs =3D { .reset =3D drm_atomic_helper_connector_reset, .detect =3D komeda_wb_connector_detect, .fill_modes =3D komeda_wb_connector_fill_modes, - .destroy =3D komeda_wb_connector_destroy, .atomic_duplicate_state =3D drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, }; @@ -143,13 +137,15 @@ static int komeda_wb_connector_add(struct komeda_kms_= dev *kms, struct komeda_wb_connector *kwb_conn; struct drm_writeback_connector *wb_conn; struct drm_display_info *info; + struct drm_encoder *encoder; + u32 *formats, n_formats =3D 0; int err; =20 if (!kcrtc->master->wb_layer) return 0; =20 - kwb_conn =3D kzalloc(sizeof(*kwb_conn), GFP_KERNEL); + kwb_conn =3D drmm_kzalloc(&kms->base, sizeof(*kwb_conn), GFP_KERNEL); if (!kwb_conn) return -ENOMEM; =20 @@ -165,11 +161,19 @@ static int komeda_wb_connector_add(struct komeda_kms_= dev *kms, return -ENOMEM; } =20 - err =3D drm_writeback_connector_init(&kms->base, wb_conn, - &komeda_wb_connector_funcs, - &komeda_wb_encoder_helper_funcs, - formats, n_formats, - BIT(drm_crtc_index(&kcrtc->base))); + encoder =3D drmm_plain_encoder_alloc(&kms->base, NULL, + DRM_MODE_ENCODER_VIRTUAL, NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &komeda_wb_encoder_helper_funcs); + + encoder->possible_crtcs =3D drm_crtc_mask(&kcrtc->base); + + err =3D drmm_writeback_connector_init(&kms->base, wb_conn, + &komeda_wb_connector_funcs, + encoder, + formats, n_formats); komeda_put_fourcc_list(formats); if (err) { kfree(kwb_conn); --=20 2.47.3 From nobody Sun Feb 8 04:18:04 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E57E0299931 for ; Sun, 28 Dec 2025 17:21:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766942510; cv=none; b=Y27D/BmC/R3bKLZDRQX6EK6+ZI23ISjQ8SUSJsM4BnjyaJjdSQ6mxscdh047Z96X/+MK82txx6gxykYdzBfW3XbaVsKLzR50RX/1jz28y4Fyu3KadCmcbuC1rbID7r+Nr4dU5X95DzbjI3/XivknaGCmppCGe2rF1k+febR5TSQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766942510; c=relaxed/simple; bh=Gak6kPX23KHHukq6jZcbolLHfiPNT+W+DhYM18BNpYA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GH7zvkE5XzB0iv4XOoGzdvSJ0M2R60b2tWvZRKy1JiSHEPhG2l+Mn7ycD3lCQZ2xIRlyVfsfQiXdoB82uM76tZNxxuaBkLSGNWvFvnnv7SZJnnk9f4btinI/s4VtpC4XhxJoP4uWW62ROc6b/M8qWUTzj3ByAtBCKUVj9ZIRZng= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kYHaLFlD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Gl5kodO+; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kYHaLFlD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Gl5kodO+" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BSGejw03477133 for ; Sun, 28 Dec 2025 17:21:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= eDPUkbWaxp6KrkSFA85zDg6sVbEErv1b26+6ctk/jsk=; b=kYHaLFlDC35bkGHD OdWJbpsrEG4tXDjd8ZRlG78SP0I0IfEgHKtIOOXDXX8RQCV7YuIpU6KhrMDdHURl DN0+OTQmmUVx1FKwoiXsL0aW19RGu027RVFBeYo4cbLU1rUE/LgQO/kDkPahXNt0 X8PO37DDjeAp7GE7oSBEkvggk4BgJG9jXhToSnvBS078IBzdedw5F9G+VTV0sBPF WDnEHHGzZooWUNtI4RgS09T6oCqlRp+6ErXP/0sRfqIyBA7Kxm9qxiWZgj9gWsQF uir8ymMHK3WcE2WC+VFV/3pfWbSZZSTXhs3cWObTZDgzdtrvPhPAkGeCdy2r9Ok5 gOXxXA== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ba7u5jey8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 28 Dec 2025 17:21:47 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-88a366fa140so424661466d6.1 for ; Sun, 28 Dec 2025 09:21:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766942507; x=1767547307; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=eDPUkbWaxp6KrkSFA85zDg6sVbEErv1b26+6ctk/jsk=; b=Gl5kodO+1SnE5qxuciW/5Ks7mRlg5P6Cg5Ute46YstHnUj3igOhLUh85qpm8mAPwXh qjh0j6uPPx3+3TGWmGWF+p0OPg+wU5LqnBpnxOupbeqF+Wc4f8EJnqqAytjVjOdEu3cC X3KIMCsnlvD6aBTLw0+BJN2IA2VR0ynWopH6UkxG46WDkG4AS5PjWEFqMzO+OYds+fpv D2lam09vOzBku68HlC8tvJMWhqLqFWFA1/dksSeVup3FmlCdaiuC1cBMHjIMy+dDPO5t XPHML8wQxVplzs42gDPZ/ewh9GERh6gvU3SE+5tX1jDKXmAK5TN5X4id6WxSCKaSib1h TiyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766942507; x=1767547307; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=eDPUkbWaxp6KrkSFA85zDg6sVbEErv1b26+6ctk/jsk=; b=IzowBO0eTyb5rSh8AWNLCys7Ap9BV2ykK5yS7gqxdR5h1VtAXbKhJ0sUwriFBlxod0 DDfqZXE4sdTrw4R3wy8/EAGIw8v80VANMVy8k24tbUZpPUsW/c0jnJZf9k18X+HNg9gH 0qIQ6N5ecm50osmzf5W8AN7bmY1IKrxXyRGxvVRb4dAvhaHNkhyYrt9xpROrLUCSpc6o uEcUce29PEx/m/DOWMy7DPoJBq+Ut0pZ2BQ1Tt02yoUVYHXocxvHBvpl6hrbyIbuoqVf bRbJZMgdNLFDzc0WU7QAquEJhdNLZV3o/U78PBT9iElPnBhCbphhTebx/kWk6BBKKCMK l70A== X-Forwarded-Encrypted: i=1; AJvYcCWwa4O8g+9MCY/4ACAS9h2bjoxOF2yRHqjkr/cPK61UPcofSZ8VZMcobGHA3HPcLGH2iAl4mMKXiwMVHuM=@vger.kernel.org X-Gm-Message-State: AOJu0YxjOC5lmYjmZJm+wMPTWocD6qm0x4tV0GqwwW4+vGkHRC4akHgU jfYfR7+fUCWNU1PEYTFIDWRe4BrxSv/iHfyiMIhe5l6dUfbfN3d3baNEMni7o9g7AG5lzyuTznQ F1Ugtx+/RGqjGyX2/r1H5u4PBkT2lQJmpCKo/qJpHlLcQ/PVUlHJYazpLo3wpR504FR4= X-Gm-Gg: AY/fxX6hOt8V5Rcwg86E6HGLOn+74EoSvr7rA52WUMyIFaiH8uPTJH5ZYY8cF72fFvP MVjX47+heQBnBVmUEXWVomWgHcaWMYtYizJCJsSuugSXuXmy/9V2Q5Y43qF1XecJeg4xg1hfYjL PpiH70pSIeg+VFTFHumT5g8yuaMXMGGitu91OatSbQU9UmnAvVzA8w5WmPlUbDebjfBx5MDlGe1 5jBlFdBnlXxDE1G2dROPpRiSCgh/gqeY2npZT/5Bk6SeWoYDFHSXHmgeXC9zogZv21BI6SKRquu jOJKkXLbXfHatSl2tZQOxZXlAeW2ZpkyMscSPVc+yY9KSlJdZZTo/GcB/3TK1Dwox2vpogbkU60 0sdWoC8VmXRHUJZOJoSETTuxYXWZAW3MEVMSADVjin7KR+gwiXqFgs7PIGCiniy6NvNR+0gHhSs 6xLSkdSSqX0SQshus3KPSE9Vg= X-Received: by 2002:ac8:7f92:0:b0:4ee:24e8:c9ae with SMTP id d75a77b69052e-4f4abd80862mr441188721cf.53.1766942506999; Sun, 28 Dec 2025 09:21:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IHf5aTkXX2NRIiLpAzpQc0et6EQtLYn+LiKPc7DpfXcCxPaXlFr5U+z+AsfAIGACL8LJu3LrQ== X-Received: by 2002:ac8:7f92:0:b0:4ee:24e8:c9ae with SMTP id d75a77b69052e-4f4abd80862mr441188411cf.53.1766942506525; Sun, 28 Dec 2025 09:21:46 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3812251cfffsm76871031fa.19.2025.12.28.09.21.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Dec 2025 09:21:44 -0800 (PST) From: Dmitry Baryshkov Date: Sun, 28 Dec 2025 19:21:36 +0200 Subject: [PATCH v4 4/8] drm/mali: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251228-wb-drop-encoder-v4-4-58d28e668901@oss.qualcomm.com> References: <20251228-wb-drop-encoder-v4-0-58d28e668901@oss.qualcomm.com> In-Reply-To: <20251228-wb-drop-encoder-v4-0-58d28e668901@oss.qualcomm.com> To: Jani Nikula , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Christophe JAILLET , Jessica Zhang , Louis Chauvet Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Suraj Kandpal X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2565; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=Gak6kPX23KHHukq6jZcbolLHfiPNT+W+DhYM18BNpYA=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpUWciDY6HHVs6gK21qEbheR3ppdMAcAcg1J1bT HyuUH3YU6yJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaVFnIgAKCRCLPIo+Aiko 1bX9B/9Zu6zJxH8C9m/gvM/KNsj5PCPWdiWrODMBmBWvdZ0kS1Zzm5usg4fc68mBA3PeOEy4kLR HQ0l69wS2Y+h9iwJ9BayE9FBb/wQN8pzE7kVD8Drxw4TCjEbziAG6HN21N7i0laDyN2j6G2Z9mr QSK92QX3QgrGr+Krx9J9wX7b7qkNzuMaQk34CAn9b2RPV0U75LTpKkfFEufPXEgF142bA6taW7g DWeoeEI5Wvmbn57820/bNnAz4D+cyqwsf21H4zDvc+i+vIpciJwLuNigEBCTLW5gewsSF7UUAyD cV2GYEwZ3Qgrzw7WdMqOvqqe10L/fRWYeNaZ9KLEL759Utp+ X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: s5tkFgzc12Do2RuDxjFpRpHjP_XIYrbA X-Proofpoint-ORIG-GUID: s5tkFgzc12Do2RuDxjFpRpHjP_XIYrbA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI4MDE1OSBTYWx0ZWRfX3fqDOZK0IIAy DwGxa8hlBrCnh8jSqgt9Rf/pUuQ0b4Ny2k+Vhllw8RGYkvFiZVjhkP/+AO8Gsekyv6hKTIghySi KgNwDG2tX3LS22wVF/NsY/oGXVng8t18sW+aKynNQvCFnxafZ0bheISNplE3X6B9fBzsaC6F5DC ZS87TYZ7dolOEidq7PNqUiT59RjhjVkSqURQNsdBcUCnhwwjWFHZiAj3EYBa4IosG0Os75uM2El koSx5Qjl2fZEP0HrlMbqPP1RDszmBPwDD5ERSdaO3TWPq0S7UJf7w0mW85XTiptYWpAMeHmJ8Sx ykN74wo20r7s1l+zoCuEAX8wIYxB/zBFrUD9cV9hlqzeVkG0TAI+QrOSh8ukIMVLod2cKH0IKT8 01+oVTWiYwMKPkL3P3O3wZ/1tCE10boTXGChxziF2c1qUxjEjTLMocMjW8Kjg82apUbbO6otdCD tG9HNPUoNCPKhIqb7Eg== X-Authority-Analysis: v=2.4 cv=DptbOW/+ c=1 sm=1 tr=0 ts=6951672b cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=mhD89yN676IZukTL2GQA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-28_06,2025-12-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 clxscore=1015 spamscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512280159 Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/arm/malidp_mw.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/arm/malidp_mw.c b/drivers/gpu/drm/arm/malidp_m= w.c index 47733c85d271..498db114ee9c 100644 --- a/drivers/gpu/drm/arm/malidp_mw.c +++ b/drivers/gpu/drm/arm/malidp_mw.c @@ -85,11 +85,6 @@ malidp_mw_connector_detect(struct drm_connector *connect= or, bool force) return connector_status_connected; } =20 -static void malidp_mw_connector_destroy(struct drm_connector *connector) -{ - drm_connector_cleanup(connector); -} - static struct drm_connector_state * malidp_mw_connector_duplicate_state(struct drm_connector *connector) { @@ -115,7 +110,6 @@ static const struct drm_connector_funcs malidp_mw_conne= ctor_funcs =3D { .reset =3D malidp_mw_connector_reset, .detect =3D malidp_mw_connector_detect, .fill_modes =3D drm_helper_probe_single_connector_modes, - .destroy =3D malidp_mw_connector_destroy, .atomic_duplicate_state =3D malidp_mw_connector_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, }; @@ -212,6 +206,7 @@ static u32 *get_writeback_formats(struct malidp_drm *ma= lidp, int *n_formats) int malidp_mw_connector_init(struct drm_device *drm) { struct malidp_drm *malidp =3D drm_to_malidp(drm); + struct drm_encoder *encoder; u32 *formats; int ret, n_formats; =20 @@ -225,11 +220,19 @@ int malidp_mw_connector_init(struct drm_device *drm) if (!formats) return -ENOMEM; =20 - ret =3D drm_writeback_connector_init(drm, &malidp->mw_connector, - &malidp_mw_connector_funcs, - &malidp_mw_encoder_helper_funcs, - formats, n_formats, - 1 << drm_crtc_index(&malidp->crtc)); + encoder =3D drmm_plain_encoder_alloc(drm, NULL, DRM_MODE_ENCODER_VIRTUAL, + NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &malidp_mw_encoder_helper_funcs); + + encoder->possible_crtcs =3D drm_crtc_mask(&malidp->crtc); + + ret =3D drmm_writeback_connector_init(drm, &malidp->mw_connector, + &malidp_mw_connector_funcs, + encoder, + formats, n_formats); kfree(formats); if (ret) return ret; --=20 2.47.3 From nobody Sun Feb 8 04:18:04 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 404D72D3A93 for ; Sun, 28 Dec 2025 17:21:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766942514; cv=none; b=Y9LU6tjt+YdgzvJz2MAATQjgh/dfwisq6QoUr8ywBJWahX/tz9m9rP6W0wFTkBt0gvBPk9LCRGFX2gHrgGcU+INU+orwrZRkpVlW5nCC0CAo4ExP+saUyt0GH5Xoi7ZZxE982/bUfQeCMOHfYY6u/lsArFN2p0Zwt077H8fgI5o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766942514; c=relaxed/simple; bh=y1SVtonrqm+Vkemj18tTHMsAczaNy4uKaP+Hxds9BuY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=B/wJNPk3s/oLRbdjrupxs8WOoVN+5nhb6FNMXazwBUIhiNJ/WZizHte19UpuB8UyjeyQakw3l9fouDEFXwPMZcyBdmEIycbTmm3fMZ5k8Wt9perDq7DQO4Gt1fSyTmDpdZOuQA67o1Cofoh0+pvoMWYb/61IMwaj7UYKDKY7OlQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Tv2gwtYh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OWyrgb24; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Tv2gwtYh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OWyrgb24" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BSGlZiK3719424 for ; Sun, 28 Dec 2025 17:21:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WlmKM553K65TViFCjEWO6I9vFd2gpoyFCkRuwRh01QQ=; b=Tv2gwtYhe9LuT/vl Ms24ndeqFrDVwYDolDRONk7c6Ce4NYzZY8Odkhnhs4DIf3Pim/yu/lou2Jp0JKmZ 2yaxQGEz/r6vwzHWz6ytkOIi+qi4rvffeaGBLT9ADJwpNFjeXTK258jJB/lGrWUO 30uFqgIcU/KBgho1EeT4RkrkVk+lH0gpB532i8rnllVykUX5Zv9/bZdk5MgHm5Ma vp/lyrEguZzkTs56kUHRgtkxJ0wMJbxrGtZ0Wc3bb02VnB8kJwRh46BV06xX3Yrw 3wC3Sgxa5rU8a9wwL2/VCOBu2tZcI0QZ7gZl2F5HGIgDaRYYWdclCS/IsA3UYs0O BgSO0A== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ba6f62jbf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 28 Dec 2025 17:21:49 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4ed6ceab125so228099181cf.1 for ; Sun, 28 Dec 2025 09:21:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766942509; x=1767547309; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=WlmKM553K65TViFCjEWO6I9vFd2gpoyFCkRuwRh01QQ=; b=OWyrgb24XyTN2WAhh6ZlT9/g/0PUyVPGFPOjf7l86MS+qY1YXC3Q6jimjHtnCl7ucu Wn0FFbEZ3VDTGD7x+4GSFA3wjk48MO1e9c6ZF7EO4FUox1sWFvt5BMZwFMrn+ZH3sQSK +w5cMTFfQUlywobUghshch9SsQZEG7b8AzjBD/iosfPux9l9Z0Zo49WVpQdO2nE2nWCb i/qaH460I4uJBZL6HBXzrK2itU6Qu6Uvqh4+wm96sjqMxFAFVd7NrTWyWy/kBCV/h5dJ WMGkeHfCUH+rhpDujApbmq0ihFFKjeiB9+LX2iUhsC2YfqZU7lweBgdqvlrdWGPMX7Du aLnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766942509; x=1767547309; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=WlmKM553K65TViFCjEWO6I9vFd2gpoyFCkRuwRh01QQ=; b=ZNN8Wzm/GP42CSAsUS4fym0UoDu0qRk1SnEQzZ3+LEjmbwmcwjjO6JekIL7WpBrwOe NBH9Oc+m50/F9qSYbh+ZeyS+kfkZEM6HUtc8uadggyjiHD/dI8idkUL2q2pTkWVjyZTV 75ND1oiC1SCZeFR5HII7gdPWCqkfk0qRBLs277V0GGjE4/kzXxrorX/rYT2uoI0e9zkl aRwb4eBXAZ4cwXvtunF6g1MYD64bqSYIXt0hUyz6zDiqWNxyDGGNA6eYRtA1CwqeWDTg ErRsz+wy9ZUb3vcyWpw7SivvIAMKGqrP76nSfQlLiK/R3Kqy8fonW2osetUMosXdaRYs 7R8A== X-Forwarded-Encrypted: i=1; AJvYcCWwJjLLICgqconlKbSJN+JX3DL8XorXLmIhiwZWTwdYO23YiOTAzo7NjBZYabxL0uEN+kroIJoQAkc1lgo=@vger.kernel.org X-Gm-Message-State: AOJu0Ywe5qZ+YBIHVAFVCHKqhBT1Ci9owEIJ4cwb3sbp0nsB10xR66v6 O9+EcZc5uaCmR/D7wxCQXyaLRp1mr3nriFa5tlz1pUEj4q+3yAb0AOxuCk9+7CAbWyDqIk0QORr kMeK0UhwUAYtYWXKzyQptNqbSKqqB1vLiOfuM80fP6OuVxXVaCkMXjKav8Vp08eRWZuQ= X-Gm-Gg: AY/fxX42meQx7eM6SRBM8ipxhTODqCHlRZVsIOHsahxp+VahnHaTRezRI3K7VUbVv5G k4i71161VKFon0kBXkS30CNH2xiXRBB40HyjZsmZgClqtGoZQeSRfviz2yL5TbDg432X7O6Ukaa 6UmIIJanWA9WEZ9wEFYqNm9Xmn1OQag5MylPXOXa3cksAqzEgFfH2K/d4/d1Ga46vZNa1nUoxyG o+6s0dtxXJppDSOU3QLLLDrBPmwNm7wZtHnAM5Ys+drdXZlYJzSdb3ZplP90mnsucNVe8PJLPeN rYbXwbv58v4lgZqT+6S7cBqssCKcsT8xAE+T8bkTt7v1DxPc4BBWbh4rpP0k8QHNwmR4TuTIaL4 5mhK8k3GipyfFmTrr2VDpzYNB0kq2rc00epAd3XbrJoRrByL35unBHLOCqiEpMv+BcFCCb80+O3 bcK+J9+oQ12DRVw4wa+SLWMFQ= X-Received: by 2002:a05:622a:1e96:b0:4e8:a9a0:48fa with SMTP id d75a77b69052e-4f4abcf6bd4mr375254141cf.30.1766942509439; Sun, 28 Dec 2025 09:21:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IGEFrvQBeWUWGNN3K4NBz/4O0OOqfjaG3q3yoWI/L8raTZ69fCS8BqISuUrv8qLP6Fu5J6f5g== X-Received: by 2002:a05:622a:1e96:b0:4e8:a9a0:48fa with SMTP id d75a77b69052e-4f4abcf6bd4mr375253831cf.30.1766942509004; Sun, 28 Dec 2025 09:21:49 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3812251cfffsm76871031fa.19.2025.12.28.09.21.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Dec 2025 09:21:47 -0800 (PST) From: Dmitry Baryshkov Date: Sun, 28 Dec 2025 19:21:37 +0200 Subject: [PATCH v4 5/8] drm: renesas: rcar-du: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251228-wb-drop-encoder-v4-5-58d28e668901@oss.qualcomm.com> References: <20251228-wb-drop-encoder-v4-0-58d28e668901@oss.qualcomm.com> In-Reply-To: <20251228-wb-drop-encoder-v4-0-58d28e668901@oss.qualcomm.com> To: Jani Nikula , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Christophe JAILLET , Jessica Zhang , Louis Chauvet Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Suraj Kandpal X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2248; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=y1SVtonrqm+Vkemj18tTHMsAczaNy4uKaP+Hxds9BuY=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ2ZgulKVA3M8710WTzVthwCt77+n/UqL+imglvP1WFdvU tLLKu5ORmMWBkYuBlkxRRafgpapMZuSwz7smFoPM4iVCWQKAxenAEzkezUHw3y7U6W/2AzlY/ga czVnPbq2vnf5299Hzepef3uYO7m4ILF8Xvi89I8fTDLiL9jZ7msSvvcteEb+PRnLiywNT65wSjd 9WTeTf62lRYW4XqEY+45Kz0s7luTnK05+bSO9I7brv3u4i0bg35NH9VqXHJhjoel9Z9p/rWeb67 +tzj3Zfe1rrcfTwmPrWIX7fvmruEtodQk2Nex6ergx8JPxukwBbtX6s44LXyZtNJSUcMnwsNxXM +uVmOy66LWbXgetvPBps3TSps/7bZiFLkc++/Gr7uvXasdZuzsrzVMv650XsZ1VEmztkizw/8mT /bwfuevOfPPw4n9Sa1EW36xWF3eYq/xlwsvVkVcsC03SAA== X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: zq2DARSMYHJR0LwygaEptPMFgQ-htQDL X-Proofpoint-ORIG-GUID: zq2DARSMYHJR0LwygaEptPMFgQ-htQDL X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI4MDE1OCBTYWx0ZWRfXy1jjD92t6LF/ 6lRFkIffqZZo5vaXcEgXOC17/sXVvSkWkwQAheAAj+ePipJjGIYgACPHABk1u545ZY4GRIK0gxh U8s+CkvGEVTuqONgBC+pCehfn3CgaqquulfOZQ0Dgh2/nuW4l9P4nvy9SjGu9gm0f0Q6YM57jiR yvd0a08FcfQ2SCfOvT7ieGYd8RakRvuW39qSdj+xlh1Qu3bt8guH6VkP+fID+RCvm6JJHcVzFKU fq7WQT6k8GAb71KX+HFkak0Cwfz6Y8T5zzbNkOX+jMLN8+0I2J3i1csMmHPp+YqFGgNN98KV2PP +6yojjQQJxVGrZOde/XxaqQR96PLZTGFx/2juE//5A8wPaTcZoHNkvf5c0X/qyQY1kUTg1ZwX7P rTWSrnQHIMASK2/XUP/i/Zr1BXRLfCh+FA8X9ecP7S0NubqGgVxBaZxEYR2CP+y9OBWEW6+G875 T2NqWHr9CyS3AiNN6Bg== X-Authority-Analysis: v=2.4 cv=YuEChoYX c=1 sm=1 tr=0 ts=6951672d cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=mhD89yN676IZukTL2GQA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-28_06,2025-12-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 adultscore=0 phishscore=0 spamscore=0 clxscore=1015 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512280158 Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/renesas/rcar-du/rcar_du_writeback.c | 23 +++++++++++++++---= ---- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c b/drivers/= gpu/drm/renesas/rcar-du/rcar_du_writeback.c index 8cd37d7b8ae2..64cea20d00b3 100644 --- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c @@ -134,7 +134,6 @@ static void rcar_du_wb_conn_reset(struct drm_connector = *connector) static const struct drm_connector_funcs rcar_du_wb_conn_funcs =3D { .reset =3D rcar_du_wb_conn_reset, .fill_modes =3D drm_helper_probe_single_connector_modes, - .destroy =3D drm_connector_cleanup, .atomic_duplicate_state =3D rcar_du_wb_conn_duplicate_state, .atomic_destroy_state =3D rcar_du_wb_conn_destroy_state, }; @@ -202,15 +201,25 @@ int rcar_du_writeback_init(struct rcar_du_device *rcd= u, { struct drm_writeback_connector *wb_conn =3D &rcrtc->writeback; =20 + struct drm_encoder *encoder; + + encoder =3D drmm_plain_encoder_alloc(&rcdu->ddev, NULL, + DRM_MODE_ENCODER_VIRTUAL, NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &rcar_du_wb_enc_helper_funcs); + + encoder->possible_crtcs =3D drm_crtc_mask(&rcrtc->crtc); + drm_connector_helper_add(&wb_conn->base, &rcar_du_wb_conn_helper_funcs); =20 - return drm_writeback_connector_init(&rcdu->ddev, wb_conn, - &rcar_du_wb_conn_funcs, - &rcar_du_wb_enc_helper_funcs, - writeback_formats, - ARRAY_SIZE(writeback_formats), - 1 << drm_crtc_index(&rcrtc->crtc)); + return drmm_writeback_connector_init(&rcdu->ddev, wb_conn, + &rcar_du_wb_conn_funcs, + encoder, + writeback_formats, + ARRAY_SIZE(writeback_formats)); } =20 void rcar_du_writeback_setup(struct rcar_du_crtc *rcrtc, --=20 2.47.3 From nobody Sun Feb 8 04:18:04 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E63022D2481 for ; Sun, 28 Dec 2025 17:21:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766942514; cv=none; b=At7Ma7CGOXcx7Vb33TJO1yhBPKzXvFxK6+JLKtOSwwOgmszdPHUxl9qhICiYzVc88zEtjijP/4D8/F8wowyNrCvVcADxq/Qy4zQKMwgKxO0XUTWZpX8dV0fznTt/MTJxdBr1+OqvD6H3I4cu6GxiRqZ+pcVas3Jhh4se7qVS4vw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766942514; c=relaxed/simple; bh=xzYTa/EfA8HI5QOy/2+R2YoV5rkgAh7n+QXK0lkObWo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jAaHEXNx55e1XigpTY8+MldM06n39pVoW9lkrJMonCxkRjShmFrfz4kTL6F2d3RyCQbHYeuwD4kBsO4Pw9/h0+NiYdp5e7SlJ+O7GfX8gOMNgHTJPM9zQpRvSO/Wp08+bIof2sRQ6YXd9yZ3WSshVwaDtXPiNvvkrKE+JgfzBUc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nHYPAMyU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SEzhhEQQ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nHYPAMyU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SEzhhEQQ" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BSCuSgE2560456 for ; Sun, 28 Dec 2025 17:21:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= stPaTlDyP6pjIcLXxQYHh7Ugkri4ssOkoL6G6tZaLY8=; b=nHYPAMyUOg4sCsC4 eB2ocb4P+RrJTbrr2y+1AnS4GWXykf+30iVKmKrxfhWMXN7G7naVKHSGHx/5gaH+ Q/Qjm+FpVgVYXStDPg86nHoGVpaZe8s5N4+26SfuTnzB4XfduT9iKuavdpu2aLlX EAf1wOxVxh3fQv4KBwz0bVIU/hZF5h/fqhg0wOoAjk3R+ZemDHhRvM+dqeMmwiQS IY2ufqEuY2hAz9DkeWrRKpKwc6osNB5VY5wxro9fHx+ZcjGjkc+LG/9l9PMCQF7L Qu2ew0tn/y7tbJtB17mpXJZKvmoO6SXpKmndZ6KxVUDKubC01Fnp9pKxKx+5IMgP 4dF9Ow== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ba6sg2ha1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 28 Dec 2025 17:21:51 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4f1d26abbd8so250847251cf.1 for ; Sun, 28 Dec 2025 09:21:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766942510; x=1767547310; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=stPaTlDyP6pjIcLXxQYHh7Ugkri4ssOkoL6G6tZaLY8=; b=SEzhhEQQiXK5lURKQ3i+S1Qr6jV1zr32fZNHQua1izH8W+AM9l2d1A6JQ4/cUuUuuL 9JATqmdz25K+5P4xQ8KzBlRedA1BFhg9hcsEMz+8Ek/EDOCPa96eRtEmy4SHWlcOfJF+ Z1yIzv7XpEiiXhHkkZO3hLo1eIQmB+rGCZhkAt3bGmPxUyNYMXebvOA0eSdz7DYw73Gy 5xnF/45D4ccR+OOWQTDsVfCvjBcl3iyNGG22x6ESl3IhsQ4oFOB/TfARgAEGWooJDOBv NHkCt1D6c7Ze8A4EvKAz54qX3g2z5uBVorljDW8OkpPqcN0Yh8LC6gBku8RoUQwGjnXQ OH8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766942510; x=1767547310; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=stPaTlDyP6pjIcLXxQYHh7Ugkri4ssOkoL6G6tZaLY8=; b=PcixesQ26uyExKAHMLKbrt8mr1V7iSxaUjBnAGWpGKbMPfPPc/0ccLBQgna8XWZ54W unpgnt4K8og7IsAmKnmffHqQSF1vC54YXwSNvOm/+cyLGGoMbnZ1038/gf7t37e5NrvS 3Vwel9iT4lQuwkLCVcAuQHwVrqqevTR4vBnIjS2KxHafXI3RbnTz8DOkdaZo0YKENx5k FAzo2AdlLkLcuOIykih9rG6scn4zCkHvN61oA2ioL5MQD3slR34xhAI1YDDgg6hJGcmy VJtamYeg2X0YnV8v8TCmHqEc6wiB4MC29dGMVfMk0kRO1n5erumOW01bikwmxDV3ScH7 sbag== X-Forwarded-Encrypted: i=1; AJvYcCXxUTeoORWL66lpmHXT2UV+EfzIHnpIjBm2FdyAERGII40kBoE8J2wHzIegGXwHavXLvR3n8Ii60uuG4eo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8f9orm33/RRSvqzsC7CMrhtVVHgeszCwVA9iPUlTNbTQYOTnP QoBqiy8QB8TyEVLIg9Qlpf//QGVYEnC7rbb/UcWuZhd62Dq44bYKmxDc7dKruqFbOH8RnQR+QBt Efn3Y/lvC1N3Q7kfQeLfj9qLFqZdorka/r3zpLKr4sjcXTVQLinYSLvFUbJrk9OpCMr4= X-Gm-Gg: AY/fxX4qpq++GZGmqu8mpCrDabnXJHdZ0PIwsZCp5iBI9Ic0SXFh2Y7mcuoid/kz3G5 HI5btZLRpBaPHV3vr1Cg75fzsokDsNGhGs6RQPtxZHjFh2ZRTOH63kQZqU1UrT7YI88BdhGwG3g Hro2Ur0pUoR7n9OJlZqYq/1LYmiClBOHVD2fJ4fCMwROHs2ySVY4L7jwmRzBg1tgdEk7gkO+bpV gINDQ2XnvsFuLVbY8H7Sz+ucb8fZ2CT4NoNfjAybfrqMuTRhe8IieFB/3D6rkT/wprqUQYDZrm7 xGKw/YJfVHM9YT9FxTVcc4wLMWKU58r4SYjnGSVXpI6YNFXbstxv1/U30av8WoznK2p8NBzvAh2 9/nbiH2kR2jHUAxhX7FDDgEh6MZXvBm8ZH14HTpC2QFNaMME3U7OteKoMI1zDs2Znvr7uN5A85w 5fpBPH/WFyPOuTIGiOy8P3bMo= X-Received: by 2002:a05:622a:1f88:b0:4ec:ed32:c3f9 with SMTP id d75a77b69052e-4f4abd055b1mr480629991cf.29.1766942510582; Sun, 28 Dec 2025 09:21:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IE46X5ME/cJSAhXh+LJc/4rpNKJJcT6TLHe0qPrboYnIgch2/evOzlw9QUxO7vnvIRO7gsLtA== X-Received: by 2002:a05:622a:1f88:b0:4ec:ed32:c3f9 with SMTP id d75a77b69052e-4f4abd055b1mr480629561cf.29.1766942510201; Sun, 28 Dec 2025 09:21:50 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3812251cfffsm76871031fa.19.2025.12.28.09.21.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Dec 2025 09:21:49 -0800 (PST) From: Dmitry Baryshkov Date: Sun, 28 Dec 2025 19:21:38 +0200 Subject: [PATCH v4 6/8] drm/vc4: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251228-wb-drop-encoder-v4-6-58d28e668901@oss.qualcomm.com> References: <20251228-wb-drop-encoder-v4-0-58d28e668901@oss.qualcomm.com> In-Reply-To: <20251228-wb-drop-encoder-v4-0-58d28e668901@oss.qualcomm.com> To: Jani Nikula , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Christophe JAILLET , Jessica Zhang , Louis Chauvet Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Suraj Kandpal X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1683; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=xzYTa/EfA8HI5QOy/2+R2YoV5rkgAh7n+QXK0lkObWo=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpUWcimSXjC5I40z+YRP5l4N9Pd8rbhOQ57vQMn zZaKY2yKwOJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaVFnIgAKCRCLPIo+Aiko 1R9HB/4mQmUa/OGajO4xKbD2IFdVvt+++OOPGvLicDm0j7FhJTr7p//We0wf1N+GA+QqJGZ0nxy V4ezDgOozgp4Uvx8QVOLOfZz1xUCjntHe6O4xTR8UBlaj/LqAjoRFm0lUyAdxxLMEyEU521iP2N ZbOLK1AC3yfLU5himWI3isf+GJ2dM/3dxP0Q1fOlY0QNu5wf6/qTsYGOUaKHuaiiVA6Di+FJC// +rGCKFkjOC/N5dGVyYL6EPg/z37Z0bKg7Niw01ZUka5FxAQFyR/SupZMD46M2HW1QCY2VYCZ2nb QUVy5ElbO6tShYK9+5jf+O7QjLkgOhuEc9COHlpUlxMEv6fO X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: f83nZdNFWVwQ2bLRITEB0wGPalvbyt_H X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI4MDE1OCBTYWx0ZWRfX+za519Mo4qb2 BgSafLyjTgG3qg0uX+BQo1EB4sLcS4r6Qdcwy306IWX7NM/1d6gHsu27FOAGBEezb3JcyrGViEM TxSjNxckUAi140+SZbwDWdPpQtt3gX0BoGd94lk8R3g9N5oZvZnIX9fnKDhcbSB6kdMIs9lb4xA ppqJi1PNi5eHsmQme9dszddFwDwV/NFJUwE4GlWL4msn5fVf/5rL69pJFfKyu5jy8iaMtz6B9qL 5M8ZjWAqRVB0LP4IgoavrGd0CA5F6hzWy/6gAk5tZcGP5IXCSwYnCCxDUn58s9tW1mUfxRaQqNh L1en+JwPdUEDyZYhcpOTBYdRa0GaS048p1CZ+VQSoaOujmiqxtZY/Dq2NPSeprSKWBf8edgLzyc SMb2cdsGb3geegokHJc6RqUVQ2+2gvfo9c4EyKp6mL3+UYYYoSM6aQLclawApMau7w0PCwA/N/K 7r/Yp8NzyBz2JFFiSbA== X-Proofpoint-ORIG-GUID: f83nZdNFWVwQ2bLRITEB0wGPalvbyt_H X-Authority-Analysis: v=2.4 cv=Y+L1cxeN c=1 sm=1 tr=0 ts=6951672f cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P-IC7800AAAA:8 a=QyXUC8HyAAAA:8 a=EUspDBNiAAAA:8 a=VKUx2AQ49gFIcjACzlMA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-28_06,2025-12-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 malwarescore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512280158 Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Louis Chauvet Reviewed-by: Suraj Kandpal Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/vc4/vc4_txp.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_txp.c b/drivers/gpu/drm/vc4/vc4_txp.c index 9082902100e4..befdb094c173 100644 --- a/drivers/gpu/drm/vc4/vc4_txp.c +++ b/drivers/gpu/drm/vc4/vc4_txp.c @@ -378,7 +378,6 @@ vc4_txp_connector_detect(struct drm_connector *connecto= r, bool force) static const struct drm_connector_funcs vc4_txp_connector_funcs =3D { .detect =3D vc4_txp_connector_detect, .fill_modes =3D drm_helper_probe_single_connector_modes, - .destroy =3D drm_connector_cleanup, .reset =3D drm_atomic_helper_connector_reset, .atomic_duplicate_state =3D drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, @@ -602,10 +601,10 @@ static int vc4_txp_bind(struct device *dev, struct de= vice *master, void *data) =20 drm_connector_helper_add(&txp->connector.base, &vc4_txp_connector_helper_funcs); - ret =3D drm_writeback_connector_init_with_encoder(drm, &txp->connector, - encoder, - &vc4_txp_connector_funcs, - drm_fmts, ARRAY_SIZE(drm_fmts)); + ret =3D drmm_writeback_connector_init(drm, &txp->connector, + &vc4_txp_connector_funcs, + encoder, + drm_fmts, ARRAY_SIZE(drm_fmts)); if (ret) return ret; =20 --=20 2.47.3 From nobody Sun Feb 8 04:18:04 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 129E12D73A8 for ; Sun, 28 Dec 2025 17:21:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766942518; cv=none; b=LBxEvJV+QUVJHGvTRN6Gk000CngcS4e2eMSM8MdJ9C57Xyz2rEKZgYZstuPSlx4nRy/8o+tIGgxZPThGwo8iXVWBHvrYB0vuV5FweCNs60xq2EManlOMYBb8fWNgNe65pX6vCzomXFmINff+WXEsB5pooj8v+5JFMaw8Jnei9RY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766942518; c=relaxed/simple; bh=H3BLuh7aucG+4twvP/0GQJX85YA5nUk09wN5sJ0vud4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Whje3g7t9Zli7v3/IC8xY+4oQmm7zvx6oPiFD0iy4YSJ9lRtrjXf6+aMrLP4L1c3h+dFBQWTTvm4CPBy11+x8Jn6eobqf+GVnZERuC/IAN4vFHeF7NcK7lqPeTmnVZ/7LPVi6FzQCN1Z37PXGoY3Lbm+5yFnvFiVkRG49gqmAok= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JEih0MQJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VD0N/aOd; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JEih0MQJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VD0N/aOd" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BSGpWP32583476 for ; Sun, 28 Dec 2025 17:21:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= M990uSOPBnzSQyXKdb+7ZT9yeTvRXfVYC9QFNhhhHfQ=; b=JEih0MQJoOeD/dP0 6h70r8Oejwzp8CNd2hman62RK6uLIxo7z2CKaj/HxKVt+r64Xusv1zB/iSx+CmZo hdhUQtT4P3IckCAHmmOTPHD1D5z8qQHCvP7MqBaqE+rrkXOCfiPDYQG4SDhYVM/w Bz3HJzMLJVvI8/YNNMJpbDYO57srM/rfrCuVPTLD7ov3aG4ehTE7zNiw11U0ZVRr BcnuXEu27tfIXlas0c+C2jY58VMbjtsO0LllKdrlf9ctMk3pNKVdGWXWAsdr4suk 5r+nsg6p2aeG1DtjcaidznjhQt+Wk/Ug4EGYjSpxy+X//cM24jKmvaV+XLBhku4c fSfR1g== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ba4tntpar-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 28 Dec 2025 17:21:55 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-88a3929171bso176776316d6.3 for ; Sun, 28 Dec 2025 09:21:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766942515; x=1767547315; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=M990uSOPBnzSQyXKdb+7ZT9yeTvRXfVYC9QFNhhhHfQ=; b=VD0N/aOddRjOal8j/nd3mSV28hOFuUVpBjta/ulDZTLTp9GtZoURzzPwl8HZrm2QON dLdxVnL37sazQ+l2Pp7p+KMjYrVsx/rKC/Oq2K0Jk4iTp/Et9lqdHrWCjc37xL7LqTBW rXpUd5kdTaFubguJJmULave4eB+HIPwhceJYP8HCdg99+oOuS2f5MP4bpzTJNQqSjg3u vuYPU/oKOrnzqRqbiPDM1l9mNuc3a0/538oXNuIMsSQB4wwMfe3OyJOysZ0x1DFeu9PU VxlpCkx+wJr6IK1dRHeUfRX6U32v37pDIbsqKhXg4JPvAEYmLL+YnhduXgeQ3z6mI8rg D5Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766942515; x=1767547315; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=M990uSOPBnzSQyXKdb+7ZT9yeTvRXfVYC9QFNhhhHfQ=; b=UBnt9G8oR3uD5N35weUFO2yt+n7Cmc4uttCxHEJ29kOGcDD9GL1lbUCjhMpIsJ29EU qBaoiXcKjOD+I5P4fGFUYE2apmwWomCZd7psKD4AWgsyH2z+AVuels30ZmLmwxcLL9Kh PmcD0V1EBAOy2fFmCFa4K+utyFXyXAtslPT8Yble42lkuYOAJmuYuDckDk90P45Zztz1 NnV5XFr8gcCOfsU2EgY/Q0lUhmvozaXyIRwVZn9tJfIcFYIovZTX2QueqswQJVy51eJb 3zrwoWRnnMKU5v7YFZeDrfvcEFwNTy9CmoPvNgUA2Xw7qJTx0k9TZb4pK2fCZL5g5zTS ghdA== X-Forwarded-Encrypted: i=1; AJvYcCXwl9NoxROJiuQnemPuX3Uazuz/vnlieRFXfoqT8/adHYyRIQaJ8F1ORu1Z906r6Kt1by2R8Sa5NEKLdTU=@vger.kernel.org X-Gm-Message-State: AOJu0YxxER4KA9YeVNSUFNxYHySceKnBIMuigZsuCG4++gIX8c0k2Txx hiMbO9SUE5TPDrfrhfjxnoCBq5Iz06Nps9KfTQfpa5KrFyohy5yWiYkYqeDs/+e8a3yJTM+wRJQ oA3u2FONIkb6DF1SfkuG0bognw0JThXW5HZ/hgw/nYsZf+00ESmld3uHCe37To4EFVmA= X-Gm-Gg: AY/fxX7I43/7qpPEhA4y71GpzL235P+FmJFDPqWIp2kp3vGVsfPpLDG/BTMcvNne3cZ IXVpW3e8Ri75g+/boYae7K/CBDTbK0/21eXTHnyZXATE4V/W84pQsKKN3wPXCzqTfyjHi3s9xPC HSnu0G5TsIlnMCTMymehWwTht2EP8nGmz/+8SE107+cGxBSH0CI0ujxkygfJvnNZfA/45DUOQsc NE2ugcJYR4hwCh8nHpg2Pb8qzS9JITtkdYxq4xpKNCjL4rGqJ5471pYx7DSCInhQG9Ys3Biig0h FxzU3THGpudi5TVAurNjlxSy2Rs9Va3ccv3ZlYsM3DNkUV6+qonjjBdawRqzSxzETbk/oOC3dea xR3+4yhOZsI2BPG2p3b6tNBGmRfLqM+lrldpxiEotatv2msGbM6MnheWT2A/FbE5eb9u9Jo3JoH Mu51KM5YyTp3VmZxV7OP+azBo= X-Received: by 2002:a05:6214:498d:b0:888:81ad:16b0 with SMTP id 6a1803df08f44-88d83d65945mr487316546d6.53.1766942515420; Sun, 28 Dec 2025 09:21:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IGcvwcNsJxfckigfIUDZG6GhjNkeQtH1Am+DpUUIQ8I+HISHgd+uxyslQbQQtyZyzXMCQbCGA== X-Received: by 2002:a05:6214:498d:b0:888:81ad:16b0 with SMTP id 6a1803df08f44-88d83d65945mr487316036d6.53.1766942514996; Sun, 28 Dec 2025 09:21:54 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3812251cfffsm76871031fa.19.2025.12.28.09.21.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Dec 2025 09:21:50 -0800 (PST) From: Dmitry Baryshkov Date: Sun, 28 Dec 2025 19:21:39 +0200 Subject: [PATCH v4 7/8] drm: writeback: drop excess connector initialization functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251228-wb-drop-encoder-v4-7-58d28e668901@oss.qualcomm.com> References: <20251228-wb-drop-encoder-v4-0-58d28e668901@oss.qualcomm.com> In-Reply-To: <20251228-wb-drop-encoder-v4-0-58d28e668901@oss.qualcomm.com> To: Jani Nikula , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Christophe JAILLET , Jessica Zhang , Louis Chauvet Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Suraj Kandpal X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4480; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=H3BLuh7aucG+4twvP/0GQJX85YA5nUk09wN5sJ0vud4=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpUWciJUZdvn/acE82l+E9R4nQ4JakRQmCYafIQ s1/38m2bxOJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaVFnIgAKCRCLPIo+Aiko 1QADB/94vJUoLDr35ABGIIs+eO+dZA4cM5aet0Kwybz4Cjxp3N51brjCEaXdsDgsZ/90lPqKS0W b+f3i+yY8HvyVuJgS9YBnxcf9atoRGg8FzThjUU/oStVtsQ57eyRwG8DI125wLXdZsp23qPsGoI 9XvypdYZSQ5t4C33IrSsOQMEFDw8piZrNPTp1bNE0W4vlz2GHGZIeTDYqMHRtUBWSVXw3NHwxLJ jGLBjX26NQPfhMfNzJVJOndj/8vSZedyk9Sfl3/5SKYZuUKicSdIb0f5pkEXuSiSRIGdDJtJw81 tOc2aBGjkj95fKSJpzHX/TM82L48RAYFfNuvGKSYaw59kw40 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=G+YR0tk5 c=1 sm=1 tr=0 ts=69516734 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=3owybDqXPaZAjLikVYcA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-GUID: mVcKFiHc8LuPKvh9xurulUT3QWEBYyUJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI4MDE1OSBTYWx0ZWRfX55J2fB8JSBJp vh3esDhGPHA0tRD5AtQzIAInEaHhAzrHuHmlpymtq5uEn1FzQe4F9rQzzut2xQQC9OPlFGC8LeY YJvnBP3n58kusoyWtwu3mnQ9SMSyl1J3StonlcPkropOkG+3VSy0Haa0xwy6nnTFCDoc+lNtDEJ BcwbqVJLbMhYRsTwusR5mGoraplzCpjTGfas9LiUlZVVlRCLYHWgqMlgHRff1XplwDi69s4TOeE gkW7+z5Nb5o862bFZWNOf3j3b0L2t50JVlvvyE08+bfcA7IMY2r4/1UhwDyHk+j9qixoVoZaaBS 793ixECMIUlzbXtp6AQs7RHiqF1e96k6M0Im/mYJtiM4O16QijrhQW4dmG9WfHCaDIGkrAqPmGm okymy2swUYUVMZfUZR/8xZBQ9ANibuAzaJnjs6n8b3IH7y6QbY1ohXrPL7zP07UnEjuPJYBaqKa aQKds1LemFjO5SyrK1w== X-Proofpoint-ORIG-GUID: mVcKFiHc8LuPKvh9xurulUT3QWEBYyUJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-28_06,2025-12-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 bulkscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512280159 Now as all drivers have been converted to drmm_writeback_connector_init(), drop drm_writeback_connector_init() and drm_writeback_connector::encoder field, they are unused now. Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_writeback.c | 55 -------------------------------------= ---- include/drm/drm_writeback.h | 18 -------------- 2 files changed, 73 deletions(-) diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writebac= k.c index 95b8a2e4bda6..1a01df91b2c5 100644 --- a/drivers/gpu/drm/drm_writeback.c +++ b/drivers/gpu/drm/drm_writeback.c @@ -142,61 +142,6 @@ static int create_writeback_properties(struct drm_devi= ce *dev) return 0; } =20 -static const struct drm_encoder_funcs drm_writeback_encoder_funcs =3D { - .destroy =3D drm_encoder_cleanup, -}; - -/** - * drm_writeback_connector_init - Initialize a writeback connector and its= properties - * @dev: DRM device - * @wb_connector: Writeback connector to initialize - * @con_funcs: Connector funcs vtable - * @enc_helper_funcs: Encoder helper funcs vtable to be used by the intern= al encoder - * @formats: Array of supported pixel formats for the writeback engine - * @n_formats: Length of the formats array - * @possible_crtcs: possible crtcs for the internal writeback encoder - * - * This function creates the writeback-connector-specific properties if th= ey - * have not been already created, initializes the connector as - * type DRM_MODE_CONNECTOR_WRITEBACK, and correctly initializes the proper= ty - * values. It will also create an internal encoder associated with the - * drm_writeback_connector and set it to use the @enc_helper_funcs vtable = for - * the encoder helper. - * - * Drivers should always use this function instead of drm_connector_init()= to - * set up writeback connectors. - * - * Returns: 0 on success, or a negative error code - */ -int drm_writeback_connector_init(struct drm_device *dev, - struct drm_writeback_connector *wb_connector, - const struct drm_connector_funcs *con_funcs, - const struct drm_encoder_helper_funcs *enc_helper_funcs, - const u32 *formats, int n_formats, - u32 possible_crtcs) -{ - int ret =3D 0; - - drm_encoder_helper_add(&wb_connector->encoder, enc_helper_funcs); - - wb_connector->encoder.possible_crtcs =3D possible_crtcs; - - ret =3D drm_encoder_init(dev, &wb_connector->encoder, - &drm_writeback_encoder_funcs, - DRM_MODE_ENCODER_VIRTUAL, NULL); - if (ret) - return ret; - - ret =3D drm_writeback_connector_init_with_encoder(dev, wb_connector, &wb_= connector->encoder, - con_funcs, formats, n_formats); - - if (ret) - drm_encoder_cleanup(&wb_connector->encoder); - - return ret; -} -EXPORT_SYMBOL(drm_writeback_connector_init); - static void delete_writeback_properties(struct drm_device *dev) { if (dev->mode_config.writeback_pixel_formats_property) { diff --git a/include/drm/drm_writeback.h b/include/drm/drm_writeback.h index c380a7b8f55a..879ca103320c 100644 --- a/include/drm/drm_writeback.h +++ b/include/drm/drm_writeback.h @@ -24,17 +24,6 @@ struct drm_writeback_connector { */ struct drm_connector base; =20 - /** - * @encoder: Internal encoder used by the connector to fulfill - * the DRM framework requirements. The users of the - * @drm_writeback_connector control the behaviour of the @encoder - * by passing the @enc_funcs parameter to drm_writeback_connector_init() - * function. - * For users of drm_writeback_connector_init_with_encoder(), this field - * is not valid as the encoder is managed within their drivers. - */ - struct drm_encoder encoder; - /** * @pixel_formats_blob_ptr: * @@ -148,13 +137,6 @@ drm_connector_to_writeback(struct drm_connector *conne= ctor) return container_of(connector, struct drm_writeback_connector, base); } =20 -int drm_writeback_connector_init(struct drm_device *dev, - struct drm_writeback_connector *wb_connector, - const struct drm_connector_funcs *con_funcs, - const struct drm_encoder_helper_funcs *enc_helper_funcs, - const u32 *formats, int n_formats, - u32 possible_crtcs); - int drm_writeback_connector_init_with_encoder(struct drm_device *dev, struct drm_writeback_connector *wb_connector, struct drm_encoder *enc, --=20 2.47.3 From nobody Sun Feb 8 04:18:04 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73BCE2D780A for ; Sun, 28 Dec 2025 17:21:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766942520; cv=none; b=fA+u1vP26FbE2Ht68KxAUX+l5flLQ6NBWKrMdXhEkR1xDvs1v/Lioo35SvhguUzGK7BIcgFgRCBX8Y/Egj4oxiLBQFqsmJ3OGmRdhieAVbqdqArNkVAou9BjoL3ldQTC8W+zzXprTI1OWrCkjvRYdaeLsCdChtEs7eg6SiMtGew= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766942520; c=relaxed/simple; bh=90ODFHe66Nfjl7yi87n5IICLXsZ4owytXCS3KVu4EDE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=K+uXwQo3uEEpTQvq0laqZ7D0hDUyEtupqQdJPCiGZUvE8ndVRfAeNBWQXXK7SwtkuW6kJu30dSoNC8fLTRpwt4eLdlbd62Th39XPs/Std2DrYj0ahx8kVf/mdttHfeCuAW0yNXgs0+NAcZ54p1nLj7JMSPBS0QJ+aJ7AlxdhV8E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fCe7uPA3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CF08gueA; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fCe7uPA3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CF08gueA" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BSErvHt3150347 for ; Sun, 28 Dec 2025 17:21:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= b9ETFH4qFVnd8+4vgMuarPmX3yRsMvDDnuUweRJUeYM=; b=fCe7uPA3Xkqmh1sr GK1R8fNjyEDbYn9uNvNzUBt10Mwwm4f85c+JJXolwuUPIOQQ9wOm3beWQ+mWllFz ReuyK8p2ew7oCfzP2vXlsqxStD0d2b8tzAuyhNfhdPOPfcirIgHYP1kgFelh20G/ 0+BLd2+5syRlaBKo0mRDyjaF3XlXNF4AE0kSnAolY9bOp+sm3VTFKO3/F9MtdoZa lMinfMZmaAcbPKid89XdkcDNOVuFE15xoFJTK78dj35mbMfaVfBPLphbNA0Xvglg 1lvLpsATW1yMPf7YL2Tcs/ez1RKXEM3Zlk3ZDFaQrEup02/QVVaaomfQswGkkVM9 vjEGyg== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ba7hsafxh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 28 Dec 2025 17:21:57 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-88a3356a310so241869866d6.3 for ; Sun, 28 Dec 2025 09:21:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766942517; x=1767547317; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=b9ETFH4qFVnd8+4vgMuarPmX3yRsMvDDnuUweRJUeYM=; b=CF08gueALR2vkFeGjLeJz2vq0F7unP2/YFZ8hLl77GLVKrvGav/QgVISyAxv0CAOYM IsuvtpMBLqga7JKh4/8AOubfD3eWBh4F8aV8twpwEUCo5tlT2syqCJ0EsSimAG4DIU6O QOYS0quIle4BXw2BD6znvjT9Yf4sKnrlg8fAtRxON4mXSQf4O913BXELBEP9NkXerKGB cKhyEx+YjArCenRRDZ4LjlY/dio+yTwSxRa+o3izw1VRjqciQdPt3oR66fwwsxe/lRTC LSFX3E7YugCaPNMpSXjCmC6ZMZJlKDeKUGyTVDPx+GecB0kIqShPv/rlAqCmL9wf1hRG aHoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766942517; x=1767547317; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=b9ETFH4qFVnd8+4vgMuarPmX3yRsMvDDnuUweRJUeYM=; b=B5MTKl1XwvsdRJ4w1MDKGcE7Kr8P5CLnHk628rEi1XiqV4uJXLVlLyaW1UVvQWH2Yo OzBPPCgm6E/46Le2oi1LWg2/Y1yD8JJ2DegKLGrOOTQlLcqEDSKppHZY5HZVhjZUw9tI sXPstJ6mGZoVDRTxyligYr6b+tEdLQ74v1GhlFoYQFXxfQ6R4BpUyiEM9eyL011xagmn 0mLJ0uskGTuGuLQyv/K+4aGqqCyLLFOV5KLlMGGrUb2XzfhLD8P4Y9uV8ApoL0YmOKdS TXjOivW2cw4gkukYT4r59Q9JQC2RcCIduUJz21XIttb970ShhBYTm8AJH1YRAwkMiTmI RhMg== X-Forwarded-Encrypted: i=1; AJvYcCUAPIVZT3izM7+P5xAwGLM2TiEEgNc8I1d3+8xeBNt9dQLd9getYQRqvHmvNsL0HJTn124um/RHSWTMcCA=@vger.kernel.org X-Gm-Message-State: AOJu0YxnlRSo1uesKLyqC7Nsj3mP3b7MBiRcLrNNaSxCEamlF0jbmRQo dEYktIvWGc3K9g6q97m4TvqQKQ0ziau2AkZXKejGheNJNHWHPrpiPL6SE41Nb3L1+VKaKV6qkOo OcwPJ3jGs1rNqwRc2fMYMkHfcfyMpEnQOLMmayKZYLdT5nRILpVitMb3gfvkXGB+DkCk= X-Gm-Gg: AY/fxX55PZ/FNHsLaTexzryxu+SKnYTTSCDcmE/0B/0bomAoyAT1deBaQnbT+3hUqzF H3MHfvUdRqpDX6rSc5qajLbIodqjJ7wI3C8s0sd2gU4LKgs9rM72ynGD93RWSM4EV2kFsMoZ6Ut OWQtvI6f7oHoOdt5uQxUdVQ4VjCyfDxsXD+8/wYRlo5mLzXTCu+w6/4WQz2UeM3xSrfDa/HY2jB UsalfEPelgvsBYrmgZ15P78uncjxpGTq7m2K31WvNByaOZvB/zkia/c0bKZ90HKTcEBmpdOx5nf n0z1pPlZZwA8tzL/yi0S3n2G393G420OU/uhqgvPN5HG5I15b3xS0EmbbOJ2iYDAjcQxggwbB4C 9zylnI/ICadCsr1+lD8+ufqtWO0m1pE56bdnrDwGH/XzXl1idNfAoohZcUfteajtk5o6gcLlcyl aIbu5VKGlEiS2tkUE8YvonUl0= X-Received: by 2002:a05:6214:62e:b0:880:4eac:8689 with SMTP id 6a1803df08f44-8901a046480mr56330026d6.57.1766942516756; Sun, 28 Dec 2025 09:21:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IGB8qEu1RTRfneqwLmQfLZtXdWTJwcJICHquzn4/JCVt3C/Ojms0Lzrm+TZNYbI+Vc4LxRkpw== X-Received: by 2002:a05:6214:62e:b0:880:4eac:8689 with SMTP id 6a1803df08f44-8901a046480mr56329426d6.57.1766942516229; Sun, 28 Dec 2025 09:21:56 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3812251cfffsm76871031fa.19.2025.12.28.09.21.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Dec 2025 09:21:55 -0800 (PST) From: Dmitry Baryshkov Date: Sun, 28 Dec 2025 19:21:40 +0200 Subject: [PATCH v4 8/8] drm: writeback: rename drm_writeback_connector_init_with_encoder() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251228-wb-drop-encoder-v4-8-58d28e668901@oss.qualcomm.com> References: <20251228-wb-drop-encoder-v4-0-58d28e668901@oss.qualcomm.com> In-Reply-To: <20251228-wb-drop-encoder-v4-0-58d28e668901@oss.qualcomm.com> To: Jani Nikula , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Christophe JAILLET , Jessica Zhang , Louis Chauvet Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Suraj Kandpal X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3014; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=90ODFHe66Nfjl7yi87n5IICLXsZ4owytXCS3KVu4EDE=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpUWcj9BzTRYnVcWpH+HOdUmVZsP41SRvbgNf65 r1tUWUIDeuJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaVFnIwAKCRCLPIo+Aiko 1aRnB/44LaHrh0nL9t+l8Vm6jhnLOGva6JBnRavBIlXxZ9z4WE23lIX3WiEyrT7KyQ8m4e+qphJ 2shMVOTKNp4d6IxIslu0RPfEZCcVynOUm+haZoWH0fbul6FKjHsfixttxMmhSBgniCaDpLn2Brm uf8MWBCmTndEK8JE5W+piAGszU88bTKxCU4YYh/eOFEb+LYAvwddqnzNk+FhaK6TL7s8H2t8cFq Sabt4YABaMeoD9UxOrjRnVuHwPET5x8fysxDQxsl/kF3qxqjF0D/Oac/p0bhLm4UPMCacwKdezp mnSB6VzLqdlVyoSSju677WRGgUmJZV98vHj3hVcEValfOlVq X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: GU9tK0Ed3IOJzQfG48CWya9gcGPBWapj X-Authority-Analysis: v=2.4 cv=O4o0fR9W c=1 sm=1 tr=0 ts=69516735 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=By2WwYRBACVvdXAjiroA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-ORIG-GUID: GU9tK0Ed3IOJzQfG48CWya9gcGPBWapj X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI4MDE1OSBTYWx0ZWRfXznUmphojHU+V qUEwgypwNAEAZSaOhornnxLO7pTwpHY9ZtOBinL/KvjU2AQJXMxr6q0vAeYaLmXZQ4JDduwdwW+ j1Z92WbaL4HocGm6+4SxB+MOjIoPF6OJdgkbJ5+cTBLLMn6WhJ3LkBitH2F2SHULrGx6ezgLPA3 u6ZezaWRyGG3KJfwCMI+TDG/F2I7EIXRbuphWsiWMgoVbkq9Ed1NxaHBbGXU3W43rO7CFTxPN6W 4f6TI7EfwiGcRfTHwxwKA1M+Pz6zMDXKdPnflFZWvvIPo4boJ6bOpa+rjSXY2vuAjcYGC2yUmwf u2CR1J/+KVJx2lcfF0OmbxeTexMspWO02oY0yo84/8ma9qKLHeeNQn/i88t5UftlpKuKwRo01Lm kCZpWpCQFv2JGkP3XhOrCtVr4dbGMkQu6Jcd3u8Kq+4GeAoyUFkVjkTYSCx6OnBbbEtr0SzSUlr q+JXZdFEalrylb2EXfQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-28_06,2025-12-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512280159 Rename drm_writeback_connector_init_with_encoder() to drm_writeback_connector_init() and adapt its interface to follow drmm_writeback_connector_init(). Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_writeback.c | 14 +++++++------- include/drm/drm_writeback.h | 10 +++++----- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writebac= k.c index 1a01df91b2c5..ec2575c4c21b 100644 --- a/drivers/gpu/drm/drm_writeback.c +++ b/drivers/gpu/drm/drm_writeback.c @@ -235,7 +235,7 @@ static int __drm_writeback_connector_init(struct drm_de= vice *dev, } =20 /** - * drm_writeback_connector_init_with_encoder - Initialize a writeback conn= ector with + * drm_writeback_connector_init - Initialize a writeback connector with * a custom encoder * * @dev: DRM device @@ -263,11 +263,11 @@ static int __drm_writeback_connector_init(struct drm_= device *dev, * * Returns: 0 on success, or a negative error code */ -int drm_writeback_connector_init_with_encoder(struct drm_device *dev, - struct drm_writeback_connector *wb_connector, - struct drm_encoder *enc, - const struct drm_connector_funcs *con_funcs, - const u32 *formats, int n_formats) +int drm_writeback_connector_init(struct drm_device *dev, + struct drm_writeback_connector *wb_connector, + const struct drm_connector_funcs *con_funcs, + struct drm_encoder *enc, + const u32 *formats, int n_formats) { struct drm_connector *connector =3D &wb_connector->base; int ret; @@ -284,7 +284,7 @@ int drm_writeback_connector_init_with_encoder(struct dr= m_device *dev, =20 return ret; } -EXPORT_SYMBOL(drm_writeback_connector_init_with_encoder); +EXPORT_SYMBOL(drm_writeback_connector_init); =20 /** * drm_writeback_connector_cleanup - Cleanup the writeback connector diff --git a/include/drm/drm_writeback.h b/include/drm/drm_writeback.h index 879ca103320c..958466a05e60 100644 --- a/include/drm/drm_writeback.h +++ b/include/drm/drm_writeback.h @@ -137,11 +137,11 @@ drm_connector_to_writeback(struct drm_connector *conn= ector) return container_of(connector, struct drm_writeback_connector, base); } =20 -int drm_writeback_connector_init_with_encoder(struct drm_device *dev, - struct drm_writeback_connector *wb_connector, - struct drm_encoder *enc, - const struct drm_connector_funcs *con_funcs, const u32 *formats, - int n_formats); +int drm_writeback_connector_init(struct drm_device *dev, + struct drm_writeback_connector *wb_connector, + const struct drm_connector_funcs *con_funcs, + struct drm_encoder *enc, + const u32 *formats, int n_formats); =20 int drmm_writeback_connector_init(struct drm_device *dev, struct drm_writeback_connector *wb_connector, --=20 2.47.3