From nobody Mon Feb 9 12:24:57 2026 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3D63324B24 for ; Sat, 27 Dec 2025 17:57:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766858269; cv=none; b=LXtdCX1fcct69vYmX6odVNuTK1CCsnXuTj3+Kjmwz+uDA7qOilvfHRENMtPFZThdmmi8y3ik0XKjvC6HP6zkgdwCFnbsn5MUpUL45MsLK+zvuord7xjVyzHuQMEk1hqbl61isRbbhR5T8xYaVp4xQNWxb0lhtMsZavD2Ee+VY6c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766858269; c=relaxed/simple; bh=DL/I39VWp/7CJui/ohWSCpeXrcyY2rJch5NlzLdxeFk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=k/jYQKKnJ3y17l/ovymGJiHNnAz2smpVJk32KdVtlACXrkv2nO2L53j+AUgPwL2Vq2OdCBbaC+phPX9Mp7oXi2Optf1j4khmPe8pdywVvTyrEKElsHang2mSvSnYMHBuLnR+h1WMILX5w0ldGY+b4StFt70bgqvadj7VMpZJFio= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=kc5S3x6n; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="kc5S3x6n" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-64951939e1eso12570982a12.1 for ; Sat, 27 Dec 2025 09:57:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1766858266; x=1767463066; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H+W6sOlw2zXBDnyDOozxSeUj9x3Kz+fCohpTNuGuaoo=; b=kc5S3x6nnQvBhhs9IYS3J9l9k5y2tFJb/BnMv8/p574nDrxNncY0BT0eXoIgzU4feG 1Jt6eDKcllVD1pOMUbs4vHAk5+3xbzRDAam0PrD15NG4k12f0/LWJ6VIwdXnJ9cJ/PDn QD/bxTQvmfxDLdCuy/JpCcy6XAbNAl/iDctvE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766858266; x=1767463066; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=H+W6sOlw2zXBDnyDOozxSeUj9x3Kz+fCohpTNuGuaoo=; b=mVb/0ceX7oocdgtD3/VPiD5s/dpp2GS/3B1n63d0sUkHsHH/ytI/xRvpHrIpgXLc7L 1ANuPVxYbNYwbLfSYTcW7rN5a67AM8vGCiVZjZiTPL6czVnGCSkp+8Wkr0+Ou/NCZxtK hDftLOIhqoJA0Fo4RPQR5Xkrn7yUMpDwPsW1MUuqHgsPSAw0J8TMLoqdWm0e9mQJan7r Q3DwHPF7pZE57JmFULD+N+zDe2WWVRE/DL/CG/inLa16sMkQzoa42AxXPxEvVkcf4aU3 Dz3foTRtF1xH8URAmIiDHFXYLvFVbDB6SakB4gbcMnmn9ASPAkaJ3KGooOJVtW5aGZYA KXiQ== X-Forwarded-Encrypted: i=1; AJvYcCUTJxYJ4L8v9eXDNsTKbO8OgVRHOZQf4bv809XPlXOyI8q1R9dr0xY/PlZEyDsmFh/MOjsGibGL4ezE87A=@vger.kernel.org X-Gm-Message-State: AOJu0YzW+E5M0R7baLxn+StgnyCAumxPRweiDO1Jnyxs/KMnJNDQdMwD yyMxUQGqmRUhUs3sO1Q0qWg7RMwJjhP/6S9AXrTVO2HVgKjJ0JAJJU8kiwxrsad4Iw== X-Gm-Gg: AY/fxX6ytsi3KbHLrDm+UkXaFz6Yn7/90tUu0LwnoGX99vtsxtHGNf+1UYh2FL3Rr+I 8TTfse7AXvh+tOhpyyLo4PCKj4V1m+V/MRYFbeBqPikEc1mDoJT1L4pRgW0WeMm1Iekf7+CUA1Z ZZhBszv7eQX7KmENtTEJR8MNEtzW2fS1hbI+MJq4QWtNuiLx+yOrhhuaT77OWvl0vg6mr0kic4A j9Srg+D6YFoY/Tlfo47XYaD8qL+iXYBVXOkZBZ5DLd5mJEcIn6Jjj4X8OlkAC3amkKBcitw/KOQ KDscY81tXdWeiuBF+NODCPYm9M2E9IYEnCcb1FPiHEtUemQGbMRwiK28Su5FtnW0aiHxQZf1ggq cdKhk3NjIB2zrBpZ9zyuytY4yT8UqeTivvtqUxuCNXERM1QTduaF0gR7VdFCgkUhZFh33ipuLNy nBipC+rEcVEokdFmqZBplT5arRi0yCC4RslKNBQLXf X-Google-Smtp-Source: AGHT+IG62TJLHHJFuWaGi70eIXKakEOO9GuSS8nGGYDZzcL4RhbAQj/mok61syj4bdN2OwKnDOwMYw== X-Received: by 2002:a17:907:7f20:b0:b76:69d6:f9fe with SMTP id a640c23a62f3a-b80371f1939mr2821226866b.60.1766858265989; Sat, 27 Dec 2025 09:57:45 -0800 (PST) Received: from localhost.localdomain ([2a02:a31b:20c3:6680:3d12:d2ea:4ee0:347a]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037de1421sm2793889166b.41.2025.12.27.09.57.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Dec 2025 09:57:45 -0800 (PST) From: Dmytro Maluka To: David Woodhouse , Lu Baolu , iommu@lists.linux.dev Cc: Joerg Roedel , Will Deacon , Robin Murphy , linux-kernel@vger.kernel.org, "Vineeth Pillai (Google)" , Aashish Sharma , Grzegorz Jaszczyk , Chuanxiao Dong , Kevin Tian , Dmytro Maluka Subject: [PATCH v2 5/5] iommu/vt-d: Use WRITE_ONCE for setting root table entries Date: Sat, 27 Dec 2025 18:57:28 +0100 Message-ID: <20251227175728.4358-6-dmaluka@chromium.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251227175728.4358-1-dmaluka@chromium.org> References: <20251227175728.4358-1-dmaluka@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Like context table entries (addressed in the previous patches), root table entries may also be set up at runtime, when DMA translation is already enabled (e.g. due to a device hotplug). So to stay on the safe side, use WRITE_ONCE when setting a root table entry, to prevent the compiler from doing store tearing which could result in setting the present bit earlier than the context table address bits. Signed-off-by: Dmytro Maluka --- drivers/iommu/intel/iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c index 134302fbcd92..fe4d0d210a5f 100644 --- a/drivers/iommu/intel/iommu.c +++ b/drivers/iommu/intel/iommu.c @@ -374,7 +374,7 @@ struct context_entry *iommu_context_addr(struct intel_i= ommu *iommu, u8 bus, =20 __iommu_flush_cache(iommu, (void *)context, CONTEXT_SIZE); phy_addr =3D virt_to_phys((void *)context); - *entry =3D phy_addr | 1; + WRITE_ONCE(*entry, phy_addr | 1); __iommu_flush_cache(iommu, entry, sizeof(*entry)); } return &context[devfn]; --=20 2.47.3