From nobody Mon Feb 9 08:29:33 2026 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC71E324B1C for ; Sat, 27 Dec 2025 17:57:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766858262; cv=none; b=H8pOuBOeg1E0c9hwFz3EVP5hNMnpkRSoCbZZEqvNm0cmW2GYeBoMsHhrXtOB+D/vzUX/nlHc/Ft3QGvQhtHhp4PVmDQcp26AtcIgcYR3avf219yRHbedW+NSxJZcLpqkN0RPVWfWdbfbYgcPjLZOCvP1xNZjWBLBQ9Fyw39y4YM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766858262; c=relaxed/simple; bh=5h5xv8JEqyQ2WZncLcxSn4irfw3Qz69HP6DNd+oeRJw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kCeMqA9UdUTUagbaLGr1Vd2uasx83juPZT+E3h3jdhbLpSXmef8k03hnfE3kVCJ3gnkHko+BwzfxWgLOG9oUtvH2PQQackc6+DnEjE5yaJZ55zVULZ2qJzfmLIQ/Lz0ETjZVnWnLhxn5jul6aJOMTUC8hRPto3+C3ZtaHGzv00o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Fa54QErs; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Fa54QErs" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-b7a02592efaso1205202066b.1 for ; Sat, 27 Dec 2025 09:57:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1766858259; x=1767463059; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FqBEXRWCaC1M7CZubzNbffExnes1O47kmw4dXZQnW3Q=; b=Fa54QErszlmoJbCA0IkvhmfQlLfvxHt7jCz0gTxdVVXPDEGnZIVcvHAtzKnVHiR8Fy UP2GeiDffdupcLjjOhO4Lu591vk82hyGxzNxrKxyaiDAd8/HSwHphUgmT9j7T9fZGjsE VsF/i9vG92ZohNkcoL+M3IY9+YkoUfJNmFOVU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766858259; x=1767463059; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FqBEXRWCaC1M7CZubzNbffExnes1O47kmw4dXZQnW3Q=; b=kR+BQUSejXdFGAAXlESMFNYXJa7Zob4RWzHMwtHtCJlVuhGD5Mh5cOH9jZGC52nYy1 aJ3KLdGqKa/5MKy/IkDejudcXbElAL39aRw5N8J/pbRqv3nCtDygq0XzmM6U2+P5HFHs Rhz9h5Xovi/IqesU+ZGcU9RfLhumt4PVTEruYr8hx2bGEtIZuxvOWCmVUBYEDXrMlQ7O 9wW7aG/RvQInnx5shiqRetMzJm1QrmNSnbNKYb6Jm39hFz3nLEkzSDUFcCeaqby0BbDY sWCHKwJ2TgrANKSlB9PhwaCZ9Ux4m7yh8Ag9SodV9obfjNldMDoSrKJWO02YTEcVTy87 OZWQ== X-Forwarded-Encrypted: i=1; AJvYcCV7DJK8G8RoO+24jtwWUpZnk6dW0k6VCzzQCKv9sn8UrGrE8cghD+9OS9VNb28c9cyqi4MOUnNjQkoETUQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyeAsfg0z2GRNKGkdQmt0DKUBSaVCxCQFcANLC0Sysy/ffxtrx3 vDW5TO/WLmmUW2WmVPMHu9yE1cGiyseIVKZYcjBFjgHqpSgj0cIq18o1/BezZpsKRg== X-Gm-Gg: AY/fxX4LXyjvKwrN+7uZ3ThLbjMohpy+9Utrqfs6HV3eBsxEqeGmZyATd1SnViwvHDq 6wroMRIHi06VMI2X3hlBZhcPibt7bui1JnJ2Z8k7RAj6OO01raFJcfy5IV84W0h7jF3TVLhAYEy +/4lJj7+IW8dNMbGTEnBxlF55fN18g219VkLp9p2Q9knvggPTVacQ/IxZNPyFlgJPr+CE34dsnH JT0x/X2X31w7vu+/Rf8j1UNMsdJouUYtQAALRUmOOXfZ6ou0gz1ALm8RQdFAtFdueqohICoXOZc XND0V3qjz0QPk8rK3h3iMHJhP04d7MHxTxA85J8evQQEPxndkKmpsR9U54X8/9fsDHPTvkCvgJT R0lRwjyW6BtBXJylXOHuBltR7rwxulQwbjcN5U4H3AMTJadZ+STf0jrwKWPZRlHDShQtrdaC8y1 yauxBywwS5kzdXozpcKVbiRKHT59nlXA== X-Google-Smtp-Source: AGHT+IHK6STg6BDB2X6G72rDgUtuf6fD4jZFsFZf9R3HxE49kfZlB1Fg4cAQYG6AyvYRR+Ir/Dy3gw== X-Received: by 2002:a17:907:6d12:b0:b76:bcf5:a388 with SMTP id a640c23a62f3a-b8037198f0cmr2774524966b.50.1766858259112; Sat, 27 Dec 2025 09:57:39 -0800 (PST) Received: from localhost.localdomain ([2a02:a31b:20c3:6680:3d12:d2ea:4ee0:347a]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037de1421sm2793889166b.41.2025.12.27.09.57.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Dec 2025 09:57:38 -0800 (PST) From: Dmytro Maluka To: David Woodhouse , Lu Baolu , iommu@lists.linux.dev Cc: Joerg Roedel , Will Deacon , Robin Murphy , linux-kernel@vger.kernel.org, "Vineeth Pillai (Google)" , Aashish Sharma , Grzegorz Jaszczyk , Chuanxiao Dong , Kevin Tian , Dmytro Maluka Subject: [PATCH v2 1/5] iommu/vt-d: Sanitize set bits in pasid_set_bits() Date: Sat, 27 Dec 2025 18:57:24 +0100 Message-ID: <20251227175728.4358-2-dmaluka@chromium.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251227175728.4358-1-dmaluka@chromium.org> References: <20251227175728.4358-1-dmaluka@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When setting PASID entry bits via pasid_set_*() helpers, apply the specified mask to the specified bits to be set, as a safety measure in case the caller accidentally passes a value that exceeds the specified mask. Also warn if that happens. Suggested-by: Lu Baolu Signed-off-by: Dmytro Maluka --- drivers/iommu/intel/pasid.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/iommu/intel/pasid.h b/drivers/iommu/intel/pasid.h index b4c85242dc79..39acd3efa3ab 100644 --- a/drivers/iommu/intel/pasid.h +++ b/drivers/iommu/intel/pasid.h @@ -113,8 +113,10 @@ static inline void pasid_set_bits(u64 *ptr, u64 mask, = u64 bits) { u64 old; =20 + WARN_ON_ONCE(bits & ~mask); + old =3D READ_ONCE(*ptr); - WRITE_ONCE(*ptr, (old & ~mask) | bits); + WRITE_ONCE(*ptr, (old & ~mask) | (bits & mask)); } =20 static inline u64 pasid_get_bits(u64 *ptr) --=20 2.47.3