From nobody Sat Feb 7 15:12:05 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54B1B32FA22 for ; Sat, 27 Dec 2025 12:25:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766838351; cv=none; b=gkmOi3JnHLEns2eAluf7fo7XAJCxv4fjaIWT2uf21WK8bG81OkwN+VfdfkGb0RUOLZL6Zctym3yZ/EN1WbfTrbd2X8tN5qIXHg1Qj/DeIxvGFLD6BUgWWM6FPc0BLz0mXHuslLu0HXvSdmiWGtwRqP907xXFjI9jm3Bgo/ru3y8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766838351; c=relaxed/simple; bh=j6nXZg1hHhayzVTNsidFsvc7cVytqKMzlXVfg5DQz3M=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BcZQ7x4iiGBkxcwsPdmVXYZiPjugzoe1+BQZqHt1dxgVlnRp3KpTDYby+nEzUGA3RWbTZfFW8sjYsYesSYUc0OGGFLIulCSpOqzeencIK8n2EJ/N1qtS0TTnxM8S6XfAjPGMye15frQav46L0zXp6+uTcn9P/ztysbY3malskFY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KYRPLJHC; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KYRPLJHC" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-477bf34f5f5so57890145e9.0 for ; Sat, 27 Dec 2025 04:25:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766838348; x=1767443148; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kuPI2aNgLX/9o6inXHM98ejerk3xQ9ReMe7Mbvn14gY=; b=KYRPLJHC6xy6Suedx5II6OEqUG6bIxBJDop8VLKmSjOREUagHNo6xvOURESxGUb2nA cXEYMY4VehwKjfs4hcxjnUgM3WZSpLsBe8j1G4r5ZUXbaMq9yED4tqZuCdMdrm2NnLO8 mVPHbXYgp0UMZvw6wZK5g7UP6zySmG0Z1Uy0YPCpfY1zt3T+d86RK+YMBtE0PvjbFFsw C48JhA/AVdWpEM1QlutzaqCLEd8kR/JhbDJSeEd/bczrONuoxFyOfoa30m4YykTDCvcQ EXSQ3yncVZs/fRBj8SNPYtS2cCLh68h7Qxp9/IWku5DTC7mIKpVSWVXoZE4rTymX96cA pL/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766838348; x=1767443148; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kuPI2aNgLX/9o6inXHM98ejerk3xQ9ReMe7Mbvn14gY=; b=KrueUJuF1OKIlesdmes0BydmTJJemujuMih8oJAucLmtK2U6XNZDYP2Z+UUfmVm5kc ACZf9NPTo1JxvONqT7oVHeSHKNC8bP9MvxWn0lMlE6rE4U2wO1pbiXREx2n2BpBLPb+e 9xRv0ctiw6y8ll3diixBPiyN/UuBf7umZ4rkd7fDKyG6PDIjPMhPRO3zDhzuUrP8O0H4 XG38Wm8g+CSH892CVSRIWLQ6+/rEgKs12UY1+MK6zd/qNlrWK2ru7nCZd7VfoGOoqRLH sNMhNHKc03aS1Zqfq5CokpJ1fm70QztiAaSOug9L0ONssv8nxyvHZA6tR3papo47CNRJ f/RQ== X-Forwarded-Encrypted: i=1; AJvYcCXjWvdaxWjoCMhLnRBdt8bZQWyhdr1kwuTVAal5/hgrTBA8j4laM266pYyAxNe4IAUoT1NYenlLwX3HHZM=@vger.kernel.org X-Gm-Message-State: AOJu0YxqxbK0+5/XUrm43/WUKAY4ZDy3kNcyIdjkAK6XvBTIRZdSL91J sSI9yuNAQ6gGb5YoFYbxqhCMra50jflG1Do7YUnRR/WoIthfAMjnkVIT X-Gm-Gg: AY/fxX4rPkODoQ5LiCcU2R82xPTEYuxg+f8U4YJ46oBkFsUKKuWDZay3V/+/O8dQTw6 gUmEptf85J3a8ienCH68pTEqNgSh9bDmCSNL3Otxs842L+QfH8+vg1dXayegQfVrB6Evxpzxdl7 TLhkorbl46oq2gjKv+3TYhX+Xm+2m+q51G/bRRDcumWZBXGq3wy3qp/+h3Wf+nDSEhM+Iabb9FY qMGbYkjzh6MHMCK90W5UploOGG9wQ0b2jcXvQBiF7YG2gwejcLcUPt6AlLpiFop7q1W5eafDnl0 jRtcqXvEYYFzyOVYAFAUTRHGDF7Iw0Xmwc6O9L5I0+O8eVnSjW8jdVAcPsHRUHzralfeTHFMFsg rcuUMKAw4Rf0yKrKDKX6827AwSs0frMBRfPOI7WRGjybZ31VCBx8qPCpezHse1lHQrZsV0JfEDl tXhGxgsEFUFyzr2xcm6uGjPSYwDnRuvOm2VTc+dAS8ax0AomgJRtFr2NHgyeWOncDVZhIHwoBrH amdvCWwCF/lSQ== X-Google-Smtp-Source: AGHT+IEIguQB0uXGfKo4fm4DJC+yzPPu45X2Bza3OL/IGVtnEDjPWFUZwpWwFO9ZDFyXjEUZ4aLtXw== X-Received: by 2002:a05:600c:1d0e:b0:47d:18b0:bb9a with SMTP id 5b1f17b1804b1-47d195a87b6mr305079455e9.33.1766838347448; Sat, 27 Dec 2025 04:25:47 -0800 (PST) Received: from ivan-laptop.. (cpc92320-cmbg19-2-0-cust3144.5-4.cable.virginm.net. [82.13.76.73]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d19346d33sm451520315e9.3.2025.12.27.04.25.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Dec 2025 04:25:47 -0800 (PST) From: Ivan Orlov To: nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com Cc: Ivan Orlov , shayne.chen@mediatek.com, sean.wang@mediatek.com, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH] wifi: mt76: Fix strscpy usage in mt76_connac2_load_patch Date: Sat, 27 Dec 2025 12:25:24 +0000 Message-ID: <20251227122525.5474-1-ivan.orlov0322@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Since mt76_connac2_patch_hdr->build_date size is 16, copying at most 17 bytes into build_date from it causes a panic when CONFIG_FORTIFY_SOURCE is enabled. So, make it 16 bytes instead to match the corresponding field of mt76_connac2_patch_hdr. Also, since strscpy always adds a null terminator, remove the line which adds it explicitly at the end of the buffer. Signed-off-by: Ivan Orlov --- drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c b/drivers= /net/wireless/mediatek/mt76/mt76_connac_mcu.c index ea99167765b0..01362b097a40 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c +++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c @@ -3101,7 +3101,7 @@ int mt76_connac2_load_patch(struct mt76_dev *dev, con= st char *fw_name) int i, ret, sem, max_len =3D mt76_is_sdio(dev) ? 2048 : 4096; const struct mt76_connac2_patch_hdr *hdr; const struct firmware *fw =3D NULL; - char build_date[17]; + char build_date[16]; =20 sem =3D mt76_connac_mcu_patch_sem_ctrl(dev, true); switch (sem) { @@ -3126,7 +3126,6 @@ int mt76_connac2_load_patch(struct mt76_dev *dev, con= st char *fw_name) =20 hdr =3D (const void *)fw->data; strscpy(build_date, hdr->build_date, sizeof(build_date)); - build_date[16] =3D '\0'; strim(build_date); dev_info(dev->dev, "HW/SW Version: 0x%x, Build Time: %.16s\n", be32_to_cpu(hdr->hw_sw_ver), build_date); --=20 2.43.0