From nobody Sun Feb 8 07:21:40 2026 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF79D32B999 for ; Sat, 27 Dec 2025 12:20:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766838033; cv=none; b=bvmyeGBTyl9RBhqFgAfUdyhzq5CSL+EVa00S4/8rQKhW231ybKNsKJMOuEVE+OeYMOZ0Wbu+8oBgGZV+2XedvoVE39HO9OERZwXRBZ0q0BtzPl/s8wSbSCrJTnlwW6Jg115yfZod9WQ5eHA7/2zYBk6APaqqPNCRJpGYfJqkm9k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766838033; c=relaxed/simple; bh=ViShpRpNoxGO8Zvlyak7SFSG0dz1mWoEy2EgxRhIuYU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=D2F8KpVZ8xlHkt2RcNgIGn4bOtqcPdrNnm7MXCRyGPKN7k+08GlUmr1q56zeQyAWA8Je8Ukg1ZsdYo6GruQ0UwEyfMaLvppdxPBq5GkXzii0kn0q5sJMwn5IG5dh4TGASXXkzz2CWqYXrfKctj2A67udWXWkZjJNaaU3Z8vXIrM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Sh09vUZJ; arc=none smtp.client-ip=209.85.167.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Sh09vUZJ" Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-5942b58ac81so6572395e87.2 for ; Sat, 27 Dec 2025 04:20:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766838030; x=1767442830; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=gu0hdt3x2HR6dSPqUKV/8Rrx3e+fQI4f8ZaVCl3DxKI=; b=Sh09vUZJwVNKvMAwpJxAg6T9ayf8h2AOJam8lGLGvxW4RE00rheTp6Pv3AhFNH62ll mnX0nlTdpJodnontvJ1JkVxKrgyHdcZbUiCcH/brbFUfmo1k6yCPhsSWzCMBQt/wZidi sb1DiUiQa1P4nxWkAPh5RxoQHf/+EwdM0tjpilP1iGOnJ5WqSdClAwl98UScEerWxIN9 3J5s79WGp+yeHRohmySNF2lCqF5lNJrICxRADRG92KVppqsovczb8twsTPTAeloQF+W7 D4IsCNkxkGmPTlrF6WPbyIbfy0qFkTMd+9ojmhXZXGCiwjWrPlopeBjJrujjOtMdY15k Hmfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766838030; x=1767442830; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gu0hdt3x2HR6dSPqUKV/8Rrx3e+fQI4f8ZaVCl3DxKI=; b=cgHyaiIsgje2Al8M4ErlYhf537PA2uymtHzHmODozRAoO5wFto83pOC8CMGBg8ZqRW oWDxqgXC2xrqIyoX/F4ohPORE4i/VtXk8S/kQej68lplobixKJlfI8LputRkDQjxaIia l6tVsDndwNvKsbN2fQicuPOMJq1AXoeDVYMzIzJCOsWzJvUYnDSWqW0l05xS2HOHi9e6 H/r6fz47taumqU26DD3v0BGsVzQqr6DUlizHoQAfjaIi5N3tsjtyPuHj1LFcu2SpgrVv 2gJskvkfVLwm7Sm5fOuoX8s+w3aYG/mXU/rcTEUkmiv6qaRDwBUY56bu3hGOd5cSfJeG wfDQ== X-Forwarded-Encrypted: i=1; AJvYcCWNBP+fPl3GtH0ud5EizzJn8IW2T/uBgWKFKl2MoQPrO9RLTzoT1JMO6chnkkucBF8oM9F5/iKt0oxmagk=@vger.kernel.org X-Gm-Message-State: AOJu0Yymm0oMqKNwZsyPlfbLwjxoCU8ek7F8AA8sFkiUisG5ngDM5f0b hFzBuoVcvNweH4empmRelmCpi7mFp9LW0u2HRwNOO5/otm4GO8dQwtJ0 X-Gm-Gg: AY/fxX6KPdX4iLB7FWvqQ1HlF8WSVLZXoy86S32kUO94Ys0hiGYP4aJaeOJdLG2sKlw QpZNVItRsVhdbVXl7OZ58Hx7+KbzecsVcw8jQrXOX2OtdE6ryKwMMeAdf3rUuB6gh8tPFR7QeYm x92vFOzvG++aZpkEg9Gh7Rcgb2Sukl3o+D8ZiGbhXkDoVFt8/dtG8oHEHhzkpDhB8mFe3nlOare Ov6n1K9drDTEcdZGmlC7C8XROmeiQU1RdJJxpX4DeqBEKStMSDuc8Huug+QUIeAE/JOncIzw1Sk TtNzSJhwgV2PBrnpE7r9XjnK0NN1ZbOvd/Qv1wq5NJxE9pNodw0DO5B6AeRZCU+blsvpRhkxAOa mpggyrZPBx1nG5sEzh2g/jYAnzPURV4kHTtWmSplAAzLYwKCml2vPVMeYwRdKEs+w1CPMTbMs7O BZ7OfIf5SE/KtLhNEpum8BWrRhRj4= X-Google-Smtp-Source: AGHT+IE3nq/gbPSFuEDdA5YBhzgkzKmx4GdK6dsDzMoBwJOj7JjaPLrx1nwV7C8th3UvQh4+NFI6qg== X-Received: by 2002:a05:6512:131c:b0:59a:1152:57d9 with SMTP id 2adb3069b0e04-59a17d722bdmr7507324e87.6.1766838029960; Sat, 27 Dec 2025 04:20:29 -0800 (PST) Received: from localhost.localdomain ([176.33.65.121]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59a185d5f07sm7356479e87.12.2025.12.27.04.20.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Dec 2025 04:20:28 -0800 (PST) From: Alper Ak To: mchehab@kernel.org, hverkuil+cisco@kernel.org Cc: Alper Ak , Laurent Pinchart , Lad Prabhakar , Tommaso Merciai , Daniel Scally , Biju Das , Jacopo Mondi , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: renesas: rzg2l-cru: Fix possible ERR_PTR dereference in rzg2l_cru_get_virtual_channel() Date: Sat, 27 Dec 2025 15:19:44 +0300 Message-ID: <20251227121946.67935-1-alperyasinak1@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" media_pad_remote_pad_unique() can return ERR_PTR(-ENOTUNIQ) or ERR_PTR(-ENOLINK) on error situation. The current code dereferences remote_pad without checking for these error cases, which could lead to invalid memory access. Add IS_ERR() check before dereferencing the pointer. Fixes: d7d72dae81d5 ("media: rzg2l-cru: Retrieve virtual channel informatio= n") Signed-off-by: Alper Ak --- drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drive= rs/media/platform/renesas/rzg2l-cru/rzg2l-video.c index 162e2ace6931..bf7d96841c78 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c @@ -411,6 +411,9 @@ static int rzg2l_cru_get_virtual_channel(struct rzg2l_c= ru_dev *cru) int ret; =20 remote_pad =3D media_pad_remote_pad_unique(&cru->ip.pads[RZG2L_CRU_IP_SIN= K]); + if (IS_ERR(remote_pad)) + return PTR_ERR(remote_pad); + ret =3D v4l2_subdev_call(cru->ip.remote, pad, get_frame_desc, remote_pad-= >index, &fd); if (ret < 0 && ret !=3D -ENOIOCTLCMD) { dev_err(cru->dev, "get_frame_desc failed on IP remote subdev\n"); --=20 2.43.0