From nobody Sun Feb 8 03:26:55 2026 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 957952737E3 for ; Sat, 27 Dec 2025 11:52:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766836324; cv=none; b=CrThMiedjxNVgt0JXE2GpILIXoChiI+ES2md1Q8Crlvy5LvT3YU8q8fAe/aHmsYb7jlz/5QIt9IL8A0m7jtqN2xeYl2v1x/Tj5FxILD0j9Dgz/dtHtAVACsy82pI2GhHnRfv6s7LlQqTNBa6psPvUOb/5ytLb6W9uX+EzS5Ovs8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766836324; c=relaxed/simple; bh=9Ro0Yy4FOznrUpy9UlA8AQBEagQRfZ38KkYQg3NOGSg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qb+uGvi59K8SV9EhUnJ4zXTtXVXa8RF1Xl21TUJ6DwQA0FBjndG1Vc4LffcLgTp5rmR4DjsnnylA7lAFMiv+QQBvbuvArRMJzoSBJCGTaAnxLaZOjSkMPAoFiJxj2SY00dnG3Nzu/HmVJT31GBW0SphoVK+xHFnWY3CVwKnVIig= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=k75MGki/; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k75MGki/" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-594330147efso9549321e87.2 for ; Sat, 27 Dec 2025 03:52:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766836321; x=1767441121; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KJLtG+kSnBxO8u9tWSlN4IpEKdHgADBZMUIyM3jPy1A=; b=k75MGki/v4UkyhooCo8aG1+YNyowrQ6oViSn66NWaDc7OqoAjnvN4qXWALWxiVh7w0 Uawqtxrxkm/ssxzIuynFJql4fqRrDK6f+uSSEc23ZclCtDZ3nBUdyEwK1GonoP106gbz iVidNJriAYz/337VMWYRBsAu4a1we+96Oo+RQrM048XnQ/ltHyQ0drI6J9KkonXeASXp mZ5/Q/gAdoeclkIqNJ6z4aX0O97GGCl51U1yRz0qS4P6C0AJIi+vo2TBgkWGjrVR7pK+ YRriGNVS+4YM0xKT38HcL9aaF4Xni31vJFiqrbP7NU6cVpxw40MfEB+sqLFxvSTP7aeI AWeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766836321; x=1767441121; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KJLtG+kSnBxO8u9tWSlN4IpEKdHgADBZMUIyM3jPy1A=; b=v5DbqBJVf75ztyvZOUGnMWAdcbDyE9Y0LJH6oEwWujMLYnhtfl0+z0XRTG74prPJcq N9TNxAWSSXjjTpFzGB4uYHgzb8/YGviR4o1Neb6DMMEh3YfQmVrmnUJhA3bysN8vl2Oq xk9L6KAfjrsQNmR3wbpLK2zmqouK9LSDGpWmx9hooNF4OhCYB6Qg00ZXdSRlLME66CJV VGp4K5VASdFzLqrq+7g9W9JiU1cHWUKM1Bjdc+sDYCzhuLwvJJIYh1zcZZPwS5TGAFAF GzkuJ51M9OfepHXlDZrE+Fdx+AIgaKYqI862gyFkztYWaRXWvcHnXoU+aldZiBBXOM75 w6+Q== X-Forwarded-Encrypted: i=1; AJvYcCV8/iFaeAfCyU37t6qYikCEaGYG4nQAaNYWNylIWT8Tm35lZkS8p9RmvpVrunmpOSU075jRrchy2pMt+NU=@vger.kernel.org X-Gm-Message-State: AOJu0YwGgbNbZIQvZdoyPS5C2Cpe1kn6WNjTkYu7z5nmsKgzCcSF7XHG ikVbalLqquKBnEsuprOxx8DmfoAKd4ph/KMz8aohBbTdhqpJhe4f87f7 X-Gm-Gg: AY/fxX6YQHB73MGSZlpo7R5U7AkBMIqvim11Ck0ra1KLjnlioWBfY/yDJZAMrvdEAcA m/RHQncgXZYFyENHuDlNpH864UsT++FJ18swYRPYbaDy2mHvhk38gM8DJShLAjXLu79QfbTjc6i plmAm09BBqJyKXTj1TLJQdQ2HUjKHddL0Wj/jSNHwxi8uMVPZ4FpN5+DTBXYZw6sgbmG/iwn8jD lLiTYZIEB9QeQaxGZDvpJiIFJPwa5EEiyOpZHJkFz2HHzjdp5w+pqCTQ7SNkz99+R/Uw5LF34ph f9GJjh9eeaKduKUWuQD5VgtluwxFFYyp1ZTg/t2XmXbWcVKzrWzi4eMw3MN+shCLvHLqapf5qnc czt+lJCxzAzrxOzt2EhusqfMg7/2T6uP9ZJDA5xBqVrIk9Ik+BbArrNr0btsfLEsxLDSB7GAxUp 59NZ2by+PO5uMPc9ismgBao6vUg7o= X-Google-Smtp-Source: AGHT+IHNyWALcAMTdxM9LLuSqGEv7zHOvrXmkX/bjPMMH/JHgWLBT/zRZsDTTIWmQlxCRXQndj5nzg== X-Received: by 2002:a05:6512:32c7:b0:595:9da3:fe6a with SMTP id 2adb3069b0e04-59a17d495f4mr9170706e87.10.1766836320371; Sat, 27 Dec 2025 03:52:00 -0800 (PST) Received: from localhost.localdomain ([176.33.65.121]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59a185d5e5csm7406722e87.15.2025.12.27.03.51.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Dec 2025 03:51:59 -0800 (PST) From: Alper Ak To: dan.scally@ideasonboard.com, jacopo.mondi@ideasonboard.com Cc: Alper Ak , Mauro Carvalho Chehab , Nayden Kanchev , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: mali-c55: Fix possible ERR_PTR dereference in mali_c55_isp_enable_streams() Date: Sat, 27 Dec 2025 14:51:52 +0300 Message-ID: <20251227115153.60862-1-alperyasinak1@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" media_pad_remote_pad_unique() can return ERR_PTR(-ENOTUNIQ) or ERR_PTR(-ENOLINK) on error situation. The current code dereferences isp->remote_src without checking for these error cases, which could lead to invalid memory access. Add IS_ERR() check before dereferencing the pointer. Fixes: d5f281f3dd29 ("media: mali-c55: Add Mali-C55 ISP driver") Signed-off-by: Alper Ak --- drivers/media/platform/arm/mali-c55/mali-c55-isp.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/media/platform/arm/mali-c55/mali-c55-isp.c b/drivers/m= edia/platform/arm/mali-c55/mali-c55-isp.c index 497f25fbdd13..ca1f0bde6f13 100644 --- a/drivers/media/platform/arm/mali-c55/mali-c55-isp.c +++ b/drivers/media/platform/arm/mali-c55/mali-c55-isp.c @@ -359,7 +359,11 @@ static int mali_c55_isp_enable_streams(struct v4l2_sub= dev *sd, */ =20 sink_pad =3D &isp->pads[MALI_C55_ISP_PAD_SINK_VIDEO]; + isp->remote_src =3D media_pad_remote_pad_unique(sink_pad); + if (IS_ERR(isp->remote_src)) + return PTR_ERR(isp->remote_src); + src_sd =3D media_entity_to_v4l2_subdev(isp->remote_src->entity); =20 isp->frame_sequence =3D 0; --=20 2.43.0