From nobody Sun Feb 8 02:26:40 2026 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6092B313270 for ; Sat, 27 Dec 2025 11:34:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766835249; cv=none; b=LIyJbG+pjb52UoRe+w2Gx3a7yIwgnPJLja7Ib5lJQkqZD4RXXodEHo9FFVPNbPg+PPVZlLfTdNIkD0CoOtYGN+y43wqHqyXouKVZufSYMHNVhRV0pC9nCJ3yO4J2b0DWpRZyd0hc2rq2JBaKdiTSVIDDQFqg9SFAUJRy4FDVamc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766835249; c=relaxed/simple; bh=IbETXDuuCJUAhe39/dgny2zVW9vK0dT/ZG3WkpVVfxE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bfxaHNT82PcqRK9PAwwwUTdGhVBQEAMJ7O8WaNDMmu7fo5D4Dnf/GgDOdcVApyYOeyx9UDq0wQtj7TgqsJnosbdz5nIBmZzL7bJ5MWGicLc0/PrdRHEfwnhLcZWdRb60OdDbkoJbH+1Szyw2ZoSvSGkYJLVQvARGuBK77P/FHPo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dHgKIKxJ; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dHgKIKxJ" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-7f121c00dedso10590229b3a.0 for ; Sat, 27 Dec 2025 03:34:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766835246; x=1767440046; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Sl10PyASTrPvts2CGD791OiWHhRS9HrDmSZd1Cd9MuA=; b=dHgKIKxJHPQ8uoY1KeEjNSWDYsPqexLvas2JHlo/PcFj8aK0GgousMqiJe8DGi2HOp iYtIkI8R5t+Uq4xtp6stDTRsYMFCypfrNDjus+8gtqZyikn/q2paH6SUwVGFMIrP8xMc xTNs+NKNzGMLPc3Dwt0xdjyXVwuaVN3RGgBqG8ljwRXQmLrUxxWquZI03pz3cUfdJJvL OtIILgH4sBIwGKZl7ym21IAaka2OnaA7IzU1QfCfexcvlxqLz7iOZfxSAH93SltAj14Y 7uvdvpUZqkrk5CHX+UdXvc1yo1yLtbL48EljUkKmP23Ksf6Rf3SEW6t69KvjroQt1d+K gWrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766835246; x=1767440046; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Sl10PyASTrPvts2CGD791OiWHhRS9HrDmSZd1Cd9MuA=; b=PEpQhh2d84GehM6EruGgmOYhQ1uT6RrXtOHAWqE+ndH4R7Qj0qZJiTgQsoN87PXehX 45ByFKjj2JoSL+wMlNGhehxkBRcgZIZl9uxh8KZxfXIWmjWIrBorM1qCPZtHki9X1mE7 a+PvQNPNd3UJ1nBesFq0buXxseNHFPCL72SJziFKh43kWNPFWm97Z2mriiPUOWXFE/eZ I9dBW17ur/X8Xrn9X0YIYU4IUXUvdn5an9UwkPfUDJUqx58QBhqbh/vhH1pNwh1U2xIQ YbDkO+kLc5aAknztaMT/0SpS3Abffn445BpzbEsfLgQnae+xcY3TkZSO5XdNEbgEdLhC gXqg== X-Forwarded-Encrypted: i=1; AJvYcCUjOBYAcl/ciSBwL5J2CiVFE+FH4RHOdTsbq/mRdV1nRrBoyIs2LT1AMbDRhE6V/pqyCms0Hj+M0rpPDCs=@vger.kernel.org X-Gm-Message-State: AOJu0YwUVxMprE51un8DndPxf8oZt6rum7krVeps87qx+DsvbbaPz0sm E84Vc8GRlWvoWzQvzpNiJcQSaHo54rs77UGefd0saePR+T7raZP4bGFV X-Gm-Gg: AY/fxX50TuSGFolN86k/EuBqX+O3NsKMePUcAjJZ/y25QqfMj+WhcDlUWnW9ZGBaXhd 470mg9ozqaF42rUBhEdKibNzpj9kyg+sROObWa/UFcy7P/8f6c0MvVcsUGE/nRgoOeUyRtEgjjs dJB0Gq4jhXYItHjhZnvz3GU+XcfyfWKtqurX6W9OloeLZFtVxz54xUKqdvFWns37uX/rpLjH5LW T00LEgefNQBLY25zYnQE1EG92VqBrRzBVExkWeZ7WDBKlMc5Wzah1pk640Uh7fbIqvMgYIHb5B9 LFuAVS/auPjIHI80lNCrqrPGiw74qvEl/h2vL+HIvI3lZcARdb1mdHGD2V6qMrCCW5FqgUVTcwU dnNYPkItHla1B1XR5d0bOoOpxOhl3HayZvy/1xT24/hyKdFuZzAGce26Mj31/FaScapHD4Ga3pi 1yBVx+NQJtBLbLSyRYI/eHfA== X-Google-Smtp-Source: AGHT+IG8n+CGndJluKrsW7TOzwprYZpSjV8sCb6MR+wsZbDK7EqUsswEX9DbCxLyZs8gTvaKvCHRfw== X-Received: by 2002:a05:6a00:ac08:b0:7e8:450c:618c with SMTP id d2e1a72fcca58-7ff664814e0mr24628746b3a.35.1766835244713; Sat, 27 Dec 2025 03:34:04 -0800 (PST) Received: from karthik.. ([43.247.159.43]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7ae354easm24434239b3a.16.2025.12.27.03.34.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Dec 2025 03:34:04 -0800 (PST) From: Karthikey D Kadati To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Karthikey D Kadati Subject: [PATCH] staging: rtl8723bs: fix missing transmission lock in rtw_xmit Date: Sat, 27 Dec 2025 17:03:48 +0530 Message-ID: <20251227113348.26272-1-karthikey3608@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The packet transmission path in rtw_xmit.c contained TODO comments indicating a missing lock. This patch implements spin_lock_bh and spin_unlock_bh around the station attribute update section. This prevents a potential race condition where station security and PHY information could be modified on another CPU core during transmission. The use of _bh variants ensures safety in bottom-half contexts common in network transmit paths. Verified that psta is NULL-checked prior to acquisition and that no double-unlocks occur on the exit path. Signed-off-by: Karthikey D Kadati --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 21690857f..5f11afb63 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -715,8 +715,9 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p if (!(psta->state & _FW_LINKED)) return _FAIL; =20 - /* TODO:_lock */ + spin_lock_bh(&psta->lock); if (update_attrib_sec_info(padapter, pattrib, psta) =3D=3D _FAIL) { + spin_unlock_bh(&psta->lock); res =3D _FAIL; goto exit; } @@ -724,7 +725,7 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p update_attrib_phy_info(padapter, pattrib, psta); =20 pattrib->psta =3D psta; - /* TODO:_unlock */ + spin_unlock_bh(&psta->lock); =20 pattrib->pctrl =3D 0; =20 --=20 2.43.0