From nobody Sun Feb 8 12:14:33 2026 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA13E24CEEA for ; Sat, 27 Dec 2025 08:41:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766824862; cv=none; b=hG3MP8fsHpoWuQER4Yw/KWO4u+NDojAis/+61Vqvn9JsZQozAJwdNvCqyxwS6Agmw5Xqsl/2YdG9BpRpytx3E2kjmThJGJNjXsI4B596MgT/orGN1v9fo3zdxk14pXP9IjggUD32yaNPlar9dCWq0OvQGVUv/uXwQPvUXh3jnYc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766824862; c=relaxed/simple; bh=Nj68t+K0+EIx3131fR5DrdLX+H05YAGgkEp3NfJOl1o=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=L1H/d08VUnV46TtDZ0VtOy0I/EIarp98HqEUKiVU7pyBX7H7nGT6CQegYE4+x+jiLyJkeoVan4r5Csu9KYF/4ouu+cGtjIIs+SeosKwzaznpM0SWSzNXxKsZdLD7hO3qoUXQm45lErzpqGZmGBF91am019J6lx7Ntl9dvDSgmbc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A44aVtPX; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A44aVtPX" Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-5959d9a8eceso8841866e87.3 for ; Sat, 27 Dec 2025 00:41:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766824859; x=1767429659; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=h1mzLS7EMQ7CMEUjGijkTRd2ui9VJENWahANf3YnZYY=; b=A44aVtPXm+ESJJrYrED3Uyap2BNM96Q361FcnJ9tKyS8i107kh+LikQOFEyc4BYiAz gBDyLlOHhgOEJFtwPh6K737l5WHID/ldlnFAnm2SMgu9pRUL6d7Minf0U+IgOb5PHVRt gB2jNbh1m5zQojxZ5RgdcL/w92auru8Y+vfTkk7EVqyfb9pdA9Pnv0EIkIwrFhA4GXlG YmiB+voU8krkhX/EY2K77EsfcGqTNya4mLUmRX4iJID9z4TTqySGqOSWlBNwQ+zzFRKI NaZtmZHVjyzpDetD4u0n3+M7hSqVuaIG0sjFdq8SK0kumRpcGtxpw76lg7PXC98CL0jX SfkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766824859; x=1767429659; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=h1mzLS7EMQ7CMEUjGijkTRd2ui9VJENWahANf3YnZYY=; b=ibl6jQiJaCJDlr2Z7zF4Xhakewa7UMlVR4eOuI6h0TsQk80xrbQs/ti9V9UmR5bwYR oSBnOKgLnmdv19dF1FcwHP+3dFw8htvvGkeTbgTr5+0NXI7bB/TNi2+Emcx5zgCHiVJX H0SJJug/ZDjplRBMV0QzRc39OuZcpbUa13QtY7V09fRRJMeGz6bgpJqagU8IU3QPaOLI LVG5QfNidETlH4hsM1LVlCN0uoSDWhM1LahQ9q0kgufEXd9K6kO57+RpK3rqBhjMQs6p WXA+oahldKfMXDr9+hGmbcpD1xIUGpWPXgrpOPnQF/FhFJxIuxOe36q1V9WbyVYWVFHN PmvQ== X-Forwarded-Encrypted: i=1; AJvYcCXV6hWGno63AXoy8fzkAUhuuwRPcN721A+Ii43JGPnoLxGpZBQSH/j6b6MvY7ueSC1+k7EoVp6XIQEH9Bk=@vger.kernel.org X-Gm-Message-State: AOJu0YxlSNLm0Q8L61be48YCAQfOO3ATHyDXUOQqM89kRfXTrIXsJ/8o mRvDkxyiE4F4jfy3RfQlWVYJZ6or25ve+aX/SpW6yEPNWMR7RGvNiVVWReLC0Q== X-Gm-Gg: AY/fxX6zY4mjYzptNeEwemejZIB16QkzSTaPUZSIc8vEVOWOEvCEC6kjLt6MKtO1TMb 5k1sFfFeHvW3bmQS7axwDWbMQGhCrB++M2+Aj5Gi6QKGLRUaMwG8SA0aQFi7RH1RdyNW+WHWTfl Zl79Kyq3gf0hvoLvATEyR9d+fWF8ioGC0MNYsL0N6Wd+bT7NRVoS86ds3vZPgHMUH5YXGEKTgCo G3/8Viei4cizIYstsRgP25xZKdTQ/jVC/XgrLMfdzQ6bxS2eWoyI+/mRzzXkfM3SSfIzZrlDGSY Ojh2YrUuJ2ukcTGK6ALn/1sZN3peLyyUdqYvZ3PPkM/dCpDXBs/qnmyVEtJxDmr5xE0DwNe9kfz 8vsjZE5UF3fc2xRlCNaq2RsxPIvmFjfWlYEivYbpBA19fjb5oq82Kzt1jxYdEzLvxbylKsDkSUi xkDDpTAdTZjVs0oytyOvNI0CdPPek= X-Google-Smtp-Source: AGHT+IE1gCiVZ/51w+w16JK8HSkIEZBaavUo8dO1lP3TNd8GAXnf3MFYxs6ktYqH0uvy4VDHnjLsEQ== X-Received: by 2002:a05:6512:3b9c:b0:594:34ae:1446 with SMTP id 2adb3069b0e04-59a17deb93amr8297083e87.41.1766824858531; Sat, 27 Dec 2025 00:40:58 -0800 (PST) Received: from localhost.localdomain ([176.33.65.121]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59a1861ffffsm7171646e87.81.2025.12.27.00.40.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Dec 2025 00:40:56 -0800 (PST) From: Alper Ak To: hverkuil@kernel.org, mchehab@kernel.org Cc: Alper Ak , Jacob Chen , Ezequiel Garcia , Heiko Stuebner , Michael Tretter , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: rockchip: rga: Fix possible ERR_PTR dereference in rga_buf_init() Date: Sat, 27 Dec 2025 11:40:37 +0300 Message-ID: <20251227084038.28679-1-alperyasinak1@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" rga_get_frame() can return ERR_PTR(-EINVAL) when buffer type is unsupported or invalid. rga_buf_init() does not check the return value and unconditionally dereferences the pointer when accessing f->size. Add proper ERR_PTR checking and return the error to prevent dereferencing an invalid pointer. Fixes: 6040702ade23 ("media: rockchip: rga: allocate DMA descriptors per bu= ffer") Signed-off-by: Alper Ak Reviewed-by: Michael Tretter --- drivers/media/platform/rockchip/rga/rga-buf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/rockchip/rga/rga-buf.c b/drivers/media/= platform/rockchip/rga/rga-buf.c index 730bdf98565a..bb575873f2b2 100644 --- a/drivers/media/platform/rockchip/rga/rga-buf.c +++ b/drivers/media/platform/rockchip/rga/rga-buf.c @@ -80,6 +80,9 @@ static int rga_buf_init(struct vb2_buffer *vb) struct rga_frame *f =3D rga_get_frame(ctx, vb->vb2_queue->type); size_t n_desc =3D 0; =20 + if (IS_ERR(f)) + return PTR_ERR(f); + n_desc =3D DIV_ROUND_UP(f->size, PAGE_SIZE); =20 rbuf->n_desc =3D n_desc; --=20 2.43.0