From nobody Tue Feb 10 06:26:49 2026 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 242BC330B29 for ; Sat, 27 Dec 2025 12:24:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766838288; cv=none; b=d25yuxYT03rW2ZJrEkMZ3IQWQXnsxvbQb9cEeMrLjFRNCwriWU0E9ivh+xlKbloOcLr8Lqpbxc5279yDSRyY7J3DgaJUzSKvnE/t8bOMw9gJ0vObTFZ9UPW5rZYh2IbLzbrd+ft6cgONgVogLCqLJKAxhBntCM+0jVf0ADI1g/U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766838288; c=relaxed/simple; bh=61ADjJrgT2o/i8020WOTVait6ro421Ajicl8SlsuO9U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qICxkyUxDPqoJBSXQylAsK+VZTWv2KOaB2ePMRTseuhGTSd3+wxFfrJf5JbeOQDe6tsI6N5msD3KXtfoMiMnBDeKF2vqiI7CbiKxhBn8yPOdy2zNMwbPWev2a4q1l+ukPgaBn94kVa0ZdOuY91uwE5T/hI9tuDwNXD+eBVyb2jQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=QgjuHIvC; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QgjuHIvC" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-64b9d01e473so10537896a12.2 for ; Sat, 27 Dec 2025 04:24:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766838281; x=1767443081; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6RGJHpYPSzzQbbGCB4wy3BgFrQgesxTAcE0/qZgwEOg=; b=QgjuHIvCQ5py7O52/Jj4oZR6bhc4rf8+nVBWdogTfdPsRyC/OHquSadTl163SPvG5A WC9pZDOdodVBwMOWLdIjqDfI4jB/Qb7Er7CXvgSF37SeU8urtVHUDtY0AsI2Rm9wt+4x Lqp+yvsS1Mr1Fnuv+nlmaV13syk3+cgmJsQEoZizieoRVTEUSeJzfMMp3zGqLcJVsdS2 znauhuMBjhkCbiTFRABwdht5p/l7tHC0as8ZmgWrSW97+YTbDbq7jF9Ak2ll+nx7l4D1 V1XA8gtit4mE/Au8GeCuydaaIYGD3Qf5WKOK2KDV3QxR+qyxCAYldONbMzciJFzOB4NK DM7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766838281; x=1767443081; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=6RGJHpYPSzzQbbGCB4wy3BgFrQgesxTAcE0/qZgwEOg=; b=U7PldSOUcBmlrcyzMLtmpCScJ9hzSg2ihqAVZaJ+NvIw00ADHK1RKML3iGRx9Evlhy Gs+rn6LUC+OGmnRkpMPwRRiNo1hGHZGL/r8N+VV8oI/kbcHM4kBx/9ykdPTmEMF8ioY7 603ByfzYTFPDHOKkBK9Xkc893YLJVFTiyxaoyKH6DA3qMlDUTsGEETDfvh6fZUpSt/D/ QPkXo/+2PmU8/NNDcKC4Obv1f047AFYAsDrC+bxJrYbhj9EQVOIDTNdZ+KmBkE09eJ+U xLdJflj7F0GuYWretAS4x+7fStXsKNiL4R0YmMJjijKTZde99UFOPo52FkWOamkiuC5c vO4A== X-Forwarded-Encrypted: i=1; AJvYcCUp0DUXUL35WOnI29TaHzdVH3tX98taJ0EuWh2/riWFpwEmmzFXJD+ddlw+ekd4EkCB1j5dM5DDbLEB86M=@vger.kernel.org X-Gm-Message-State: AOJu0YzQcsJ1Dwg+VD7T/rJ8dyGgc87q8xmsjoHpzYuNVAwNT9L0kJd5 wCxgcgbCsrHsmJdXbbijUVzuP2/gPg3VJla5iPL0qOJ+3l+sxlKZCbyOfQuhIvfospI= X-Gm-Gg: AY/fxX5cOxM1xgJT59YZVrcmdBsGygJYrDrm338SLGVNZWzWlTnpj8Q272HRmvX4+lp 9KMLQeiSpnoODHKFKMBdxHmCWsmQwowZLbgPPqFkN6aB604Diu2c7PDS+mCRSpGPpYn+RY3Paml 6eaU6zI5afutM4533NHUERy2RUuF9L0HXI6oSjiTqdqS9eKwr/2pLBWES3eopmJ3x/wWoN2U3xS WMwAO3Frg32axsNRkwJcR1zZxtBc/Mwf6ZfPYE/WezQScKZdiH+90UEd3kqmG4iOb/4ub6SYrlf eELkH+LjFh6VGDhZh0q1a1pqe/VJSbG5mp51dd01bO5o8LwG4BGvCnNypI+P3kPhWjLmOmgaLwO HeP9zhH/Q/RHwWcsw+NNfbVhK6sZhOWDjqrtaVCqmqmOdnu5xbmAticRJV2cK18jJ1VbQ/uTgVw d3QDU6OIBffp76lV6zDVgaTolb0diUdN46NEfft15dTERs92Uy/x2YhgpH38hriB0mrXuHgBV4m v/4aw== X-Google-Smtp-Source: AGHT+IEZhhM0KME5WuKQ84Ts8cerCjpsb60R6tSjSyudT0VTKXNA6pzXYu7jRUwWEVFLnHJWn9IpIQ== X-Received: by 2002:a05:6402:51cb:b0:64b:3eeb:80b1 with SMTP id 4fb4d7f45d1cf-64b8ec6cb05mr22638603a12.22.1766838281265; Sat, 27 Dec 2025 04:24:41 -0800 (PST) Received: from puffmais2.c.googlers.com (244.175.141.34.bc.googleusercontent.com. [34.141.175.244]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b916adc61sm25932659a12.31.2025.12.27.04.24.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Dec 2025 04:24:41 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Sat, 27 Dec 2025 12:24:43 +0000 Subject: [PATCH v5 21/21] regulator: s2mps11: enable-gpios is optional on s2mpg1x Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251227-s2mpg1x-regulators-v5-21-0c04b360b4c9@linaro.org> References: <20251227-s2mpg1x-regulators-v5-0-0c04b360b4c9@linaro.org> In-Reply-To: <20251227-s2mpg1x-regulators-v5-0-0c04b360b4c9@linaro.org> To: Tudor Ambarus , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Lee Jones , Linus Walleij , Bartosz Golaszewski , Krzysztof Kozlowski , Linus Walleij , Bartosz Golaszewski Cc: Peter Griffin , Will McVicker , Juan Yescas , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 For s2mpg1x, enable-gpios is optional, but when not given, the driver is complaining quite verbosely about the missing property. Refactor the code slightly to avoid printing those messages to the kernel log in that case. Signed-off-by: Andr=C3=A9 Draszik --- drivers/regulator/s2mps11.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c index 178a032c0dc192874118906aee45441a1bbd8515..2d5510acd0780ab6f9296c48ddc= de5efe15ff488 100644 --- a/drivers/regulator/s2mps11.c +++ b/drivers/regulator/s2mps11.c @@ -352,7 +352,7 @@ static int s2mps11_regulator_set_suspend_disable(struct= regulator_dev *rdev) } =20 static int s2mps11_of_parse_gpiod(struct device_node *np, - const char *con_id, + const char *con_id, bool optional, const struct regulator_desc *desc, struct regulator_config *config) { @@ -371,14 +371,19 @@ static int s2mps11_of_parse_gpiod(struct device_node = *np, if (ret =3D=3D -EPROBE_DEFER) return ret; =20 - if (ret =3D=3D -ENOENT) + if (ret =3D=3D -ENOENT) { + if (optional) + return 0; + dev_info(config->dev, "No entry for control GPIO for %d/%s in node %pOF\n", desc->id, desc->name, np); - else + } else { dev_warn_probe(config->dev, ret, "Failed to get control GPIO for %d/%s in node %pOF\n", desc->id, desc->name, np); + } + return 0; } =20 @@ -409,7 +414,8 @@ static int s2mps11_of_parse_cb(struct device_node *np, else return 0; =20 - return s2mps11_of_parse_gpiod(np, "samsung,ext-control", desc, config); + return s2mps11_of_parse_gpiod(np, "samsung,ext-control", false, desc, + config); } =20 static int s2mpg10_of_parse_cb(struct device_node *np, @@ -528,7 +534,7 @@ static int s2mpg10_of_parse_cb(struct device_node *np, =20 ++s2mpg10_desc->desc.ops; =20 - return s2mps11_of_parse_gpiod(np, "enable", desc, config); + return s2mps11_of_parse_gpiod(np, "enable", true, desc, config); } =20 static int s2mpg10_enable_ext_control(struct s2mps11_info *s2mps11, --=20 2.52.0.351.gbe84eed79e-goog