From nobody Mon Feb 9 21:37:12 2026 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A39F3148C3 for ; Sat, 27 Dec 2025 12:17:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766837877; cv=none; b=ErSMpKCdZ3AG18R+1i8MbjorzmZgBLH7JugHZkR74lhcRtQuJ8OT+XiWTtidCK+xkGIktU+olsnbTPgyYwW9a7Zj98MbMijcyZqp2sSDKa1AMhYhFsomhCnsiB9OSfoE76Lq82WIlGoBTlGHt5B0JYvXm8oTnMRwcQPVtsxdmnM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766837877; c=relaxed/simple; bh=g7vjWoXnb2wErw2pXGilOcZRY2UtJd0VKIpjLqQ0jFk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fjyn16EWxSnmHM7gOOkeCuY4LTs2qe5QrV8VutWggHjxMJxPyi+TjVGQmTeyyt57oiCpfwxYRftlzxmjmYSuo0baciFUA4FKWKEsfq39+CV6UcqMPjJ/gAjhz927qy7QTKy4QziXKVVotOwMEhaUFWhz30EX9OmJjTdSgz9sXKo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ct9C0Oel; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ct9C0Oel" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-64d2c50f0d6so8160807a12.3 for ; Sat, 27 Dec 2025 04:17:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766837871; x=1767442671; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dH+IcWZ7Hp5DOdrxmSeMrUXVZaD5ihy5s0VkQhp0qtQ=; b=ct9C0OelMHhH4Uc+ZkVBmpNsSP6WKJ9bGdrr5V8z5EXW6zEF6FQktwjqgTPYY+IU+0 S/bMIABkoY/jt0aVaQXGlykqlDvAwMl1+Qdsvo9o20pTvnzkuIbieKBhKAtSz9H9n85Q w8O0FJVVyb/MQJYdscVZk3lq/qz5ZhV9qwy/KoqlPd6sl1dcisYbW0tzCzc2gAtyAa6/ 9n7oNuJykNQvBSDAP7T4lsabPV6ere/4+3NllcfYavGySGFHQl0Z8G3gmZVEtNzsT+Q+ 8Jhwup9Y81mqaRGMjNUNRzboZkr8azyaufHHOpJFtjs9gW26mZVLbYbCaBTZYsvd8UIg UwPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766837871; x=1767442671; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=dH+IcWZ7Hp5DOdrxmSeMrUXVZaD5ihy5s0VkQhp0qtQ=; b=HvZmC8Ys6PJnvkAeLIRCQ9gqWf8Vb3aegvloSr/q3iUibNtGUKbAuVRcZk/CGtX0CO DbC4ccT6eGZJvveDaPDCw4IREPwe/yHk5wCENV0gRGMlJMhX7u97kXs7+r91EgnmIVv9 0J172P7B4EMeO+DpTirNxpXU4hH/0qFkgyJbxXDozgHm5y9IPCyn1eASu/TARN8aZbCB xpV+A1l14CI0ddHYtdd2d6Nn+y0uqejX7N9Wsu8zU1zt0A4+2tLvyumCo80fRqLASX3M jI34xbBU/EknJEKF2fYrsb3eUJItistp8o0z3rO091OYYFUmPB9wcWtSiaertJnI3HSd O9WA== X-Forwarded-Encrypted: i=1; AJvYcCXONPubuuiVg+8rAsQH4BPk38yqy0FlZrsm4+EStksh/Ye19htmIv1t65O/qEsti2IbUPYen4SqahwGuYw=@vger.kernel.org X-Gm-Message-State: AOJu0YyNi6UfyYmr5gzELAjyhagm3xBhL8x4f+JSpwkiPCKQfBBlQYqy yJspjSc/Kf3Zseh0jiT8zL7OlS7F1iQyEPk5/mrmLCyuzKhdlNBXPyvovmVlKoT8yoA= X-Gm-Gg: AY/fxX7JxGZcB6p+d3Z8CMTAkpOpEX3Qqd0JRiXl2qFWZkO5quNkSBKmw3LmaTr1Kch HxHtHs79E4TN4Z2kuCPWcELsM0kHUIAlsnhtwlNlrpv33jh2ouX1loCMo1+/A6dMh2t7RD3treg FpTOdwkZoaNcRrNfGX0ngeJVJCOJZKdrdifv0YE+5qSih0RJhXhUR7p/l6GMg5Xy8WgEKHa905+ suDlKkzzwyqL/Bdu+yOKE0u6PyqY1ALsk4ExmwLYbJedOp6Gbb+6AxstJuBRZn4RLQNQTQztVdR vBmZRJLpWbooAXxTSURqv8gWM7ImuD+DESUHkp6WOUECBSLjQ09xnsftYFctVknRKR6I8LBJVKB KWgEtvL04heB8qMcy4XEcTm2aHmEmelobMXTavsDbPDeuXdJnVVGIY8gTRxYMMei7UOBwdpbIov +qJe0n103Oi6Fq3EgcZQXX/sopsp07NgC+mNLbJjBh8fIBeY3fuT8xVgdFSoYT5ALm21IXL7mBn 4boKQ== X-Google-Smtp-Source: AGHT+IFxLJhySmbzqKKN5f1k19NMRw4YAMo+p1rLarzbgXU+B3E+eTFXBDwdWc9HEfREHc0Gj6WpaQ== X-Received: by 2002:a17:907:8686:b0:b7c:e5d6:2462 with SMTP id a640c23a62f3a-b8036f60923mr2824273066b.28.1766837870771; Sat, 27 Dec 2025 04:17:50 -0800 (PST) Received: from puffmais2.c.googlers.com (244.175.141.34.bc.googleusercontent.com. [34.141.175.244]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f18575sm2616274666b.54.2025.12.27.04.17.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Dec 2025 04:17:50 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Sat, 27 Dec 2025 12:17:50 +0000 Subject: [PATCH 6/8] regulator: core: don't ignore errors from event forwarding setup Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251227-regulators-defer-v1-6-3104b22d84cb@linaro.org> References: <20251227-regulators-defer-v1-0-3104b22d84cb@linaro.org> In-Reply-To: <20251227-regulators-defer-v1-0-3104b22d84cb@linaro.org> To: Liam Girdwood , Mark Brown , Javier Martinez Canillas , Jon Hunter , Dmitry Baryshkov , Oleksij Rempel Cc: Peter Griffin , Tudor Ambarus , Will McVicker , Juan Yescas , kernel-team@android.com, linux-kernel@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 Receiving and forwarding critical supply events seems like they're important information and we shouldn't ignore errors occurring during registration for such events. With this change the supply is unset on event registration failure, allowing us to potentially retry another time. Fixes: 433e294c3c5b ("regulator: core: forward undervoltage events downstre= am by default") Signed-off-by: Andr=C3=A9 Draszik --- drivers/regulator/core.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index fd8da369c0529da12d6e80d90032e07bed414316..86dbee3ffda0b950619db8b52d6= c6eab8be31a53 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -2273,10 +2273,21 @@ static int regulator_resolve_supply(struct regulato= r_dev *rdev) * under-voltage. */ ret =3D register_regulator_event_forwarding(rdev); - if (ret < 0) + if (ret < 0) { + struct regulator *supply; + rdev_warn(rdev, "Failed to register event forwarding: %pe\n", ERR_PTR(ret)); =20 + supply =3D rdev->supply; + rdev->supply =3D NULL; + + regulator_unlock_two(rdev, supply->rdev, &ww_ctx); + + regulator_put(supply); + goto out; + } + regulator_unlock_two(rdev, r, &ww_ctx); =20 /* rdev->supply was created in set_supply() */ --=20 2.52.0.351.gbe84eed79e-goog