From nobody Mon Feb 9 17:34:38 2026 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28161315D32 for ; Sat, 27 Dec 2025 12:17:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766837878; cv=none; b=h7FdncrpKGGJ0jqtb1UYP2JRaKyG6xRHGZHLGiYBeqgizZIHlaY8Yc0rkto2BPWuk0c7KIlCHyVQPtMZxTkuwG513+dNs9UZwM9DwXckQnabOUBxDeiseqcwt4xY6uxUAM+wN7L4Wr8jlC8zOD73xEO+gKP/70YVN0KIJ8TcJ7Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766837878; c=relaxed/simple; bh=nquanBULeO6xKzKO4nj8Ei9OarW51quNRhICQgnB8BA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JE8S9p6oqYYzXA5j93XxML4/aRcdOS4zmKTf4hVoB8sKdWvbYRVatbZBdAuZ1ynazDSK1Or8s7DHUe7DeXV7LCuvvovdsIpLblTHNsW1jDzReEvGv+roUhMb3Yu1sPCuLjsq3JoGI0CN25pA/IjQr+sWSZjgjc2ZN2hG5RB0AdY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=y4VZyGmt; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="y4VZyGmt" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-b804646c718so776056166b.2 for ; Sat, 27 Dec 2025 04:17:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766837870; x=1767442670; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9RDG90BShY04pEbW8nv19ek68fiClLIBjgI2NCpLlGA=; b=y4VZyGmt0MJfFaNEO6u7vtd+wqd1bv16Bd8LqppUCIoD3U/gbFgw82QUsDIknMqCpA Gg46/kGtcr7KJfBO6nPBe8MEWc9iNhXenVx3hWaMQcHw/hZSMusLDNRqwpUNHNRkk9z3 hVSS4qO43umePAAIBUycZ01y8NSsQkbOlqG2iPm60UDmyikWedGqDBbcdvAU/e7q0yC3 EMDnLhtKre4jpYyeDgftKBDH2LTn5490+7j6Rr5LzZOSrWDdz9Mn7XECwYiUrB38vT25 e1AKpWxD5f9lir93sDlVBd6G6EBvef0pJqcY9lptyBPYIPhSdebOL1qqo7LX+4tXXUL0 Mu0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766837870; x=1767442670; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=9RDG90BShY04pEbW8nv19ek68fiClLIBjgI2NCpLlGA=; b=e1CngOF0vg2SAmQPvZluOd4ylZuUhT1VczzbR/efpn8AkodaU9klxhAjvWwWIy3yga R1DlwHvQLaVpOM4BJzPdSDCQm4DfFis2IScsJomQjAssRYDAWGFYcs+A4N23tE6uvkkI Xc4PVMyCD3Jj41TDA362O/esg3gcUI47Pw11quHwmV8GK16e5dRX04p5e/ZskYCre3gN vWEWjr4B1C1ZsRrjZyUsWAdXw9y4B6UUoOJMBJYWqiKZmfSlx3CT4kMGE/BNKlgO+Yqi gWuI/aWqLP//wm054bmOZ4AfSztTnnf5JHNOHl65p6bK9k/vEoJ49lMolto8dtW49rEP jcPA== X-Forwarded-Encrypted: i=1; AJvYcCWVYQsyPdB1RjaOoy5jJDu0ef/K5DLneAEArx14aGANnX3wtpUDGwFbQ8qeM57QTmvwPuOxXwVA/MZykCA=@vger.kernel.org X-Gm-Message-State: AOJu0YzyuwMSXAL+/V1+/q4pAr74iaiAgC1ecKwDwia3wCbyPi4WhVKP F9UAN9Z1VErqwksVUfdIOFGZIdNTwhN0WyhDpijXOLKE0lJs0Ml6izl2T3MVqYQ4yAA= X-Gm-Gg: AY/fxX6DISexwIQ9Tmz3SV44BPKwH2r2ynRrTn98QWWR3RtTEiAsujJsAWhCOg+klCN NNR4S69vCyjURv4MmOevAXNegBDleDjkyyEXzZLl/OWCW135T+GXpbBZIkifWB+FBhY5um5tpk7 ECQ219qfS84X3p66fjxzkFwanfVbn+T4R2FFOKjQ0HoYjl+lJDZgygQiSTqflm326wekSgYOLqb MMKfmQnjLJoy+TmWr3EMvB78cGPwBwxBxKMmbsEJ/b+Bn30aB9exeYsPchrIaaYzAP6D6FM//BC DnJT2ObVnfOSDXtJlaonwK8K1TQ7PGPDTx0iYFCfpJIlilqtDeAM8/XVjjCe4cdxXxDqXo9KLIR MXqvnzItwFrU88LmrqGDyJ/FuuSKQZPIzyQR7e4rJpk2SiRymFUJs3wLAGAWxOX1Jib2YXOY+iL sss6HBwPMnDmU7OyLZwHLm3h/9jdPS0hqvJFPBgE/TL/VeZbF0onLXPzEo8VXsm6HicxxJ8Ot+G 83rFw== X-Google-Smtp-Source: AGHT+IGQecDueUGZfL4ZM1NVtq0XX5KhDj8pci1KCpMzItV2EblvTpK929IOxznTat07v80WgMrikA== X-Received: by 2002:a17:907:6d0e:b0:b72:d8da:7aac with SMTP id a640c23a62f3a-b80371f10e6mr2820658966b.56.1766837870300; Sat, 27 Dec 2025 04:17:50 -0800 (PST) Received: from puffmais2.c.googlers.com (244.175.141.34.bc.googleusercontent.com. [34.141.175.244]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f18575sm2616274666b.54.2025.12.27.04.17.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Dec 2025 04:17:50 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Sat, 27 Dec 2025 12:17:49 +0000 Subject: [PATCH 5/8] regulator: core: remove dead code in regulator_resolve_supply() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251227-regulators-defer-v1-5-3104b22d84cb@linaro.org> References: <20251227-regulators-defer-v1-0-3104b22d84cb@linaro.org> In-Reply-To: <20251227-regulators-defer-v1-0-3104b22d84cb@linaro.org> To: Liam Girdwood , Mark Brown , Javier Martinez Canillas , Jon Hunter , Dmitry Baryshkov , Oleksij Rempel Cc: Peter Griffin , Tudor Ambarus , Will McVicker , Juan Yescas , kernel-team@android.com, linux-kernel@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 Since commit 98e48cd9283d ("regulator: core: resolve supply for boot-on/always-on regulators") we require that a regulator's supply has been resolved before enabling the regulator. Furthermore, regulator_get() also fails if the supply hasn't been resolved yet (preventing consumers from enabling a regulator without its supply known). In combination this means that regulator_resolve_supply() now always runs before the regulator has been enabled via set_machine_constraints(). The code here was meant to run after enabling the regulator in case the supply hadn't been resolved at that time and can therefore never execute anymore since that commit. Remove it. No functional change intended. Fixes: 98e48cd9283d ("regulator: core: resolve supply for boot-on/always-on= regulators") Signed-off-by: Andr=C3=A9 Draszik --- drivers/regulator/core.c | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 08bdb1e4175e6d47d154e7a2d859a9d39dcfd021..fd8da369c0529da12d6e80d9003= 2e07bed414316 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -2282,28 +2282,6 @@ static int regulator_resolve_supply(struct regulator= _dev *rdev) /* rdev->supply was created in set_supply() */ link_and_create_debugfs(rdev->supply, r, &rdev->dev); =20 - /* - * In set_machine_constraints() we may have turned this regulator on - * but we couldn't propagate to the supply if it hadn't been resolved - * yet. Do it now. - */ - if (rdev->use_count) { - ret =3D regulator_enable(rdev->supply); - if (ret < 0) { - struct regulator *supply; - - regulator_lock_two(rdev, rdev->supply->rdev, &ww_ctx); - - supply =3D rdev->supply; - rdev->supply =3D NULL; - - regulator_unlock_two(rdev, supply->rdev, &ww_ctx); - - regulator_put(supply); - goto out; - } - } - out: return ret; } --=20 2.52.0.351.gbe84eed79e-goog