From nobody Sat Feb 7 04:57:11 2026 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EFFC1391 for ; Fri, 26 Dec 2025 23:03:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766790210; cv=none; b=tsHhxNHBw4d59gzAJ2AapUqlby/w4XXJYTVnXRo0Z2SJbsWdgZdfeRLkAHC1RDfZEZoQv8ELXNF/O/sTz6hi9Gpef0BlncC5qhQ2kdQ0U4sNhU/Vp8QVQkQBWISYtk4dW4RtcGseyQM4Iu0KC/+KxKWGo/XBBWJ2tvqNhYslD3w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766790210; c=relaxed/simple; bh=subUScYBtR62M9Pea+YuouEdzgwnyMHl65l1+pbLD7w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MZVmoxsyQ+q3GqnOaUYH0WXBgmm0Hz6bXbtZmn5ma0HvYcebnPsxKXbB0NVS+tFifotqz7zwFKPJly01z2toakrnNEuVI8f9DUjSUSZ1AdYPMPHHprIEc9RlYa86rcmqnBr9O/dQUU1vSJefETE2WYbvQ/IVPkO84gNBhqUS8DQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JzdlrQcC; arc=none smtp.client-ip=209.85.167.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JzdlrQcC" Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-598efcf3a89so7420883e87.1 for ; Fri, 26 Dec 2025 15:03:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766790206; x=1767395006; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=y+UoJ9wTpClfFEDjDLgUD36z1gMAgjnC04BUiYEaS0g=; b=JzdlrQcCjMQvCNeWnXsAN8kQWGQTu7NIXF56rMZw7Hiq3PBx3PZELs8qhlJVqrFC+V GNbKLl592SG8aaWGr++uwaCd1hbcw9/c+TY1poFuD0pGFiFN45cVmhdFCamn1fIlQOjS WtkMool+MzEPzvEidiMKNsAQZKGAJXS3yK0C1cmKySB6Rx9qIFP57iBjj+vvLk5Pm8YO 80kM3BvQ1lE9AH6h3cSWGpfyHhSX8y7qmxAg3YzqRZJCu/NTdfu38HLH3nhH+DfMoLuq rIRof8Ak4Nv//Qor38SLJIxgBs94VbSGUntk7Qm0tKQnrPt375fp2GeGFG+UopYYYkSU XKbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766790206; x=1767395006; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=y+UoJ9wTpClfFEDjDLgUD36z1gMAgjnC04BUiYEaS0g=; b=E1Gd+CuGlnyVoEzj3BcS7J08Y8QDdkVv+B6WdNtUsaUA4Yf8M/AGxLYGcx6POtesNP TY7dhVdZGIq3SBLYY5a+4sCcDqfUU/27uT2Man1D8bQ7jIbc3whN6qgfpyvPNU476Edk q4CfeMRe/jLkSwBRgb7sYTCrSM4JLuGcqB6GYs7lec9uVd7HnkHtHzPMTbEUxTsRB1qf M4NU0bufK6hFyzeCzO14QrfvNRQ05RfePP3I/8x0Uc/n8IMZLfi2QaqHAHfSOjKULfWr 5uWQoaY3ax+QgxzWQqKwUOUJhZOmZoDD5wTH00QCYlJCr+O8AKh74Rz8cSY0Sp3YGdDd kLHA== X-Forwarded-Encrypted: i=1; AJvYcCVZr+rJEpjWNZJWRmhZ/aJfZE9dJLAHEuICUfWMZBFMbZoM1S/BDY8zR+Qhn2i5xUIUbT2fVzrrDWGaLLU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3u31bO5LB4vIr5x1VK+pRKwUVC6+RrxSsUdgY21DKRM1jKxhP RrEbhkRDDRMEUVYFixfIFSsCWkGo6+RzNgbdaHpZKTRqbGgMsk4a+jtI X-Gm-Gg: AY/fxX4YTaudB/msd2ZonqF8R6RcJ4ouvTuNr/CHjxlgwSQYyqUzfFteui1SCxZkTJO fKalkJ8WoP6uq75/Z3luz2ZK2YB1tyVMQg8g+2od4FnAk6Fy78Le5vbIrtL648ToOEkXkj+VSXn huxAbiLBbUbF6uuzUVKr4FWb+rkiqhwP8VAsiK1seNsjZ4YAHZnEUM6xRa6gEXVKvMWIHF7HDQK /dq/ej1ZyOAwlih05zbg52U7EskmWy3vfUYJSU8j64o2Sbx08kNXDv7CZY6eEKfTAdFxqstblJO XVt4tBE/IbbE1cXypVNTF9upwWLBl9S94JIMttOhvTJi5ngO1Zfs6ix/SQWqQuEEGQehRk4VL2g pTDPdxcmwriQU1+YZ9Z857NmYdluLehKn/VlT90lqayJO86CENGwnuKw4AYZIWqKQt3TuVyfdrm vIVngrYWOyLaPAEYOo14UBiPNVFuc= X-Google-Smtp-Source: AGHT+IHPw1AaFAwZ00bYDJ+BNB9B1YjnxDPHSW7kTDD4EpEvUf2Y3Jg9mvpkXZUyxLML5+yJHbxlgQ== X-Received: by 2002:a05:6512:a96:b0:594:5f00:c0b7 with SMTP id 2adb3069b0e04-59a17d8cf43mr8352861e87.15.1766790206149; Fri, 26 Dec 2025 15:03:26 -0800 (PST) Received: from localhost.localdomain ([176.33.65.121]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59a185d5e32sm6835603e87.8.2025.12.26.15.03.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Dec 2025 15:03:24 -0800 (PST) From: Alper Ak To: cascardo@igalia.com Cc: alperyasinak1@gmail.com, arnd@arndb.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, kernel test robot , Dan Carpenter Subject: [PATCH] char: misc: Use IS_ERR() for filp_open() return value Date: Sat, 27 Dec 2025 02:02:48 +0300 Message-ID: <20251226230248.113073-1-alperyasinak1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" filp_open() never returns NULL, it returns either a valid pointer or an error pointer. Using IS_ERR_OR_NULL() is unnecessary. Additionally, if filp were NULL, PTR_ERR(NULL) would return 0, leading to a misleading error message. Fixes: 74d8361be344 ("char: misc: add test cases") Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202506132058.thWZHlrb-lkp@intel.com/ Signed-off-by: Alper Ak Acked-by: Thadeu Lima de Souza Cascardo --- drivers/char/misc_minor_kunit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/misc_minor_kunit.c b/drivers/char/misc_minor_kuni= t.c index 6fc8b05169c5..e930c78e1ef9 100644 --- a/drivers/char/misc_minor_kunit.c +++ b/drivers/char/misc_minor_kunit.c @@ -166,7 +166,7 @@ static void __init miscdev_test_can_open(struct kunit *= test, struct miscdevice * KUNIT_FAIL(test, "failed to create node\n"); =20 filp =3D filp_open(devname, O_RDONLY, 0); - if (IS_ERR_OR_NULL(filp)) + if (IS_ERR(filp)) KUNIT_FAIL(test, "failed to open misc device: %ld\n", PTR_ERR(filp)); else fput(filp); --=20 2.43.0