From nobody Sun Feb 8 06:55:35 2026 Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BB7D7E792 for ; Fri, 26 Dec 2025 22:33:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766788393; cv=none; b=SC7a6C0VE7UCUhgLppKg0llbDsdkxgrK7omUrmY1h7zb/KJnLwOyPr5DB2dTRfM9oKi1TWV1QOCaBnVtfD9KcSfvP9Du6GEWuEKdn3R+v2vEETRv3Z60bAjyaxRk0IbMhIxUIAIMWvt3c0X+/8iCgb9/pf+d6DD9kxRYelivMOI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766788393; c=relaxed/simple; bh=PJcMa/qagm3mI2YMTAsaMZlvDfMDOcocY8Z0CzxCbks=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Wa0tbsXNxv0ojNBxK/0+8p/4Vf7sKwgAq5KdQ1MjzBAw7G2BSRFpoJS0dupxLCcuxNerzimDyzowJmx0mYRCn/50/Zvyxs9gmR/eL/6yGnLquBn4vAx6NqUCR73a9M+1F2voTCwI5lxDuQObQE6MtC21q8UawZaBURozA7QZvok= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K+ruXm4K; arc=none smtp.client-ip=209.85.208.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K+ruXm4K" Received: by mail-ed1-f66.google.com with SMTP id 4fb4d7f45d1cf-64d02c01865so8617372a12.1 for ; Fri, 26 Dec 2025 14:33:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766788390; x=1767393190; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=j8CxVX1qWvQ4lkG5RXNtsZNTMQqCg7BcQuj4X8ilrOQ=; b=K+ruXm4Kkov3EkQgrj+nQXNn8WmSbGHqNKXYRs3VqxWLB+bCZ9zpTH8j2KjMRMEu5c ySN+EuD/bCQ9zcAX0lJJNaRpfPhY8j4HA+0yN7NzIrVDX3LD9fD0tS7AWHSpgVPNqSsk ckfK5OAc9mm53fLlBDDbsqgWYQIMYeg30/w5PdBFs8obNRdgwOyQR+HXp2Mlsxx/bG+e QYuTnWP0/474K401mOMNGe5jK97qncnVzHnnlo3j/JBTOv4evXyKZ+FrjaU8YS5fHZSW h6KAmjzhrrKZf5IO43U9tJidqCmJAJEClEQKdP+puq5SeriTF/b/qppm8KfBdgsaV3Pw PYqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766788390; x=1767393190; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=j8CxVX1qWvQ4lkG5RXNtsZNTMQqCg7BcQuj4X8ilrOQ=; b=L9v/Pj+J5JSISG7Q9+IKhYWjwnBU2/Fq82hVkgs9Glaouh6WWdxidcOk3olVUyaDF5 PdhcQAMpMoJXv+pu2VWJzOEUC3HrQRE8evk25e3ym1piPxCScHQze80Bv6CBgUevCLAE PWMOtUiQsvFqGiY5nbXDhc7qJVbJnWfcysr9NGZ0cpn6yAE+0L1FNLp6d20fwJ/pFNzM PtrWdOv+gjCp0zgHYxEwKMbxBwfXf4V71crEJxzkzsOuXapBCWSCuv2KemOCTq7UTXax qxoADP4krWhQtjJ20OZgIKkQ9gSEX1mhS80EsYOxtZM38dUoqaTRvg+XpQvdxdOch9TA CTxQ== X-Forwarded-Encrypted: i=1; AJvYcCX1KwToqor+xyi/7Cqe2SOG0PTVITOxyshJEyAimgIUOb4q89qFRJLNCpazRR1qHPiyklZHuEwHZ8DEWSY=@vger.kernel.org X-Gm-Message-State: AOJu0YxVlKvW5N7M1PJVJoTa0LOnR6OD/JFVEFuhcDLZhfTc+4/EeFth QV861jCSNiKIEGwON618OVrLvEfrAa9rqI2GQiug6eEVPR211pSAx8+l X-Gm-Gg: AY/fxX6k5JsC3tfurXEckd/X4fovmxUc/diMFpNmsJkP8QzkDT2JpAgs7VaFKyEP78P IFld1i8Rbp/qVTSIUy8iRcVabnlTJkCgykYnC5V44N28v0hgx3XQ26iqnhxk1Qpnp/cgPTj4Fxb m74Nor8EcXQ7q44UMOadazVLmkZRPbrO213ypgBxx9XsqaVF4tXwhSkbmbJz0Oy7AYHtWe8d2si x4jFMR74Zq4ekNQNZ/yLkHBSHZoS2aJ9vu6TMBW4G9XmFxP417s4k+qd3Ud6QqoKOPnerL+S/y2 s/xOm89lfBJyhRETHIlCS47QzBftUy2LepmeuBlToUd2W4STABS8UKGARwBYeZZOBmPG1H4MdAm TGF4CKSufIxEVtowGGpT5EnbuQVBaCoYi5gX12RlOWUuJ9IH1f7RAA0imfdOEtfL8V0IxbqYexH y1UuFCH31EeA8astMw2QbueO4JPg== X-Google-Smtp-Source: AGHT+IFezj0P6NsDe4IVAJ6GUY/QTGFK6DsM/n4DJGRerM3qHMQMcQsSMEh/LwANi1tYAp72ha0kDg== X-Received: by 2002:a17:907:1c27:b0:b75:7b39:847a with SMTP id a640c23a62f3a-b80372228e5mr2733650266b.60.1766788390149; Fri, 26 Dec 2025 14:33:10 -0800 (PST) Received: from osama.. ([2a02:908:1b4:dac0:2c1e:db18:2fb6:1aa0]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f3ffbasm2519099466b.61.2025.12.26.14.33.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Dec 2025 14:33:09 -0800 (PST) From: Osama Abdelkader To: Andy Yan Cc: Osama Abdelkader , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/bridge: synopsys: dw-dp: return when attach bridge fail Date: Fri, 26 Dec 2025 23:32:28 +0100 Message-ID: <20251226223229.123860-1-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When drm_bridge_attach() fails, the function should return an error instead of continuing execution. Signed-off-by: Osama Abdelkader --- drivers/gpu/drm/bridge/synopsys/dw-dp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/brid= ge/synopsys/dw-dp.c index 82aaf74e1bc0..b6fe313ccaf8 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c @@ -2062,8 +2062,10 @@ struct dw_dp *dw_dp_bind(struct device *dev, struct = drm_encoder *encoder, } =20 ret =3D drm_bridge_attach(encoder, bridge, NULL, DRM_BRIDGE_ATTACH_NO_CON= NECTOR); - if (ret) + if (ret) { dev_err_probe(dev, ret, "Failed to attach bridge\n"); + return ERR_PTR(ret); + } =20 dw_dp_init_hw(dp); =20 --=20 2.43.0