From nobody Sat Feb 7 06:21:39 2026 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84DE3288C86 for ; Fri, 26 Dec 2025 12:09:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766750978; cv=none; b=p1+R555I8z8HHAFo814kvFvk6skpWv3nnQqr7kIPjvNXp60d2Ol3uhG4gMi1297IFDl1aFI5UZRHxZ+HNiVCY4QhcicsgrugxFm9ArF4ozxilhC3EovaXiRZZh8a3HCo+bd1dYe7S/J+sJuzR1URBmb6SSNSOyt5/ZG9SjAFP5g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766750978; c=relaxed/simple; bh=P+0Qx3sZetbkSWiOm2AFC37FSFNQ4o+XGqGdVw99zqc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=XesZx/Uue1hBMNiAfKbpoIy9e8ueN7j+8jJcSol8zwDp2vJDWnskrpp5apSjP9UPS80HxyQOCjq1YAiqSCkTUmu3A9QalM44nd85h4wx1xmwRm5yIfWfE4PlOdy/dlaZPOncKnotKw3UqK172ODmZhX9pkd18ybhY/BeR2PxutQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JgXTLw/G; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JgXTLw/G" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-59a10ef758aso5999870e87.2 for ; Fri, 26 Dec 2025 04:09:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766750975; x=1767355775; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6V2FKk+nq/UWbVzWV/SlXvxgESiQ13Hs+bkW8OxV61k=; b=JgXTLw/GIgJVX9S3HI2fMuGQ3t+B+aeniUCmz0B12f4f3cTLeRaeyzoQbwIXhKNk5f bir5XXwVarjSQmEMlrCCQ/2qMaqkGcR4KLnu/6jP6BhvDTgD5r2THPHE1LxvpbyOnvPj Y9s5S3e5l9TsH4HsC2PSHsX7gfbOvo6faV6Emsv3J3NdMAIoOC4dc+prkS30mu7AeSjf f0cozoeN0f/ogl2n/9teTcqE7GNVelGwDhxHnQOMuhDft62atD0+545vS3b2MlXabL+A fO8DarkE4FsC7byvuSW7mUb7eNOPf9BaCv1HW152AmYdqryhh0RXFigm3VZBkCr1i+6m sQGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766750975; x=1767355775; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6V2FKk+nq/UWbVzWV/SlXvxgESiQ13Hs+bkW8OxV61k=; b=WBQ8WvVw7NS1h+Xp/48Xi/+H4eXEc/pte5oiRPh4Mu8UHDJXOA9luMcjKxoZeE0iwC L39XbVITUHW01HstVI/qTT3sJWSmTa1LyR9HZXoL3QYv3acc7bdPxOM+yzTXwk3iVAMb 9qdLAwSmragDBpiVE/9Ta5CtsR8pwahPQRwIofxqj7c05jsxssLurFEm3BwNU9oaTQVK uPPpUySeT5/7Rwp6EtpKNd9tPfeb+bxQ3amCmYChctyRgffMntVd342LU5h5OZFx6zXy U6FyqwENvyVKIe5DmdywwuNOrX8hZKOL4hG/HZlgauhEHwjsWNtzoNA52oUsIn1aqFlf G6Ag== X-Forwarded-Encrypted: i=1; AJvYcCUX7tWQD/zN9Hl+PjrpqpEf+GcWN38cqfQayVWH7YT3wJ9oblgXAjUkrubwf8jJY5ItGn/G3ghfuHSWars=@vger.kernel.org X-Gm-Message-State: AOJu0YyGQoadsNFJMM1Dd1z3LOkkj4QBeCEFcVJCuu2M4bX0oKZPV92t eEBH5RPkQTNg7+V7tbpft2ChrpkCqYytBWVLXKfixNKixwbsWDjJlub1 X-Gm-Gg: AY/fxX4Dyler0XXr5ZJMD5lxTiIydAyuuaMNIX9oVMw92J89Rrt0QiARw1gTSyYTNIi 1BYubtmVNhWjZA/CiGL19v1xYDVpsFFYTL2QuOPSGzmM2eyHOcK5HRNMuMQMpHcfRc2vAolBcZM ZRL28Jqu1TjNE90AOSu4DjlZMC9GKmg03kUEfnKIjUIqnuGuG4MpjBQe/UpdxfwtUtRKxr+NASN YEMaq8QLtf8cO1cDrBX1SJN736NLi3DCYkFpHkXquzu+iE2dm3iI4jdgfPaGE8kO/vkVBvqCcEx i2R+h0z1asiLibqk3R6l4EBnJ4r8tMOE37wV6p6NGHMpLF5QFwDV+XXQtDC2KagYNDFqZOc5Xqg BetPkT9AfVy16MpbkBcbJKaUMM9TJoDz122LyK0fieBySOm5mxKh1Jm1DtiOpvre8bn4w6p3ayq kpOvE80XRzcjYKnQ+J+Y5t1T5av7U= X-Google-Smtp-Source: AGHT+IFfEKBr6eBl7ykv4GEdX7LpO80HMpB4K8mx96ZtUwr8pKVo/di8GIolUfkR36Y/Dp8fDlINjg== X-Received: by 2002:a05:6512:3f10:b0:594:2e7e:7897 with SMTP id 2adb3069b0e04-59a17d3b3demr7599475e87.29.1766750974420; Fri, 26 Dec 2025 04:09:34 -0800 (PST) Received: from localhost.localdomain ([176.33.65.121]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59a18618abbsm6832456e87.50.2025.12.26.04.09.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Dec 2025 04:09:34 -0800 (PST) From: Alper Ak To: peterhuewe@gmx.de, jarkko@kernel.org Cc: Alper Ak , Jason Gunthorpe , Stefano Garzarella , Christophe Ricard , linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] tpm: st33zp24: Fix missing cleanup on get_burstcount() error Date: Fri, 26 Dec 2025 15:09:27 +0300 Message-ID: <20251226120929.61630-1-alperyasinak1@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" get_burstcount() can return -EBUSY on timeout. When this happens, st33zp24_send() returns directly without releasing the locality acquired earlier. Use goto out_err to ensure proper cleanup when get_burstcount() fails. Fixes: bf38b8710892 ("tpm/tpm_i2c_stm_st33: Split tpm_i2c_tpm_st33 in 2 lay= ers (core + phy)") Signed-off-by: Alper Ak Reviewed-by: Jarkko Sakkinen --- drivers/char/tpm/st33zp24/st33zp24.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/char/tpm/st33zp24/st33zp24.c b/drivers/char/tpm/st33zp= 24/st33zp24.c index 2ed7815e4899..e2b7451ea7cc 100644 --- a/drivers/char/tpm/st33zp24/st33zp24.c +++ b/drivers/char/tpm/st33zp24/st33zp24.c @@ -328,8 +328,10 @@ static int st33zp24_send(struct tpm_chip *chip, unsign= ed char *buf, =20 for (i =3D 0; i < len - 1;) { burstcnt =3D get_burstcount(chip); - if (burstcnt < 0) - return burstcnt; + if (burstcnt < 0) { + ret =3D burstcnt; + goto out_err; + } size =3D min_t(int, len - i - 1, burstcnt); ret =3D tpm_dev->ops->send(tpm_dev->phy_id, TPM_DATA_FIFO, buf + i, size); --=20 2.43.0