From nobody Sat Feb 7 04:56:59 2026 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 610A1296BB6 for ; Fri, 26 Dec 2025 10:24:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766744649; cv=none; b=sFilcTbPxBHLQh634cdoD+lttFYkXLJCF1eKKPGeG8cvoMe/FQiLMb81WwGnER9yf7NWwg5OD77McJqQsxvpqrp71ymxsm4olfTkaLBl24uIuSKePYidk/VZne3GtnTaJByg/jwomjY2vp17v70FUtSbrdemUL7H7OW7VytCFiw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766744649; c=relaxed/simple; bh=q54TVE9xxsQky3EH8n2s/mW+Y5L3ExtjjV/hstmghSw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Dhg+SQro17Qf6L9PB8VCukEdT5WSNFbPHsOZyar/6yc8DTThQkILcFVMrIWvWgnuLDeVbzT3n2gFDw4yJneSVWBF66v4DSlVZEoq9LzU0tLREsKOp2v4Xo8DqqPrmkRJl6uJ80MwBije3ghR8nufN3sYYDOlF+X43AnYtGr6JqY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XwhsPqCT; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XwhsPqCT" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-59581e32163so8380953e87.1 for ; Fri, 26 Dec 2025 02:24:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766744644; x=1767349444; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MGr0steWVR+tud6A7R1zsUzouFtLNpTY8y6W21UhPic=; b=XwhsPqCTsefKADYOApNHM2ktRA95jFJosqxakaYjA0JBrxnadrxNMRgCu5qZHKtzi+ mV96q0gdwAgbO9ZTgdoQWPH4n4wlm3+iDXTiP2bEejOx6/7IhUmekA9+gca88/Ih1D94 lblWVd5WIOT2H2kvNblvazMQUfOmeLhl187A9GHcF2TRUoqwmcrk0GP5Yebup3yERQqG A47VVy83+tUWpjsEGOA90yNHPEg/OUh4pRsLR/vvNBwFgG/d1PPtRiWZE+SM0THU7hQf u2EzlEYOVeFATquvTxT32Tvw+Ck5pBZDAy1GQJsnfBOYLd+hE5/xDjrNtXT8CgYfE0GI 9BSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766744644; x=1767349444; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MGr0steWVR+tud6A7R1zsUzouFtLNpTY8y6W21UhPic=; b=q02y8kb3i8DISNxtUI0lGw97gxRHE99XRwhFni4SAGO08t4xIdBaAQ94m6Pg5bLkq0 p+QbBA9qxXNo/T6t2UFbEoADKWdZm4X70+TF+uZX3rE+9eKMPER9Mi9exiSXzLm1wY+r XxmhrcchIzII21VT1T+o83iKwXXBaMd/J/tMi2KDwf2eFJXSO/O8LCVmicoeiZFE1G6B 9s8ohrDLgpk9A02lsNGKkCxmO2mi9jlcyYGhw5Rc7at4PGj2t+fpQcnGOuJD1NPSJ4Gq D9pTXabJk3pdOIopjcVqp7aQC1DypxCAKV49nYHI8+B+1tanj0Ns00vPPvRuUdp+omUc FwLA== X-Forwarded-Encrypted: i=1; AJvYcCUWAjJ0Th9+jlNDCxlxATgQQWBx0wKRXK+ujM0k1F8s4hdjc+xLXIGI9d7o8JLG8KuqVcc74OpfmrOAHI0=@vger.kernel.org X-Gm-Message-State: AOJu0Yzs7GdS4KoI2CpGdHQaEnVzJK/7EdkiTu19Fy+h1L6sSaPZDkB+ VpFyw7GYuU3SLjiCSd+22P50AR7lhTHUTf9GN+BoKXylsWgi7N0y8uRY X-Gm-Gg: AY/fxX4DFypE3oms2WZdhniiiAfrfJyl36jCwB/bDNp14oYVCMTdHMtL6Y8/n8OlYTz B7sEcaexDmJ6Ft+ykNf11KCGAzrlMgVZFytoWQArnb7HNg/BLAUk2s8E29pFHLtiVOwcK790S1r e9zgNZMHIbdn25u3kkPTnJ6ufecvN9rXx77U9IrnBr60Rmju4kySD6oNdUdhzxBn8Kq3+XipYUB zYsdZ8UYa5zk42Ff2CReYrlH8fBIrEhwoCEaNUhbz5pqlYXojTwFk7Iv9zq5QVIKmhwqBY99sSI ev3wDOUBnnykUh5sisifpF9isaP6hCc28Um3HTpFsnmtR856mFh4OOCHTedNF21trXMfySY8zLZ CpNKMkMeEGgkuRGPAcxTgwt0vzxnxVrULtXZ55YFL/XceuFZKHBfFpLPYm2ZHFpWnK5BmJ4J6UP hqkSf1Ro6KJN8HoGVNTSA7Rh2Hn2Y= X-Google-Smtp-Source: AGHT+IGVV8Y/v4qTcN26cr5MHMCOzKjuyYzizYRbwpe8C3zUOB+9ClEo3hD2TUdNBCc/S6c1ZoRJpA== X-Received: by 2002:a05:6512:4005:b0:592:f330:221 with SMTP id 2adb3069b0e04-59a17d18296mr7419824e87.6.1766744644182; Fri, 26 Dec 2025 02:24:04 -0800 (PST) Received: from localhost.localdomain ([176.33.65.121]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59a1862026bsm6472189e87.84.2025.12.26.02.24.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Dec 2025 02:24:03 -0800 (PST) From: Alper Ak To: peterhuewe@gmx.de, jarkko@kernel.org Cc: Alper Ak , Jason Gunthorpe , Bryan Freed , Andi Shyti , Kent Yoder , Marcel Selhorst , linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] tpm: tpm_i2c_infineon: Fix locality leak on get_burstcount() failure Date: Fri, 26 Dec 2025 13:23:38 +0300 Message-ID: <20251226102339.45054-1-alperyasinak1@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" get_burstcount() can return -EBUSY on timeout. When this happens, the function returns directly without releasing the locality that was acquired at the beginning of tpm_tis_i2c_send(). Use goto out_err to ensure proper cleanup when get_burstcount() fails. Fixes: aad628c1d91a ("char/tpm: Add new driver for Infineon I2C TIS TPM") Signed-off-by: Alper Ak Reviewed-by: Jarkko Sakkinen --- drivers/char/tpm/tpm_i2c_infineon.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/char/tpm/tpm_i2c_infineon.c b/drivers/char/tpm/tpm_i2c= _infineon.c index bdf1f329a679..8b7d32de0b2e 100644 --- a/drivers/char/tpm/tpm_i2c_infineon.c +++ b/drivers/char/tpm/tpm_i2c_infineon.c @@ -544,8 +544,10 @@ static int tpm_tis_i2c_send(struct tpm_chip *chip, u8 = *buf, size_t bufsiz, burstcnt =3D get_burstcount(chip); =20 /* burstcnt < 0 =3D TPM is busy */ - if (burstcnt < 0) - return burstcnt; + if (burstcnt < 0) { + rc =3D burstcnt; + goto out_err; + } =20 if (burstcnt > (len - 1 - count)) burstcnt =3D len - 1 - count; --=20 2.43.0