From nobody Sat Feb 7 04:57:04 2026 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C0192765C0 for ; Fri, 26 Dec 2025 09:15:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766740509; cv=none; b=PvOtJx+Dzxhr2Ixrguo47SRudLh4pGU+m8wIgCleTVPwYxLKynQ0xmxx2/5lGcdMe3gpMkdtk8s1seoBdACXRI6jIECf1x/n6FQRLHbgkF0XKD8cxzv7mbpPpz2Y83JkFbBaqVjpIDA4Cu5EeCywtt6v8Ljptg4NaLoWz/vUkyY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766740509; c=relaxed/simple; bh=MtjxdXCNkrPQUWWsg8M0yr1PDlNr1GzQf2UupXCdgp0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bUKfOKMT1KzvH21xd23ml7el9iEfptz2MRbkah+/+53KxiXlkScBlS8R79LFe4l6b6AXPvZH4kSdmD+1XyS+PCjNJprsPe4QBvz2TLMsXVIbkxED9Hlep45RKSfuDgUz6oQkP/8q1+yeIyVl0llk3lFJoZrVYF3WFBNqJLoo8Wc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lHUECD3L; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lHUECD3L" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-59581e32163so8331920e87.1 for ; Fri, 26 Dec 2025 01:15:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766740505; x=1767345305; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Y7aSBhKql7LrqECG0QcQgaU0abR6EWPPcAeyvikAZ5I=; b=lHUECD3LTE4UO/0OoiPo7zFZWhUNTQ/ZSvJczxjrLqRLWKbBL8aXUDmsaDhZud0VZY 7H7SXKbH+6PUCMtJzFdy5Tfm7cfJqorlET5hH1Hj2kpoNb6vK4VtVeLiqCVEAsVDRwwf FjD2M7CKB/vrzFardn5WBWi5o7ZEc5DsLILaYDgOSabdlUwtX7JTWeMWWRi1kCI9P9DF NsEFpaOQo2bt7dz43zndzRW9p5eIwU86aiFR37AL53U5yhFWQHWeniEFc3I9UUxOf/ZB Yqq6v2mbiM52DiV+ZdPjpoXhkVpSfL+4KwDyoOT4YBYSPIWV/IBQr5sWB431aGejgqpy 3IVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766740505; x=1767345305; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Y7aSBhKql7LrqECG0QcQgaU0abR6EWPPcAeyvikAZ5I=; b=uQxtUwb4nF7r1ir4812xp32Oj3Wg3WEvSzcwWNMMuqPl3BB8wquGsYTnPF9cgkt/CV tj3nspLa1HhpKScDBwdjmhCPInPERtdfR5ko2gxtO0P5mVwS1UGX1SmXHahNvi0cHSKh axJhBvjdBT2HKYefdMGib6SASXNoTKph4B6TpD+noqzLuA6i5sdk5JvTQZbBpYmJsoF6 2NzGctjVlauUbXuKnm1ipeDXDNJfZ7mO2TWG4J15uQr7A/HHUH5CtV+fNFn2hkyxcNyX 4kUyoZSSDtnQcoJFaibLwkSb9+K2GYo7NZ9mGVzLg3EEBrcJDt3FR7rKqiQ1YKAyZQ9o WVEg== X-Forwarded-Encrypted: i=1; AJvYcCX9kCyGcdW6LETl6ePiVFezWUShnlO7HVXlHooKF+2BugVIJg6di3Iv4vUyB9UJ2/OUDnibcNz+os1XXuk=@vger.kernel.org X-Gm-Message-State: AOJu0Yy97+2fraPicSbn8wH2QmnTxsd/wpdy2UDVxZF6tmpQq1VF027A V/TqvYjgUUBpQjh76SYbzZeT1IjtdM/mXLI6sLyHGyFeRJEJKJIGhRmO X-Gm-Gg: AY/fxX6tZAJey3E8F88kyjhWxs/siOsgADeRsgp53pQmm0xw5iVHUFcUIW5fhMqkz/g 0qcnlV4A7X1EmIrjy3YwQ+7nJiXfVxaCBrR5j7FbbjykV283stV1H4h1hc7y5Nv7IyzmNH3lax9 P3nR66qBJo+IHAUoy4PjhkbLLba/NnvsouZjLeFPRvqMYiJkaMDbLriUbqPkKx7jpgaHg2soXG1 hXa56a+rA7UHbz3WuZ2dY4e1GiRzFfKD1102kwGhEzfoZblk6rfWiS6y0l5sTx6zfivXGaK0KJ7 1RgkZ2NIgwW8Dkmt3syHxo/tec+3vwMwaCOo0ajQt011Jfx3+1rCBXz13ES7gSsl2YZfQi6/ClB HuM0xQrFMGXlZK+tqlprZi8tJSAk0SCUccQc2Go0+1C3S1Z6MPY7yLKj8+B65HtZBDTXTo+xBkC K71MKIlA1sHufxDXwNI1Wf5n09LO8= X-Google-Smtp-Source: AGHT+IH99cHZd+tTBe421lLIxVKr63TRfk1+0CoBMYzIEaDyI3MlGw6NZkxZirpFbqD06FxZEB/x7Q== X-Received: by 2002:a05:6512:4010:b0:595:9d6b:1174 with SMTP id 2adb3069b0e04-59a17d5d890mr7064160e87.35.1766740504831; Fri, 26 Dec 2025 01:15:04 -0800 (PST) Received: from localhost.localdomain ([176.33.65.121]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59a185d5ee4sm6654912e87.17.2025.12.26.01.15.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Dec 2025 01:15:04 -0800 (PST) From: Alper Ak To: arnd@arndb.de, gregkh@linuxfoundation.org Cc: cascardo@igalia.com, linux-kernel@vger.kernel.org, Alper Ak Subject: [PATCH] char: misc: Use IS_ERR() for filp_open() return value Date: Fri, 26 Dec 2025 12:14:51 +0300 Message-ID: <20251226091451.33900-1-alperyasinak1@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" filp_open() never returns NULL, it returns either a valid pointer or an error pointer. Using IS_ERR_OR_NULL() is unnecessary. Additionally, if filp were NULL, PTR_ERR(NULL) would return 0, leading to a misleading error message. Fixes: 74d8361be344 ("char: misc: add test cases") Signed-off-by: Alper Ak Acked-by: Thadeu Lima de Souza Cascardo Reported-by: Dan Carpenter Reported-by: kernel test robot --- drivers/char/misc_minor_kunit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/misc_minor_kunit.c b/drivers/char/misc_minor_kuni= t.c index 6fc8b05169c5..e930c78e1ef9 100644 --- a/drivers/char/misc_minor_kunit.c +++ b/drivers/char/misc_minor_kunit.c @@ -166,7 +166,7 @@ static void __init miscdev_test_can_open(struct kunit *= test, struct miscdevice * KUNIT_FAIL(test, "failed to create node\n"); =20 filp =3D filp_open(devname, O_RDONLY, 0); - if (IS_ERR_OR_NULL(filp)) + if (IS_ERR(filp)) KUNIT_FAIL(test, "failed to open misc device: %ld\n", PTR_ERR(filp)); else fput(filp); --=20 2.43.0